Page MenuHomeFreeBSD

[PowerPC] Floating-point exception trap followup
ClosedPublic

Authored by bdragon on Dec 3 2020, 1:44 AM.
Referenced Files
Unknown Object (File)
Sun, Oct 12, 4:01 PM
Unknown Object (File)
Sun, Oct 12, 12:40 PM
Unknown Object (File)
Fri, Oct 3, 10:08 AM
Unknown Object (File)
Thu, Oct 2, 9:47 PM
Unknown Object (File)
Thu, Oct 2, 7:04 AM
Unknown Object (File)
Thu, Oct 2, 5:30 AM
Unknown Object (File)
Tue, Sep 30, 4:32 AM
Unknown Object (File)
Sun, Sep 21, 1:08 AM
Subscribers

Details

Summary
  • Fix incorrect operation on 32-bit caused by incorrectly-sized storage for a temporary FPSCR.
  • Fix several whitespace problems.
  • Don't unconditionally try to enable VSX during cleanup_fpscr().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/powerpc/powerpc/fpu.c
221–224 ↗(On Diff #80250)

I don't think PSL_VSX is needed here at all.

sys/powerpc/powerpc/fpu.c
221–224 ↗(On Diff #80250)

Yeah, FPSCR has VXSOFT bit that is being cleared, but documentation doesn't mention PSL_VSX bit should be enabled when manipulating FPSCR. PSL_FP is mandatory

Addressing review comments.

This revision is now accepted and ready to land.Dec 12 2020, 11:49 PM
This revision was automatically updated to reflect the committed changes.