Page MenuHomeFreeBSD
Differential D27453

[PowerPC] Floating-point exception trap followup
ClosedPublic
Actions

Authored by bdragon on Dec 3 2020, 1:44 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, Apr 16, 1:27 AM
Unknown Object (File)
Thu, Apr 11, 7:44 AM
Unknown Object (File)
Jan 27 2024, 3:41 AM
Unknown Object (File)
Dec 26 2023, 1:52 AM
Unknown Object (File)
Dec 20 2023, 2:47 AM
Unknown Object (File)
Nov 12 2023, 4:58 PM
Unknown Object (File)
Nov 9 2023, 9:42 PM
Unknown Object (File)
Nov 8 2023, 3:57 PM
View All 27 Files
Subscribers
imp
luporl

Details

Reviewers
jhibbits
alfredo
Commits
rS368604: [PowerPC] Floating-point exception trap followup
Summary
  • Fix incorrect operation on 32-bit caused by incorrectly-sized storage for a temporary FPSCR.
  • Fix several whitespace problems.
  • Don't unconditionally try to enable VSX during cleanup_fpscr().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bdragon created this revision.Dec 3 2020, 1:44 AM
Herald added subscribers: luporl, imp. · View Herald TranscriptDec 3 2020, 1:44 AM
bdragon requested review of this revision.Dec 3 2020, 1:44 AM
jhibbits added inline comments.Dec 3 2020, 2:20 AM
sys/powerpc/powerpc/fpu.c
221–224 ↗(On Diff #80250)

I don't think PSL_VSX is needed here at all.

alfredo added inline comments.Dec 3 2020, 11:09 AM
sys/powerpc/powerpc/fpu.c
221–224 ↗(On Diff #80250)

Yeah, FPSCR has VXSOFT bit that is being cleared, but documentation doesn't mention PSL_VSX bit should be enabled when manipulating FPSCR. PSL_FP is mandatory

bdragon updated this revision to Diff 80653.Dec 12 2020, 11:47 PM

Addressing review comments.

bdragon marked 2 inline comments as done.Dec 12 2020, 11:47 PM
alfredo accepted this revision.Dec 12 2020, 11:49 PM
This revision is now accepted and ready to land.Dec 12 2020, 11:49 PM
Closed by commit rS368604: [PowerPC] Floating-point exception trap followup (authored by bdragon). · Explain WhyDec 13 2020, 3:59 AM
This revision was automatically updated to reflect the committed changes.
bdragon added a commit: rS368604: [PowerPC] Floating-point exception trap followup.

Revision Contents
Changeset List

PathSize
head/
sys/
powerpc/
include/
8 lines
powerpc/
11 lines
10 lines

Diff 80657

View Options

head/sys/powerpc/include/cpufunc.h

Loading...
View Options

head/sys/powerpc/powerpc/exec_machdep.c

Loading...
View Options

head/sys/powerpc/powerpc/fpu.c

Loading...