Differential D27453

[PowerPC] Floating-point exception trap followup
ClosedPublic
Actions

Authored by bdragon on Dec 3 2020, 1:44 AM.

Tags

Referenced Files

	F171882226: D27453.id80250.diff
	Mon, Sep 14, 7:52 AM

	Unknown Object (File)
	Thu, Sep 10, 6:08 PM

	Unknown Object (File)
	Tue, Sep 8, 2:10 AM

	Unknown Object (File)
	Mon, Sep 7, 9:58 PM

	Unknown Object (File)
	Sun, Sep 6, 8:52 AM

	Unknown Object (File)
	Sun, Sep 6, 3:55 AM

	Unknown Object (File)
	Sun, Sep 6, 2:57 AM

	Unknown Object (File)
	Sat, Sep 5, 12:05 PM

Subscribers

Details

Reviewers

jhibbits
alfredo

Commits

rS368604: [PowerPC] Floating-point exception trap followup

Summary

Fix incorrect operation on 32-bit caused by incorrectly-sized storage for a temporary FPSCR.
Fix several whitespace problems.
Don't unconditionally try to enable VSX during cleanup_fpscr().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdragon created this revision.Dec 3 2020, 1:44 AM

Herald added subscribers: luporl, imp. · View Herald TranscriptDec 3 2020, 1:44 AM

bdragon requested review of this revision.Dec 3 2020, 1:44 AM

jhibbits added inline comments.Dec 3 2020, 2:20 AM

sys/powerpc/powerpc/fpu.c
221–224 ↗	(On Diff #80250)	I don't think PSL_VSX is needed here at all.

alfredo added inline comments.Dec 3 2020, 11:09 AM

sys/powerpc/powerpc/fpu.c
221–224 ↗	(On Diff #80250)	Yeah, FPSCR has VXSOFT bit that is being cleared, but documentation doesn't mention PSL_VSX bit should be enabled when manipulating FPSCR. PSL_FP is mandatory

Addressing review comments.

bdragon marked 2 inline comments as done.Dec 12 2020, 11:47 PM

alfredo accepted this revision.Dec 12 2020, 11:49 PM

This revision is now accepted and ready to land.Dec 12 2020, 11:49 PM

Closed by commit rS368604: [PowerPC] Floating-point exception trap followup (authored by bdragon). · Explain WhyDec 13 2020, 3:59 AM

This revision was automatically updated to reflect the committed changes.

bdragon added a commit: rS368604: [PowerPC] Floating-point exception trap followup.

Revision Contents
Changeset List

Path

Size

head/

sys/

powerpc/

include/

8 lines

powerpc/

11 lines

10 lines

Diff 80657

head/sys/powerpc/include/cpufunc.h

Loading...

head/sys/powerpc/powerpc/exec_machdep.c

Loading...

head/sys/powerpc/powerpc/fpu.c

Loading...