Page MenuHomeFreeBSD

luporl (Leandro Lupori)
Engineering

Projects

User Details

User Since
Jan 7 2019, 7:21 PM (111 w, 4 d)

Recent Activity

Wed, Feb 24

luporl added inline comments to D27475: ofwfb: fix boot on LE.
Wed, Feb 24, 7:49 PM · PowerPC
luporl accepted D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.

It looks great now! Since this changes core libc functions, can you perform a buildworld on a system with the modified libc installed to confirm everything works fine?

Wed, Feb 24, 12:36 PM · PowerPC

Mon, Feb 22

luporl added a comment to D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.

@bruno.larsen_eldorado.org.br, overall your changes look good to me.
I have only one more suggestion and some nitpicks.

Mon, Feb 22, 6:37 PM · PowerPC
luporl added a comment to D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.
  • improved formatting
  • solution to the problem outlined by luporl

The alignment problem is solved, but this patch makes bcopy performance go down by a factor of 10. I think a third version of the code should be considered, restricting this patch only to POWER7 CPUs.

Does it produce any gain over original non-optimized code on Power7? If there's no gain I'd suggest restrict optimizations to ISA >= v.2.07 (POWER8). And in this case, remove unaligned access handling since newer CPUs can handle it transparently.

If there's still a gain I agree with having two optimized versions one handling VSX & ISA <=2.06 and the other for VSX & ISA >=2.07 (probably removing unaligned handling to make code simpler if no negative performance impact)

Mon, Feb 22, 5:02 PM · PowerPC

Fri, Feb 19

luporl accepted D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.

Worked fine on PPC64LE, both on Talos and QEMU, with D27475 to fix boot with ofwfb on LE.

Fri, Feb 19, 12:02 PM · PowerPC

Thu, Feb 18

luporl added inline comments to D27475: ofwfb: fix boot on LE.
Thu, Feb 18, 9:07 PM · PowerPC
luporl added inline comments to D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.
Thu, Feb 18, 7:14 PM · PowerPC
luporl added inline comments to D27475: ofwfb: fix boot on LE.
Thu, Feb 18, 5:50 PM · PowerPC

Fri, Feb 12

luporl added a comment to D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.

Looks good. I have been using a slightly modified version of this on Talos II and it is working well.

Fri, Feb 12, 12:44 PM · PowerPC

Fri, Feb 5

luporl added a comment to D28494: mrsas: unbreak i386 build.

Using only htole64() won't work in all cases.

Fri, Feb 5, 4:30 PM

Dec 4 2020

luporl requested review of D27475: ofwfb: fix boot on LE.
Dec 4 2020, 2:56 PM · PowerPC

Nov 25 2020

luporl accepted D26531: mrsas: Add big-endian support.
Nov 25 2020, 7:36 PM · PowerPC

Nov 17 2020

luporl closed D27156: [PowerPC] Don't overwrite vm.pmap sysctl node.
Nov 17 2020, 11:36 AM · PowerPC
luporl committed rS367758: [PowerPC] Don't overwrite vm.pmap sysctl node.
[PowerPC] Don't overwrite vm.pmap sysctl node
Nov 17 2020, 11:36 AM

Nov 16 2020

luporl added a comment to D26531: mrsas: Add big-endian support.

The changes look good to me overall.

Nov 16 2020, 6:10 PM · PowerPC
luporl updated the diff for D27156: [PowerPC] Don't overwrite vm.pmap sysctl node.

Leave superpages disabled by default

Nov 16 2020, 4:48 PM · PowerPC

Nov 13 2020

luporl accepted D27201: [POWERPC] msun: fix incorrect flag in fesetexceptflag.
Nov 13 2020, 7:54 PM · PowerPC
luporl accepted D27181: [PowerPC64LE] Radix fixes for LE.

Wow, that's really a lot of endianness fixes, nice job!

Nov 13 2020, 2:13 PM · PowerPC

Nov 9 2020

luporl requested review of D27156: [PowerPC] Don't overwrite vm.pmap sysctl node.
Nov 9 2020, 8:31 PM · PowerPC

Nov 6 2020

luporl committed rS367427: Fix powerpc and LINT builds.
Fix powerpc and LINT builds
Nov 6 2020, 6:50 PM
luporl closed D25237: Implement superpages for PowerPC64 (HPT).
Nov 6 2020, 2:13 PM · PowerPC
luporl committed rS367417: Implement superpages for PowerPC64 (HPT).
Implement superpages for PowerPC64 (HPT)
Nov 6 2020, 2:12 PM

Nov 5 2020

luporl committed rS367397: Fix powerpc and powerpcspe builds.
Fix powerpc and powerpcspe builds
Nov 5 2020, 8:18 PM
luporl closed D26114: pmcstat: fix PPC kernel symbol resolution.
Nov 5 2020, 8:10 PM · PowerPC
luporl closed D26113: libpmc: add support for POWER8/9 PMCs.
Nov 5 2020, 8:10 PM
luporl committed rS367392: pmcstat: fix PPC kernel symbol resolution.
pmcstat: fix PPC kernel symbol resolution
Nov 5 2020, 8:10 PM
luporl committed rS367391: libpmc: add support for POWER8/9 PMCs.
libpmc: add support for POWER8/9 PMCs
Nov 5 2020, 8:10 PM
luporl closed D26110: [PowerPC64] hwpmc: add support for POWER8/9 PMCs.
Nov 5 2020, 4:37 PM · PowerPC
luporl committed rS367390: [PowerPC] hwpmc: add support for POWER8/9 PMCs.
[PowerPC] hwpmc: add support for POWER8/9 PMCs
Nov 5 2020, 4:37 PM
luporl closed D26532: [PowerPC] Make PPC 970 PMC SPRs the standard ones.
Nov 5 2020, 2:16 PM · PowerPC
luporl committed rS367383: [PowerPC] Make PPC 970 PMC SPRs the standard ones.
[PowerPC] Make PPC 970 PMC SPRs the standard ones
Nov 5 2020, 2:16 PM
luporl added inline comments to D25237: Implement superpages for PowerPC64 (HPT).
Nov 5 2020, 2:11 PM · PowerPC
luporl updated the diff for D25237: Implement superpages for PowerPC64 (HPT).

Restore comment about tlbie instruction forms

Nov 5 2020, 2:07 PM · PowerPC

Oct 23 2020

luporl updated the diff for D25237: Implement superpages for PowerPC64 (HPT).
  • improve performance
    • force inline in new moea64_pte_* functions to avoid extra overhead with clang -O now defaulting -O1
    • look for superpage PVO in moea64_enter only when superpages are enabled
    • use multiple PV locks for superpage ops, instead of making a single PV lock cover a superpage
Oct 23 2020, 5:11 PM · PowerPC

Sep 23 2020

luporl updated the diff for D26113: libpmc: add support for POWER8/9 PMCs.

Rename ppcpnv/powernv to power8.

Sep 23 2020, 6:19 PM
luporl updated the diff for D26110: [PowerPC64] hwpmc: add support for POWER8/9 PMCs.

This diff has several changes on top of the previous one. The main ones are:

Sep 23 2020, 5:59 PM · PowerPC
luporl requested review of D26532: [PowerPC] Make PPC 970 PMC SPRs the standard ones.
Sep 23 2020, 5:27 PM · PowerPC

Sep 14 2020

luporl added a reviewer for D26110: [PowerPC64] hwpmc: add support for POWER8/9 PMCs: bdragon.
Sep 14 2020, 5:24 PM · PowerPC

Sep 10 2020

luporl added inline comments to D25237: Implement superpages for PowerPC64 (HPT).
Sep 10 2020, 5:46 PM · PowerPC
luporl updated the diff for D25237: Implement superpages for PowerPC64 (HPT).

Fix ERAT multi-hit issue

Sep 10 2020, 5:33 PM · PowerPC

Sep 1 2020

luporl committed rS365033: [PowerPC] Fix PMCLOG address width.
[PowerPC] Fix PMCLOG address width
Sep 1 2020, 11:34 AM
luporl closed D26112: [PowerPC64] Fix PMCLOG address width.
Sep 1 2020, 11:34 AM
luporl closed D26111: [PowerPC] Move pmc_hook out of critical section.
Sep 1 2020, 11:30 AM
luporl committed rS365032: [PowerPC] Move pmc_hook out of critical section.
[PowerPC] Move pmc_hook out of critical section
Sep 1 2020, 11:30 AM

Aug 31 2020

luporl accepted D26234: [PowerPC64LE] Fix Lua 5.2 runtime issue.

Looks good to me.

Aug 31 2020, 4:48 PM · PowerPC

Aug 28 2020

luporl added inline comments to D25237: Implement superpages for PowerPC64 (HPT).
Aug 28 2020, 5:39 PM · PowerPC
luporl updated the diff for D25237: Implement superpages for PowerPC64 (HPT).
  • address (part of) markj's comments
Aug 28 2020, 5:35 PM · PowerPC

Aug 24 2020

luporl added inline comments to D25237: Implement superpages for PowerPC64 (HPT).
Aug 24 2020, 8:17 PM · PowerPC
luporl closed D25651: [PPC] Make new auxv format default.
Aug 24 2020, 1:40 PM · PowerPC
luporl committed rS364675: [PowerPC] Make new auxv format default.
[PowerPC] Make new auxv format default
Aug 24 2020, 1:40 PM

Aug 21 2020

luporl updated the diff for D26114: pmcstat: fix PPC kernel symbol resolution.

Address jhibbits' comments

Aug 21 2020, 5:46 PM · PowerPC
luporl updated the diff for D25651: [PPC] Make new auxv format default.

Address bdragon's comments

Aug 21 2020, 5:33 PM · PowerPC
luporl added a comment to D26114: pmcstat: fix PPC kernel symbol resolution.

Makes sense to me. Is there a good way to test this?

Additionally, I believe this would also be relevant to ppc32, perhaps use the __powerpc__ ifdef instead.

Aug 21 2020, 2:43 PM · PowerPC

Aug 20 2020

luporl added a comment to D26113: libpmc: add support for POWER8/9 PMCs.

One thing we do have is the full power8/9 pmcs in src/lib/libpmc/pmu-events/arch. I think these just need to be hooked up

Aug 20 2020, 2:49 PM
luporl accepted D26040: Fix mprutil endianness.

Looks good to me.

Aug 20 2020, 11:46 AM · PowerPC

Aug 18 2020

luporl requested review of D26114: pmcstat: fix PPC kernel symbol resolution.
Aug 18 2020, 7:26 PM · PowerPC
luporl requested review of D26113: libpmc: add support for POWER8/9 PMCs.
Aug 18 2020, 7:08 PM
luporl requested review of D26112: [PowerPC64] Fix PMCLOG address width.
Aug 18 2020, 7:00 PM
luporl requested review of D26111: [PowerPC] Move pmc_hook out of critical section.
Aug 18 2020, 6:37 PM
luporl requested review of D26110: [PowerPC64] hwpmc: add support for POWER8/9 PMCs.
Aug 18 2020, 6:31 PM · PowerPC

Aug 11 2020

luporl accepted D26004: [PowerPC] print debugging information on trap signal.

Looks good, very similar to amd64 code.
But if you want to make it equivalent to amd64 code, you could also print SP, PC (that would be frame->fixreg[1] and frame->srr0, I think) and the word (or maybe the first 2 words) at frame->srr0.

Aug 11 2020, 11:36 AM · PowerPC

Aug 3 2020

luporl accepted D25785: Fix mpr driver endianness.
Aug 3 2020, 7:01 PM · PowerPC

Jul 29 2020

luporl added a comment to D25785: Fix mpr driver endianness.

Nice. I just have a few more nitpicks.

Jul 29 2020, 11:36 AM · PowerPC

Jul 27 2020

luporl added inline comments to D25785: Fix mpr driver endianness.
Jul 27 2020, 5:23 PM · PowerPC

Jul 21 2020

luporl added a comment to D25237: Implement superpages for PowerPC64 (HPT).

Just for the record, measuring buildworld (as well as kernel and libc builds) times with superpages enabled and disabled didn't show any significant variation.
But when comparing the build times with a kernel that has D25237 vs one without it, there is a consistent performance hit of about 3%.

Jul 21 2020, 7:18 PM · PowerPC
luporl added inline comments to D25237: Implement superpages for PowerPC64 (HPT).
Jul 21 2020, 7:02 PM · PowerPC
luporl updated the diff for D25237: Implement superpages for PowerPC64 (HPT).
  • Address jhibbits comments
Jul 21 2020, 6:58 PM · PowerPC

Jul 20 2020

luporl committed rS363376: MFC r362958.
MFC r362958
Jul 20 2020, 8:20 PM
luporl committed rS363372: MFC r362958.
MFC r362958
Jul 20 2020, 5:04 PM

Jul 15 2020

luporl closed D25654: Use PVO_PADDR to get the PA from PVO.
Jul 15 2020, 1:44 PM · PowerPC
luporl committed rS363222: [PowerPC] Use PVO_PADDR to get the PA from PVO.
[PowerPC] Use PVO_PADDR to get the PA from PVO
Jul 15 2020, 1:44 PM

Jul 14 2020

luporl updated the summary of D25237: Implement superpages for PowerPC64 (HPT).
Jul 14 2020, 6:33 PM · PowerPC

Jul 13 2020

luporl updated the diff for D25237: Implement superpages for PowerPC64 (HPT).

Moved PVO_PADDR() changes to another diff (D25654).

Jul 13 2020, 8:13 PM · PowerPC
luporl requested review of D25654: Use PVO_PADDR to get the PA from PVO.
Jul 13 2020, 8:03 PM · PowerPC
luporl requested review of D25651: [PPC] Make new auxv format default.
Jul 13 2020, 6:10 PM · PowerPC

Jul 6 2020

luporl committed rS362958: Handle non-PLT GNU IFUNC relocations in rtld.
Handle non-PLT GNU IFUNC relocations in rtld
Jul 6 2020, 11:58 AM
luporl closed D25550: Handle non-PLT GNU IFUNC relocations in rtld.
Jul 6 2020, 11:58 AM

Jul 3 2020

luporl updated the diff for D25550: Handle non-PLT GNU IFUNC relocations in rtld.

Address kib's review comments

Jul 3 2020, 6:15 PM
luporl added inline comments to D25550: Handle non-PLT GNU IFUNC relocations in rtld.
Jul 3 2020, 6:14 PM
luporl added a comment to D25550: Handle non-PLT GNU IFUNC relocations in rtld.
In D25550#564939, @kib wrote:

Provide the amd64 example, in binary form.

Jul 3 2020, 4:45 PM

Jul 2 2020

luporl requested review of D25550: Handle non-PLT GNU IFUNC relocations in rtld.
Jul 2 2020, 7:10 PM

Jul 1 2020

luporl added a comment to D25237: Implement superpages for PowerPC64 (HPT).

As an intermediate first diff it would be nice to split out the changes to use PVO_PADDR().

Do you have an idea where the slowdown is coming from with pg_ps_enabled=1?

Jul 1 2020, 1:35 PM · PowerPC

Jun 18 2020

luporl added a comment to D25237: Implement superpages for PowerPC64 (HPT).

Right now I'm planning to profile the code to try to improve superpages performance, that should at least present some gain over not using it.

Jun 18 2020, 9:18 AM · PowerPC
luporl updated the diff for D25237: Implement superpages for PowerPC64 (HPT).
  • Add more specific sysctl counters about promotion failures.
  • Add an early check to handle a very common promote fail case, that dramatically reduces the number of promotion failures and improves buildworld performance substantially.
  • Factor out different PPC64 tlbie instruction forms into an ifunc, which also corrects large page invalidation on older cores.
Jun 18 2020, 9:18 AM · PowerPC

Jun 15 2020

luporl updated the summary of D25237: Implement superpages for PowerPC64 (HPT).
Jun 15 2020, 5:24 PM · PowerPC
luporl updated the diff for D25237: Implement superpages for PowerPC64 (HPT).
  • Address jhibbits' comments
Jun 15 2020, 5:20 PM · PowerPC
luporl added inline comments to D25237: Implement superpages for PowerPC64 (HPT).
Jun 15 2020, 5:04 PM · PowerPC

Jun 12 2020

luporl updated the summary of D25237: Implement superpages for PowerPC64 (HPT).
Jun 12 2020, 5:32 PM · PowerPC
luporl updated the summary of D25237: Implement superpages for PowerPC64 (HPT).
Jun 12 2020, 2:35 PM · PowerPC

Jun 11 2020

luporl updated the diff for D25237: Implement superpages for PowerPC64 (HPT).
  • add missing count increment when handling superpages, in moea64_clear_bit()
Jun 11 2020, 7:32 PM · PowerPC
luporl requested review of D25237: Implement superpages for PowerPC64 (HPT).
Jun 11 2020, 6:54 PM · PowerPC

Apr 7 2020

luporl committed rS359716: Add support to MSDOS FS in PPC loader.
Add support to MSDOS FS in PPC loader
Apr 7 2020, 7:46 PM
luporl closed D24328: Add support to MSDOS FS in PPC loader.
Apr 7 2020, 7:46 PM · PowerPC
luporl created D24329: loader: allow TFTP to be used by default.
Apr 7 2020, 7:35 PM
luporl created D24328: Add support to MSDOS FS in PPC loader.
Apr 7 2020, 6:33 PM · PowerPC
luporl closed D24313: [PPC] Fix loader call to instantiate-rtas.
Apr 7 2020, 12:46 PM · PowerPC
luporl committed rS359687: [PPC] Fix loader call to instantiate-rtas.
[PPC] Fix loader call to instantiate-rtas
Apr 7 2020, 12:46 PM

Apr 6 2020

luporl created D24313: [PPC] Fix loader call to instantiate-rtas.
Apr 6 2020, 5:12 PM · PowerPC

Mar 26 2020

luporl closed D24185: [PowerPC64] Fix OPAL IPMI driver.
Mar 26 2020, 12:18 PM · PowerPC
luporl committed rS359329: [PowerPC64] Fix OPAL IPMI driver.
[PowerPC64] Fix OPAL IPMI driver
Mar 26 2020, 12:18 PM