Page MenuHomeFreeBSD

luporl (Leandro Lupori)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2019, 7:21 PM (24 w, 1 d)

Recent Activity

Wed, Jun 19

D20694: powerpc64/pmap: Reduce scope of PV_LOCK in remove path is now accepted and ready to land.

Nice, LGTM.

Wed, Jun 19, 11:46 AM

Mon, Jun 17

luporl created D20676: [PPC] Fix loader input with newer QEMU versions.
Mon, Jun 17, 7:34 PM

Fri, Jun 14

luporl updated the summary of D20640: Enable use of ofwcons for early debug.
Fri, Jun 14, 7:07 PM
luporl created D20640: Enable use of ofwcons for early debug.
Fri, Jun 14, 7:05 PM

Tue, Jun 11

luporl accepted D20608: Fix PPC970 boot after r348783.

Looks good, thanks for fixing this.
I've tested this on QEMU, both with and without huge pages and it worked fine.

Tue, Jun 11, 5:19 PM · PowerPC
luporl committed rS348900: [PPC] Fix build error when POWERNV is disabled.
[PPC] Fix build error when POWERNV is disabled
Tue, Jun 11, 11:23 AM
luporl committed rS348899: [PPC64] Fix ofw_initrd.
[PPC64] Fix ofw_initrd
Tue, Jun 11, 11:17 AM
luporl closed D20553: [PPC64] Fix ofw_initrd.
Tue, Jun 11, 11:17 AM

Fri, Jun 7

luporl committed rS348783: [PPC64] Support QEMU/KVM pseries without hugepages.
[PPC64] Support QEMU/KVM pseries without hugepages
Fri, Jun 7, 5:59 PM
luporl closed D20522: [PPC64] Support QEMU/KVM pseries without hugepages.
Fri, Jun 7, 5:59 PM
luporl added inline comments to D20522: [PPC64] Support QEMU/KVM pseries without hugepages.
Fri, Jun 7, 5:52 PM
luporl created D20553: [PPC64] Fix ofw_initrd.
Fri, Jun 7, 5:15 PM
luporl added inline comments to D20522: [PPC64] Support QEMU/KVM pseries without hugepages.
Fri, Jun 7, 12:48 PM

Wed, Jun 5

luporl commandeered D15369: strncpy optimization for PowerPC64.
Wed, Jun 5, 6:18 PM · PowerPC
luporl updated the summary of D20522: [PPC64] Support QEMU/KVM pseries without hugepages.
Wed, Jun 5, 4:14 PM
luporl created D20522: [PPC64] Support QEMU/KVM pseries without hugepages.
Wed, Jun 5, 4:07 PM
luporl committed rS348691: MFC r345676:.
MFC r345676:
Wed, Jun 5, 2:23 PM
luporl committed rS348690: MFC r343744:.
MFC r343744:
Wed, Jun 5, 2:20 PM
luporl committed rS348686: MFC r348028:.
MFC r348028:
Wed, Jun 5, 12:53 PM
luporl committed rS348685: MFC r348112:.
MFC r348112:
Wed, Jun 5, 12:44 PM
luporl committed rS348684: MFC r348025:.
MFC r348025:
Wed, Jun 5, 12:39 PM
luporl committed rS348683: MFC r348005:.
MFC r348005:
Wed, Jun 5, 12:34 PM

May 24 2019

luporl committed rS348248: Make options MD_ROOT_MEM default on PPC64.
Make options MD_ROOT_MEM default on PPC64
May 24 2019, 6:41 PM
luporl abandoned D15339: Mark relocated memory region as valid.

This is pretty old and it seems the issue that this change was supposed to fix was already fixed in a proper way quite some time ago.

May 24 2019, 3:32 PM
luporl accepted D20383: [PowerPC64] starting from FreeBSD 13.0, default 64-bit ELF ABI is V2 (ELFv2).

The change itself LGTM.

May 24 2019, 3:27 PM

May 22 2019

luporl committed rS348112: Fix PPC64 kernel build with clang8 + lld8.
Fix PPC64 kernel build with clang8 + lld8
May 22 2019, 3:56 PM
luporl closed D19352: Fix PPC64 kernel build with clang8 + lld8.
May 22 2019, 3:56 PM

May 21 2019

luporl accepted D19352: Fix PPC64 kernel build with clang8 + lld8.

LGTM. Tested on ppcdevref.

May 21 2019, 8:14 PM

May 20 2019

luporl committed rS348005: [PowerPC64] stand: fix build using clang 8 as compiler.
[PowerPC64] stand: fix build using clang 8 as compiler
May 20 2019, 7:21 PM
luporl closed D20026: [PowerPC64] stand: fix build using clang 8 as compiler.
May 20 2019, 7:21 PM
luporl committed rS347992: [PPC] Enable build/install of ld.bfd on base.
[PPC] Enable build/install of ld.bfd on base
May 20 2019, 4:00 PM
luporl closed D20259: [PPC] Enable build/install of ld.bfd on base.
May 20 2019, 4:00 PM
luporl added a comment to D19352: Fix PPC64 kernel build with clang8 + lld8.

@git_bdragon.rtk0.net, I haven't tested your last revision, but Alfredo and I have been using your previous revision for more than a month, both in ELFv1 environments as in ELFv2, with no issues so far, and it is essential for the ELFv2 transition on PPC.

May 20 2019, 1:05 PM

May 14 2019

luporl updated the test plan for D20259: [PPC] Enable build/install of ld.bfd on base.
May 14 2019, 1:27 PM
luporl created D20259: [PPC] Enable build/install of ld.bfd on base.
May 14 2019, 1:25 PM

May 10 2019

luporl committed rS347445: Fix build issue with clang 8.0.1.
Fix build issue with clang 8.0.1
May 10 2019, 5:05 PM

May 3 2019

luporl accepted D20119: powerpc: Merge all pmap struct definitions.

The 64-bit Book-E pmap overhead is around 32kB (12 bits worth of PP2D_NENTRIES, so 4096 8-byte entries), and 4kB on 32-bit. This is not small by any stretch, and I do want to rework it, and plan to over the next couple months. For now I can #ifdef within the union (I do want to keep it a union, so that we can eventually have a GENERIC that boots on both AIM and Book-E).

May 3 2019, 2:06 PM

May 2 2019

luporl added a comment to D20119: powerpc: Merge all pmap struct definitions.

Overall this change looks good to me, but I'm worried with the union of structs parts (see comment below).

May 2 2019, 5:10 PM

Apr 29 2019

luporl closed D20098: [PPC64] Turn opal_flash.c into a device.
Apr 29 2019, 4:50 PM
luporl committed rS346897: [PPC64] Turn opal_flash.c into a device.
[PPC64] Turn opal_flash.c into a device
Apr 29 2019, 4:50 PM
luporl added reviewers for D20098: [PPC64] Turn opal_flash.c into a device: jhibbits, bdragon.
Apr 29 2019, 4:37 PM
luporl created D20098: [PPC64] Turn opal_flash.c into a device.
Apr 29 2019, 4:36 PM

Apr 23 2019

luporl added a comment to D15368: strcpy optimization for PowerPC64.

I guess now this revision is waiting only for @gromero_br.ibm.com approval, right?

Apr 23 2019, 5:57 PM · PowerPC
luporl committed rS346600: [PPC64] Fix wrong KASSERT in mphyp_pte_insert().
[PPC64] Fix wrong KASSERT in mphyp_pte_insert()
Apr 23 2019, 5:12 PM
luporl closed D20012: [PPC64] Fix wrong KASSERT in mphyp_pte_insert().
Apr 23 2019, 5:11 PM

Apr 22 2019

luporl updated subscribers of D20012: [PPC64] Fix wrong KASSERT in mphyp_pte_insert().
Apr 22 2019, 5:30 PM
luporl created D20012: [PPC64] Fix wrong KASSERT in mphyp_pte_insert().
Apr 22 2019, 5:29 PM

Apr 5 2019

luporl added a comment to D19352: Fix PPC64 kernel build with clang8 + lld8.

@alfredo.junior_eldorado.org.br and I found out that a kernel linked with lld won't boot if the .toc section is merged into .got.
Also note that the ldscript change was part of the original patch by @git_bdragon.rtk0.net, but was removed when merging with @jhibbits changes (D19574).

Apr 5 2019, 9:12 PM
luporl updated the diff for D19352: Fix PPC64 kernel build with clang8 + lld8.
  • Do not ommit .toc section when linking
Apr 5 2019, 9:04 PM

Apr 1 2019

luporl accepted D19743: powerpc/powernv: Add OPAL heartbeat thread.

Ok, thanks for the explanation, then it LGTM.

Apr 1 2019, 3:51 PM
luporl updated the summary of D19352: Fix PPC64 kernel build with clang8 + lld8.
Apr 1 2019, 2:03 PM
luporl updated the diff for D19352: Fix PPC64 kernel build with clang8 + lld8.

Patch updated, merged with parts already commited

Apr 1 2019, 1:24 PM
luporl added a comment to D19743: powerpc/powernv: Add OPAL heartbeat thread.

Looks good overall, but check the comments below.

Apr 1 2019, 12:53 PM

Mar 26 2019

luporl accepted D19708: powerpc64: Use medium code model in asm files for TOC references.

LGTM.
I see this is basically a subset of D19352, with the exception of booke/locore.S, right?
BTW, I need to come back to D19352 and refactor it.

Mar 26 2019, 2:00 PM

Mar 20 2019

luporl accepted D19634: powerpc: Add Hypervisor Maintenance Interrupt handler.

I'm on the fence between interrupt.c and trap.c. I put it in interrupt.c for the following reasons:
a) Avoid duplicating code between the user and kernel checks
b) Avoid enabling the EE bit when handling the HMI
Neither are critical, I think, so if there are strong feelings one way or another I can yield to it.

Mar 20 2019, 7:16 PM

Mar 19 2019

luporl added a comment to D19634: powerpc: Add Hypervisor Maintenance Interrupt handler.

The code looks good to me.
But I'm not sure if it is better to handle this in interrupt.c or trap.c. Why do you think it fits better in interrupt.c?

Mar 19 2019, 5:15 PM

Mar 6 2019

luporl added a comment to D19352: Fix PPC64 kernel build with clang8 + lld8.

I've confirmed that a kernel with this change compiles fine with base gcc + ld, and works fine on both pseries (qemu+kvm) and powernv (power8 machine).

Mar 6 2019, 6:07 PM

Feb 27 2019

luporl committed rS344622: power8_bringup_hacks branch is not needed anymore.
power8_bringup_hacks branch is not needed anymore
Feb 27 2019, 2:20 PM
luporl committed rS344620: Fix kldxref on PowerPC64.
Fix kldxref on PowerPC64
Feb 27 2019, 1:25 PM
luporl closed D19370: Fix kldxref on PowerPC64.
Feb 27 2019, 1:24 PM

Feb 26 2019

luporl added a reviewer for D19370: Fix kldxref on PowerPC64: emaste.
Feb 26 2019, 9:17 PM
luporl created D19370: Fix kldxref on PowerPC64.
Feb 26 2019, 9:13 PM

Feb 25 2019

luporl committed rS344534: Increase ctfconvert buffer size.
Increase ctfconvert buffer size
Feb 25 2019, 6:53 PM
luporl closed D19353: Increase ctfconvert buffer size.
Feb 25 2019, 6:53 PM
luporl updated subscribers of D19353: Increase ctfconvert buffer size.
Feb 25 2019, 6:50 PM
luporl created D19353: Increase ctfconvert buffer size.
Feb 25 2019, 6:46 PM
luporl updated subscribers of D19352: Fix PPC64 kernel build with clang8 + lld8.
Feb 25 2019, 6:15 PM
luporl updated the summary of D19352: Fix PPC64 kernel build with clang8 + lld8.
Feb 25 2019, 6:15 PM
luporl created D19352: Fix PPC64 kernel build with clang8 + lld8.
Feb 25 2019, 5:53 PM

Feb 14 2019

luporl closed D19166: [PPC64] Fix mismatch between thread flags and MSR.
Feb 14 2019, 3:15 PM
luporl committed rS344123: [PPC64] Fix mismatch between thread flags and MSR.
[PPC64] Fix mismatch between thread flags and MSR
Feb 14 2019, 3:15 PM

Feb 13 2019

luporl closed D18807: silence cast-align warnings from clang on powerpc64.
Feb 13 2019, 6:29 PM
luporl committed rS344109: silence cast-align warnings from clang on powerpc64.
silence cast-align warnings from clang on powerpc64
Feb 13 2019, 6:29 PM
luporl accepted D18807: silence cast-align warnings from clang on powerpc64.

Approving the minor '-' signal move to unblock this change.

Feb 13 2019, 6:22 PM

Feb 12 2019

luporl added a reviewer for D19166: [PPC64] Fix mismatch between thread flags and MSR: jhibbits.
Feb 12 2019, 6:52 PM
luporl created D19166: [PPC64] Fix mismatch between thread flags and MSR.
Feb 12 2019, 6:50 PM
luporl closed D19149: [ppc64] prevent infinite loop on icache sync.
Feb 12 2019, 11:29 AM
luporl committed rS344049: [ppc64] prevent infinite loop on icache sync.
[ppc64] prevent infinite loop on icache sync
Feb 12 2019, 11:29 AM

Feb 11 2019

luporl updated the summary of D19149: [ppc64] prevent infinite loop on icache sync.
Feb 11 2019, 6:49 PM
luporl updated the summary of D19149: [ppc64] prevent infinite loop on icache sync.
Feb 11 2019, 6:41 PM
luporl created D19149: [ppc64] prevent infinite loop on icache sync.
Feb 11 2019, 6:14 PM

Feb 7 2019

luporl closed D19086: [ppc64] fix /dev/kmem.
Feb 7 2019, 5:31 PM
luporl committed rS343872: [ppc64] fix /dev/kmem.
[ppc64] fix /dev/kmem
Feb 7 2019, 5:31 PM

Feb 5 2019

luporl updated the summary of D19086: [ppc64] fix /dev/kmem.
Feb 5 2019, 6:29 PM
luporl updated the test plan for D19086: [ppc64] fix /dev/kmem.
Feb 5 2019, 6:26 PM
luporl created D19086: [ppc64] fix /dev/kmem.
Feb 5 2019, 6:23 PM
luporl committed rS343791: [ppc64] llan: fix fatal kernel trap when system is low on memory.
[ppc64] llan: fix fatal kernel trap when system is low on memory
Feb 5 2019, 6:16 PM
luporl closed D19084: [ppc64] llan: fix fatal kernel trap when system is low on memory.
Feb 5 2019, 6:16 PM
luporl added reviewers for D19084: [ppc64] llan: fix fatal kernel trap when system is low on memory: nwhitehorn, jhibbits.
Feb 5 2019, 11:16 AM
luporl created D19084: [ppc64] llan: fix fatal kernel trap when system is low on memory.
Feb 5 2019, 11:11 AM

Feb 4 2019

luporl committed rS343744: powerpc64: Add a trap stack area.
powerpc64: Add a trap stack area
Feb 4 2019, 4:02 PM
luporl closed D14484: powerpc64: Add a trap stack area.
Feb 4 2019, 4:02 PM · PowerPC
luporl added a comment to D14484: powerpc64: Add a trap stack area.

@jhibbits, is this change good to go now? It would be nice to get DDB working on boot.

Feb 4 2019, 3:21 PM · PowerPC

Jan 8 2019

luporl committed rD52753: Changed PGP key.
Changed PGP key
Jan 8 2019, 5:57 PM

Jan 7 2019

luporl updated luporl.
Jan 7 2019, 7:40 PM
luporl commandeered D15339: Mark relocated memory region as valid.
Jan 7 2019, 7:38 PM
Herald updated subscribers of D17806: ppc64: handle exception 0x1500 (soft patch).
Jan 7 2019, 7:35 PM