In D31109#704608, @mhorne wrote:

Looks good, thanks for finishing this. Will you handle the removal of the static power8 definitions as well?

This approach of auto detecting the correct frame buffer physical address based on Vendor ID looks good.
It would help to make FreeBSD graphics work out of the box for Blackbird and Talos II machines, instead of forcing the user to figure out the physical address of its VGA adapter and pass it to the kernel manually, or else the system just hangs.
Ideally, Petitboot should fix it on their side, but I don't know if it will happen anytime soon, since Linux isn't affected, because it just talks directly to ASPEED video device, instead of relying on the framebuffer info exposed in the device tree.

D31232 fixes OFWFB with radix. After it lands it should be safe to make radix default.

@imp I've added the rate limiter, do you think this revision is ok now?

• Fix event name mapping
• Handle non-programmable PMCs (PMC5 and PMC6)
• Add missing event counter check

Commandeering revision to finish changes while Leonardo is out.

LGTM. The changes are similar to the PPC64 ones, in D31109.

I have investigated the issue further and have some suggestions of how it can be fixed (inline).

Overall the changes look good.

Address review's comments

Address review's comments.

LGTM. The code is also easier to read now, without those hw_direct_map conditionals.

Address jhibbits' comments

LGTM

LGTM.

Rebased.

Your changes look good to me overall.

It looks great now! Since this changes core libc functions, can you perform a buildworld on a system with the modified libc installed to confirm everything works fine?

@bruno.larsen_eldorado.org.br, overall your changes look good to me.
I have only one more suggestion and some nitpicks.

In D28776#646046, @alfredo wrote:

In D28776#645964, @bruno.larsen_eldorado.org.br wrote:

• improved formatting
• solution to the problem outlined by luporl

The alignment problem is solved, but this patch makes bcopy performance go down by a factor of 10. I think a third version of the code should be considered, restricting this patch only to POWER7 CPUs.

Does it produce any gain over original non-optimized code on Power7? If there's no gain I'd suggest restrict optimizations to ISA >= v.2.07 (POWER8). And in this case, remove unaligned access handling since newer CPUs can handle it transparently.

If there's still a gain I agree with having two optimized versions one handling VSX & ISA <=2.06 and the other for VSX & ISA >=2.07 (probably removing unaligned handling to make code simpler if no negative performance impact)

Worked fine on PPC64LE, both on Talos and QEMU, with D27475 to fix boot with ofwfb on LE.

Looks good. I have been using a slightly modified version of this on Talos II and it is working well.

Using only htole64() won't work in all cases.

The changes look good to me overall.

Leave superpages disabled by default

Wow, that's really a lot of endianness fixes, nice job!