Page MenuHomeFreeBSD

luporl (Leandro Lupori)
Engineering

Projects

User Details

User Since
Jan 7 2019, 7:21 PM (134 w, 10 h)

Recent Activity

Fri, Jul 30

luporl added inline comments to D31232: powerpc64: fix OFWFB with Radix MMU.
Fri, Jul 30, 2:33 PM · PowerPC

Thu, Jul 29

luporl committed R10:95d619a8ea1f: hwpmc: remove static POWER8 definitions (authored by luporl).
hwpmc: remove static POWER8 definitions
Thu, Jul 29, 5:57 PM
luporl closed D31334: hwpmc: remove static POWER8 definitions.
Thu, Jul 29, 5:57 PM
luporl added inline comments to D31334: hwpmc: remove static POWER8 definitions.
Thu, Jul 29, 5:33 PM

Wed, Jul 28

luporl abandoned D24329: loader: allow TFTP to be used by default.
Wed, Jul 28, 5:42 PM
luporl abandoned D21554: Fix kvm bitmap index.
Wed, Jul 28, 5:38 PM
luporl committed R10:7844e5a4fc0a: powerpc: change mfpvr return type to uint32_t (authored by luporl).
powerpc: change mfpvr return type to uint32_t
Wed, Jul 28, 5:11 PM
luporl closed D31332: powerpc: change mfpvr return type to uint32_t.
Wed, Jul 28, 5:11 PM
luporl requested review of D31334: hwpmc: remove static POWER8 definitions.
Wed, Jul 28, 4:54 PM
luporl requested review of D31332: powerpc: change mfpvr return type to uint32_t.
Wed, Jul 28, 12:41 PM

Mon, Jul 26

luporl committed R10:0f47f916811a: hwpmc: fix powerpc/powerpcspe builds (authored by luporl).
hwpmc: fix powerpc/powerpcspe builds
Mon, Jul 26, 4:37 PM
luporl committed R10:b48a2770d48b: powerpc64: add Power8 and Power9 PMCs (authored by luporl).
powerpc64: add Power8 and Power9 PMCs
Mon, Jul 26, 1:31 PM
luporl closed D31109: Add Power8 and Power9 PMCs.
Mon, Jul 26, 1:31 PM

Fri, Jul 23

luporl added a comment to D31109: Add Power8 and Power9 PMCs.

Looks good, thanks for finishing this. Will you handle the removal of the static power8 definitions as well?

Fri, Jul 23, 4:36 PM
luporl added a comment to D30626: ofwfb: fix vga/hdmi console during boot on powerpc64.

This approach of auto detecting the correct frame buffer physical address based on Vendor ID looks good.
It would help to make FreeBSD graphics work out of the box for Blackbird and Talos II machines, instead of forcing the user to figure out the physical address of its VGA adapter and pass it to the kernel manually, or else the system just hangs.
Ideally, Petitboot should fix it on their side, but I don't know if it will happen anytime soon, since Linux isn't affected, because it just talks directly to ASPEED video device, instead of relying on the framebuffer info exposed in the device tree.

Fri, Jul 23, 2:49 PM · PowerPC
luporl added a reviewer for D29000: ofwfb: export RGB offsets with FBIO_GETRGBOFFS: emaste.
Fri, Jul 23, 12:26 PM · PowerPC
luporl added inline comments to D29000: ofwfb: export RGB offsets with FBIO_GETRGBOFFS.
Fri, Jul 23, 12:26 PM · PowerPC
luporl added a reviewer for D31109: Add Power8 and Power9 PMCs: PowerPC.
Fri, Jul 23, 11:53 AM
luporl added a comment to D30797: powerpc64: make radix with superpages default.

D31232 fixes OFWFB with radix. After it lands it should be safe to make radix default.

Fri, Jul 23, 11:51 AM · PowerPC
luporl added a reviewer for D30799: aacraid: log DMA failures: imp.
Fri, Jul 23, 11:48 AM
luporl added a comment to D30799: aacraid: log DMA failures.

@imp I've added the rate limiter, do you think this revision is ok now?

Fri, Jul 23, 11:47 AM
luporl committed R10:572e3575dba5: aacraid: reduce max I/O size to avoid DMA issues (authored by luporl).
aacraid: reduce max I/O size to avoid DMA issues
Fri, Jul 23, 11:31 AM

Wed, Jul 21

luporl updated the diff for D31109: Add Power8 and Power9 PMCs.
  • Fix event name mapping
  • Handle non-programmable PMCs (PMC5 and PMC6)
  • Add missing event counter check
Wed, Jul 21, 6:46 PM
luporl commandeered D31109: Add Power8 and Power9 PMCs.

Commandeering revision to finish changes while Leonardo is out.

Wed, Jul 21, 6:42 PM

Tue, Jul 20

luporl accepted D31221: Fix various issues with commit 28dd6730a5d6, 8cc3815f02be.

LGTM. The changes are similar to the PPC64 ones, in D31109.

Tue, Jul 20, 2:08 PM
luporl added inline comments to D31109: Add Power8 and Power9 PMCs.
Tue, Jul 20, 1:53 PM
luporl requested review of D31232: powerpc64: fix OFWFB with Radix MMU.
Tue, Jul 20, 1:16 PM · PowerPC

Thu, Jul 15

luporl added a comment to D31109: Add Power8 and Power9 PMCs.

I have investigated the issue further and have some suggestions of how it can be fixed (inline).

Thu, Jul 15, 7:43 PM
luporl added a comment to D31109: Add Power8 and Power9 PMCs.

Overall the changes look good.

Thu, Jul 15, 5:06 PM

Jun 21 2021

luporl committed R10:71fd1bfd5ed5: aacraid: ignore data overrun on INQUIRY (authored by luporl).
aacraid: ignore data overrun on INQUIRY
Jun 21 2021, 6:16 PM
luporl closed D30843: aacraid: ignore data overrun on INQUIRY.
Jun 21 2021, 6:16 PM
luporl committed R10:9c2c6353193b: aacraid: reduce max I/O size to avoid DMA issues (authored by luporl).
aacraid: reduce max I/O size to avoid DMA issues
Jun 21 2021, 6:11 PM
luporl closed D30798: aacraid: reduce max I/O size to avoid DMA issues.
Jun 21 2021, 6:11 PM
luporl added inline comments to D30799: aacraid: log DMA failures.
Jun 21 2021, 5:57 PM
luporl updated the diff for D30799: aacraid: log DMA failures.

Address review's comments

Jun 21 2021, 5:48 PM
luporl added inline comments to D30798: aacraid: reduce max I/O size to avoid DMA issues.
Jun 21 2021, 3:01 PM
luporl updated the summary of D30798: aacraid: reduce max I/O size to avoid DMA issues.
Jun 21 2021, 3:00 PM
luporl updated the diff for D30798: aacraid: reduce max I/O size to avoid DMA issues.

Address review's comments.

Jun 21 2021, 2:59 PM
luporl requested review of D30843: aacraid: ignore data overrun on INQUIRY.
Jun 21 2021, 2:41 PM

Jun 17 2021

luporl added reviewers for D30799: aacraid: log DMA failures: jhibbits, scottl, emaste.
Jun 17 2021, 1:14 PM
luporl added reviewers for D30798: aacraid: reduce max I/O size to avoid DMA issues: jhibbits, scottl, emaste.
Jun 17 2021, 1:14 PM
luporl updated the summary of D30798: aacraid: reduce max I/O size to avoid DMA issues.
Jun 17 2021, 1:13 PM
luporl requested review of D30799: aacraid: log DMA failures.
Jun 17 2021, 12:50 PM
luporl requested review of D30798: aacraid: reduce max I/O size to avoid DMA issues.
Jun 17 2021, 12:11 PM
luporl requested review of D30797: powerpc64: make radix with superpages default.
Jun 17 2021, 11:20 AM · PowerPC

Jun 2 2021

luporl committed R10:4a66b8083cc6: powerpc: fix boot on pseries without hugepages (authored by luporl).
powerpc: fix boot on pseries without hugepages
Jun 2 2021, 7:29 PM

May 14 2021

luporl accepted D29809: Make ISA_206_ATOMICS a kernel option.
May 14 2021, 12:01 PM

May 10 2021

luporl added inline comments to D29000: ofwfb: export RGB offsets with FBIO_GETRGBOFFS.
May 10 2021, 7:25 PM · PowerPC

May 5 2021

luporl accepted D30071: powerpc64: Split out DMAP and non-DMAP implementations of some methods.

LGTM. The code is also easier to read now, without those hw_direct_map conditionals.

May 5 2021, 12:16 PM

Apr 22 2021

luporl committed R10:019cdd20bbd3: powerpc64: add missing TLB invalidations to radix (authored by luporl).
powerpc64: add missing TLB invalidations to radix
Apr 22 2021, 2:32 PM
luporl committed R10:f05174ed3547: powerpc64: clear low-order bits of ARPN (authored by luporl).
powerpc64: clear low-order bits of ARPN
Apr 22 2021, 2:31 PM

Apr 20 2021

luporl accepted D26040: Fix mprutil endianness.
Apr 20 2021, 7:22 PM · PowerPC

Apr 16 2021

luporl accepted D29063: [POWERPC] opal_console: fix serial console output corruption.
Apr 16 2021, 2:32 PM · PowerPC

Apr 9 2021

luporl added inline comments to D29063: [POWERPC] opal_console: fix serial console output corruption.
Apr 9 2021, 12:09 PM · PowerPC

Apr 6 2021

luporl committed R10:32b50b8520d0: powerpc64: support superpages on pmap_mincore (authored by luporl).
powerpc64: support superpages on pmap_mincore
Apr 6 2021, 11:49 AM
luporl closed D29511: powerpc64: add missing TLB invalidations to radix.
Apr 6 2021, 11:43 AM · PowerPC
luporl committed R10:28d14569c873: powerpc64: add missing TLB invalidations to radix (authored by luporl).
powerpc64: add missing TLB invalidations to radix
Apr 6 2021, 11:43 AM
luporl committed R10:1805ce694542: powerpc64: enforce natural alignment in bcopy (authored by luporl).
powerpc64: enforce natural alignment in bcopy
Apr 6 2021, 11:30 AM
luporl committed R10:e21b6ce854f2: [PowerPC64] Port optimized strcpy to PPC64LE (authored by luporl).
[PowerPC64] Port optimized strcpy to PPC64LE
Apr 6 2021, 11:28 AM

Apr 5 2021

luporl updated the diff for D29511: powerpc64: add missing TLB invalidations to radix.

Address jhibbits' comments

Apr 5 2021, 6:00 PM · PowerPC

Mar 31 2021

luporl added reviewers for D29511: powerpc64: add missing TLB invalidations to radix: bdragon, jhibbits, PowerPC.
Mar 31 2021, 12:13 PM · PowerPC
luporl requested review of D29511: powerpc64: add missing TLB invalidations to radix.
Mar 31 2021, 12:12 PM · PowerPC

Mar 30 2021

luporl committed R10:75e67b4920f2: powerpc64: support superpages on pmap_mincore (authored by luporl).
powerpc64: support superpages on pmap_mincore
Mar 30 2021, 7:14 PM
luporl closed D29230: Add support for superpages - pmap_mincore [powerpc64].
Mar 30 2021, 7:13 PM · PowerPC

Mar 25 2021

luporl committed R10:3d0399c718b2: [PowerPC64] Clear low-order bits of ARPN (authored by luporl).
[PowerPC64] Clear low-order bits of ARPN
Mar 25 2021, 5:06 PM
luporl closed D29067: powerpc64le: port optimized strcpy for LE version of processor.
Mar 25 2021, 4:21 PM · PowerPC
luporl committed R10:9f50aa45be18: [PowerPC64] Port optimized strcpy to PPC64LE (authored by luporl).
[PowerPC64] Port optimized strcpy to PPC64LE
Mar 25 2021, 4:21 PM
luporl committed R10:2f561284033c: [PowerPC64] Enforce natural alignment in bcopy (authored by luporl).
[PowerPC64] Enforce natural alignment in bcopy
Mar 25 2021, 4:12 PM
luporl closed D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.
Mar 25 2021, 4:11 PM · PowerPC

Mar 24 2021

luporl accepted D29230: Add support for superpages - pmap_mincore [powerpc64].

LGTM

Mar 24 2021, 11:39 AM · PowerPC

Mar 22 2021

luporl committed R10:3aa6cc000f74: ofwfb: fix boot on LE (authored by luporl).
ofwfb: fix boot on LE
Mar 22 2021, 1:53 PM

Mar 9 2021

luporl committed R10:043577b721ec: ofwfb: fix boot on LE (authored by luporl).
ofwfb: fix boot on LE
Mar 9 2021, 4:44 PM
luporl closed D27475: ofwfb: fix boot on LE.
Mar 9 2021, 4:43 PM · PowerPC
luporl accepted D29067: powerpc64le: port optimized strcpy for LE version of processor.

LGTM.

Mar 9 2021, 11:48 AM · PowerPC

Mar 8 2021

luporl updated the diff for D27475: ofwfb: fix boot on LE.

Rebased.

Mar 8 2021, 6:37 PM · PowerPC
luporl added inline comments to D29067: powerpc64le: port optimized strcpy for LE version of processor.
Mar 8 2021, 6:00 PM · PowerPC
luporl added a comment to D29063: [POWERPC] opal_console: fix serial console output corruption.

Your changes look good to me overall.

Mar 8 2021, 5:45 PM · PowerPC

Mar 1 2021

luporl added reviewers for D29000: ofwfb: export RGB offsets with FBIO_GETRGBOFFS: alfredo, bdragon, jhibbits, nwhitehorn.
Mar 1 2021, 6:27 PM · PowerPC
luporl requested review of D29000: ofwfb: export RGB offsets with FBIO_GETRGBOFFS.
Mar 1 2021, 6:22 PM · PowerPC

Feb 24 2021

luporl added inline comments to D27475: ofwfb: fix boot on LE.
Feb 24 2021, 7:49 PM · PowerPC
luporl accepted D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.

It looks great now! Since this changes core libc functions, can you perform a buildworld on a system with the modified libc installed to confirm everything works fine?

Feb 24 2021, 12:36 PM · PowerPC

Feb 22 2021

luporl added a comment to D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.

@bruno.larsen_eldorado.org.br, overall your changes look good to me.
I have only one more suggestion and some nitpicks.

Feb 22 2021, 6:37 PM · PowerPC
luporl added a comment to D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.
  • improved formatting
  • solution to the problem outlined by luporl

The alignment problem is solved, but this patch makes bcopy performance go down by a factor of 10. I think a third version of the code should be considered, restricting this patch only to POWER7 CPUs.

Does it produce any gain over original non-optimized code on Power7? If there's no gain I'd suggest restrict optimizations to ISA >= v.2.07 (POWER8). And in this case, remove unaligned access handling since newer CPUs can handle it transparently.

If there's still a gain I agree with having two optimized versions one handling VSX & ISA <=2.06 and the other for VSX & ISA >=2.07 (probably removing unaligned handling to make code simpler if no negative performance impact)

Feb 22 2021, 5:02 PM · PowerPC

Feb 19 2021

luporl accepted D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.

Worked fine on PPC64LE, both on Talos and QEMU, with D27475 to fix boot with ofwfb on LE.

Feb 19 2021, 12:02 PM · PowerPC

Feb 18 2021

luporl added inline comments to D27475: ofwfb: fix boot on LE.
Feb 18 2021, 9:07 PM · PowerPC
luporl added inline comments to D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.
Feb 18 2021, 7:14 PM · PowerPC
luporl added inline comments to D27475: ofwfb: fix boot on LE.
Feb 18 2021, 5:50 PM · PowerPC

Feb 12 2021

luporl added a comment to D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.

Looks good. I have been using a slightly modified version of this on Talos II and it is working well.

Feb 12 2021, 12:44 PM · PowerPC

Feb 5 2021

luporl added a comment to D28494: mrsas: unbreak i386 build.

Using only htole64() won't work in all cases.

Feb 5 2021, 4:30 PM

Dec 4 2020

luporl requested review of D27475: ofwfb: fix boot on LE.
Dec 4 2020, 2:56 PM · PowerPC

Nov 25 2020

luporl accepted D26531: mrsas: Add big-endian support.
Nov 25 2020, 7:36 PM · PowerPC

Nov 17 2020

luporl closed D27156: [PowerPC] Don't overwrite vm.pmap sysctl node.
Nov 17 2020, 11:36 AM · PowerPC
luporl committed rS367758: [PowerPC] Don't overwrite vm.pmap sysctl node.
[PowerPC] Don't overwrite vm.pmap sysctl node
Nov 17 2020, 11:36 AM

Nov 16 2020

luporl added a comment to D26531: mrsas: Add big-endian support.

The changes look good to me overall.

Nov 16 2020, 6:10 PM · PowerPC
luporl updated the diff for D27156: [PowerPC] Don't overwrite vm.pmap sysctl node.

Leave superpages disabled by default

Nov 16 2020, 4:48 PM · PowerPC

Nov 13 2020

luporl accepted D27201: [POWERPC] msun: fix incorrect flag in fesetexceptflag.
Nov 13 2020, 7:54 PM · PowerPC
luporl accepted D27181: [PowerPC64LE] Radix fixes for LE.

Wow, that's really a lot of endianness fixes, nice job!

Nov 13 2020, 2:13 PM · PowerPC

Nov 9 2020

luporl requested review of D27156: [PowerPC] Don't overwrite vm.pmap sysctl node.
Nov 9 2020, 8:31 PM · PowerPC

Nov 6 2020

luporl committed rS367427: Fix powerpc and LINT builds.
Fix powerpc and LINT builds
Nov 6 2020, 6:50 PM
luporl closed D25237: Implement superpages for PowerPC64 (HPT).
Nov 6 2020, 2:13 PM · PowerPC