Page MenuHomeFreeBSD

luporl (Leandro Lupori)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2019, 7:21 PM (14 w, 5 d)

Recent Activity

Fri, Apr 5

luporl added a comment to D19352: Fix PPC64 kernel build with clang8 + lld8.

@alfredo.junior_eldorado.org.br and I found out that a kernel linked with lld won't boot if the .toc section is merged into .got.
Also note that the ldscript change was part of the original patch by @git_bdragon.rtk0.net, but was removed when merging with @jhibbits changes (D19574).

Fri, Apr 5, 9:12 PM
luporl updated the diff for D19352: Fix PPC64 kernel build with clang8 + lld8.
  • Do not ommit .toc section when linking
Fri, Apr 5, 9:04 PM

Mon, Apr 1

luporl accepted D19743: powerpc/powernv: Add OPAL heartbeat thread.

Ok, thanks for the explanation, then it LGTM.

Mon, Apr 1, 3:51 PM
luporl updated the summary of D19352: Fix PPC64 kernel build with clang8 + lld8.
Mon, Apr 1, 2:03 PM
luporl updated the diff for D19352: Fix PPC64 kernel build with clang8 + lld8.

Patch updated, merged with parts already commited

Mon, Apr 1, 1:24 PM
luporl added a comment to D19743: powerpc/powernv: Add OPAL heartbeat thread.

Looks good overall, but check the comments below.

Mon, Apr 1, 12:53 PM

Tue, Mar 26

luporl accepted D19708: powerpc64: Use medium code model in asm files for TOC references.

LGTM.
I see this is basically a subset of D19352, with the exception of booke/locore.S, right?
BTW, I need to come back to D19352 and refactor it.

Tue, Mar 26, 2:00 PM

Mar 20 2019

luporl accepted D19634: powerpc: Add Hypervisor Maintenance Interrupt handler.

I'm on the fence between interrupt.c and trap.c. I put it in interrupt.c for the following reasons:
a) Avoid duplicating code between the user and kernel checks
b) Avoid enabling the EE bit when handling the HMI
Neither are critical, I think, so if there are strong feelings one way or another I can yield to it.

Mar 20 2019, 7:16 PM

Mar 19 2019

luporl added a comment to D19634: powerpc: Add Hypervisor Maintenance Interrupt handler.

The code looks good to me.
But I'm not sure if it is better to handle this in interrupt.c or trap.c. Why do you think it fits better in interrupt.c?

Mar 19 2019, 5:15 PM

Mar 6 2019

luporl added a comment to D19352: Fix PPC64 kernel build with clang8 + lld8.

I've confirmed that a kernel with this change compiles fine with base gcc + ld, and works fine on both pseries (qemu+kvm) and powernv (power8 machine).

Mar 6 2019, 6:07 PM

Feb 27 2019

luporl committed rS344622: power8_bringup_hacks branch is not needed anymore.
power8_bringup_hacks branch is not needed anymore
Feb 27 2019, 2:20 PM
luporl committed rS344620: Fix kldxref on PowerPC64.
Fix kldxref on PowerPC64
Feb 27 2019, 1:25 PM
luporl closed D19370: Fix kldxref on PowerPC64.
Feb 27 2019, 1:24 PM

Feb 26 2019

luporl added a reviewer for D19370: Fix kldxref on PowerPC64: emaste.
Feb 26 2019, 9:17 PM
luporl created D19370: Fix kldxref on PowerPC64.
Feb 26 2019, 9:13 PM

Feb 25 2019

luporl committed rS344534: Increase ctfconvert buffer size.
Increase ctfconvert buffer size
Feb 25 2019, 6:53 PM
luporl closed D19353: Increase ctfconvert buffer size.
Feb 25 2019, 6:53 PM
luporl updated subscribers of D19353: Increase ctfconvert buffer size.
Feb 25 2019, 6:50 PM
luporl created D19353: Increase ctfconvert buffer size.
Feb 25 2019, 6:46 PM
luporl updated subscribers of D19352: Fix PPC64 kernel build with clang8 + lld8.
Feb 25 2019, 6:15 PM
luporl updated the summary of D19352: Fix PPC64 kernel build with clang8 + lld8.
Feb 25 2019, 6:15 PM
luporl created D19352: Fix PPC64 kernel build with clang8 + lld8.
Feb 25 2019, 5:53 PM

Feb 14 2019

luporl closed D19166: [PPC64] Fix mismatch between thread flags and MSR.
Feb 14 2019, 3:15 PM
luporl committed rS344123: [PPC64] Fix mismatch between thread flags and MSR.
[PPC64] Fix mismatch between thread flags and MSR
Feb 14 2019, 3:15 PM

Feb 13 2019

luporl closed D18807: silence cast-align warnings from clang on powerpc64.
Feb 13 2019, 6:29 PM
luporl committed rS344109: silence cast-align warnings from clang on powerpc64.
silence cast-align warnings from clang on powerpc64
Feb 13 2019, 6:29 PM
luporl accepted D18807: silence cast-align warnings from clang on powerpc64.

Approving the minor '-' signal move to unblock this change.

Feb 13 2019, 6:22 PM

Feb 12 2019

luporl added a reviewer for D19166: [PPC64] Fix mismatch between thread flags and MSR: jhibbits.
Feb 12 2019, 6:52 PM
luporl created D19166: [PPC64] Fix mismatch between thread flags and MSR.
Feb 12 2019, 6:50 PM
luporl closed D19149: [ppc64] prevent infinite loop on icache sync.
Feb 12 2019, 11:29 AM
luporl committed rS344049: [ppc64] prevent infinite loop on icache sync.
[ppc64] prevent infinite loop on icache sync
Feb 12 2019, 11:29 AM

Feb 11 2019

luporl updated the summary of D19149: [ppc64] prevent infinite loop on icache sync.
Feb 11 2019, 6:49 PM
luporl updated the summary of D19149: [ppc64] prevent infinite loop on icache sync.
Feb 11 2019, 6:41 PM
luporl created D19149: [ppc64] prevent infinite loop on icache sync.
Feb 11 2019, 6:14 PM

Feb 7 2019

luporl closed D19086: [ppc64] fix /dev/kmem.
Feb 7 2019, 5:31 PM
luporl committed rS343872: [ppc64] fix /dev/kmem.
[ppc64] fix /dev/kmem
Feb 7 2019, 5:31 PM

Feb 5 2019

luporl updated the summary of D19086: [ppc64] fix /dev/kmem.
Feb 5 2019, 6:29 PM
luporl updated the test plan for D19086: [ppc64] fix /dev/kmem.
Feb 5 2019, 6:26 PM
luporl created D19086: [ppc64] fix /dev/kmem.
Feb 5 2019, 6:23 PM
luporl committed rS343791: [ppc64] llan: fix fatal kernel trap when system is low on memory.
[ppc64] llan: fix fatal kernel trap when system is low on memory
Feb 5 2019, 6:16 PM
luporl closed D19084: [ppc64] llan: fix fatal kernel trap when system is low on memory.
Feb 5 2019, 6:16 PM
luporl added reviewers for D19084: [ppc64] llan: fix fatal kernel trap when system is low on memory: nwhitehorn, jhibbits.
Feb 5 2019, 11:16 AM
luporl created D19084: [ppc64] llan: fix fatal kernel trap when system is low on memory.
Feb 5 2019, 11:11 AM

Feb 4 2019

luporl committed rS343744: powerpc64: Add a trap stack area.
powerpc64: Add a trap stack area
Feb 4 2019, 4:02 PM
luporl closed D14484: powerpc64: Add a trap stack area.
Feb 4 2019, 4:02 PM · PowerPC
luporl added a comment to D14484: powerpc64: Add a trap stack area.

@jhibbits, is this change good to go now? It would be nice to get DDB working on boot.

Feb 4 2019, 3:21 PM · PowerPC

Jan 8 2019

luporl committed rD52753: Changed PGP key.
Changed PGP key
Jan 8 2019, 5:57 PM

Jan 7 2019

luporl updated luporl.
Jan 7 2019, 7:40 PM
luporl commandeered D15339: Mark relocated memory region as valid.
Jan 7 2019, 7:38 PM
Herald updated subscribers of D17806: ppc64: handle exception 0x1500 (soft patch).
Jan 7 2019, 7:35 PM