Page MenuHomeFreeBSD

luporl (Leandro Lupori)
Engineering

Projects

User Details

User Since
Jan 7 2019, 7:21 PM (72 w, 15 h)

Recent Activity

Apr 7 2020

luporl committed rS359716: Add support to MSDOS FS in PPC loader.
Add support to MSDOS FS in PPC loader
Apr 7 2020, 7:46 PM
luporl closed D24328: Add support to MSDOS FS in PPC loader.
Apr 7 2020, 7:46 PM · PowerPC
luporl created D24329: loader: allow TFTP to be used by default.
Apr 7 2020, 7:35 PM
luporl created D24328: Add support to MSDOS FS in PPC loader.
Apr 7 2020, 6:33 PM · PowerPC
luporl closed D24313: [PPC] Fix loader call to instantiate-rtas.
Apr 7 2020, 12:46 PM · PowerPC
luporl committed rS359687: [PPC] Fix loader call to instantiate-rtas.
[PPC] Fix loader call to instantiate-rtas
Apr 7 2020, 12:46 PM

Apr 6 2020

luporl created D24313: [PPC] Fix loader call to instantiate-rtas.
Apr 6 2020, 5:12 PM · PowerPC

Mar 26 2020

luporl closed D24185: [PowerPC64] Fix OPAL IPMI driver.
Mar 26 2020, 12:18 PM · PowerPC
luporl committed rS359329: [PowerPC64] Fix OPAL IPMI driver.
[PowerPC64] Fix OPAL IPMI driver
Mar 26 2020, 12:18 PM

Mar 25 2020

luporl updated the diff for D24185: [PowerPC64] Fix OPAL IPMI driver.
  • avoid #if
Mar 25 2020, 8:06 PM · PowerPC
luporl added inline comments to D24185: [PowerPC64] Fix OPAL IPMI driver.
Mar 25 2020, 5:49 PM · PowerPC
luporl created D24185: [PowerPC64] Fix OPAL IPMI driver.
Mar 25 2020, 5:27 PM · PowerPC

Mar 19 2020

luporl added inline comments to D24102: Set moea64_bpvo_pool_size based on physical memory.
Mar 19 2020, 11:35 AM · PowerPC

Mar 18 2020

luporl committed rS359069: Add fsck_flags config option.
Add fsck_flags config option
Mar 18 2020, 1:10 PM
luporl closed D24087: Add fsck_flags config option.
Mar 18 2020, 1:10 PM

Mar 17 2020

luporl updated the diff for D24087: Add fsck_flags config option.

Address review's comments

Mar 17 2020, 12:45 PM

Mar 16 2020

luporl created D24087: Add fsck_flags config option.
Mar 16 2020, 4:59 PM

Mar 12 2020

luporl accepted D23776: [PowerPC] fix panic reading /dev/kmem on !DMAP machines.

Nice, it looks good to me.

Mar 12 2020, 4:36 PM · PowerPC
luporl committed rS358908: Enable ixl device on PowerPC64.
Enable ixl device on PowerPC64
Mar 12 2020, 12:47 PM
luporl closed D23974: Enable ixl device on PowerPC64.
Mar 12 2020, 12:47 PM · PowerPC
luporl added a comment to D23974: Enable ixl device on PowerPC64.
In D23974#528509, @erj wrote:

I'm generally okay with this, but with the caveat that we can't test to make sure any future changes we make will work on anything other than amd64.

Mar 12 2020, 12:39 PM · PowerPC

Mar 9 2020

luporl closed D23859: [aacraid] Handle both AIF and SYNC interrupts.
Mar 9 2020, 7:01 PM
luporl committed rS358814: [aacraid] Handle both AIF and SYNC interrupts.
[aacraid] Handle both AIF and SYNC interrupts
Mar 9 2020, 7:01 PM
luporl added reviewers for D23859: [aacraid] Handle both AIF and SYNC interrupts: emaste, jhibbits.
Mar 9 2020, 5:50 PM

Mar 6 2020

luporl added a comment to D23974: Enable ixl device on PowerPC64.
In D23974#527044, @erj wrote:

The driver is only intended to work on amd64; I can accept PowerPC64 but we don't want to support this driver on 32-bit architectures.

Mar 6 2020, 2:38 PM · PowerPC
luporl updated the diff for D23974: Enable ixl device on PowerPC64.
  • Make ixl device available only on amd64 and PowerPC64
  • Enable ixl by default on PowerPC64
Mar 6 2020, 2:37 PM · PowerPC
luporl committed rS358698: ixl: Add missing conversions from/to LE16.
ixl: Add missing conversions from/to LE16
Mar 6 2020, 12:37 PM
luporl closed D23975: ixl: Add missing conversions from/to LE16.
Mar 6 2020, 12:37 PM · PowerPC

Mar 5 2020

luporl committed rS358684: [aacraid] Port driver to big-endian.
[aacraid] Port driver to big-endian
Mar 5 2020, 8:05 PM
luporl closed D23887: [aacraid] Port driver to big-endian.
Mar 5 2020, 8:05 PM · PowerPC
luporl added reviewers for D23975: ixl: Add missing conversions from/to LE16: sbruno, erj.
Mar 5 2020, 6:09 PM · PowerPC
luporl updated the summary of D23974: Enable ixl device on PowerPC64.
Mar 5 2020, 6:05 PM · PowerPC
luporl retitled D23975: ixl: Add missing conversions from/to LE16 from ixl: Add missing CPU_TO_LE16 conversions to ixl: Add missing conversions from/to LE16.
Mar 5 2020, 5:07 PM · PowerPC
luporl created D23975: ixl: Add missing conversions from/to LE16.
Mar 5 2020, 5:05 PM · PowerPC
luporl created D23974: Enable ixl device on PowerPC64.
Mar 5 2020, 4:57 PM · PowerPC
luporl added inline comments to D23969: powerpc/powerpc64: Enforce natural alignment in memcpy.
Mar 5 2020, 4:10 PM
luporl added inline comments to D23969: powerpc/powerpc64: Enforce natural alignment in memcpy.
Mar 5 2020, 4:09 PM
luporl added inline comments to D23776: [PowerPC] fix panic reading /dev/kmem on !DMAP machines.
Mar 5 2020, 1:48 PM · PowerPC

Mar 4 2020

luporl accepted D23958: [PowerPC64] restrict memcpy/bcopy optimization to POWER ISA >=V2.07.

LGTM

Mar 4 2020, 5:57 PM · PowerPC
luporl updated the diff for D23887: [aacraid] Port driver to big-endian.

Address review's comments

Mar 4 2020, 5:29 PM · PowerPC
luporl committed rS358613: [aacraid] Add missing unmap call for SYNC mode.
[aacraid] Add missing unmap call for SYNC mode
Mar 4 2020, 12:22 PM
luporl closed D23668: [aacraid] Add missing aac_unmap_command() call for SYNC mode.
Mar 4 2020, 12:22 PM · PowerPC

Mar 2 2020

luporl added inline comments to D23776: [PowerPC] fix panic reading /dev/kmem on !DMAP machines.
Mar 2 2020, 5:06 PM · PowerPC
luporl closed D23667: [aacraid] Prevent sense data from causing a buffer overflow.
Mar 2 2020, 4:11 PM · PowerPC
luporl committed rS358550: [aacraid] Prevent sense data from causing a buffer overflow.
[aacraid] Prevent sense data from causing a buffer overflow
Mar 2 2020, 4:11 PM
luporl added a comment to D23668: [aacraid] Add missing aac_unmap_command() call for SYNC mode.

Yes, the similar path in aac.c has

			aac_remove_busy(cm);
 			aac_unmap_command(cm);
Mar 2 2020, 2:20 PM · PowerPC
luporl updated the diff for D23887: [aacraid] Port driver to big-endian.
  • enable aacraid module for powerpc
  • add aacraid_be.c in aacraid module's src list
Mar 2 2020, 1:54 PM · PowerPC

Feb 28 2020

luporl updated the summary of D23887: [aacraid] Port driver to big-endian.
Feb 28 2020, 7:38 PM · PowerPC
luporl created D23887: [aacraid] Port driver to big-endian.
Feb 28 2020, 7:37 PM · PowerPC

Feb 27 2020

luporl added inline comments to D23859: [aacraid] Handle both AIF and SYNC interrupts.
Feb 27 2020, 7:33 PM
luporl created D23859: [aacraid] Handle both AIF and SYNC interrupts.
Feb 27 2020, 7:31 PM
luporl abandoned D22761: [PPC] Fix register context fetch from pcb.

Replaced by D23844.

Feb 27 2020, 12:31 PM · PowerPC
luporl abandoned D21946: [PPC] Fix kgdb symbol resolution.

Replaced by D23844.

Feb 27 2020, 12:30 PM · PowerPC

Feb 13 2020

luporl created D23668: [aacraid] Add missing aac_unmap_command() call for SYNC mode.
Feb 13 2020, 6:12 PM · PowerPC
luporl added a reviewer for D23667: [aacraid] Prevent sense data from causing a buffer overflow: scottl.
Feb 13 2020, 6:04 PM · PowerPC
luporl created D23667: [aacraid] Prevent sense data from causing a buffer overflow.
Feb 13 2020, 5:59 PM · PowerPC

Feb 12 2020

luporl added inline comments to D23623: [POWERPC] Handles float point exception.
Feb 12 2020, 1:43 PM · PowerPC
luporl added a comment to D23623: [POWERPC] Handles float point exception.

Looks good.
I just have some style related comments and 2 questions about the changes.

Feb 12 2020, 11:47 AM · PowerPC

Feb 6 2020

luporl committed rS357615: Implement kvm_kerndisp.
Implement kvm_kerndisp
Feb 6 2020, 1:22 PM
luporl closed D23285: Implement kvm_kerndisp.
Feb 6 2020, 1:22 PM

Feb 5 2020

luporl added inline comments to D23285: Implement kvm_kerndisp.
Feb 5 2020, 7:18 PM
luporl updated the diff for D23285: Implement kvm_kerndisp.

Address review's comments

Feb 5 2020, 7:11 PM
luporl updated the diff for D23285: Implement kvm_kerndisp.

Add man page for kvm_kerndisp

Feb 5 2020, 4:46 PM
luporl committed rS357570: Add SYSCTL to get KERNBASE and relocated KERNBASE.
Add SYSCTL to get KERNBASE and relocated KERNBASE
Feb 5 2020, 11:34 AM
luporl closed D23284: Add SYSCTL to get KERNBASE and relocated KERNBASE.
Feb 5 2020, 11:34 AM

Feb 4 2020

luporl accepted D23401: Make access to VirtIO configuration with proper endianness on big endian platforms.
Feb 4 2020, 4:16 PM · PowerPC
luporl added inline comments to D23497: [PowerPC] Fix VSX context handling.
Feb 4 2020, 2:00 PM · PowerPC
luporl updated subscribers of D23497: [PowerPC] Fix VSX context handling.

Adding Renato Riolino, as he is investigating failing PowerPC tests and this fixes some of them.

Feb 4 2020, 12:46 PM · PowerPC
luporl accepted D23497: [PowerPC] Fix VSX context handling.

Nice, thanks for debugging this issue and documenting psl_userstatic / psl_userset.

Feb 4 2020, 12:44 PM · PowerPC

Jan 29 2020

luporl committed rS357262: [PPC64] Fix NUMA on POWER8.
[PPC64] Fix NUMA on POWER8
Jan 29 2020, 6:13 PM
luporl closed D23414: [PPC64] Fix NUMA on POWER8.
Jan 29 2020, 6:13 PM · PowerPC
luporl added inline comments to D23414: [PPC64] Fix NUMA on POWER8.
Jan 29 2020, 5:58 PM · PowerPC
luporl updated the diff for D23414: [PPC64] Fix NUMA on POWER8.
  • Address review comments
Jan 29 2020, 5:57 PM · PowerPC
luporl added inline comments to D23414: [PPC64] Fix NUMA on POWER8.
Jan 29 2020, 5:20 PM · PowerPC
luporl updated the diff for D23414: [PPC64] Fix NUMA on POWER8.

Address review comments

Jan 29 2020, 5:19 PM · PowerPC
luporl created D23414: [PPC64] Fix NUMA on POWER8.
Jan 29 2020, 4:16 PM · PowerPC

Jan 20 2020

luporl created D23285: Implement kvm_kerndisp.
Jan 20 2020, 7:20 PM
luporl created D23284: Add SYSCTL to get KERNBASE and relocated KERNBASE.
Jan 20 2020, 7:10 PM

Jan 17 2020

luporl accepted D23220: powerpc: Fix the NUMA domain list on powernv.
Jan 17 2020, 5:03 PM
luporl added inline comments to D23220: powerpc: Fix the NUMA domain list on powernv.
Jan 17 2020, 12:21 PM

Jan 14 2020

luporl accepted D22833: [PowerPC64] Enable virtio drivers.

LGTM.
I've tested this by applying the QEMU patch over version 4.2.0 and everything worked fine.

Jan 14 2020, 4:35 PM · PowerPC

Jan 6 2020

luporl added inline comments to D15118: memcpy optimization for powerpc64.
Jan 6 2020, 6:11 PM · PowerPC
luporl updated the diff for D15118: memcpy optimization for powerpc64.

Align src in bcopy/memmove

Jan 6 2020, 5:59 PM · PowerPC

Jan 3 2020

luporl added inline comments to D15118: memcpy optimization for powerpc64.
Jan 3 2020, 8:01 PM · PowerPC

Jan 2 2020

luporl updated the diff for D15118: memcpy optimization for powerpc64.

Fix ifunc resolver parameter name.

Jan 2 2020, 12:43 PM · PowerPC
luporl updated the diff for D15369: strncpy optimization for PowerPC64.

Fix ifunc resolver parameter name.

Jan 2 2020, 12:40 PM · PowerPC
luporl updated the diff for D15368: strcpy optimization for PowerPC64.

Fix diff, bypassing wrong arcanist copy detection.

Jan 2 2020, 12:34 PM · PowerPC
luporl updated the diff for D15368: strcpy optimization for PowerPC64.
  • [PPC64] strcpy optimization
  • Fix ifunc resolver parameter name
  • Merge branch 'master' into luporl-strcpy
Jan 2 2020, 12:15 PM · PowerPC

Dec 13 2019

luporl added a comment to D22789: [PowerPC] powerpc64 rtld IFUNC handling code.

About the tests part, I've been using this patch for a couple months now (actually, "RTLD WIP3"), along with ELFv2 and libc optimization patches (D15118, D15368, D15369), and I have observed no issues so far.

Dec 13 2019, 1:54 PM · PowerPC
luporl added a comment to D22767: [PPC] Handle qOffsets packet.
In D22767#498741, @cem wrote:

There is some precedent for putting MD gdb code paths in, e.g., sys/powerpc/powerpc/gdb_machdep.c. The naming convention appears to be something like, gdb_cpu_do_offsets(). If you want to put the current gdb_do_offses code there, that would be cool. I would be fine leaving #ifdef __powerpc__ around the qOffsets handler and not implementing it everywhere, given it doesn't seem to be needed on other platforms. It is also fine with me to gdb_do_offset here, until/unless a second arch shows up needing to provide another implementation.

Dec 13 2019, 1:39 PM · PowerPC
luporl updated the diff for D22767: [PPC] Handle qOffsets packet.

Move implementation of qOffsets to gdb_machdep.c

Dec 13 2019, 1:35 PM · PowerPC

Dec 12 2019

luporl added inline comments to D22767: [PPC] Handle qOffsets packet.
Dec 12 2019, 8:27 PM · PowerPC
luporl updated the diff for D22767: [PPC] Handle qOffsets packet.

-Fix qOffsets for 32-bit PowerPC

Dec 12 2019, 8:16 PM · PowerPC
luporl added inline comments to D15369: strncpy optimization for PowerPC64.
Dec 12 2019, 7:04 PM · PowerPC
luporl added inline comments to D15369: strncpy optimization for PowerPC64.
Dec 12 2019, 6:11 PM · PowerPC
luporl added inline comments to D22767: [PPC] Handle qOffsets packet.
Dec 12 2019, 2:22 PM · PowerPC
luporl added a comment to D22761: [PPC] Fix register context fetch from pcb.
In D22761#498280, @jhb wrote:

The kgdb bits actually live in github at https://github.com/bsdjhb/gdb/tree/kgdb-8.3 If it's not too hard to make a pull request against that, that would be nicer.

The other thing to consider after that is changing it to be cross-debug friendly. I can help with that. It means not using struct pcb but using a table describing the offsets of the registers from the pcb address.

Dec 12 2019, 12:26 PM · PowerPC

Dec 11 2019

luporl added a comment to D21946: [PPC] Fix kgdb symbol resolution.

For remote targets, symbol resolution can be fixed by implementing qOffsets packet handling (D22767).

Dec 11 2019, 7:16 PM · PowerPC
luporl created D22767: [PPC] Handle qOffsets packet.
Dec 11 2019, 7:11 PM · PowerPC
luporl added a comment to D21946: [PPC] Fix kgdb symbol resolution.
In D21946#479486, @jhb wrote:

The relocation needs to be done a different way to support, e.g. remote debugging (e.g. attaching gdb to qemu's debug stub). Also, kgdb_main.c is just a simpler wrapper, and 'target vmcore /path/to/vmcore' in plain gdb should also work. I'll have to think about how this might be doable, but this approach is rather hacky. It also won't work for cross-debugging (examining a ppc vmcore on a non-ppc host which kgdb generally supports for other architectures). For PIE executables gdb relies on using the ELF auxv values to find the relocated binary.

Dec 11 2019, 2:24 PM · PowerPC