Page MenuHomeFreeBSD

luporl (Leandro Lupori)
Engineering

Projects

User Details

User Since
Jan 7 2019, 7:21 PM (58 w, 3 d)

Recent Activity

Thu, Feb 13

luporl created D23668: [aacraid] Add missing aac_unmap_command() call for SYNC mode.
Thu, Feb 13, 6:12 PM · PowerPC
luporl added a reviewer for D23667: [aacraid] Prevent sense data from causing a buffer overflow: scottl.
Thu, Feb 13, 6:04 PM · PowerPC
luporl created D23667: [aacraid] Prevent sense data from causing a buffer overflow.
Thu, Feb 13, 5:59 PM · PowerPC

Wed, Feb 12

luporl added inline comments to D23623: [POWERPC] Handles float point exception.
Wed, Feb 12, 1:43 PM · PowerPC
luporl added a comment to D23623: [POWERPC] Handles float point exception.

Looks good.
I just have some style related comments and 2 questions about the changes.

Wed, Feb 12, 11:47 AM · PowerPC

Thu, Feb 6

luporl committed rS357615: Implement kvm_kerndisp.
Implement kvm_kerndisp
Thu, Feb 6, 1:22 PM
luporl closed D23285: Implement kvm_kerndisp.
Thu, Feb 6, 1:22 PM

Wed, Feb 5

luporl added inline comments to D23285: Implement kvm_kerndisp.
Wed, Feb 5, 7:18 PM
luporl updated the diff for D23285: Implement kvm_kerndisp.

Address review's comments

Wed, Feb 5, 7:11 PM
luporl updated the diff for D23285: Implement kvm_kerndisp.

Add man page for kvm_kerndisp

Wed, Feb 5, 4:46 PM
luporl committed rS357570: Add SYSCTL to get KERNBASE and relocated KERNBASE.
Add SYSCTL to get KERNBASE and relocated KERNBASE
Wed, Feb 5, 11:34 AM
luporl closed D23284: Add SYSCTL to get KERNBASE and relocated KERNBASE.
Wed, Feb 5, 11:34 AM

Tue, Feb 4

luporl accepted D23401: Make access to VirtIO configuration with proper endianness on big endian platforms.
Tue, Feb 4, 4:16 PM · PowerPC
luporl added inline comments to D23497: [PowerPC] Fix VSX context handling.
Tue, Feb 4, 2:00 PM · PowerPC
luporl updated subscribers of D23497: [PowerPC] Fix VSX context handling.

Adding Renato Riolino, as he is investigating failing PowerPC tests and this fixes some of them.

Tue, Feb 4, 12:46 PM · PowerPC
luporl accepted D23497: [PowerPC] Fix VSX context handling.

Nice, thanks for debugging this issue and documenting psl_userstatic / psl_userset.

Tue, Feb 4, 12:44 PM · PowerPC

Wed, Jan 29

luporl committed rS357262: [PPC64] Fix NUMA on POWER8.
[PPC64] Fix NUMA on POWER8
Wed, Jan 29, 6:13 PM
luporl closed D23414: [PPC64] Fix NUMA on POWER8.
Wed, Jan 29, 6:13 PM · PowerPC
luporl added inline comments to D23414: [PPC64] Fix NUMA on POWER8.
Wed, Jan 29, 5:58 PM · PowerPC
luporl updated the diff for D23414: [PPC64] Fix NUMA on POWER8.
  • Address review comments
Wed, Jan 29, 5:57 PM · PowerPC
luporl added inline comments to D23414: [PPC64] Fix NUMA on POWER8.
Wed, Jan 29, 5:20 PM · PowerPC
luporl updated the diff for D23414: [PPC64] Fix NUMA on POWER8.

Address review comments

Wed, Jan 29, 5:19 PM · PowerPC
luporl created D23414: [PPC64] Fix NUMA on POWER8.
Wed, Jan 29, 4:16 PM · PowerPC

Jan 20 2020

luporl created D23285: Implement kvm_kerndisp.
Jan 20 2020, 7:20 PM
luporl created D23284: Add SYSCTL to get KERNBASE and relocated KERNBASE.
Jan 20 2020, 7:10 PM

Jan 17 2020

luporl accepted D23220: powerpc: Fix the NUMA domain list on powernv.
Jan 17 2020, 5:03 PM
luporl added inline comments to D23220: powerpc: Fix the NUMA domain list on powernv.
Jan 17 2020, 12:21 PM

Jan 14 2020

luporl accepted D22833: [PowerPC64] Enable virtio drivers.

LGTM.
I've tested this by applying the QEMU patch over version 4.2.0 and everything worked fine.

Jan 14 2020, 4:35 PM · PowerPC

Jan 6 2020

luporl added inline comments to D15118: memcpy optimization for powerpc64.
Jan 6 2020, 6:11 PM · PowerPC
luporl updated the diff for D15118: memcpy optimization for powerpc64.

Align src in bcopy/memmove

Jan 6 2020, 5:59 PM · PowerPC

Jan 3 2020

luporl added inline comments to D15118: memcpy optimization for powerpc64.
Jan 3 2020, 8:01 PM · PowerPC

Jan 2 2020

luporl updated the diff for D15118: memcpy optimization for powerpc64.

Fix ifunc resolver parameter name.

Jan 2 2020, 12:43 PM · PowerPC
luporl updated the diff for D15369: strncpy optimization for PowerPC64.

Fix ifunc resolver parameter name.

Jan 2 2020, 12:40 PM · PowerPC
luporl updated the diff for D15368: strcpy optimization for PowerPC64.

Fix diff, bypassing wrong arcanist copy detection.

Jan 2 2020, 12:34 PM · PowerPC
luporl updated the diff for D15368: strcpy optimization for PowerPC64.
  • [PPC64] strcpy optimization
  • Fix ifunc resolver parameter name
  • Merge branch 'master' into luporl-strcpy
Jan 2 2020, 12:15 PM · PowerPC

Dec 13 2019

luporl added a comment to D22789: [PowerPC] powerpc64 rtld IFUNC handling code.

About the tests part, I've been using this patch for a couple months now (actually, "RTLD WIP3"), along with ELFv2 and libc optimization patches (D15118, D15368, D15369), and I have observed no issues so far.

Dec 13 2019, 1:54 PM · PowerPC
luporl added a comment to D22767: [PPC] Handle qOffsets packet.
In D22767#498741, @cem wrote:

There is some precedent for putting MD gdb code paths in, e.g., sys/powerpc/powerpc/gdb_machdep.c. The naming convention appears to be something like, gdb_cpu_do_offsets(). If you want to put the current gdb_do_offses code there, that would be cool. I would be fine leaving #ifdef __powerpc__ around the qOffsets handler and not implementing it everywhere, given it doesn't seem to be needed on other platforms. It is also fine with me to gdb_do_offset here, until/unless a second arch shows up needing to provide another implementation.

Dec 13 2019, 1:39 PM · PowerPC
luporl updated the diff for D22767: [PPC] Handle qOffsets packet.

Move implementation of qOffsets to gdb_machdep.c

Dec 13 2019, 1:35 PM · PowerPC

Dec 12 2019

luporl added inline comments to D22767: [PPC] Handle qOffsets packet.
Dec 12 2019, 8:27 PM · PowerPC
luporl updated the diff for D22767: [PPC] Handle qOffsets packet.

-Fix qOffsets for 32-bit PowerPC

Dec 12 2019, 8:16 PM · PowerPC
luporl added inline comments to D15369: strncpy optimization for PowerPC64.
Dec 12 2019, 7:04 PM · PowerPC
luporl added inline comments to D15369: strncpy optimization for PowerPC64.
Dec 12 2019, 6:11 PM · PowerPC
luporl added inline comments to D22767: [PPC] Handle qOffsets packet.
Dec 12 2019, 2:22 PM · PowerPC
luporl added a comment to D22761: [PPC] Fix register context fetch from pcb.
In D22761#498280, @jhb wrote:

The kgdb bits actually live in github at https://github.com/bsdjhb/gdb/tree/kgdb-8.3 If it's not too hard to make a pull request against that, that would be nicer.
The other thing to consider after that is changing it to be cross-debug friendly. I can help with that. It means not using struct pcb but using a table describing the offsets of the registers from the pcb address.

Dec 12 2019, 12:26 PM · PowerPC

Dec 11 2019

luporl added a comment to D21946: [PPC] Fix kgdb symbol resolution.

For remote targets, symbol resolution can be fixed by implementing qOffsets packet handling (D22767).

Dec 11 2019, 7:16 PM · PowerPC
luporl created D22767: [PPC] Handle qOffsets packet.
Dec 11 2019, 7:11 PM · PowerPC
luporl added a comment to D21946: [PPC] Fix kgdb symbol resolution.
In D21946#479486, @jhb wrote:

The relocation needs to be done a different way to support, e.g. remote debugging (e.g. attaching gdb to qemu's debug stub). Also, kgdb_main.c is just a simpler wrapper, and 'target vmcore /path/to/vmcore' in plain gdb should also work. I'll have to think about how this might be doable, but this approach is rather hacky. It also won't work for cross-debugging (examining a ppc vmcore on a non-ppc host which kgdb generally supports for other architectures). For PIE executables gdb relies on using the ELF auxv values to find the relocated binary.

Dec 11 2019, 2:24 PM · PowerPC
luporl updated the diff for D21946: [PPC] Fix kgdb symbol resolution.

Removed the backtrace fix part, that was moved to D22761.

Dec 11 2019, 2:09 PM · PowerPC
luporl created D22761: [PPC] Fix register context fetch from pcb.
Dec 11 2019, 2:02 PM · PowerPC

Dec 9 2019

luporl added a reviewer for D21554: Fix kvm bitmap index: emaste.
Dec 9 2019, 3:57 PM

Dec 6 2019

luporl updated the diff for D22649: [PPC64] Enable opal console use as a GDB DBGPORT.
  • Fix compiler warning
Dec 6 2019, 6:58 PM · PowerPC

Dec 4 2019

luporl updated the summary of D22649: [PPC64] Enable opal console use as a GDB DBGPORT.
Dec 4 2019, 7:18 PM · PowerPC
luporl updated the diff for D22649: [PPC64] Enable opal console use as a GDB DBGPORT.
  • Merge with 'master'
  • Address review comments
Dec 4 2019, 7:15 PM · PowerPC
luporl added inline comments to D22649: [PPC64] Enable opal console use as a GDB DBGPORT.
Dec 4 2019, 1:02 PM · PowerPC
luporl updated subscribers of D15369: strncpy optimization for PowerPC64.
Dec 4 2019, 11:58 AM · PowerPC
luporl added a project to D21555: [PPC64] Initial libkvm minidump implementation: PowerPC.
Dec 4 2019, 11:57 AM · PowerPC
luporl added a project to D21946: [PPC] Fix kgdb symbol resolution: PowerPC.
Dec 4 2019, 11:57 AM · PowerPC
luporl added a project to D22649: [PPC64] Enable opal console use as a GDB DBGPORT: PowerPC.
Dec 4 2019, 11:57 AM · PowerPC
luporl updated subscribers of D15368: strcpy optimization for PowerPC64.
Dec 4 2019, 11:56 AM · PowerPC
luporl added a project to D20640: Enable use of ofwcons for early debug: PowerPC.
Dec 4 2019, 11:55 AM · PowerPC
luporl updated subscribers of D15369: strncpy optimization for PowerPC64.
Dec 4 2019, 11:50 AM · PowerPC
luporl updated subscribers of D20640: Enable use of ofwcons for early debug.
Dec 4 2019, 11:49 AM · PowerPC
luporl updated subscribers of D21555: [PPC64] Initial libkvm minidump implementation.
Dec 4 2019, 11:48 AM · PowerPC
luporl updated subscribers of D21946: [PPC] Fix kgdb symbol resolution.
Dec 4 2019, 11:48 AM · PowerPC
luporl updated subscribers of D15368: strcpy optimization for PowerPC64.
Dec 4 2019, 11:47 AM · PowerPC
luporl added a member for PowerPC: luporl.
Dec 4 2019, 11:44 AM
luporl updated subscribers of D22649: [PPC64] Enable opal console use as a GDB DBGPORT.
Dec 4 2019, 11:43 AM · PowerPC

Dec 3 2019

luporl updated the test plan for D22649: [PPC64] Enable opal console use as a GDB DBGPORT.
Dec 3 2019, 8:49 PM · PowerPC
luporl updated the test plan for D22649: [PPC64] Enable opal console use as a GDB DBGPORT.
Dec 3 2019, 8:45 PM · PowerPC
luporl created D22649: [PPC64] Enable opal console use as a GDB DBGPORT.
Dec 3 2019, 8:41 PM · PowerPC

Dec 2 2019

luporl added a comment to D22608: [PowerPC] Implement jump table processing (Secure-PLT only) in ppc32 in-kernel linker, allow MD code to participate in DYNAMIC parsing..

Looks good to me.

Dec 2 2019, 6:18 PM · PowerPC
luporl accepted D21449: powerpc/pmap: NUMA-ize vm_page_array on powerpc.
Dec 2 2019, 12:51 PM

Nov 29 2019

luporl added a comment to D21449: powerpc/pmap: NUMA-ize vm_page_array on powerpc.

Overall the changes look ok to me.

Nov 29 2019, 5:52 PM
luporl added inline comments to D22549: [PowerPC] enable atomic.c in compiler_rt and do not check and forces lock/lock_free decisions in compiled time.
Nov 29 2019, 2:15 PM · PowerPC
luporl accepted D22524: [PowerPC] Enable TLS usage in system libraries on ELFv2..
Nov 29 2019, 1:57 PM · PowerPC
luporl accepted D22341: powerpc64/pmap: micro-optimize some PVO-PTE logic.

The changes look ok to me. They seem to preserve the original logic, while avoiding the full PTE from PVO conversion.

Nov 29 2019, 1:16 PM

Nov 28 2019

luporl accepted D22340: powerpc: Use builtins for fls/flsl.

Looks good.

Nov 28 2019, 9:10 PM
luporl updated the summary of D20640: Enable use of ofwcons for early debug.
Nov 28 2019, 8:22 PM · PowerPC
luporl updated the diff for D20640: Enable use of ofwcons for early debug.
  • Address review's comments
  • Fixed an issue in ofw_real_mtx_unlock()
Nov 28 2019, 8:18 PM · PowerPC

Nov 25 2019

luporl added inline comments to D22171: [PPC] Remove extra \0 char inserted on vty by QEMU.
Nov 25 2019, 7:50 PM
luporl updated the diff for D22171: [PPC] Remove extra \0 char inserted on vty by QEMU.
  • Merge branch 'master' into luporl-fix-vty
  • Address review comments
Nov 25 2019, 7:42 PM
luporl updated the test plan for D22171: [PPC] Remove extra \0 char inserted on vty by QEMU.
Nov 25 2019, 7:38 PM

Oct 31 2019

luporl added a comment to D22199: Avoid wrong sigtramp detection on ppc64.

The trampoline for ppc64 is at 0x3ffffffffffe000 + offset, in the shared page.

Oct 31 2019, 5:47 PM
luporl updated the diff for D22199: Avoid wrong sigtramp detection on ppc64.
  • Merge branch 'master' into luporl-fix-gdb-sigtramp
  • Add proper sigtramp detection for ppc64
Oct 31 2019, 5:45 PM
luporl created D22205: [PPC64] Enable phyp vty use as a GDB DBGPORT.
Oct 31 2019, 12:44 PM

Oct 30 2019

luporl created D22201: Fix GDB machdep code for PPC/PPC64.
Oct 30 2019, 9:40 PM
luporl created D22200: [PPC64] Fix trapstk overflow.
Oct 30 2019, 9:27 PM
luporl planned changes to D22199: Avoid wrong sigtramp detection on ppc64.
Oct 30 2019, 9:04 PM
luporl created D22199: Avoid wrong sigtramp detection on ppc64.
Oct 30 2019, 8:58 PM

Oct 28 2019

luporl created D22171: [PPC] Remove extra \0 char inserted on vty by QEMU.
Oct 28 2019, 12:50 PM

Oct 21 2019

luporl added inline comments to D22087: powerpc: Use doorbell interrupts as IPIs where supported.
Oct 21 2019, 5:29 PM
luporl requested changes to D22087: powerpc: Use doorbell interrupts as IPIs where supported.
Oct 21 2019, 4:46 PM

Oct 15 2019

luporl updated the diff for D15368: strcpy optimization for PowerPC64.

Fix diff.

Oct 15 2019, 3:28 PM · PowerPC
luporl updated the diff for D15369: strncpy optimization for PowerPC64.

Fix diff

Oct 15 2019, 2:24 PM · PowerPC
luporl updated the diff for D15369: strncpy optimization for PowerPC64.
  • Merge branch 'master'
Oct 15 2019, 2:21 PM · PowerPC

Oct 9 2019

luporl accepted D21954: gcore: Add powerpc64 32-bit gcore support.

Looks good.

Oct 9 2019, 12:39 PM

Oct 8 2019

luporl updated subscribers of D21946: [PPC] Fix kgdb symbol resolution.
Oct 8 2019, 8:09 PM · PowerPC
luporl created D21946: [PPC] Fix kgdb symbol resolution.
Oct 8 2019, 8:02 PM · PowerPC

Oct 1 2019

luporl updated the diff for D21555: [PPC64] Initial libkvm minidump implementation.
  • make kvatop handle dpcpu/vnet addresses properly
Oct 1 2019, 5:02 PM · PowerPC
luporl added a comment to D21555: [PPC64] Initial libkvm minidump implementation.

This is very specific to AIM64 HPT. Can you rename it to kvm_..._hpt.c, or something, and add another key to the header to probe against for the particular pmap implementation? I'll want to add Book-E support, as well as AIM Radix when we do finally get radix stabilized.

Oct 1 2019, 1:15 PM · PowerPC