Page MenuHomeFreeBSD

powerpc: add R_PPC_ADDR32 handler for kldxref
ClosedPublic

Authored by alfredo on Jan 4 2022, 8:42 PM.

Details

Summary

Implements R_PPC_ADDR32 handler for kldxref, addressing "kldxref: unhandled relocation type 1" when running "kldxref /boot/kernel" on powerpc 32 bits.
Apparently this relocation appeared after in-tree LLVM compiler upgrade between versions LLVM11 and 13.

In this change added a "where32" variable with type Elf32_Addr when destination is word32 on both 32 or 64 bits and guarded PPC64-only relocation with an ifdef. Comments are welcome.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Looks good.

usr.sbin/kldxref/ef_powerpc.c
66

No change is really needed here, but maybe just cast 'where' to (Elf32_Addr *)?

This revision is now accepted and ready to land.Jan 6 2022, 6:53 PM
alfredo added inline comments.
usr.sbin/kldxref/ef_powerpc.c
66

yes but the cast need to be later since at this point we don't know what data size is going to be used.
Then I preferred to create a new variable here and use it where appropriate, following the pattern used on other architectures.

This revision was automatically updated to reflect the committed changes.