powerpc: add R_PPC_ADDR32 handler for kldxref
ClosedPublic
Actions

Authored by alfredo on Jan 4 2022, 8:42 PM.

Details

Reviewers

jhibbits
luporl

Group Reviewers

PowerPC

Commits

rG0d27ad33a44c: kldxref: add R_PPC_ADDR32 handler
rG79f5d19890c3: kldxref: add R_PPC_ADDR32 handler

Summary

Implements R_PPC_ADDR32 handler for kldxref, addressing "kldxref: unhandled relocation type 1" when running "kldxref /boot/kernel" on powerpc 32 bits.
Apparently this relocation appeared after in-tree LLVM compiler upgrade between versions LLVM11 and 13.

In this change added a "where32" variable with type Elf32_Addr when destination is word32 on both 32 or 64 bits and guarded PPC64-only relocation with an ifdef. Comments are welcome.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alfredo created this revision.Jan 4 2022, 8:42 PM

Herald added subscribers: luporl, bdragon, imp. · View Herald TranscriptJan 4 2022, 8:42 PM

alfredo requested review of this revision.Jan 4 2022, 8:42 PM

Harbormaster completed remote builds in B43706: Diff 100939.Jan 4 2022, 8:42 PM

alfredo added reviewers: jhibbits, luporl.Jan 6 2022, 6:00 PM

Looks good.

usr.sbin/kldxref/ef_powerpc.c
67	No change is really needed here, but maybe just cast 'where' to (Elf32_Addr *)?

This revision is now accepted and ready to land.Jan 6 2022, 6:53 PM

alfredo marked an inline comment as done.Feb 10 2022, 11:59 AM

alfredo added inline comments.

usr.sbin/kldxref/ef_powerpc.c
67	yes but the cast need to be later since at this point we don't know what data size is going to be used. Then I preferred to create a new variable here and use it where appropriate, following the pattern used on other architectures.