Just have the MD code provide syscall and have generic code for the
rest.
Sponsored by: Netflix
Details
Details
This commit is the one I'm most worried about
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| stand/kboot/arch/powerpc64/host_syscall.S | ||
|---|---|---|
| 18 | 'so' flag is used by the syscall interface, on FreeBSD too, to denote error. Examining uses of host_open(), I'm guessing that 0 is already a taken file descriptor (stdin?), so returning 0 on error is acceptable. Not sure why host_read() would return 0 on error. I would expect -1 instead. | |
| stand/kboot/arch/powerpc64/host_syscall.S | ||
|---|---|---|
| 18 | Yea. It's weird. And these are Linux calls, so a negative errno is expected... And looking at how it's used, an error in open would translate to reading stdin given how open is used. So I'm guessing there were no such errors. Likewise for reads.... But why is that code even there... | |
Comment Actions
I was able to build kboot for powerpc64, with diffs D33511 - D33515.
In the machines that I have access to, Petitboot can't run BE loader.kboot, but I was able to build and run a LE loader.kboot.
However, as mentioned in D33511, it can just run some loader commands, but can't list files or load a kernel. But the older version, without these changes, also can't.