Page MenuHomeFreeBSD

wma (Wojciech Macek)
User

Projects

User Details

User Since
Jan 20 2016, 6:04 AM (435 w, 11 h)

Recent Activity

Dec 14 2022

wma updated the diff for D37419: arm: Add support for using VFP in kernel.
Dec 14 2022, 4:02 PM

Dec 12 2022

wma updated the diff for D37419: arm: Add support for using VFP in kernel.
Dec 12 2022, 12:40 PM
wma commandeered D37419: arm: Add support for using VFP in kernel.
Dec 12 2022, 12:39 PM

Dec 9 2022

wma added inline comments to D37419: arm: Add support for using VFP in kernel.
Dec 9 2022, 4:39 PM

Dec 5 2022

wma added a comment to D37421: ossl: Add AES-GCM implementation for ARMv7 NEON.

The biggest use case of AES-GCM is in the ipsec stack. Actually, that layer should be responsible for providing valid data to ossl. It is expected for the ossl function to fail if lengths are not aligned to block size (similar to what AES CBC does) as only the upper layers have the knowledge what algorithm has to be used for padding, if any. The AES-GCM RFC does not define any standard padding mechanism as this is the "stream encryption", but RFCs which make use of AES-GCM might have.

Dec 5 2022, 10:50 AM
wma added inline comments to D37419: arm: Add support for using VFP in kernel.
Dec 5 2022, 7:01 AM
wma committed rG9476c1675c53: lm75: fix typo (authored by wma).
lm75: fix typo
Dec 5 2022, 6:31 AM

Dec 1 2022

wma accepted D37579: rx8803: Improve probing logic.
Dec 1 2022, 8:38 AM
wma committed rGda3557899886: lm75: Refactor code to fix io error (authored by jkol_semihalf.com).
lm75: Refactor code to fix io error
Dec 1 2022, 8:19 AM
wma closed D37497: lm75: Refactor code to fix io error.
Dec 1 2022, 8:18 AM

Nov 30 2022

wma accepted D37497: lm75: Refactor code to fix io error.
Nov 30 2022, 10:01 AM

Nov 25 2022

wma added inline comments to D37497: lm75: Refactor code to fix io error.
Nov 25 2022, 5:05 AM

Nov 23 2022

wma added a comment to D37419: arm: Add support for using VFP in kernel.

On arm64 we always use pcb->pcb_vfpsaved to find the correct state to use in context switch so make sure it is always valid (except in the savectx special case).
If you make sure the pcb_vfpsaved pointer is always valid, and call vfp_save_state where we are currently calling vfp_store the save side should work the same as on arm64. For restore you'll need to update vfp_bounce to handle a kernel VFP exception.

Nov 23 2022, 4:36 PM
wma added a comment to D37419: arm: Add support for using VFP in kernel.

@andrew
Thanks for looking into it.
However, isn't that why we always pass ctx to fpu_kern_enter? In the end of that function (line 425) the vfpsaved pointer is swapped with ctx->prev which apparently should provide additional place for storing "old" vfp state. Therefore, in context switch any additional call to vfp_save_state should cause storing vfp state in temporary &ctx->state. Is it a case you were referring to?

Nov 23 2022, 11:20 AM

Nov 18 2022

wma added inline comments to D37419: arm: Add support for using VFP in kernel.
Nov 18 2022, 6:57 AM

Oct 11 2022

wma added a comment to D34622: init: allow to start script executions with sh -o verify.

Oh, I see now.
@sebastien.bini_stormshield.eu The best way to send patches to Phabricator is preparing them as diff-to-baseline (to main in this case). This way the most up=to-date patch contains all necessary changes. Phabricator will automatically handle all modifications in lines which had some todo/comment attached and mark those issues as resolved.

Oct 11 2022, 7:56 AM
wma committed rGf3dba162bd46: init: allow to start script executions with sh -o verify (authored by sebastien.bini_stormshield.eu).
init: allow to start script executions with sh -o verify
Oct 11 2022, 7:53 AM
wma closed D34622: init: allow to start script executions with sh -o verify.
Oct 11 2022, 7:52 AM

Sep 27 2022

wma added a comment to D34622: init: allow to start script executions with sh -o verify.

@sebastien.bini_stormshield.eu could you confirm if this changes still apply to HEAD? I was trying to find anything related to -oVERIFY in init.c but there is none such string. Is there anything missing which needs to be merged before this patch?

Sep 27 2022, 4:22 AM

Aug 12 2022

wma added a comment to D34622: init: allow to start script executions with sh -o verify.

Are there any more issues to be resolved? Can we proceed with committing this patch?

Aug 12 2022, 7:43 AM

Jun 29 2022

wma committed rGb439f64ac1b9: Improve parameters handling in veriexec (authored by hum_semihalf.com).
Improve parameters handling in veriexec
Jun 29 2022, 8:58 AM
wma closed D33246: Improve parameters handling in veriexec.
Jun 29 2022, 8:57 AM
wma closed D35120: libsecureboot: Do not propagate empty string.
Jun 29 2022, 8:51 AM
wma committed rGe6ef5042e485: libsecureboot: Do not propagate empty string (authored by wma).
libsecureboot: Do not propagate empty string
Jun 29 2022, 8:51 AM
wma committed rG15c362aeb778: mac_veriexec: Authorize reads of secured sysctls (authored by wma).
mac_veriexec: Authorize reads of secured sysctls
Jun 29 2022, 8:49 AM
wma closed D34327: mac_veriexec: Authorize reads of secured sysctls.
Jun 29 2022, 8:49 AM

Jun 7 2022

wma committed rG1315446ba0cd: LACP: Do not wait response for marker messages not sent (authored by arnaud.ysmal_stormshield.eu).
LACP: Do not wait response for marker messages not sent
Jun 7 2022, 3:59 AM

Jun 3 2022

wma committed rG067a4b656b9b: [vlan + lagg] add IFNET_EVENT_UPDATE_BAUDRATE event (authored by ae).
[vlan + lagg] add IFNET_EVENT_UPDATE_BAUDRATE event
Jun 3 2022, 4:50 AM

May 20 2022

wma committed rGf2ab91608440: [vlan + lagg] add IFNET_EVENT_UPDATE_BAUDRATE event (authored by ae).
[vlan + lagg] add IFNET_EVENT_UPDATE_BAUDRATE event
May 20 2022, 4:41 AM
wma closed D33405: Add IFNET_EVENT_UPDATE_BAUDRATE event and use it to update if_baudrate for vlan interfaces created on the LACP lagg..
May 20 2022, 4:40 AM

May 19 2022

wma updated the diff for D33405: Add IFNET_EVENT_UPDATE_BAUDRATE event and use it to update if_baudrate for vlan interfaces created on the LACP lagg..

I've updated the patch with epoch_wait changes.

May 19 2022, 7:39 AM

Apr 28 2022

wma committed rG0923ff82fb38: Add USB ID and quirks for Huawei E3372 (authored by kd).
Add USB ID and quirks for Huawei E3372
Apr 28 2022, 6:44 AM
wma committed rG3ee943868c74: usb: Respect NO_INQUIRY quirk during device enumeration (authored by kd).
usb: Respect NO_INQUIRY quirk during device enumeration
Apr 28 2022, 6:43 AM
wma closed D35076: Add USB ID and quirks for Huawei E3372.
Apr 28 2022, 6:43 AM
wma closed D35075: usb: Respect NO_INQUIRY quirk during device enumeration.
Apr 28 2022, 6:43 AM
wma accepted D35076: Add USB ID and quirks for Huawei E3372.
Apr 28 2022, 4:02 AM
wma accepted D35075: usb: Respect NO_INQUIRY quirk during device enumeration.
Apr 28 2022, 4:02 AM

Apr 20 2022

wma committed rG06f659c39da1: dmar: Disable PMR in driver attach routine (authored by kd).
dmar: Disable PMR in driver attach routine
Apr 20 2022, 7:41 AM
wma closed D34907: dmar: Disable PMR in driver attach routine.
Apr 20 2022, 7:41 AM
wma committed rG14b7706264f6: mac_pimd: Support for privilege drop in pimd (authored by wma).
mac_pimd: Support for privilege drop in pimd
Apr 20 2022, 6:09 AM

Mar 24 2022

wma committed rG6ad638acd110: hardware: added Dell H840 raid support (authored by wma).
hardware: added Dell H840 raid support
Mar 24 2022, 6:15 AM
wma closed D34623: hardware: added Dell H840 raid support.
Mar 24 2022, 6:15 AM

Mar 22 2022

wma accepted D34627: IPv4 multicast: fix netstat -g.
Mar 22 2022, 8:46 AM
wma accepted D34624: Enter epoch when addding IPv4 multicast forwarding cache entry.
Mar 22 2022, 7:47 AM
wma accepted D34623: hardware: added Dell H840 raid support.
Mar 22 2022, 7:45 AM

Mar 14 2022

wma committed rG25bcd81b8d12: armv6/legacy: optimize cpu_getcount performance (authored by wma).
armv6/legacy: optimize cpu_getcount performance
Mar 14 2022, 6:53 AM
wma closed D33719: armv6/legacy: optimize cpy_getcount performance.
Mar 14 2022, 6:52 AM

Feb 22 2022

wma committed rGf97e7d6e9d3e: sdhci_fsl_fdt: Add voltage switching through syscon (authored by hum_semihalf.com).
sdhci_fsl_fdt: Add voltage switching through syscon
Feb 22 2022, 9:00 AM
wma committed rGcaca7dd08752: sdhci_fsl_fdt: Apply errata for LX2160A (authored by hum_semihalf.com).
sdhci_fsl_fdt: Apply errata for LX2160A
Feb 22 2022, 9:00 AM
wma committed rG29cb30dcb08e: sdhci_fsl_fdt: Fix tuning code (authored by kd).
sdhci_fsl_fdt: Fix tuning code
Feb 22 2022, 8:59 AM
wma committed rGa974a7bcdf44: sdhci_fsl_fdt: Fix pulse width errata application (authored by kd).
sdhci_fsl_fdt: Fix pulse width errata application
Feb 22 2022, 8:59 AM
wma closed D34029: sdhci_fsl_fdt: Add voltage switching through syscon.
Feb 22 2022, 8:59 AM
wma closed D34028: sdhci_fsl_fdt: Apply errata for LX2160A.
Feb 22 2022, 8:59 AM
wma closed D34027: sdhci_fsl_fdt: Fix tuning code.
Feb 22 2022, 8:59 AM
wma closed D33981: sdhci_fsl_fdt: Fix pulse width errata application.
Feb 22 2022, 8:59 AM

Feb 14 2022

wma added a comment to D34027: sdhci_fsl_fdt: Fix tuning code.

Any comments here? I'd like to merge the code this week.

Feb 14 2022, 10:02 AM

Feb 7 2022

wma added a reviewer for D33246: Improve parameters handling in veriexec: sjg.
Feb 7 2022, 10:36 AM
wma updated the diff for D33246: Improve parameters handling in veriexec.

Rebased version.

Feb 7 2022, 10:32 AM
wma added a comment to D33926: This change allows the veriexec binary to (optionally) load its CA store from a verified tarball..

Any comments?

Feb 7 2022, 5:28 AM

Feb 4 2022

wma added a comment to D33719: armv6/legacy: optimize cpy_getcount performance.

It's not used on any official FreeBSD platform. However, with some out-of-tree BSPs this portion of code becomes active.

Feb 4 2022, 10:13 AM
wma committed rGcd7306bb1fd1: ip_mroute: split mrouter interface deactivation and if_free (authored by Sylvian Meygret <sylvain.meygret.external@stormshield.eu>).
ip_mroute: split mrouter interface deactivation and if_free
Feb 4 2022, 9:26 AM

Feb 2 2022

wma committed rG77223d98b6f8: ip_mroute: refactor epoch-basd locking (authored by wma).
ip_mroute: refactor epoch-basd locking
Feb 2 2022, 5:50 AM
wma closed D34030: ip_mroute: refactor epoch-based locking.
Feb 2 2022, 5:49 AM

Jan 31 2022

wma committed rG1a6d987b7f32: enetc: Wait for pending transmissions before disabling TX queues (authored by kd).
enetc: Wait for pending transmissions before disabling TX queues
Jan 31 2022, 8:02 AM
wma committed rGa6bda3e1ef4d: enetc: Simply TX ring credits counting logic (authored by kd).
enetc: Simply TX ring credits counting logic
Jan 31 2022, 8:01 AM
wma committed rGf485d733e87e: enetc: Disable HW IP packet alignment (authored by kd).
enetc: Disable HW IP packet alignment
Jan 31 2022, 8:01 AM
wma added a comment to D32846: ip_forward: store temporary mbuf on stack.

Are there any objections for this patch (+ all mentioned fixes)?

Jan 31 2022, 6:30 AM
wma updated the diff for D34030: ip_mroute: refactor epoch-based locking.

There is still a potential race between rip_detach and handling MRT_DONE (both call ip_mrouter_done). AFAIK these functions are not used at the same time so its highly unlikely this ever happen - I've never seen it so far.
I'm planning to further refactor ip_mroute.c to avoid this kind of issues, but not in this commit.

Jan 31 2022, 6:16 AM

Jan 25 2022

wma accepted D33981: sdhci_fsl_fdt: Fix pulse width errata application.
Jan 25 2022, 9:27 AM
wma requested review of D34030: ip_mroute: refactor epoch-based locking.
Jan 25 2022, 9:23 AM

Jan 24 2022

wma added a reviewer for D33926: This change allows the veriexec binary to (optionally) load its CA store from a verified tarball.: wma.
Jan 24 2022, 10:54 AM
wma added reviewers for D33926: This change allows the veriexec binary to (optionally) load its CA store from a verified tarball.: sjg, mw, imp.
Jan 24 2022, 10:52 AM

Jan 22 2022

wma committed rG0daa28057c6c: ip_mroute: add unlock in early-exit (authored by wma).
ip_mroute: add unlock in early-exit
Jan 22 2022, 1:49 PM
wma committed rG889c60500d30: ip_mroute: release epoch lock if mrouter is not configured (authored by wma).
ip_mroute: release epoch lock if mrouter is not configured
Jan 22 2022, 10:50 AM

Jan 21 2022

wma added a reverting change for rG2e72208b6c62: ip_mroute: do not call epoch_waitwhen lock is taken: rG58630bdd13fd: Revert "ip_mroute: do not call epoch_waitwhen lock is taken".
Jan 21 2022, 5:19 AM
wma committed rG9ce46cbc95d7: ip_mroute: move ip_mrouter_done outside lock (authored by wma).
ip_mroute: move ip_mrouter_done outside lock
Jan 21 2022, 5:19 AM
wma committed rG58630bdd13fd: Revert "ip_mroute: do not call epoch_waitwhen lock is taken" (authored by wma).
Revert "ip_mroute: do not call epoch_waitwhen lock is taken"
Jan 21 2022, 5:19 AM

Jan 11 2022

wma committed rG776c34f64615: ip_mroute: remove unused variables (authored by wma).
ip_mroute: remove unused variables
Jan 11 2022, 12:07 PM
wma committed rG2e72208b6c62: ip_mroute: do not call epoch_waitwhen lock is taken (authored by wma).
ip_mroute: do not call epoch_waitwhen lock is taken
Jan 11 2022, 10:20 AM
wma committed rG68f28dd1ccc3: ip_mroute: do not sleep when lock is taken (authored by wma).
ip_mroute: do not sleep when lock is taken
Jan 11 2022, 10:20 AM

Jan 4 2022

wma committed rG4885d6f3ec5b: if_mvneta: Use clock frequency (authored by hum_semihalf.com).
if_mvneta: Use clock frequency
Jan 4 2022, 12:33 PM
wma closed D32336: if_mvneta: Use clock frequency.
Jan 4 2022, 12:32 PM
wma closed D32294: Add driver for marvell, a37x0 peripheral clocks.
Jan 4 2022, 12:32 PM
wma committed rGf21c469dbca6: Add driver for marvell, a37x0 peripheral clocks (authored by hum_semihalf.com).
Add driver for marvell, a37x0 peripheral clocks
Jan 4 2022, 12:32 PM
wma closed D32293: Add driver for armada, 37x0-tbg-clock.
Jan 4 2022, 12:31 PM
wma committed rG127e4d9524ae: Add driver for armada, 37x0-tbg-clock (authored by hum_semihalf.com).
Add driver for armada, 37x0-tbg-clock
Jan 4 2022, 12:31 PM
wma closed D32292: Add driver for marvell, armada-3700 oscillator.
Jan 4 2022, 12:30 PM
wma committed rG01b9c59fd262: Add driver for marvell, armada-3700 oscillator (authored by hum_semihalf.com).
Add driver for marvell, armada-3700 oscillator
Jan 4 2022, 12:30 PM

Jan 2 2022

wma committed rGbffefaf3e1ef: pmcstudy: fix error handling (authored by sebastien.bini_stormshield.eu).
pmcstudy: fix error handling
Jan 2 2022, 9:53 AM
wma requested review of D33719: armv6/legacy: optimize cpy_getcount performance.
Jan 2 2022, 8:56 AM
wma committed rGd28d74de876b: smp.h: make sign conversion explicit (authored by sebastien.bini_stormshield.eu).
smp.h: make sign conversion explicit
Jan 2 2022, 8:00 AM

Dec 20 2021

wma committed rGe0ceec676dc8: cam: don't send scsi commands on shutdown when reboot method RB_NOSYNC (authored by wma).
cam: don't send scsi commands on shutdown when reboot method RB_NOSYNC
Dec 20 2021, 5:35 AM
wma closed D31549: Don't sync DAs if reboot type is RB_NOSYNC.
Dec 20 2021, 5:35 AM
wma closed D33116: t_setrlimit: Adjust resource limit to 20M..
Dec 20 2021, 5:30 AM
wma committed rG4f741801d860: t_setrlimit: Adjust resource limit to 20M (authored by dgr_semihalf.com).
t_setrlimit: Adjust resource limit to 20M
Dec 20 2021, 5:30 AM

Dec 17 2021

wma committed rG3e5fe3d5bf88: pcf85063: Set RTC device to work in 24h mode (authored by hum_semihalf.com).
pcf85063: Set RTC device to work in 24h mode
Dec 17 2021, 10:10 AM
wma closed D33497: pcf85063: Set RTC device to work in 24h mode.
Dec 17 2021, 10:10 AM

Dec 15 2021

wma committed rG77b3cf989fc1: pci: Don't try to read cfg registers of non-existing devices (authored by kd).
pci: Don't try to read cfg registers of non-existing devices
Dec 15 2021, 10:48 AM

Dec 13 2021

wma requested review of D33405: Add IFNET_EVENT_UPDATE_BAUDRATE event and use it to update if_baudrate for vlan interfaces created on the LACP lagg..
Dec 13 2021, 5:40 AM
wma added a comment to D31549: Don't sync DAs if reboot type is RB_NOSYNC.

Thanks for comment, yes, the description might have been misleading.

Dec 13 2021, 5:29 AM