Page MenuHomeFreeBSD

wma (Wojciech Macek)
User

Projects

User Details

User Since
Jan 20 2016, 6:04 AM (289 w, 1 d)

Recent Activity

Fri, Jul 30

wma added a comment to D30992: ipsec: Handle ICMP NEEDFRAG message..

SPI is a 32-bit semi-random value which would be quite hard to guess, unless somebody can sniff the traffic (but such case is a problem for all rfc1191-enabled protocols regardless of any anti-tampering checks).
To be 100% sure the packet belong to IPSEC tunnel (and that's how it works in ipsec module) is to use SPI and analyse ESP-Trailer and ESP-Authentication to confirm the originator of the packet is the machine we expect and data was not modified. Unfortunately, both of these are the last entries in IPSEC packet thus are not available in PTB response.

Fri, Jul 30, 9:44 AM
wma updated the diff for D30992: ipsec: Handle ICMP NEEDFRAG message..

The longer I look into it the more I think the UDP part should be moved to the UDP code. Althoug it would be cleaner to have it here, due to limitations in RFC1191 payload length it is impossible to associate tunnel ID if knowing only UDP flow. I will handle it in a separate review and propose sth more generic.

Fri, Jul 30, 9:06 AM

Thu, Jul 29

wma added a comment to D30992: ipsec: Handle ICMP NEEDFRAG message..

Basic protection is guaranteed by IPSEC code. PMTUD NEEDFRAG msg contains a header of packet which caused the router to send such ICMP response. IPSEC handles PMTU change only if that header matches an existing tunnel.

Thu, Jul 29, 2:53 PM
wma added a comment to D30992: ipsec: Handle ICMP NEEDFRAG message..

Any objections for committing this after adding a hook to udp_userreq?

Thu, Jul 29, 11:20 AM
wma abandoned D31272: Small patch to optionally remove the TCP reassembly max queue length.
Thu, Jul 29, 10:12 AM
wma committed R10:fe8ce390b8bc: Fix mac_veriexec version mismatch (authored by wma).
Fix mac_veriexec version mismatch
Thu, Jul 29, 9:06 AM
wma closed D31268: Fix mac_veriexec version mismatch.
Thu, Jul 29, 9:05 AM

Fri, Jul 23

wma added a reviewer for D31283: Measure latency of PMC interruptions: kib.
Fri, Jul 23, 8:10 AM
wma requested review of D31283: Measure latency of PMC interruptions.
Fri, Jul 23, 8:09 AM

Thu, Jul 22

wma requested review of D31272: Small patch to optionally remove the TCP reassembly max queue length.
Thu, Jul 22, 10:31 AM
wma requested review of D31271: Small patch that fixes a race condition in sys/netipsec/key.c.
Thu, Jul 22, 10:30 AM
wma requested review of D31270: Short patch to add support for PCI VT8251 bridge.
Thu, Jul 22, 10:29 AM
wma requested review of D31269: Add support for Lewisburg GPIO through P2SB.
Thu, Jul 22, 10:28 AM

Mon, Jul 19

wma added a comment to D30991: sys/netinet: handle IPv4 PMTU Discovery.

Good point. I removed all *input processing and left only *output check, which might be worth to have it in one place as we don't update mtu here anyway. Also pushed some changes to UDP ctlinput to match https://reviews.freebsd.org/D30992

Mon, Jul 19, 11:18 AM
wma updated the diff for D30992: ipsec: Handle ICMP NEEDFRAG message..
Mon, Jul 19, 11:17 AM
wma updated the diff for D30991: sys/netinet: handle IPv4 PMTU Discovery.
Mon, Jul 19, 11:16 AM

Jul 6 2021

wma committed R10:382376f39863: enetc: Add support for 2.5G fixed-link speed (authored by wma).
enetc: Add support for 2.5G fixed-link speed
Jul 6 2021, 7:03 AM

Jul 2 2021

wma requested review of D30994: Return error code if no matching SA was found.
Jul 2 2021, 4:41 AM
wma requested review of D30993: Check PMTU before sending a frame..
Jul 2 2021, 4:40 AM
wma requested review of D30992: ipsec: Handle ICMP NEEDFRAG message..
Jul 2 2021, 4:38 AM
wma requested review of D30991: sys/netinet: handle IPv4 PMTU Discovery.
Jul 2 2021, 4:37 AM

Jun 23 2021

wma committed R10:17ac6d94dbc0: ip_mroute: initialize vif ifnet properly (authored by wma).
ip_mroute: initialize vif ifnet properly
Jun 23 2021, 8:14 AM
wma closed D30608: ip_mroute: initialize vif ifnet properly.
Jun 23 2021, 8:14 AM

Jun 2 2021

wma requested review of D30608: ip_mroute: initialize vif ifnet properly.
Jun 2 2021, 6:50 AM

May 31 2021

wma committed R10:d40cd26a86a7: ip_mroute: rework ip_mroute (authored by wma).
ip_mroute: rework ip_mroute
May 31 2021, 3:50 AM
wma closed D30354: ip_mroute: rework ip_mroute.
May 31 2021, 3:50 AM

May 25 2021

wma added inline comments to D30354: ip_mroute: rework ip_mroute.
May 25 2021, 9:47 AM

May 21 2021

wma committed R10:eedbbec3fd62: ip_mroute: remove unused declarations (authored by wma).
ip_mroute: remove unused declarations
May 21 2021, 6:02 AM
wma committed R10:741afc623391: ip_mroute: refactor bw_meter API (authored by wma).
ip_mroute: refactor bw_meter API
May 21 2021, 4:58 AM

May 20 2021

wma added a reverting change for R10:d1cd99b14741: ip_mroute: refactor bw_meter API: R10:787845c0e8e8: Revert "ip_mroute: refactor bw_meter API".
May 20 2021, 10:15 AM
wma committed R10:787845c0e8e8: Revert "ip_mroute: refactor bw_meter API" (authored by wma).
Revert "ip_mroute: refactor bw_meter API"
May 20 2021, 10:15 AM
wma added a reverting change for D30210: ip_mroute: refactor bw_meter API: R10:787845c0e8e8: Revert "ip_mroute: refactor bw_meter API".
May 20 2021, 10:15 AM
wma requested review of D30354: ip_mroute: rework ip_mroute.
May 20 2021, 8:18 AM
wma committed R10:d1cd99b14741: ip_mroute: refactor bw_meter API (authored by wma).
ip_mroute: refactor bw_meter API
May 20 2021, 8:14 AM
wma closed D30210: ip_mroute: refactor bw_meter API.
May 20 2021, 8:14 AM

May 14 2021

wma updated the diff for D30210: ip_mroute: refactor bw_meter API.
May 14 2021, 1:13 PM

May 11 2021

wma requested review of D30210: ip_mroute: refactor bw_meter API.
May 11 2021, 10:41 AM
wma committed R10:0b103f72376b: mrouter: do not loopback packets unconditionally (authored by wma).
mrouter: do not loopback packets unconditionally
May 11 2021, 10:38 AM
wma committed R10:65634ae748e7: mroute: fix race condition during mrouter shutting down (authored by wma).
mroute: fix race condition during mrouter shutting down
May 11 2021, 10:38 AM
wma closed D29947: mrouter: do not loopback packets unconditionally.
May 11 2021, 10:37 AM
wma closed D29946: mroute: fix race condition during mrouter shutting down.
May 11 2021, 10:37 AM

Apr 23 2021

wma requested review of D29947: mrouter: do not loopback packets unconditionally.
Apr 23 2021, 11:14 AM
wma requested review of D29946: mroute: fix race condition during mrouter shutting down.
Apr 23 2021, 11:13 AM

Apr 9 2021

wma closed D29625: pci_dw.c: Trim ATU windows bigger than 4GB.
Apr 9 2021, 7:40 AM
wma committed R10:243000b19f8b: pci_dw: Trim ATU windows bigger than 4GB (authored by wma).
pci_dw: Trim ATU windows bigger than 4GB
Apr 9 2021, 7:40 AM

Mar 4 2021

wma updated the diff for D28883: Shared library randomization.
Mar 4 2021, 1:23 PM

Feb 24 2021

wma added a comment to D28883: Shared library randomization.

That's a very good point, unfortunately I don't have a clear answer.
I'm aware of the problem with grep and this patch definitely not resolves it.

Feb 24 2021, 7:35 AM

Feb 23 2021

wma updated the summary of D28883: Shared library randomization.
Feb 23 2021, 11:05 AM
wma requested review of D28883: Shared library randomization.
Feb 23 2021, 11:02 AM

Apr 7 2020

wma added reviewers for D21339: GICv2m: parse SPI_BASE and NUM_SPIS from DTS: jhibbits, stevek.
Apr 7 2020, 4:51 AM
wma added reviewers for D21354: Introduce Broadcom NS2 iProc PCIe RC driver: jhibbits, stevek.
Apr 7 2020, 4:49 AM
wma added reviewers for D21342: GICv2m: quirks for Broadcom NS2: stevek, jhibbits.
Apr 7 2020, 4:48 AM

Apr 6 2020

wma committed rS359647: Add MDIO PHY driver for NS2 ARM64 platform..
Add MDIO PHY driver for NS2 ARM64 platform.
Apr 6 2020, 5:49 AM
wma closed D21335: Implement MDIO mux with Broadcom NS2 PCIe PHY initialization.
Apr 6 2020, 5:49 AM
wma accepted D21335: Implement MDIO mux with Broadcom NS2 PCIe PHY initialization.
Apr 6 2020, 4:15 AM

Apr 23 2019

wma committed rS346593: This patch offers a workaround to buf_ring reordering.
This patch offers a workaround to buf_ring reordering
Apr 23 2019, 6:36 AM
wma closed D19932: Add barrier in buf ring peek function to prevent race in ARM and ARM64.
Apr 23 2019, 6:36 AM · ARM, arm64, network

Apr 19 2019

wma accepted D19932: Add barrier in buf ring peek function to prevent race in ARM and ARM64.

Yet another reincarnation of https://reviews.freebsd.org/rS302292 this time in peak_clear_sc
If no objections, I will commit this next week.

Apr 19 2019, 6:08 AM · ARM, arm64, network

Jul 10 2018

wma committed rS336166: Fix build broken by r336130.
Fix build broken by r336130
Jul 10 2018, 9:49 AM

Jul 9 2018

wma committed rS336130: ARM64: Add quirk mechanism to pci_host_generic_acpi.
ARM64: Add quirk mechanism to pci_host_generic_acpi
Jul 9 2018, 9:00 AM
wma closed D15929: Add quirk mechanism to pci_host_generic_acpi.
Jul 9 2018, 9:00 AM
wma committed rS336129: ARM64: Add support for ThunderX2 PCIe.
ARM64: Add support for ThunderX2 PCIe
Jul 9 2018, 8:55 AM
wma closed D15141: Add support for ThunderX2 PCIe.
Jul 9 2018, 8:55 AM
wma closed D15928: Add ThunderX2 CPU revision macro. Add ThunderX2 name in identcpu.c.

Closed by https://svnweb.freebsd.org/changeset/base/336128

Jul 9 2018, 8:48 AM
wma committed rS336128: ARM64: Add ThunderX2 CPU revision macro. Add ThunderX2 name in identcpu.c.
ARM64: Add ThunderX2 CPU revision macro. Add ThunderX2 name in identcpu.c
Jul 9 2018, 8:42 AM

Jun 12 2018

wma added inline comments to D15763: powerpc64: Avoid type promotion.
Jun 12 2018, 4:34 AM

May 25 2018

wma added inline comments to D15566: Make opal_pci driver work with POWER9.
May 25 2018, 4:32 AM

Mar 16 2018

wma accepted D14703: nvme: Revert to using the old API..

Here is my two cents.

Mar 16 2018, 8:50 AM
wma edited reviewers for D14703: nvme: Revert to using the old API., added: wma, mst_semihalf.com; removed: wma_semihalf.com.
Mar 16 2018, 8:16 AM

Mar 15 2018

wma committed rS330971: Reverting r330925 for now.
Reverting r330925 for now
Mar 15 2018, 6:20 AM

Mar 14 2018

wma committed rS330925: PowerNV: Fix I2C to compile if FDT is disabled.
PowerNV: Fix I2C to compile if FDT is disabled
Mar 14 2018, 9:20 AM

Mar 1 2018

wma committed rS330240: PowerNV: Initial support for OPAL I2C transfers.
PowerNV: Initial support for OPAL I2C transfers
Mar 1 2018, 2:11 PM

Feb 24 2018

wma accepted D14483: Fix sysutils/smartmontools following Sr329824.

We'll handle the BE part.

Feb 24 2018, 8:07 AM

Feb 23 2018

wma committed rS329862: powerpc64: add NVMe to GENERIC64.
powerpc64: add NVMe to GENERIC64
Feb 23 2018, 7:44 AM
wma added a reviewer for D14483: Fix sysutils/smartmontools following Sr329824: mst_semihalf.com.

Looks OK, we'll test it on our hardware.

Feb 23 2018, 7:39 AM

Feb 22 2018

wma committed rS329824: NVMe: Add big-endian support.
NVMe: Add big-endian support
Feb 22 2018, 1:33 PM
wma closed D13916: Add big-endian support to NVMe.
Feb 22 2018, 1:33 PM
wma accepted D13916: Add big-endian support to NVMe.

I think we talked out all issues here.
I'll split this to separate patches and commit to the HEAD. Please let me know if you have any objections.

Feb 22 2018, 12:33 PM
wma committed rS329822: Add bsdlabel and fdisk to powerpc64.
Add bsdlabel and fdisk to powerpc64
Feb 22 2018, 12:31 PM

Feb 21 2018

wma committed rS329712: PowerNV: Put processor to power-save state in idle thread.
PowerNV: Put processor to power-save state in idle thread
Feb 21 2018, 2:29 PM
wma closed D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 21 2018, 2:29 PM · PowerPC
wma accepted D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 21 2018, 12:59 PM · PowerPC
wma committed rS329702: PowerNV: add missing RTC_WRITE support.
PowerNV: add missing RTC_WRITE support
Feb 21 2018, 8:13 AM
wma committed rS329701: CXGBE: implement prefetch on non-Intel architectures.
CXGBE: implement prefetch on non-Intel architectures
Feb 21 2018, 8:06 AM
wma closed D14452: CXGBE: implement prefetch on non-Intel architectures.
Feb 21 2018, 8:06 AM

Feb 20 2018

wma added inline comments to D14330: PowerNV: Put processor to power-save state in idle thread.
Feb 20 2018, 9:22 AM · PowerPC
wma committed rS329635: PowerPC: Switch to more accurate unit to avoid division rounding.
PowerPC: Switch to more accurate unit to avoid division rounding
Feb 20 2018, 7:31 AM
wma closed D14433: PowerPC: Switch to more accurate unit to avoid division rounding.
Feb 20 2018, 7:31 AM
wma closed D14437: Send SIGILL on HEA illegal instruction exception.
Feb 20 2018, 6:39 AM
wma committed rS329634: PowerNV: Send SIGILL on HEA illegal instruction exception.
PowerNV: Send SIGILL on HEA illegal instruction exception
Feb 20 2018, 6:39 AM

Feb 16 2018

wma added a comment to D14330: PowerNV: Put processor to power-save state in idle thread.

Actually, this is the only way to release resources by idling CPUs within the same SMT group - Linux does the same.
Sleep mode used here has the shortest wakeup delay, so the only performance hit is from saving and restoring context. However, it's still less complex than the one in cpu_switch.

Feb 16 2018, 7:12 AM · PowerPC

Feb 14 2018

wma accepted D14060: IFLIB: do not remove dmamap on buffer unload.
Feb 14 2018, 12:33 PM

Feb 8 2018

wma accepted D14267: loader: fix endianness conversion.

Nice!

Feb 8 2018, 5:50 PM

Jan 31 2018

wma committed rS328616: PowerNV: fix compilation on non-NV platforms.
PowerNV: fix compilation on non-NV platforms
Jan 31 2018, 6:42 AM

Jan 29 2018

wma committed rS328537: PowerNV: move LPCR and LPID altering to cpudep_ap_early_bootstrap.
PowerNV: move LPCR and LPID altering to cpudep_ap_early_bootstrap
Jan 29 2018, 9:27 AM
wma committed rS328536: loader: support for mixed-endianness ELF/loader and POWER8.
loader: support for mixed-endianness ELF/loader and POWER8
Jan 29 2018, 9:24 AM
wma closed D12422: loader: support for mixed-endianness ELF/loader and POWER8.
Jan 29 2018, 9:24 AM
wma committed rS328534: PPC64: use hwref instead of cpuid.
PPC64: use hwref instead of cpuid
Jan 29 2018, 9:15 AM
wma closed D14011: PPC64: use hwref instead of cpuid.
Jan 29 2018, 9:15 AM
wma added a comment to D14011: PPC64: use hwref instead of cpuid.

It SHOULD work on PowerNV as the code for cpuid swap is there, however I did not run much of testing, so I'd rather consider this as experimental/not-working. The CHRP platform has no such code, so there the BSP must be at CPU0.

Jan 29 2018, 9:12 AM