Page MenuHomeFreeBSD

hum_semihalf.com (Hubert Mazur)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2021, 9:28 AM (43 w, 2 d)

Recent Activity

Yesterday

hum_semihalf.com updated the diff for D33246: Improve parameters handling in veriexec.

Add a simple check for the argument whether it matches only one option. In case of ambiguity return an error.

Tue, May 17, 7:10 AM

Mon, May 16

hum_semihalf.com updated the diff for D33246: Improve parameters handling in veriexec.

Rebase the revision.

Mon, May 16, 5:24 AM
hum_semihalf.com updated the diff for D35120: libsecureboot: Do not propagate empty string.

Rebase the revision.

Mon, May 16, 5:23 AM

Mon, May 9

hum_semihalf.com updated the diff for D35120: libsecureboot: Do not propagate empty string.

Do not return immediately in case TRUST ANCHORS are NULL, as openpgp may be supported as well.

Mon, May 9, 7:54 AM
hum_semihalf.com updated the diff for D33246: Improve parameters handling in veriexec.

Fix style issues.

Mon, May 9, 7:50 AM

Wed, May 4

hum_semihalf.com requested review of D35120: libsecureboot: Do not propagate empty string.
Wed, May 4, 11:57 AM
hum_semihalf.com updated the diff for D33246: Improve parameters handling in veriexec.

Match args with shortest prefix. Add help message and prevent from running with invalid path.

Wed, May 4, 11:52 AM
hum_semihalf.com commandeered D33246: Improve parameters handling in veriexec.
Wed, May 4, 8:55 AM

Feb 10 2022

hum_semihalf.com added a comment to D32706: sdhci_fsl_fdt: Provide more accurate clk calculation.

The driver doesn't use Programmable Clock Mode because it does not converges to the SDHCI standard here.
In case of ls1028 the generic code (even with the added support) won't switch to PCM considering it unsupported... Obviously, we can switch to PCM on our own, but all that logic must be performed in additional function like fsl_sdhc_fdt_set_clock. IMHO that is not the case to rewrite the function to use PCM.
Divided Clock Mode can be used without any additional helper functions, but then divider 3 is unavailable - we won't get 600/3=200MHz for HS200. DCM is inapplicable.

Feb 10 2022, 12:32 PM

Feb 8 2022

hum_semihalf.com added a comment to D32706: sdhci_fsl_fdt: Provide more accurate clk calculation.

We still need to apply a limited clock division errata. Basically in HS400 mode and that mode only the controller can only use a limited set of divisors. I will try to modify the generic code to support Programmable Clock Mode and test it against ls1028 whether HS400 mode works correctly with or without errata application. Then we could possibly get rid of the problematic sdhci_fsl_fdt_set_clock function, and possibly apply the errata in some other, less invasive way.

Feb 8 2022, 8:24 AM

Feb 7 2022

hum_semihalf.com added a comment to D32706: sdhci_fsl_fdt: Provide more accurate clk calculation.

There are still some conditions under which this patch is valid and necessary. On ls1028a the base clock is 600MHz, therefore to obtain 200MHz frequency for HS200 we need divider 3. As SDHCI standard does not support odd dividers, this patch allows to use them. With this, we can use 200MHz instead of 150MHz for HS200 for faster transfers.
As it comes to the SDHCI_CLOCK_CONTROL register, it is captured properly in sdhci_fsl_fdt_read_2 function - we read controller register responsible for clock stability indicator and set flag if matched. I can't see any other invalid usages of aforementioned.

Feb 7 2022, 10:33 AM

Feb 1 2022

hum_semihalf.com abandoned D33585: sdhci_fsl_fdt: Add custom method for retune .

Abandon this revision as retuning is handled in https://reviews.freebsd.org/D34027 patch, which covers all cases and fixes.

Feb 1 2022, 10:44 AM

Jan 31 2022

hum_semihalf.com updated the diff for D34029: sdhci_fsl_fdt: Add voltage switching through syscon.

Change voltage switching logic. After setting registers check for errata flag for missing regulator and use syscon register for voltage switch if necessary. Check for a fixed regulator presence afterwards, as it still might be possible and use it.

Jan 31 2022, 9:22 AM

Jan 27 2022

hum_semihalf.com updated the diff for D34029: sdhci_fsl_fdt: Add voltage switching through syscon.

Fix typos. Don't return from function right after voltage switching with a syscon, but go to the fixed regulator logic.

Jan 27 2022, 9:29 AM

Jan 25 2022

hum_semihalf.com requested review of D34029: sdhci_fsl_fdt: Add voltage switching through syscon.
Jan 25 2022, 8:37 AM
hum_semihalf.com requested review of D34028: sdhci_fsl_fdt: Apply errata for LX2160A.
Jan 25 2022, 8:35 AM

Jan 4 2022

hum_semihalf.com updated the diff for D32336: if_mvneta: Use clock frequency.

Rebase patch on HEAD.

Jan 4 2022, 9:34 AM
hum_semihalf.com updated the diff for D32294: Add driver for marvell, a37x0 peripheral clocks.

Rebase patch on HEAD.

Jan 4 2022, 9:33 AM
hum_semihalf.com updated the diff for D32293: Add driver for armada, 37x0-tbg-clock.

Rebase patch on HEAD.

Jan 4 2022, 9:32 AM
hum_semihalf.com updated the diff for D32292: Add driver for marvell, armada-3700 oscillator.

Rebase on HEAD

Jan 4 2022, 9:31 AM

Dec 20 2021

hum_semihalf.com requested review of D33585: sdhci_fsl_fdt: Add custom method for retune .
Dec 20 2021, 12:52 PM

Dec 17 2021

hum_semihalf.com updated the diff for D33497: pcf85063: Set RTC device to work in 24h mode.

Update commit log with differential information.

Dec 17 2021, 10:04 AM

Dec 16 2021

hum_semihalf.com requested review of D33497: pcf85063: Set RTC device to work in 24h mode.
Dec 16 2021, 9:07 AM

Dec 9 2021

hum_semihalf.com added a comment to D33320: sdhci_fsl_fdt: Add support for HS200/HS400 modes .

Apparently LX2160A requires window pointer errata enabled for tuning to succeed. (SDHCI_FSL_TUNING_ERRATUM_TYPE2)
Unfortunately on this SoC we have a generic compat string for SDHCI driver, so there is no easy way to detect and apply it.
For now, I will prepare a patch that disables HS200/HS400 modes for all boards that use the generic compat.

Dec 9 2021, 1:16 PM

Dec 8 2021

hum_semihalf.com updated the diff for D33319: sdhci_fsl_fdt: Fix vccq reconfiguration .

Remove redundant variable.

Dec 8 2021, 9:54 AM
hum_semihalf.com updated the diff for D33320: sdhci_fsl_fdt: Add support for HS200/HS400 modes .

Update commit log. Add helper function for polling registers. Fix typos and remove redundant variables declaration.

Dec 8 2021, 9:23 AM
hum_semihalf.com updated the diff for D33319: sdhci_fsl_fdt: Fix vccq reconfiguration .

Update commit log.

Dec 8 2021, 9:21 AM
hum_semihalf.com updated the diff for D33318: sdhci_fsl_fdt: Add LS1012A compat string .

Update commit log.

Dec 8 2021, 9:21 AM

Dec 7 2021

hum_semihalf.com updated the diff for D33318: sdhci_fsl_fdt: Add LS1012A compat string .

Fix typo in commit log: s/LS1028A/LS1012A.

Dec 7 2021, 12:26 PM
hum_semihalf.com requested review of D33320: sdhci_fsl_fdt: Add support for HS200/HS400 modes .
Dec 7 2021, 12:21 PM
hum_semihalf.com requested review of D33319: sdhci_fsl_fdt: Fix vccq reconfiguration .
Dec 7 2021, 12:19 PM
hum_semihalf.com requested review of D33318: sdhci_fsl_fdt: Add LS1012A compat string .
Dec 7 2021, 12:14 PM

Dec 1 2021

hum_semihalf.com updated the diff for D33222: NXP: Implement errata workaround for SDHCI driver .

Change time period in license entry from 2021 to 2020 - 2021.

Dec 1 2021, 3:06 PM
hum_semihalf.com requested review of D33222: NXP: Implement errata workaround for SDHCI driver .
Dec 1 2021, 2:46 PM

Nov 30 2021

hum_semihalf.com updated the diff for D33162: sys/libkern.h: Add type conversion helpers.

Change function's names to more self-descriptive, reflecting followed ARM instructions behavior.

Nov 30 2021, 8:44 AM

Nov 29 2021

hum_semihalf.com updated the diff for D32818: TMP461: Add thermal sensor driver.

Remove conversion helper function, as it is separate commit.

Nov 29 2021, 12:31 PM
hum_semihalf.com requested review of D33162: sys/libkern.h: Add type conversion helpers.
Nov 29 2021, 12:29 PM

Nov 25 2021

hum_semihalf.com updated the diff for D32818: TMP461: Add thermal sensor driver.

Move signed -> unsigned helper function to libkern.h.

Nov 25 2021, 1:17 PM

Nov 3 2021

hum_semihalf.com requested review of D32819: TCA6408: Add driver for tca6408 gpio expander.
Nov 3 2021, 12:00 PM
hum_semihalf.com requested review of D32818: TMP461: Add thermal sensor driver.
Nov 3 2021, 11:57 AM
hum_semihalf.com requested review of D32817: Pcf85063: Add RTC driver.
Nov 3 2021, 11:54 AM

Oct 22 2021

hum_semihalf.com updated the diff for D32294: Add driver for marvell, a37x0 peripheral clocks.

Split driver into two separate drivers, each for north bridge or south bridge domain.

Oct 22 2021, 11:44 AM

Oct 6 2021

hum_semihalf.com requested review of D32336: if_mvneta: Use clock frequency.
Oct 6 2021, 12:13 PM

Oct 4 2021

hum_semihalf.com requested review of D32294: Add driver for marvell, a37x0 peripheral clocks.
Oct 4 2021, 2:18 PM
hum_semihalf.com requested review of D32293: Add driver for armada, 37x0-tbg-clock.
Oct 4 2021, 2:13 PM
hum_semihalf.com requested review of D32292: Add driver for marvell, armada-3700 oscillator.
Oct 4 2021, 2:09 PM

Sep 13 2021

hum_semihalf.com updated the diff for D31581: if_mvneta: Build the driver as a kernel module.

Rebase against main

Sep 13 2021, 8:55 AM
hum_semihalf.com updated the diff for D31580: e6000sw: Build the driver as a kernel module.

Rebase against main

Sep 13 2021, 8:54 AM
hum_semihalf.com updated the diff for D31579: e6000sw: Use taskqueue subsytem for MDIO polling.

Rebase against main

Sep 13 2021, 8:53 AM

Sep 3 2021

hum_semihalf.com updated the diff for D31579: e6000sw: Use taskqueue subsytem for MDIO polling.
Sep 3 2021, 7:37 AM

Aug 17 2021

hum_semihalf.com added a reviewer for D31579: e6000sw: Use taskqueue subsytem for MDIO polling: manu.
Aug 17 2021, 12:03 PM
hum_semihalf.com updated the diff for D31581: if_mvneta: Build the driver as a kernel module.

Added back neta entry in sys/arm64/conf/std.marvell.

Aug 17 2021, 12:01 PM
hum_semihalf.com requested review of D31581: if_mvneta: Build the driver as a kernel module.
Aug 17 2021, 8:47 AM
hum_semihalf.com requested review of D31580: e6000sw: Build the driver as a kernel module.
Aug 17 2021, 8:41 AM
hum_semihalf.com requested review of D31579: e6000sw: Use taskqueue subsytem for MDIO polling.
Aug 17 2021, 8:38 AM