Page MenuHomeFreeBSD

sdhci_fsl_fdt: Fix vccq reconfiguration
ClosedPublic

Authored by hum_semihalf.com on Dec 7 2021, 12:19 PM.

Details

Summary

As vqmmc-supply is an optional Device Tree property, don't skip vccq
reconfiguration when the regulator is not specified. Instead, accept
voltage specified by the voltage-ranges property.

The actual voltage switch is done through a hw register in LS1028A.
Add errata flag for other boards, as they are not supported. Return
not supported error code when switching to 1.8V on affected platforms.

Fixes: b08bf4c3 ("sdhci_fsl_fdt: Skip vccq reconfiguration without regulator")

Co-authored-by: Artur Rojek <ar@semihalf.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu requested changes to this revision.Dec 8 2021, 9:27 AM
manu added inline comments.
sys/dev/sdhci/sdhci_fsl_fdt.c
523

You don't need this variable.

This revision now requires changes to proceed.Dec 8 2021, 9:27 AM
This revision is now accepted and ready to land.Dec 8 2021, 10:09 AM
This revision was automatically updated to reflect the committed changes.