Page MenuHomeFreeBSD

sdhci_fsl_fdt: Fix vccq reconfiguration
ClosedPublic

Authored by hum_semihalf.com on Dec 7 2021, 12:19 PM.
Tags
None
Referenced Files
F68177795: D33319.diff
Sun, Sep 24, 10:58 AM
F68172833: D33319.id99651.diff
Sun, Sep 24, 8:39 AM
F68172739: D33319.id99701.diff
Sun, Sep 24, 8:36 AM
F68172727: D33319.id99693.diff
Sun, Sep 24, 8:36 AM
F68172721: D33319.id99699.diff
Sun, Sep 24, 8:36 AM
F68172720: D33319.id.diff
Sun, Sep 24, 8:36 AM
F68171628: D33319.diff
Sun, Sep 24, 8:08 AM
Unknown Object (File)
Sun, Sep 17, 5:19 PM

Details

Summary

As vqmmc-supply is an optional Device Tree property, don't skip vccq
reconfiguration when the regulator is not specified. Instead, accept
voltage specified by the voltage-ranges property.

The actual voltage switch is done through a hw register in LS1028A.
Add errata flag for other boards, as they are not supported. Return
not supported error code when switching to 1.8V on affected platforms.

Fixes: b08bf4c3 ("sdhci_fsl_fdt: Skip vccq reconfiguration without regulator")

Co-authored-by: Artur Rojek <ar@semihalf.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu requested changes to this revision.Dec 8 2021, 9:27 AM
manu added inline comments.
sys/dev/sdhci/sdhci_fsl_fdt.c
524

You don't need this variable.

This revision now requires changes to proceed.Dec 8 2021, 9:27 AM
This revision is now accepted and ready to land.Dec 8 2021, 10:09 AM
This revision was automatically updated to reflect the committed changes.