Page MenuHomeFreeBSD

kd (Kornel Dulęba)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 19 2018, 1:41 PM (281 w, 5 d)

Recent Activity

Mar 31 2023

kd abandoned D39364: arm: Restore the names of fields in fpreg structure.
Mar 31 2023, 1:19 PM
kd added a reviewer for D39364: arm: Restore the names of fields in fpreg structure: markmi_dsl-only.net.
Mar 31 2023, 12:17 PM
kd requested review of D39364: arm: Restore the names of fields in fpreg structure.
Mar 31 2023, 12:16 PM

Mar 30 2023

kd added a comment to D37419: arm: Add support for using VFP in kernel.

A list of the FreeBSD servers is maintained at: https://github.com/bdrewery/pkg-status.freebsd.org/blob/master/servers.txt

My guess here is that I have IPv6 access via my ISP (not just IPv4) and that you do not have IPv6 access. I did not find any official listing of the protocols supported but I did find material claiming IPv6-only for some of the servers as an explanation of why some folks in a 2021 discussion could vs. could-not get information from the servers of interest in that discussion.

Mar 30 2023, 4:14 PM
kd added inline comments to D37419: arm: Add support for using VFP in kernel.
Mar 30 2023, 7:16 AM

Mar 21 2023

kd committed rG19a4869d66f5: OpenSSL: aes/asm/bsaes-armv7.pl: Replace adrl with add (authored by kd).
OpenSSL: aes/asm/bsaes-armv7.pl: Replace adrl with add
Mar 21 2023, 7:05 PM
kd closed D39091: OpenSSL: aes/asm/bsaes-armv7.pl: Replace adrl with add.
Mar 21 2023, 7:05 PM

Mar 16 2023

kd updated the diff for D37420: ossl: add supprot for ARMv7.

The patch has been rewritten from scratch.
In order to build it D39091 has to be applied first.
Then the ossl armv7 assembly logic has to be regenerated - crypto/openssl/crypto/aes/asm/bsaes-armv7.pl > sys/crypto/openssl/arm/bsaes-armv7.S

Mar 16 2023, 9:11 AM

Mar 15 2023

kd requested review of D39091: OpenSSL: aes/asm/bsaes-armv7.pl: Replace adrl with add.
Mar 15 2023, 11:09 AM

Feb 23 2023

kd committed rG98c666cf8758: arm: Fix initialization of VFP context (authored by kd).
arm: Fix initialization of VFP context
Feb 23 2023, 4:51 PM
kd committed rG4d2427f2c445: arm: Unbreak debugging programs that use FP instructions (authored by kd).
arm: Unbreak debugging programs that use FP instructions
Feb 23 2023, 4:51 PM
kd closed D38698: arm: Fix initialization of VFP context.
Feb 23 2023, 4:51 PM
kd closed D38696: arm: Unbreak debugging programs that use FP instructions.
Feb 23 2023, 4:51 PM
kd added a comment to D38698: arm: Fix initialization of VFP context.

@andrew Do you have any more comment w.r.t. this?
If not I'll commit this patch and D38696 soon.

Feb 23 2023, 10:29 AM

Feb 22 2023

kd added a comment to D38696: arm: Unbreak debugging programs that use FP instructions.

Do not take the following as indicating anything is necessarily wrong. It is more about my ignorance in the subjects involved.

Why does get_vfpcontext only need critical_enter/critical_exit to span so little but set_vfpcontext to span so much?

An implication is that no variation in context from the likes of, say, a cpu migration would mess up an already partially completed memcpy in get_vfpcontext. So the pcb_vfpstate storage used would apparently be unchanged over the whole memcpy operation.

Feb 22 2023, 6:24 PM
kd updated the diff for D38696: arm: Unbreak debugging programs that use FP instructions.
Feb 22 2023, 6:24 PM
kd added inline comments to D38698: arm: Fix initialization of VFP context.
Feb 22 2023, 6:23 PM
kd updated the diff for D38698: arm: Fix initialization of VFP context.

Fix kernel build when VFP is not used.

Feb 22 2023, 6:23 PM

Feb 20 2023

kd requested review of D38698: arm: Fix initialization of VFP context.
Feb 20 2023, 5:40 PM
kd requested review of D38696: arm: Unbreak debugging programs that use FP instructions.
Feb 20 2023, 3:02 PM

Feb 4 2023

kd committed rGe5d7c5c857f8: arm: mv: Add missing function prototype (authored by kd).
arm: mv: Add missing function prototype
Feb 4 2023, 7:23 PM
kd committed rG6926e2699ae5: arm: Add support for using VFP in kernel (authored by kd).
arm: Add support for using VFP in kernel
Feb 4 2023, 7:23 PM
kd closed D37419: arm: Add support for using VFP in kernel.
Feb 4 2023, 7:22 PM

Jan 19 2023

kd abandoned D21337: bnxt: Set max number of descriptors to a power of 2.

This was fixed in D24922.

Jan 19 2023, 10:17 AM

Jan 16 2023

kd added inline comments to D37419: arm: Add support for using VFP in kernel.
Jan 16 2023, 2:19 PM
kd updated the diff for D37419: arm: Add support for using VFP in kernel.
  • Fix a shallow copy bug in cpu_fork
  • Adjust the logic to match the recent changes made to arm64 implementation by andrew@.
  • Remove the _MC_FP_VALID, as it's not needed.
Jan 16 2023, 11:53 AM
kd commandeered D37419: arm: Add support for using VFP in kernel.
Jan 16 2023, 11:51 AM

Jan 13 2023

kd added a comment to D32954: Retire non-NEW_PCIB code and remove config option.

I've applied this patch and it seems to work just fine with a ARMADA38X config, which didn't use the NEW_PCIB option before.
That is the system boots, but I don't have anything plugged into the pcie slot at the moment.
I'll look for a card that I can put in, and will let you know if it works.

Jan 13 2023, 1:25 PM
kd accepted D37813: Mechanically convert etherswitch drivers to DrvAPI.

LGTM, but I've mostly only looked at felix and e6000sw.

Jan 13 2023, 11:38 AM

Dec 13 2022

kd added a comment to D37421: ossl: Add AES-GCM implementation for ARMv7 NEON.
In D37421#855702, @jhb wrote:

Huh? Rejecting that would be utterly wrong. AES-GCM as a stream cipher permits payloads that are not a multiple of a block size. tools/tools/crypto/cryptocheck explicitly checks for that for stream ciphers like AES-CTR and AES-GCM in its tests with -z as well. There is no padding for IPsec when using a stream cipher.

Dec 13 2022, 11:29 AM
kd added a reviewer for D37420: ossl: add supprot for ARMv7: jhb.
Dec 13 2022, 11:26 AM
kd updated the diff for D37421: ossl: Add AES-GCM implementation for ARMv7 NEON.
Dec 13 2022, 11:26 AM
kd commandeered D37421: ossl: Add AES-GCM implementation for ARMv7 NEON.
Dec 13 2022, 11:25 AM
kd updated the diff for D37420: ossl: add supprot for ARMv7.
Dec 13 2022, 11:24 AM
kd commandeered D37420: ossl: add supprot for ARMv7.
Dec 13 2022, 11:20 AM

Dec 1 2022

kd added a comment to D37421: ossl: Add AES-GCM implementation for ARMv7 NEON.

Please remove the file mode change to tests/sys/opencrypto/runtests.sh.

Dec 1 2022, 10:22 AM
kd committed rG6f9c622690fd: rx8803: Improve probing logic (authored by kd).
rx8803: Improve probing logic
Dec 1 2022, 9:16 AM
kd closed D37579: rx8803: Improve probing logic.
Dec 1 2022, 9:15 AM
kd requested review of D37579: rx8803: Improve probing logic.
Dec 1 2022, 8:35 AM

Nov 21 2022

kd added inline comments to D37419: arm: Add support for using VFP in kernel.
Nov 21 2022, 9:26 AM
kd added a comment to D37441: param: increase KSTACK for hash context.

Since this isn't an Armada38x specific change I believe that it should be applied to all kernel configs.
IMHO we should modify the default value in arm/include/param.h.
Another thing is that 8 pages might be more than needed, e.g. amd64 defaults to 4/6 depending on whether KASAN is enabled.
Also as mw mentioned the commit message should contain a verbose explanation why we need to increase the kernel stack size.

Nov 21 2022, 9:21 AM

Nov 8 2022

kd committed rGf1717ffd7a08: gpio: Fix typo causing GPIO configuration mismatch (authored by jkol_semihalf.com).
gpio: Fix typo causing GPIO configuration mismatch
Nov 8 2022, 1:29 PM
kd closed D37262: Fix typo causing GPIO configuration mismatch.
Nov 8 2022, 1:28 PM

Nov 4 2022

kd accepted D37262: Fix typo causing GPIO configuration mismatch.
Nov 4 2022, 3:05 PM

Oct 19 2022

kd committed rG7a3d9a7d49f1: qoriq_dw_pci: Fix typo in link status checking code (authored by bag_semihalf.com).
qoriq_dw_pci: Fix typo in link status checking code
Oct 19 2022, 12:46 PM

Oct 6 2022

kd committed rG6bdc398832a6: uart_dev_snps: Fix device probing (authored by kd).
uart_dev_snps: Fix device probing
Oct 6 2022, 2:53 PM
kd committed rGfdbd0ba75d99: test/sys/opencrypto: Fix NIST KAT parser iterator (authored by kd).
test/sys/opencrypto: Fix NIST KAT parser iterator
Oct 6 2022, 2:53 PM
kd closed D36880: uart_dev_snps: Fix device probing.
Oct 6 2022, 2:53 PM
kd closed D36861: test/sys/opencrypto: Fix NIST KAT parser iterator.
Oct 6 2022, 2:53 PM

Oct 5 2022

kd updated the diff for D36880: uart_dev_snps: Fix device probing.

Fix patch context (-U9999)

Oct 5 2022, 6:58 AM
kd requested review of D36880: uart_dev_snps: Fix device probing.
Oct 5 2022, 6:57 AM

Oct 4 2022

kd added inline comments to D36861: test/sys/opencrypto: Fix NIST KAT parser iterator.
Oct 4 2022, 7:56 AM
kd updated the diff for D36861: test/sys/opencrypto: Fix NIST KAT parser iterator.

Update the patch based on ngie@ comments.

Oct 4 2022, 7:55 AM

Oct 3 2022

kd requested review of D36861: test/sys/opencrypto: Fix NIST KAT parser iterator.
Oct 3 2022, 10:06 AM

Sep 29 2022

kd committed rG7b54d275ef6f: libsa/netif.c: Replace #if with #ifdef (authored by mig_semihalf.com).
libsa/netif.c: Replace #if with #ifdef
Sep 29 2022, 11:01 AM
kd closed D36740: libsa/netif.c: Replace #if with #ifdef.
Sep 29 2022, 11:00 AM
kd committed rGc66c6da4f081: libsa/arp.c: Change printf format string (authored by mig_semihalf.com).
libsa/arp.c: Change printf format string
Sep 29 2022, 11:00 AM
kd committed rGee0d06faa0a5: libsa/rarp.c: Change casted type and printf format (authored by mig_semihalf.com).
libsa/rarp.c: Change casted type and printf format
Sep 29 2022, 11:00 AM
kd committed rG1ed7916188b5: libsa/rarp.c: Change printf format string (authored by mig_semihalf.com).
libsa/rarp.c: Change printf format string
Sep 29 2022, 11:00 AM
kd closed D36735: libsa/arp.c: Change printf format string.
Sep 29 2022, 10:59 AM
kd closed D36738: libsa/rarp.c: Change casted type and printf format string.
Sep 29 2022, 10:59 AM
kd closed D36739: libsa/rarp.c: Change printf format string.
Sep 29 2022, 10:59 AM

Sep 28 2022

kd accepted D36740: libsa/netif.c: Replace #if with #ifdef.

This matches other occurrences of NETIF_DEBUG in this file.

Sep 28 2022, 12:31 PM

Sep 26 2022

kd committed rG7b8bb67135f2: igc: Don't start in promiscious mode by default (authored by hum_semihalf.com).
igc: Don't start in promiscious mode by default
Sep 26 2022, 8:29 AM

Sep 19 2022

kd closed D36591: if_igc: Don't start in promiscious mode by default.
Sep 19 2022, 7:28 AM
kd closed D36559: Merge TCA6416 & TCA6408 modules into TCA64XX.
Sep 19 2022, 7:28 AM
kd committed rGb8a083ea32f5: gpio: Merge TCA6416 & TCA6408 drivers into TCA64XX (authored by jkol_semihalf.com).
gpio: Merge TCA6416 & TCA6408 drivers into TCA64XX
Sep 19 2022, 7:28 AM
kd committed rG55760984d56b: igc: Don't start in promiscious mode by default (authored by hum_semihalf.com).
igc: Don't start in promiscious mode by default
Sep 19 2022, 7:28 AM
kd accepted D36559: Merge TCA6416 & TCA6408 modules into TCA64XX.
Sep 19 2022, 7:16 AM

Sep 9 2022

kd committed rGcbe3966fb9c9: tpm: Fix entropy harvesting logic (authored by kd).
tpm: Fix entropy harvesting logic
Sep 9 2022, 1:26 PM
kd closed D36464: TMP461: Add support for ADT7461 sensor.
Sep 9 2022, 11:51 AM
kd committed rG6665c7a62839: TMP461: Add support for ADT7461 sensor (authored by mkoz_semihalf.com).
TMP461: Add support for ADT7461 sensor
Sep 9 2022, 11:51 AM

Sep 7 2022

kd committed rG06c30b2c7618: mvneta: Use clkgen API on armv7 (authored by aja_semihalf.com).
mvneta: Use clkgen API on armv7
Sep 7 2022, 8:01 AM
kd committed rG4a4c6dc9a3e8: Add ARMADA38X gateclk control (authored by aja_semihalf.com).
Add ARMADA38X gateclk control
Sep 7 2022, 8:01 AM
kd committed rG59c2babcabdc: mv_twsi: Use the clock API on armv7 (authored by aja_semihalf.com).
mv_twsi: Use the clock API on armv7
Sep 7 2022, 8:01 AM
kd committed rG07c5be33f145: Add ARMADA38X clkgen driver (authored by aja_semihalf.com).
Add ARMADA38X clkgen driver
Sep 7 2022, 8:00 AM
kd committed rG299b6c9cb1a9: uart_bus_acpi: Read clock frequency from bus (authored by mkoz_semihalf.com).
uart_bus_acpi: Read clock frequency from bus
Sep 7 2022, 8:00 AM
kd closed D36465: mvneta: Use clkgen API in armv7.
Sep 7 2022, 8:00 AM
kd closed D36455: Add ARMADA38X gateclk control.
Sep 7 2022, 8:00 AM
kd closed D36456: mv_twsi: Use the clock API on armv7.
Sep 7 2022, 8:00 AM
kd closed D36453: Add ARMADA38X clkgen driver.
Sep 7 2022, 8:00 AM
kd closed D36326: uart: Read clock frequency from bus.
Sep 7 2022, 8:00 AM

Sep 2 2022

kd committed rG66c73af7ea59: stand: Parse BIOS revision from SMBIOS (authored by kd).
stand: Parse BIOS revision from SMBIOS
Sep 2 2022, 11:20 AM
kd closed D36413: stand: Parse BIOS revision from SMBIOS.
Sep 2 2022, 11:20 AM
kd closed D36412: tpm: Fix entropy harvesting logic.
Sep 2 2022, 11:20 AM
kd committed rGe23ad9c4ba2d: tpm: Fix entropy harvesting logic (authored by kd).
tpm: Fix entropy harvesting logic
Sep 2 2022, 11:20 AM

Sep 1 2022

kd updated the diff for D36413: stand: Parse BIOS revision from SMBIOS.

sprintf -> snprintf

Sep 1 2022, 3:26 PM
kd requested review of D36413: stand: Parse BIOS revision from SMBIOS.
Sep 1 2022, 2:13 PM
kd requested review of D36412: tpm: Fix entropy harvesting logic.
Sep 1 2022, 12:58 PM
kd committed rG91af12081edc: TPM: do not set device description if probe fails (authored by kjopek_gmail.com).
TPM: do not set device description if probe fails
Sep 1 2022, 7:22 AM
kd committed rG108b6eb670ec: neta: Fix MTU change sequence (authored by kd).
neta: Fix MTU change sequence
Sep 1 2022, 7:22 AM

Aug 22 2022

kd closed D36260: Add ACPI entry for LS1046A UART.
Aug 22 2022, 7:22 AM
kd committed rG7cb73f654ff4: uart: Add ACPI entry for LS1046A UART (authored by mkoz_semihalf.com).
uart: Add ACPI entry for LS1046A UART
Aug 22 2022, 7:22 AM
kd accepted D36260: Add ACPI entry for LS1046A UART.
Aug 22 2022, 7:13 AM

Aug 18 2022

kd committed rG97ecdc00ac5a: neta: Fix MTU change sequence (authored by kd).
neta: Fix MTU change sequence
Aug 18 2022, 4:57 PM

Aug 16 2022

kd closed D35998: TPM: do not set device description if probe fails.
Aug 16 2022, 9:12 AM
kd committed rG31ee3a33aa61: TPM: do not set device description if probe fails (authored by kjopek_gmail.com).
TPM: do not set device description if probe fails
Aug 16 2022, 9:12 AM
kd committed rGc8cc66928b8b: icmp6: Improve validation of PMTU (authored by kd).
icmp6: Improve validation of PMTU
Aug 16 2022, 8:22 AM

Jul 30 2022

kd added a comment to D35998: TPM: do not set device description if probe fails.

Would you like me to commit it?

Jul 30 2022, 9:50 AM
kd accepted D35998: TPM: do not set device description if probe fails.

LGTM

Jul 30 2022, 9:47 AM