Differential D36740

libsa/netif.c: Replace #if with #ifdef
ClosedPublic
Actions

Authored by mig_semihalf.com on Sep 27 2022, 1:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 10, 12:56 AM

	Unknown Object (File)
	Fri, Oct 10, 12:56 AM

	Unknown Object (File)
	Fri, Oct 10, 12:56 AM

	Unknown Object (File)
	Thu, Oct 9, 8:44 PM

	Unknown Object (File)
	Wed, Sep 24, 3:23 AM

	Unknown Object (File)
	Wed, Sep 24, 2:20 AM

	Unknown Object (File)
	Aug 12 2025, 6:09 PM

	Unknown Object (File)
	Aug 7 2025, 3:13 PM

View All 98 Files

Subscribers

Details

Reviewers

imp
wma
mw
kd
manu

Commits

rGf600fa25a2f2: libsa/netif.c: Replace #if with #ifdef
rG7b54d275ef6f: libsa/netif.c: Replace #if with #ifdef

Summary

Follow the convention with *_DEBUG macros in stand/libsa/* and
replace #if with #ifdef.

Test Plan

In stand/libsa/netif.c after all #include's add:
#define NETIF_DEBUG
temporary directory to hold compilation files:
mkdir -p $HOME/obj
set appropriate environmental variables, e.g. ARCH=arm64, TARGET_ARCH=aarch64, MAKEOBJDIRPREFIX=$HOME/obj.
In stand/libsa:
sudo -E make buildenv
make
compilation ends with error.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mig_semihalf.com created this revision.Sep 27 2022, 1:17 AM

Herald added a reviewer: manu. · View Herald TranscriptSep 27 2022, 1:17 AM

Herald added subscribers: dab, imp. · View Herald Transcript

mig_semihalf.com requested review of this revision.Sep 27 2022, 1:17 AM

Harbormaster completed remote builds in B47558: Diff 111046.Sep 27 2022, 1:17 AM

mig_semihalf.com edited reviewers, added: imp, wma, mw, kd; removed: manu.Sep 27 2022, 1:20 AM

Herald added a reviewer: manu. · View Herald TranscriptSep 27 2022, 1:20 AM

This matches other occurrences of NETIF_DEBUG in this file.

This revision is now accepted and ready to land.Sep 28 2022, 12:31 PM

Closed by commit rG7b54d275ef6f: libsa/netif.c: Replace #if with #ifdef (authored by mig_semihalf.com, committed by kd). · Explain WhySep 29 2022, 11:00 AM

This revision was automatically updated to reflect the committed changes.

kd added a commit: rG7b54d275ef6f: libsa/netif.c: Replace #if with #ifdef.

imp added a commit: rGf600fa25a2f2: libsa/netif.c: Replace #if with #ifdef.Jan 24 2023, 10:18 PM

Revision Contents
Changeset List

Path

Size

stand/

libsa/

2 lines

Diff 111179

stand/libsa/netif.c

Loading...