Page MenuHomeFreeBSD

mw (Marcin Wojtas)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 21 2017, 11:02 PM (195 w, 3 d)

Recent Activity

Wed, Apr 7

mw accepted D29625: pci_dw.c: Trim ATU windows bigger than 4GB.
Wed, Apr 7, 1:55 PM

Tue, Apr 6

mw committed R10:9857e00a528b: pci_user: fix build for 32-bit platforms (authored by mw).
pci_user: fix build for 32-bit platforms
Tue, Apr 6, 4:58 PM
mw committed R10:f2f1ab39c040: pci_user: call bus_translate_resource before BAR mmap (authored by mw).
pci_user: call bus_translate_resource before BAR mmap
Tue, Apr 6, 3:17 PM
mw committed R10:1c1ead9b94a1: pciconf: Use VM_MEMATTR_DEVICE on supported architectures (authored by mw).
pciconf: Use VM_MEMATTR_DEVICE on supported architectures
Tue, Apr 6, 3:17 PM
mw closed D29604: pci_user.c: Call bus_translate_resource before mmaping bars.
Tue, Apr 6, 3:17 PM
mw closed D29603: pciconf: Use VM_MEMATTR_DEVICE on supported architectures.
Tue, Apr 6, 3:17 PM
mw committed R10:57dbb3c25936: pci_dw: fix outbound I/O window configuration (authored by mw).
pci_dw: fix outbound I/O window configuration
Tue, Apr 6, 12:35 PM
mw closed D29516: pci_dw.c: Set IO ATU window correctly.
Tue, Apr 6, 12:35 PM

Mon, Apr 5

mw accepted D29520: Merge the QorIQ GPIO drivers between arm and powerpc.
Mon, Apr 5, 10:58 AM

Thu, Apr 1

mw requested changes to D29520: Merge the QorIQ GPIO drivers between arm and powerpc.

Thank you Justin for doing the change!

Thu, Apr 1, 7:31 AM

Wed, Mar 31

mw accepted D29516: pci_dw.c: Set IO ATU window correctly.
Wed, Mar 31, 4:20 PM

Tue, Mar 30

mw added inline comments to D28803: arm64: Don't rely on firmware interrupt mapping in ICU.
Tue, Mar 30, 3:55 PM
mw added inline comments to D28803: arm64: Don't rely on firmware interrupt mapping in ICU.
Tue, Mar 30, 3:23 PM

Mar 4 2021

mw closed D28850: arm64: Fix spi_ranges_cnt in mv_ap806_gicp.

Change commited: https://cgit.freebsd.org/src/commit/?id=622d17da46eb360c3d6847e4da8dbb166b775d14
Forgot to refer to this revision.

Mar 4 2021, 5:26 PM

Mar 3 2021

mw added a comment to D29044: mvebu_gpio: fix gpio pin configuration update.

@mmel you can commit this patch, it's basically your change. I only want it to be in the tree :)

Mar 3 2021, 10:01 PM
mw updated the diff for D29044: mvebu_gpio: fix gpio pin configuration update.
Mar 3 2021, 9:48 PM
mw added a comment to D29044: mvebu_gpio: fix gpio pin configuration update.

Confirmed with the specs and agree. Updating.

Mar 3 2021, 9:46 PM
mw updated the diff for D28911: mvebu_gpio: do not force data in value invertion during attach.
Mar 3 2021, 9:45 PM
mw added a comment to D28911: mvebu_gpio: do not force data in value invertion during attach.
In D28911#650354, @mmel wrote:

I don't think this change is necessary (it mitigates another bug). So I prefer to unconditionally initialize both registers in attach.

Mar 3 2021, 8:22 PM
mw added a comment to D29013: mvebu_gpio: fix interrupt cause register configuration.

@mmel please review https://reviews.freebsd.org/D29044

Mar 3 2021, 6:38 PM
mw updated the diff for D28911: mvebu_gpio: do not force data in value invertion during attach.
Mar 3 2021, 6:36 PM
mw requested review of D29044: mvebu_gpio: fix gpio pin configuration update.
Mar 3 2021, 6:35 PM
mw added a comment to D29013: mvebu_gpio: fix interrupt cause register configuration.
In D29013#650253, @mmel wrote:

I have initial part of this fixup. It should allow board to boot, at minimum. Unfortunately , the interrupt handling have still locking problem -> the solution needs change in syscon provided by simple_mfd driver -> so i need more time for this (one or two days).
But it would be nice if you can test this in your environment. It should fix hang-up issue in pcie driver.
What an ignominy...

https://github.com/strejda/freebsd/commit/b7756af37ddbb45c9c0ac421ac896c16d36b9eac

Mar 3 2021, 6:22 PM
mw added a comment to D29013: mvebu_gpio: fix interrupt cause register configuration.
In D29013#649762, @mmel wrote:

Noooo, Im stupid :( The root of the problem is trivial -> gpio_write() doesn't modify only the required bit, but the whole 32-bit register. HW init should use new gpio_modify() (implemented with SYSCON_MODIFY_4() not SYSCON_WRITE_4()). Big big sorry for troubles. I'll fix it tomorrow.

Mar 3 2021, 4:53 PM
mw committed R10:622d17da46eb: arm64: mv_ap806_gicp: Fix spi_ranges_cnt (authored by zr_semihalf.com).
arm64: mv_ap806_gicp: Fix spi_ranges_cnt
Mar 3 2021, 4:12 PM

Mar 2 2021

mw committed R10:09c3f04ff3be: iflib: add support for admin completion queues (authored by mw).
iflib: add support for admin completion queues
Mar 2 2021, 11:41 PM
mw closed D28708: iflib: add support for admin completion queues.
Mar 2 2021, 11:41 PM
mw closed D29013: mvebu_gpio: fix interrupt cause register configuration.
Mar 2 2021, 11:24 PM
mw committed R10:819760b35f31: mvebu_gpio: fix interrupt cause register configuration (authored by mw).
mvebu_gpio: fix interrupt cause register configuration
Mar 2 2021, 11:24 PM
mw requested review of D29013: mvebu_gpio: fix interrupt cause register configuration.
Mar 2 2021, 4:10 PM
mw retitled D28911: mvebu_gpio: do not force data in value invertion during attach from mvebu_gpio: Do not set input data polarity for every pin during attach. to mvebu_gpio: do not reconfigure every pin during attach.
Mar 2 2021, 4:08 PM
mw updated the diff for D28911: mvebu_gpio: do not force data in value invertion during attach.

Testing showed, more changes are needed compared to v1. Now the pin configuration can be done only on purpose (which aligns the behavior to Linux).

Mar 2 2021, 4:08 PM
mw commandeered D28911: mvebu_gpio: do not force data in value invertion during attach.
Mar 2 2021, 4:05 PM
mw added a comment to D28911: mvebu_gpio: do not force data in value invertion during attach.
In D28911#649159, @mmel wrote:

Can you please try the test again with https://cgit.FreeBSD.org/src/commit/?id=ce5a4083de2d79bc44d209c9e355a09ede47346c ? I hope that it fixed also this problem. Thanks.

Mar 2 2021, 4:04 PM

Mar 1 2021

mw added a comment to D28803: arm64: Don't rely on firmware interrupt mapping in ICU.

@mmel Thanks for the review. I'd also prefer the msi approach, in fact this is what GICP-ICU really is. I thought the the MSI code in FreeBSD is PCI-dependent, but after another look I can see it may work in our case. Let us update the code to this approach.

Mar 1 2021, 5:10 PM

Feb 25 2021

mw committed R10:19cd12a32afe: Disable PIE for MIPS BERI boot loader (authored by mw).
Disable PIE for MIPS BERI boot loader
Feb 25 2021, 5:51 AM
mw committed R10:ef567155d35f: Fix powerpc build after 6dd69f0064f1 (authored by mw).
Fix powerpc build after 6dd69f0064f1
Feb 25 2021, 1:36 AM

Feb 24 2021

mw committed R10:9a227a2fd642: Enable PIE by default on 64-bit architectures (authored by mw).
Enable PIE by default on 64-bit architectures
Feb 24 2021, 11:28 PM
mw closed D28328: Enable PIE by default on 64-bit architectures.
Feb 24 2021, 11:28 PM · PowerPC, arm64
mw closed D28893: Disable PIE for PowerPC bootloaders..
Feb 24 2021, 11:28 PM · PowerPC
mw committed R10:3aa023643e9d: Disable PIE for powerpc bootloaders. (authored by mw).
Disable PIE for powerpc bootloaders.
Feb 24 2021, 11:28 PM
mw closed D28370: Disable PIE for MIPS u-boot-loader..
Feb 24 2021, 11:27 PM · MIPS
mw committed R10:cd992885bcdf: Disable PIE for MIPS ubldr (authored by mw).
Disable PIE for MIPS ubldr
Feb 24 2021, 11:27 PM
mw closed D28706: iflib: add new field: isc_dma_width.
Feb 24 2021, 11:27 PM
mw committed R10:6dd69f0064f1: iflib: introduce isc_dma_width (authored by mw).
iflib: introduce isc_dma_width
Feb 24 2021, 11:27 PM
mw added inline comments to D28328: Enable PIE by default on 64-bit architectures.
Feb 24 2021, 6:46 PM · PowerPC, arm64
mw added a reviewer for D28911: mvebu_gpio: do not force data in value invertion during attach: manu.
Feb 24 2021, 3:33 PM

Feb 23 2021

mw updated the diff for D28328: Enable PIE by default on 64-bit architectures.

Update revision:

  • Add comment justifying disabling feature on 32-bit archs
  • Sort MACHINE_ARCH's alphabetically
Feb 23 2021, 8:51 AM · PowerPC, arm64

Feb 22 2021

mw committed R10:79474cbd9bc4: MFC 1c808fcd859f: Allocate BAR for ENA MSIx vector table (authored by mk_semihalf.com).
MFC 1c808fcd859f: Allocate BAR for ENA MSIx vector table
Feb 22 2021, 8:47 PM
mw committed R10:bc1df392499d: MFC 1c808fcd859f: Allocate BAR for ENA MSIx vector table (authored by mk_semihalf.com).
MFC 1c808fcd859f: Allocate BAR for ENA MSIx vector table
Feb 22 2021, 8:32 PM
mw committed R10:5de955fe436a: MFC 1c808fcd859f: Allocate BAR for ENA MSIx vector table (authored by mk_semihalf.com).
MFC 1c808fcd859f: Allocate BAR for ENA MSIx vector table
Feb 22 2021, 4:31 PM
mw committed R10:e540e45097e5: MFC 1c808fcd859f: Allocate BAR for ENA MSIx vector table (authored by mk_semihalf.com).
MFC 1c808fcd859f: Allocate BAR for ENA MSIx vector table
Feb 22 2021, 4:29 PM

Feb 19 2021

mw added a comment to D28793: www/mathopd: Fix build with default PIE..

@emaste Thanks for the review. Please merge, I cannot commit to ports.

Feb 19 2021, 5:32 PM

Feb 18 2021

mw committed R10:1c808fcd859f: Allocate BAR for ENA MSIx vector table (authored by mk_semihalf.com).
Allocate BAR for ENA MSIx vector table
Feb 18 2021, 12:55 PM

Feb 13 2021

mw added a comment to D28328: Enable PIE by default on 64-bit architectures.

Thanks @imp ! Regarding the logistics, 2 questions:

  • should it land after all ports exp-run failures are fixed?
  • should we consider MFC (at least to stable/13)?
Feb 13 2021, 9:27 AM · PowerPC, arm64

Feb 12 2021

mw updated the diff for D28328: Enable PIE by default on 64-bit architectures.

Update the patch by:

  • using MACHINE_ARCH only
  • inverting the if logic
Feb 12 2021, 7:07 PM · PowerPC, arm64

Feb 5 2021

mw accepted D28418: bsdinstall: add knob to set ASLR sysctls.
Feb 5 2021, 5:43 PM

Feb 3 2021

mw added a comment to D28328: Enable PIE by default on 64-bit architectures.

Do you have any feedback about this patch (and https://reviews.freebsd.org/D28370 + https://reviews.freebsd.org/D27666 as well)?

Feb 3 2021, 9:56 AM · PowerPC, arm64

Feb 2 2021

mw committed R10:cd925aaa73e1: marvell: ap806_clock: add missing frequency modes (authored by mw).
marvell: ap806_clock: add missing frequency modes
Feb 2 2021, 12:29 PM
mw committed R10:cd1393dfe718: marvell: ap806_clock: add missing frequency modes (authored by mw).
marvell: ap806_clock: add missing frequency modes
Feb 2 2021, 12:28 PM

Feb 1 2021

mw added inline comments to D28418: bsdinstall: add knob to set ASLR sysctls.
Feb 1 2021, 9:57 AM

Jan 26 2021

mw committed R10:a86b0839d7bf: marvell: ap806_clock: add missing frequency modes (authored by mw).
marvell: ap806_clock: add missing frequency modes
Jan 26 2021, 1:05 PM

Jan 25 2021

mw updated the summary of D27666: Enable ASLR by default for 64-bit executables..
Jan 25 2021, 9:54 AM · PowerPC, security, arm64
mw updated the diff for D27666: Enable ASLR by default for 64-bit executables..

Update revision after splitting PIE enablement to a separate patch (https://reviews.freebsd.org/D28328)

Jan 25 2021, 9:54 AM · PowerPC, security, arm64
mw requested review of D28328: Enable PIE by default on 64-bit architectures.
Jan 25 2021, 9:53 AM · PowerPC, arm64

Jan 15 2021

mw added a comment to D27666: Enable ASLR by default for 64-bit executables..
In D27666#629463, @mw wrote:

Thanks @emaste. Is there any part requiring additional work / contribution? If yes, please reach me out, so we can sync and help with whatever is needed.

Mainly I think we need to make a concerted effort towards identifying ports that require ELF feature tags to opt out of various features, and some common mechanism (either infrastructure or template approach) for setting those bits. I submitted PR252629

As above PR239873 reports issues with firefox and thunderbird with ASLR stack gap. I found libreoffice is incompatible with W^X and submitted PR252689 for that.

Jan 15 2021, 6:06 PM · PowerPC, security, arm64
mw added inline comments to D27666: Enable ASLR by default for 64-bit executables..
Jan 15 2021, 5:31 PM · PowerPC, security, arm64

Jan 14 2021

mw added a comment to D27666: Enable ASLR by default for 64-bit executables..
Jan 14 2021, 7:42 PM · PowerPC, security, arm64

Jan 13 2021

mw added a comment to D27666: Enable ASLR by default for 64-bit executables..

Hi! Any thoughts? If no objections, I plan to merge the patch after February 5th.

Jan 13 2021, 10:06 AM · PowerPC, security, arm64

Jan 6 2021

mw committed R10:ca71c7e3bb0a: arm64: QorIQ: gpio: return BUS_PROBE_DEFAULT (authored by mw).
arm64: QorIQ: gpio: return BUS_PROBE_DEFAULT
Jan 6 2021, 9:40 PM
mw closed D26869: arm64: QorIQ: gpio: return BUS_PROBE_DEFAULT.
Jan 6 2021, 9:39 PM
mw closed D26868: arm64: QorIQ: gpio: Cleanup qoriq_gpio_* helpers.
Jan 6 2021, 9:39 PM
mw committed R10:39c24889b022: arm64: QorIQ: gpio: Cleanup qoriq_gpio_* helpers (authored by mw).
arm64: QorIQ: gpio: Cleanup qoriq_gpio_* helpers
Jan 6 2021, 9:39 PM
mw closed D26867: arm64: QorIQ: gpio: Style cleanups..
Jan 6 2021, 9:39 PM
mw committed R10:c76c36f95c3c: arm64: QorIQ: gpio: Style cleanups (authored by mw).
arm64: QorIQ: gpio: Style cleanups
Jan 6 2021, 9:39 PM

Jan 4 2021

mw accepted D27870: mvneta: Fix 64-bit MIB reads.
Jan 4 2021, 1:19 AM

Jan 2 2021

mw requested changes to D27870: mvneta: Fix 64-bit MIB reads.
Jan 2 2021, 7:39 AM

Dec 31 2020

mw requested changes to D27870: mvneta: Fix 64-bit MIB reads.
Dec 31 2020, 11:50 PM

Dec 29 2020

mw added a comment to D27666: Enable ASLR by default for 64-bit executables..

Hi! Any thoughts about the patch? Do you have objections to get it merged?

Dec 29 2020, 1:17 PM · PowerPC, security, arm64

Dec 24 2020

mw added inline comments to D27666: Enable ASLR by default for 64-bit executables..
Dec 24 2020, 7:32 AM · PowerPC, security, arm64
mw closed D25373: Fix AccessWidth and BitWidth parsing in SPCR table.
Dec 24 2020, 7:27 AM · x86, arm64

Dec 18 2020

mw closed D27025: [RFC] Fix abort in malloc extent coalescing..
Dec 18 2020, 10:09 AM
mw committed rS368756: Fix abort in jemalloc extent coalescing..
Fix abort in jemalloc extent coalescing.
Dec 18 2020, 10:09 AM
mw requested review of D27666: Enable ASLR by default for 64-bit executables..
Dec 18 2020, 4:51 AM · PowerPC, security, arm64
mw added a comment to D27025: [RFC] Fix abort in malloc extent coalescing..

In jemalloc upstream repo based on this patch another PR was merged, that applies on top of tree (https://github.com/jemalloc/jemalloc/pull/2003).

Dec 18 2020, 4:31 AM

Nov 26 2020

mw accepted D27306: Detect ACPI early by FADT, not SPCR.
Nov 26 2020, 3:02 PM

Nov 25 2020

mw committed rS368013: MFC: Merge ENA v2.3.0 driver.
MFC: Merge ENA v2.3.0 driver
Nov 25 2020, 9:37 AM
mw committed rS368012: MFC: Merge ENA v2.3.0 driver.
MFC: Merge ENA v2.3.0 driver
Nov 25 2020, 3:24 AM

Nov 18 2020

mw closed D27120: Update ENA driver version to v2.3.0.
Nov 18 2020, 3:25 PM · network
mw committed rS367805: Update ENA driver version to v2.3.0.
Update ENA driver version to v2.3.0
Nov 18 2020, 3:25 PM
mw closed D27119: Rename descriptions of the supported ENA devices.
Nov 18 2020, 3:20 PM · network
mw committed rS367803: Rename descriptions of the supported ENA devices.
Rename descriptions of the supported ENA devices
Nov 18 2020, 3:20 PM
mw closed D27118: Add ENI metrics for the ENA driver.
Nov 18 2020, 3:18 PM · network
mw committed rS367802: Add ENI metrics for the ENA driver.
Add ENI metrics for the ENA driver
Nov 18 2020, 3:18 PM
mw closed D27117: Add SPDX license tag to the ENA driver files.
Nov 18 2020, 3:08 PM · network
mw committed rS367801: Add SPDX license tag to the ENA driver files.
Add SPDX license tag to the ENA driver files
Nov 18 2020, 3:08 PM
mw closed D27116: Add Rx offsets support for the ENA driver.
Nov 18 2020, 3:02 PM · network
mw committed rS367800: Add Rx offsets support for the ENA driver.
Add Rx offsets support for the ENA driver
Nov 18 2020, 3:02 PM
mw closed D27115: Upgrade ENA HAL and driver accordingly.
Nov 18 2020, 2:59 PM · network
mw committed rS367799: Adjust ENA driver files to latest ena-com changes.
Adjust ENA driver files to latest ena-com changes
Nov 18 2020, 2:59 PM