Page MenuHomeFreeBSD

mw (Marcin Wojtas)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 21 2017, 11:02 PM (357 w, 2 d)

Recent Activity

Dec 18 2023

mw accepted D42662: ena: Update driver version to v2.7.0.
Dec 18 2023, 12:16 PM
mw accepted D42661: ena: Update the license dating to 2023.
Dec 18 2023, 12:16 PM
mw accepted D42660: ena: Support srd metrics with sysctl.
Dec 18 2023, 12:16 PM
mw accepted D42659: ena: Support customer metric with sysctl.
Dec 18 2023, 12:15 PM
mw accepted D42658: ena: Introduce shared sample interval for all stats.
Dec 18 2023, 12:11 PM
mw accepted D42657: ena: Remove CQ tail pointer update API.
Dec 18 2023, 12:10 PM
mw accepted D42656: ena: Update ena_com_update_intr_reg API usage.
Dec 18 2023, 12:09 PM
mw accepted D42655: ena: Change measurement unit of time since last tx cleanup to ms.
Dec 18 2023, 12:09 PM
mw accepted D42654: ena: Upgrade ena-com to freebsd v2.7.0.

LGTM, this patch should go through the vendor branch first.

Dec 18 2023, 12:00 PM
mw accepted D42653: ena: Add sysctl support for spreading IRQs.
Dec 18 2023, 12:00 PM

Jul 31 2023

mw committed rGa3927f6e3aba: ena: Update driver version to v2.6.3 (authored by akiyano_amazon.com).
ena: Update driver version to v2.6.3
Jul 31 2023, 12:57 PM
mw committed rG383cf7052a29: ena: Initialize statistics before the interface is available (authored by osamaabb_amazon.com).
ena: Initialize statistics before the interface is available
Jul 31 2023, 12:57 PM
mw committed rGb390fe1d806a: ena: Fix driver unload crash (authored by akiyano_amazon.com).
ena: Fix driver unload crash
Jul 31 2023, 12:57 PM
mw committed rGe99baa40d8cf: ena: Update driver version to v2.6.3 (authored by akiyano_amazon.com).
ena: Update driver version to v2.6.3
Jul 31 2023, 12:27 PM
mw committed rGeff0170df142: ena: Fix driver unload crash (authored by akiyano_amazon.com).
ena: Fix driver unload crash
Jul 31 2023, 12:27 PM
mw committed rG8a6ba4eefb66: ena: Initialize statistics before the interface is available (authored by osamaabb_amazon.com).
ena: Initialize statistics before the interface is available
Jul 31 2023, 12:27 PM

Jul 4 2023

mw committed rGac40021c935d: ena: Update driver version to v2.6.3 (authored by akiyano_amazon.com).
ena: Update driver version to v2.6.3
Jul 4 2023, 2:01 PM
mw committed rGc59a5fbd8a2e: ena: Fix driver unload crash (authored by akiyano_amazon.com).
ena: Fix driver unload crash
Jul 4 2023, 2:01 PM
mw committed rGb9e80b5280b7: ena: Initialize statistics before the interface is available (authored by osamaabb_amazon.com).
ena: Initialize statistics before the interface is available
Jul 4 2023, 2:01 PM

Jan 31 2023

mw committed rG00a6bb16fb6c: ena: Update driver version to v2.6.2 (authored by akiyano_amazon.com).
ena: Update driver version to v2.6.2
Jan 31 2023, 1:20 PM
mw committed rG235f2ddf9dff: ena: Switch driver owners from semihalf to amazon in man file (authored by akiyano_amazon.com).
ena: Switch driver owners from semihalf to amazon in man file
Jan 31 2023, 1:20 PM
mw committed rGb1f4275bfe86: ena: Remove timer service re-arm on ena_restore_device failure (authored by darinzon_amazon.com).
ena: Remove timer service re-arm on ena_restore_device failure
Jan 31 2023, 1:20 PM
mw committed rG113c730edcca: ena: Re-Enable per-packet missing tx completion print (authored by akiyano_amazon.com).
ena: Re-Enable per-packet missing tx completion print
Jan 31 2023, 1:20 PM
mw committed rGffcc58a767bd: ena: Remove write only variables (authored by imp).
ena: Remove write only variables
Jan 31 2023, 1:19 PM
mw committed rG98091db83d98: ena: Remove unused variable. (authored by jhb).
ena: Remove unused variable.
Jan 31 2023, 1:19 PM

Jan 27 2023

mw committed rGa33b0a2ab29e: ena: Update driver version to v2.6.2 (authored by akiyano_amazon.com).
ena: Update driver version to v2.6.2
Jan 27 2023, 2:00 PM
mw committed rGff1a2fe6da0e: ena: Switch driver owners from semihalf to amazon in man file (authored by akiyano_amazon.com).
ena: Switch driver owners from semihalf to amazon in man file
Jan 27 2023, 2:00 PM
mw committed rG92761fcc3b40: ena: Remove timer service re-arm on ena_restore_device failure (authored by darinzon_amazon.com).
ena: Remove timer service re-arm on ena_restore_device failure
Jan 27 2023, 2:00 PM
mw committed rG35797fe2aeb6: ena: Re-Enable per-packet missing tx completion print (authored by akiyano_amazon.com).
ena: Re-Enable per-packet missing tx completion print
Jan 27 2023, 2:00 PM
mw committed rG761d30c8d07e: ena: Remove write only variables (authored by imp).
ena: Remove write only variables
Jan 27 2023, 2:00 PM
mw committed rG201f6507c0f5: ena: Remove unused variable. (authored by jhb).
ena: Remove unused variable.
Jan 27 2023, 2:00 PM
mw committed rG44180bc8e6be: ena: Remove unused devclass argument to DRIVER_MODULE. (authored by jhb).
ena: Remove unused devclass argument to DRIVER_MODULE.
Jan 27 2023, 2:00 PM

Jan 13 2023

mw committed rG7583c633e0aa: Mechanically convert ena(4) to DrvAPI (authored by jhibbits).
Mechanically convert ena(4) to DrvAPI
Jan 13 2023, 4:11 PM
mw closed D37837: Mechanically convert ena(4) to DrvAPI.
Jan 13 2023, 4:11 PM
mw committed rGe5de1d8dad25: ena: Update driver version to v2.6.2 (authored by Arthur Kiyanovski <akiyano@amazon.com>).
ena: Update driver version to v2.6.2
Jan 13 2023, 4:09 PM
mw committed rGfb47286c38a5: ena: Switch driver owners from semihalf to amazon in man file (authored by Arthur Kiyanovski <akiyano@amazon.com>).
ena: Switch driver owners from semihalf to amazon in man file
Jan 13 2023, 4:09 PM
mw committed rGc4a85b8d684d: ena: Remove timer service re-arm on ena_restore_device failure (authored by David Arinzon <darinzon@amazon.com>).
ena: Remove timer service re-arm on ena_restore_device failure
Jan 13 2023, 4:09 PM
mw committed rGf01b2cd98e93: ena: Re-Enable per-packet missing tx completion print (authored by Arthur Kiyanovski <akiyano@amazon.com>).
ena: Re-Enable per-packet missing tx completion print
Jan 13 2023, 4:09 PM
mw accepted D37837: Mechanically convert ena(4) to DrvAPI.
Jan 13 2023, 4:04 PM

Jan 10 2023

mw added a comment to D37837: Mechanically convert ena(4) to DrvAPI.

Thank you for the patch. Overall - LGTM, however I got a request from Amazon, to wait with landing after their release 2.6.2 patches (a matter of day or two).
If you wish, I can take care of their patches and this one - is that ok for you?

Jan 10 2023, 2:28 PM
mw accepted D37825: Mechanically convert neta(4) to DrvAPI.

LGTM, thanks!

Jan 10 2023, 9:25 AM

Jan 9 2023

mw added inline comments to D37825: Mechanically convert neta(4) to DrvAPI.
Jan 9 2023, 5:58 PM
mw requested changes to D37825: Mechanically convert neta(4) to DrvAPI.
Jan 9 2023, 3:04 PM

Nov 23 2022

mw added a reviewer for D37421: ossl: Add AES-GCM implementation for ARMv7 NEON: jhb.
Nov 23 2022, 8:58 AM

Nov 18 2022

mw requested changes to D37441: param: increase KSTACK for hash context.
Nov 18 2022, 7:16 PM
mw added a comment to D37441: param: increase KSTACK for hash context.

The default config Armada 38x should run with is sys/arm/conf/GENERIC. Can you please add a commit with that?

Nov 18 2022, 7:15 PM
mw requested changes to D37419: arm: Add support for using VFP in kernel.
Nov 18 2022, 6:07 PM

Oct 5 2022

mw accepted D36880: uart_dev_snps: Fix device probing.
Oct 5 2022, 12:26 PM
mw added a comment to D36793: device_get_property: add a HANDLE case.
In D36793#837252, @bz wrote:
In D36793#837249, @mw wrote:

That looks really good, thanks a lot!

One idea:
OF_device_from_xref(OF_xref_from_node(sc->sfp))
I think it would be useful to have a wrapper: OF_device_from_node

I was thinking long about that and I had actually done an OF_dev_from_xref_node() to not lose the xref but I decided it's a few one-time calls ... If we do that we should do it seperately and fix the entire tree (as this is a more-than-once pattern).

Oct 5 2022, 7:05 AM

Oct 4 2022

mw accepted D36793: device_get_property: add a HANDLE case.

That looks really good, thanks a lot!

Oct 4 2022, 10:03 PM
mw added a comment to D36793: device_get_property: add a HANDLE case.
In D36793#837060, @dsl wrote:

@mw, this diff is supposed to substitute some pieces from sys/dev/dpaa2/dpaa2_mc_fdt.c and sys/dev/dpaa2/dpaa2_mc_acpi.c (https://reviews.freebsd.org/D36638):

static int
dpaa2_mac_dev_attach(device_t dev)
{
...
hobj = NULL;
	s = device_get_property(dev, "phy-handle", &hobj, sizeof(hobj),
	    DEVICE_PROP_ANY);
	if (s > 0) {
		if (hobj->Type != ACPI_TYPE_PACKAGE) {
			device_printf(dev, "Cannot get 'phy-handle' "
			    "package obj, not ACPI_TYPE_PACKAGE\n");
			goto out;
		}
		if (hobj->Package.Count != 1) {
			device_printf(dev, "Cannot get 'phy-handle' "
			    "package obj, count %d\n", hobj->Package.Count);
			goto out;
		}
		pobj = &hobj->Package.Elements[0];
		if (pobj == NULL) {
			device_printf(dev, "Cannot get 'phy-handle' "
			    "package pobj is NULL\n");
			goto out;
		}
		if (pobj->Type != ACPI_TYPE_LOCAL_REFERENCE) {
			device_printf(dev, "Cannot get 'phy-handle' package "
			    "pobj, no ACPI_TYPE_LOCAL_REFERENCE\n");
			goto out;
		}
		sc->phy_channel = acpi_GetReference(NULL, pobj);
		if (sc->phy_channel == NULL) {
			device_printf(dev, "Cannot get 'phy-handle' reference "
			    "handle ph is NULL\n");
			goto out;
		}
	}
...
}

You've requested such change in https://reviews.freebsd.org/D36677#833135, haven't you?

Oct 4 2022, 8:47 AM

Sep 29 2022

mw requested changes to D36793: device_get_property: add a HANDLE case.

Overall, LGTM - thank you for this patch! One nit/suggestion inline. Do you have an example code locally that shows real-life usage - I would like to see a code snippet/diff.

Sep 29 2022, 3:14 PM

Sep 25 2022

mw added a comment to D36677: Add an ability to read PACKAGE and LOCAL_REFERENCE properties.

On the occasion, it would be great to extend device_get_property or add a new routine (e.g. device_get_reference) for obtaining phandles in a unified way. That would allow minimizing the code related to HW description in https://reviews.freebsd.org/D36638 (and some future code I'm working on :) ).

Sep 25 2022, 7:37 AM

Sep 6 2022

mw accepted D36326: uart: Read clock frequency from bus.
Sep 6 2022, 11:40 AM

Sep 5 2022

mw requested changes to D36326: uart: Read clock frequency from bus.
Sep 5 2022, 11:07 PM

Sep 2 2022

mw accepted D36412: tpm: Fix entropy harvesting logic.
Sep 2 2022, 3:40 AM

Sep 1 2022

mw accepted D36413: stand: Parse BIOS revision from SMBIOS.
Sep 1 2022, 11:23 PM

Aug 19 2022

mw accepted D36260: Add ACPI entry for LS1046A UART.
Aug 19 2022, 10:17 AM

Jul 30 2022

mw accepted D35998: TPM: do not set device description if probe fails.
Jul 30 2022, 8:59 AM
mw added a reviewer for D35998: TPM: do not set device description if probe fails: kd.
Jul 30 2022, 8:59 AM

Jul 27 2022

mw accepted D35872: ipsec: Improve validation of PMTU.
Jul 27 2022, 12:11 PM
mw accepted D35871: icmp6: Improve validation of PMTU.
Jul 27 2022, 11:53 AM

Jul 26 2022

mw committed rGaabc314c3fff: ena: Remove write-only datapath variable (authored by mk_semihalf.com).
ena: Remove write-only datapath variable
Jul 26 2022, 7:39 PM
mw committed rG0ed37def561f: ena: Align req_id and qid print order (authored by mk_semihalf.com).
ena: Align req_id and qid print order
Jul 26 2022, 7:38 PM
mw committed rG96c5c2901c51: ena: Align names of constants (authored by dgr_semihalf.com).
ena: Align names of constants
Jul 26 2022, 7:38 PM
mw committed rG1a97579ae67a: ena: Update driver version to v2.6.1 (authored by mk_semihalf.com).
ena: Update driver version to v2.6.1
Jul 26 2022, 7:34 PM
mw committed rG417cd20ee3c4: ena: Fix LLQ descriptor reconfiguration (authored by mk_semihalf.com).
ena: Fix LLQ descriptor reconfiguration
Jul 26 2022, 7:34 PM
mw committed rG5393b9247fb0: ena: Make first_interrupt a uint8_t (authored by markj).
ena: Make first_interrupt a uint8_t
Jul 26 2022, 7:34 PM
mw committed rGe6e5305132d3: ena: Align req_id and qid print order (authored by mk_semihalf.com).
ena: Align req_id and qid print order
Jul 26 2022, 7:34 PM
mw committed rG7f12992281c7: ena: Update driver version to v2.6.0 (authored by mk_semihalf.com).
ena: Update driver version to v2.6.0
Jul 26 2022, 7:34 PM
mw committed rG4568630d8905: ena: Align names of constants (authored by dgr_semihalf.com).
ena: Align names of constants
Jul 26 2022, 7:34 PM
mw committed rG26d0d8bd1b3e: ena: Fix styling issues (authored by dgr_semihalf.com).
ena: Fix styling issues
Jul 26 2022, 7:34 PM
mw committed rGb672b9ef77d7: ena: Fix invalid KASSERT test in netmap code (authored by mk_semihalf.com).
ena: Fix invalid KASSERT test in netmap code
Jul 26 2022, 7:34 PM
mw committed rG0ee8440d1334: ena: Move reset completion logging to the reset function (authored by dgr_semihalf.com).
ena: Move reset completion logging to the reset function
Jul 26 2022, 7:34 PM
mw committed rGc093a162a2ac: ena: Use device_set_desc in probe (authored by dgr_semihalf.com).
ena: Use device_set_desc in probe
Jul 26 2022, 7:34 PM
mw committed rGfdeb262d1861: ena: Store ticks of last Tx cleanup (authored by dgr_semihalf.com).
ena: Store ticks of last Tx cleanup
Jul 26 2022, 7:34 PM
mw committed rGed037ffb2c05: ena: Move ena_copy_eni_metrics into separate task (authored by dgr_semihalf.com).
ena: Move ena_copy_eni_metrics into separate task
Jul 26 2022, 7:34 PM
mw committed rGb53231f40cc5: ena: Add ena_ring_tx_doorbell() function (authored by dgr_semihalf.com).
ena: Add ena_ring_tx_doorbell() function
Jul 26 2022, 7:34 PM
mw committed rGa244d6ec4ea8: ena: Extend debug prints for invalid req_id resets (authored by dgr_semihalf.com).
ena: Extend debug prints for invalid req_id resets
Jul 26 2022, 7:34 PM
mw committed rGbb98012e39ac: ena: Prevent LLQ initialization when membar isn't exposed (authored by dgr_semihalf.com).
ena: Prevent LLQ initialization when membar isn't exposed
Jul 26 2022, 7:34 PM
mw committed rGa72bdc8b3776: ena: Update driver version to v2.6.1 (authored by mk_semihalf.com).
ena: Update driver version to v2.6.1
Jul 26 2022, 7:34 PM
mw committed rGe8253e47e1dc: ena: Fix LLQ descriptor reconfiguration (authored by mk_semihalf.com).
ena: Fix LLQ descriptor reconfiguration
Jul 26 2022, 7:34 PM
mw committed rG3d5fed51ed46: ena: Fix invalid KASSERT test in netmap code (authored by mk_semihalf.com).
ena: Fix invalid KASSERT test in netmap code
Jul 26 2022, 7:33 PM
mw committed rGd91776d81bb2: ena: Make first_interrupt a uint8_t (authored by markj).
ena: Make first_interrupt a uint8_t
Jul 26 2022, 7:33 PM
mw committed rG43e446ede277: ena: Update driver version to v2.6.0 (authored by mk_semihalf.com).
ena: Update driver version to v2.6.0
Jul 26 2022, 7:33 PM
mw committed rGaf445a63a3d8: ena: Remove write-only datapath variable (authored by mk_semihalf.com).
ena: Remove write-only datapath variable
Jul 26 2022, 7:33 PM
mw committed rGcbbecd257ed6: ena: Fix styling issues (authored by dgr_semihalf.com).
ena: Fix styling issues
Jul 26 2022, 7:33 PM
mw committed rGaea2edcc00a1: ena: Move ena_copy_eni_metrics into separate task (authored by dgr_semihalf.com).
ena: Move ena_copy_eni_metrics into separate task
Jul 26 2022, 7:33 PM
mw committed rG5d747111151d: ena: Use device_set_desc in probe (authored by dgr_semihalf.com).
ena: Use device_set_desc in probe
Jul 26 2022, 7:33 PM
mw committed rGc5da1ee63d03: ena: Use atomic_load/store functions for first_interrupt variable (authored by dgr_semihalf.com).
ena: Use atomic_load/store functions for first_interrupt variable
Jul 26 2022, 7:33 PM
mw committed rGc41b1259ceb1: ena: Store ticks of last Tx cleanup (authored by dgr_semihalf.com).
ena: Store ticks of last Tx cleanup
Jul 26 2022, 7:33 PM
mw committed rG609b1df672c2: ena: Prevent LLQ initialization when membar isn't exposed (authored by dgr_semihalf.com).
ena: Prevent LLQ initialization when membar isn't exposed
Jul 26 2022, 7:33 PM
mw committed rG274af2948a31: ena: Extend debug prints for invalid req_id resets (authored by dgr_semihalf.com).
ena: Extend debug prints for invalid req_id resets
Jul 26 2022, 7:33 PM
mw committed rG963a1b06d9b7: ena: Move reset completion logging to the reset function (authored by dgr_semihalf.com).
ena: Move reset completion logging to the reset function
Jul 26 2022, 7:32 PM
mw committed rGafc13757eaa9: ena: Add ena_ring_tx_doorbell() function (authored by dgr_semihalf.com).
ena: Add ena_ring_tx_doorbell() function
Jul 26 2022, 7:31 PM

Jul 18 2022

mw accepted D35393: Rework how shared page related data is stored.
Jul 18 2022, 11:14 AM
mw accepted D35392: Introduce the PROC_SIGCODE() macro.
Jul 18 2022, 10:57 AM
mw accepted D35349: [RFC] Shared page address randomization.
Jul 18 2022, 8:12 AM

Jul 7 2022

mw committed rG469290648005: e6000sw: add readphy and writephy wrappers (authored by aja_semihalf.com).
e6000sw: add readphy and writephy wrappers
Jul 7 2022, 4:45 PM
mw closed D35656: e6000sw: Add readphy and writephy wrappers.
Jul 7 2022, 4:45 PM