Page MenuHomeFreeBSD

mw (Marcin Wojtas)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 21 2017, 11:02 PM (252 w, 1 d)

Recent Activity

Mar 29 2022

mw committed R10:992e326cd8cc: neta: split fixed and in-band link status configuration (authored by sebastien.bini_stormshield.eu).
neta: split fixed and in-band link status configuration
Mar 29 2022, 11:03 PM
mw committed R10:817556add336: Extend device_get_property API (authored by mindal_semihalf.com).
Extend device_get_property API
Mar 29 2022, 11:03 PM
mw committed R10:a2bd4cd7863c: bus_if: Add a default implementation of get_property (authored by mindal_semihalf.com).
bus_if: Add a default implementation of get_property
Mar 29 2022, 11:03 PM
mw committed R10:f0a6f99b2a3a: miibus: Add support for mapping OFW nodes to PHY devices (authored by mindal_semihalf.com).
miibus: Add support for mapping OFW nodes to PHY devices
Mar 29 2022, 11:03 PM
mw committed R10:993cd606c238: sdhci_xenon: add ACPI support (authored by bag_semihalf.com).
sdhci_xenon: add ACPI support
Mar 29 2022, 11:02 PM
mw committed R10:b329bb8fd7b6: mii_fdt: Add support for switch PHY node lookup (authored by mindal_semihalf.com).
mii_fdt: Add support for switch PHY node lookup
Mar 29 2022, 11:02 PM
mw committed R10:693af80b7435: sdhci_xenon: split driver file into generic file and fdt parts (authored by bag_semihalf.com).
sdhci_xenon: split driver file into generic file and fdt parts
Mar 29 2022, 11:01 PM
mw committed R10:2f9a9149e526: mmc: switch mmc_helper to device_ api (authored by bag_semihalf.com).
mmc: switch mmc_helper to device_ api
Mar 29 2022, 11:01 PM
mw committed R10:45b49a0f96e0: device: add device_get_property and device_has_property (authored by bag_semihalf.com).
device: add device_get_property and device_has_property
Mar 29 2022, 11:00 PM
mw committed R10:fd08253cdcec: acpica: add ACPI_GET_PROPERTY to access Device Specific Data (DSD) (authored by bag_semihalf.com).
acpica: add ACPI_GET_PROPERTY to access Device Specific Data (DSD)
Mar 29 2022, 11:00 PM

Mar 22 2022

mw closed D34394: Fix mvneta driver that doesn't handle fixed link properly.
Mar 22 2022, 4:08 PM
mw committed R10:231237bbb0e8: neta: split fixed and in-band link status configuration (authored by sebastien.bini_stormshield.eu).
neta: split fixed and in-band link status configuration
Mar 22 2022, 4:08 PM
mw accepted D34394: Fix mvneta driver that doesn't handle fixed link properly.
Mar 22 2022, 3:53 PM

Mar 10 2022

mw committed R10:b344de4d0d16: Extend device_get_property API (authored by mindal_semihalf.com).
Extend device_get_property API
Mar 10 2022, 11:31 AM
mw closed D33457: Expand device_get_property API.
Mar 10 2022, 11:30 AM
mw committed R10:206dc82bc3fc: bus_if: Add a default implementation of get_property (authored by mindal_semihalf.com).
bus_if: Add a default implementation of get_property
Mar 10 2022, 11:30 AM
mw closed D34031: bus_if: Add a default implementation of get_property.
Mar 10 2022, 11:30 AM
mw accepted D33457: Expand device_get_property API.

There are minor style issues (they will be fixed when commiting), but otherwise LGTM.

Mar 10 2022, 11:28 AM

Mar 7 2022

mw added a reverting change for R10:7d8700bc291b: sdhci: extend bus_dma_tag boundary to 64-bit space: R10:016f965722c6: Revert "sdhci: extend bus_dma_tag boundary to 64-bit space".
Mar 7 2022, 4:46 PM
mw committed R10:016f965722c6: Revert "sdhci: extend bus_dma_tag boundary to 64-bit space" (authored by mw).
Revert "sdhci: extend bus_dma_tag boundary to 64-bit space"
Mar 7 2022, 4:46 PM
mw added a reverting change for D30560: sdhci: extend bus_dma_tag boundary to 64-bit space: R10:016f965722c6: Revert "sdhci: extend bus_dma_tag boundary to 64-bit space".
Mar 7 2022, 4:46 PM
mw committed R10:1b19617e9662: sdhci_xenon: remove redundant code in property parsing (authored by bag_semihalf.com).
sdhci_xenon: remove redundant code in property parsing
Mar 7 2022, 4:01 PM
mw committed R10:a2f06581802b: sdhci_xenon: add AP807 compatible string (authored by bag_semihalf.com).
sdhci_xenon: add AP807 compatible string
Mar 7 2022, 4:01 PM
mw committed R10:8bb448b66e9d: sdhci_xenon: add UHS support (authored by mw).
sdhci_xenon: add UHS support
Mar 7 2022, 4:01 PM
mw committed R10:7518736826a2: sdhci_xenon: improve the VCCQ voltage switch sequence (authored by mw).
sdhci_xenon: improve the VCCQ voltage switch sequence
Mar 7 2022, 4:01 PM
mw committed R10:68be9ab5bd53: sdhci_xenon: allow to properly disable the UHS signaling (authored by mw).
sdhci_xenon: allow to properly disable the UHS signaling
Mar 7 2022, 4:00 PM
mw committed R10:707ab1f0643a: sdhci_xenon: enable MMC FDT parsing (authored by mw).
sdhci_xenon: enable MMC FDT parsing
Mar 7 2022, 4:00 PM
mw committed R10:55e7f40ce3a5: sdhci: allow setting MMC capabilities before sdhci_init_slot (authored by mw).
sdhci: allow setting MMC capabilities before sdhci_init_slot
Mar 7 2022, 4:00 PM
mw committed R10:393538e35d26: pci_host_generic: Add Synopsys Designware PCIe controller quirk (authored by pan_semihalf.com).
pci_host_generic: Add Synopsys Designware PCIe controller quirk
Mar 7 2022, 11:21 AM
mw committed R10:7aa6014fb16f: mmc: Fix HS200/HS400 capability check (authored by mindal_semihalf.com).
mmc: Fix HS200/HS400 capability check
Mar 7 2022, 11:20 AM
mw committed R10:63f3afe497ff: uart_dev_ns8250: Switch ACPI UART subtype for Marvell SoCs (authored by mw).
uart_dev_ns8250: Switch ACPI UART subtype for Marvell SoCs
Mar 7 2022, 11:20 AM
mw committed R10:6f37cb64f3c7: pci_host_generic: update Synopsys device description for ACPI (authored by mw).
pci_host_generic: update Synopsys device description for ACPI
Mar 7 2022, 11:20 AM

Feb 25 2022

mw added a comment to D30560: sdhci: extend bus_dma_tag boundary to 64-bit space.

@mmel Hi. I rechecked and you are right. Additional handling should be done in generic code. FYI, the SoC that needed the change had no < 4G physical address space at all, however it adds the upper 32-bit on HW level. Since current patch is incomplete, I'll revert for now.

Feb 25 2022, 10:35 AM

Feb 24 2022

mw committed R10:09f78eb9e68f: ena: update ENA version to v2.5.0 (authored by mk_semihalf.com).
ena: update ENA version to v2.5.0
Feb 24 2022, 1:06 PM
mw committed R10:5a0f4eba2adb: ena: fix man page typos and update contact section (authored by mk_semihalf.com).
ena: fix man page typos and update contact section
Feb 24 2022, 1:06 PM
mw committed R10:e0edb7f3aad5: ena: do not call reset if device is unresponsive (authored by dgr_semihalf.com).
ena: do not call reset if device is unresponsive
Feb 24 2022, 1:06 PM
mw committed R10:ddee5284d692: ena: start timer service on attach (authored by dgr_semihalf.com).
ena: start timer service on attach
Feb 24 2022, 1:05 PM
mw committed R10:ecafc181ed0a: ena: rework tx req_id validation logic (authored by ar_semihalf.com).
ena: rework tx req_id validation logic
Feb 24 2022, 1:05 PM
mw committed R10:126a30da9cff: ena: properly handle IPv6 L4 checksum offload (authored by dgr_semihalf.com).
ena: properly handle IPv6 L4 checksum offload
Feb 24 2022, 1:05 PM
mw committed R10:c749d614b8e4: ena: merge ena-com v2.5.0 upgrade (authored by mw).
ena: merge ena-com v2.5.0 upgrade
Feb 24 2022, 1:04 PM
mw committed R10:c27f502ed8ef: ena: update ENA version to v2.5.0 (authored by mk_semihalf.com).
ena: update ENA version to v2.5.0
Feb 24 2022, 12:57 PM
mw committed R10:b94392fc6d91: ena: fix man page typos and update contact section (authored by mk_semihalf.com).
ena: fix man page typos and update contact section
Feb 24 2022, 12:57 PM
mw committed R10:ed4368c216c6: ena: start timer service on attach (authored by dgr_semihalf.com).
ena: start timer service on attach
Feb 24 2022, 12:57 PM
mw committed R10:8875a5872c1a: ena: do not call reset if device is unresponsive (authored by dgr_semihalf.com).
ena: do not call reset if device is unresponsive
Feb 24 2022, 12:56 PM
mw committed R10:eff45c1e6627: ena: properly handle IPv6 L4 checksum offload (authored by dgr_semihalf.com).
ena: properly handle IPv6 L4 checksum offload
Feb 24 2022, 12:56 PM
mw committed R10:dbc92a6d9d2b: ena: rework tx req_id validation logic (authored by ar_semihalf.com).
ena: rework tx req_id validation logic
Feb 24 2022, 12:56 PM
mw committed R10:5922f5218fcf: ena: merge ena-com v2.5.0 upgrade (authored by mw).
ena: merge ena-com v2.5.0 upgrade
Feb 24 2022, 12:56 PM

Jan 23 2022

mw committed R10:8a5b4859c7fc: ena: update ENA version to v2.5.0 (authored by mk_semihalf.com).
ena: update ENA version to v2.5.0
Jan 23 2022, 7:51 PM
mw committed R10:d10ec3ad7739: ena: do not call reset if device is unresponsive (authored by dgr_semihalf.com).
ena: do not call reset if device is unresponsive
Jan 23 2022, 7:51 PM
mw committed R10:95161adfcb92: ena: fix man page typos and update contact section (authored by mk_semihalf.com).
ena: fix man page typos and update contact section
Jan 23 2022, 7:51 PM
mw committed R10:78554d0c707c: ena: start timer service on attach (authored by dgr_semihalf.com).
ena: start timer service on attach
Jan 23 2022, 7:51 PM
mw committed R10:b168d0c850f3: ena: rework tx req_id validation logic (authored by ar_semihalf.com).
ena: rework tx req_id validation logic
Jan 23 2022, 7:51 PM
mw committed R10:2bbef9d95dc1: ena: properly handle IPv6 L4 checksum offload (authored by dgr_semihalf.com).
ena: properly handle IPv6 L4 checksum offload
Jan 23 2022, 7:51 PM
mw committed R10:eb4c4f4a2e18: ena: merge ena-com v2.5.0 upgrade (authored by mw).
ena: merge ena-com v2.5.0 upgrade
Jan 23 2022, 7:51 PM
mw committed R10:7ff278267bce: Regenerate src.conf(5) after PIE default change (authored by kevans).
Regenerate src.conf(5) after PIE default change
Jan 23 2022, 10:29 AM
mw committed R10:f50c1c5b7c1f: Add UPDATING entry for PIE default (authored by emaste).
Add UPDATING entry for PIE default
Jan 23 2022, 10:28 AM
mw committed R10:396e9f259d96: Enable PIE by default on 64-bit architectures (authored by mw).
Enable PIE by default on 64-bit architectures
Jan 23 2022, 10:28 AM
mw committed R10:408c698b133f: t_setrlimit: Adjust resource limit to 20M (authored by dgr_semihalf.com).
t_setrlimit: Adjust resource limit to 20M
Jan 23 2022, 10:27 AM
Herald added a reviewer for D28893: Disable PIE for PowerPC bootloaders.: manu.
Jan 23 2022, 10:27 AM · PowerPC
mw committed R10:5b042fcbdff8: Disable PIE for powerpc bootloaders. (authored by mw).
Disable PIE for powerpc bootloaders.
Jan 23 2022, 10:26 AM
Herald added a reviewer for D28370: Disable PIE for MIPS u-boot-loader.: manu.
Jan 23 2022, 10:26 AM · MIPS
mw committed R10:afd4a4940790: Disable PIE for MIPS ubldr (authored by mw).
Disable PIE for MIPS ubldr
Jan 23 2022, 10:26 AM
mw committed R10:f79791ab6049: Disable PIE for MIPS BERI boot loader (authored by mw).
Disable PIE for MIPS BERI boot loader
Jan 23 2022, 10:26 AM

Jan 21 2022

mw committed R10:2530eb1fa01b: ena-com: add NUMA allocations macros (authored by ar_semihalf.com).
ena-com: add NUMA allocations macros
Jan 21 2022, 7:46 PM
mw committed R10:41160c140e31: ena-com: remove CSUM_OFFLOAD from the plat file (authored by mk_semihalf.com).
ena-com: remove CSUM_OFFLOAD from the plat file
Jan 21 2022, 7:46 PM
mw committed R10:32e1beb19c7e: ena-com: remove redundant declaration of ena_log_level. (authored by jhb).
ena-com: remove redundant declaration of ena_log_level.
Jan 21 2022, 7:46 PM

Jan 10 2022

mw accepted D33719: armv6/legacy: optimize cpy_getcount performance.
Jan 10 2022, 12:11 PM

Jan 5 2022

mw requested changes to D33457: Expand device_get_property API.
Jan 5 2022, 3:17 PM
mw abandoned D32833: bsdinstall: adjust ASLR knob to new defaults.

Change no longer relevant after removing the knob in https://cgit.freebsd.org/src/commit/?id=bf410c6eda515364db5f6ed74b765efdec0595ae

Jan 5 2022, 1:03 AM

Dec 30 2021

mw committed R10:d8247df24c1d: libthr: Use kern.stacktop for thread stack calculation. (authored by dgr_semihalf.com).
libthr: Use kern.stacktop for thread stack calculation.
Dec 30 2021, 3:38 PM
mw committed R10:532d925b6f02: kern_exec: Add kern.stacktop sysctl. (authored by dgr_semihalf.com).
kern_exec: Add kern.stacktop sysctl.
Dec 30 2021, 3:38 PM
mw committed R10:16a900ae0242: setrlimit: Take stack gap into account. (authored by dgr_semihalf.com).
setrlimit: Take stack gap into account.
Dec 30 2021, 3:37 PM

Dec 23 2021

mw added inline comments to D33457: Expand device_get_property API.
Dec 23 2021, 4:34 PM

Dec 20 2021

mw added a reverting change for R10:4f741801d860: t_setrlimit: Adjust resource limit to 20M: R10:4b97eef0bb3e: Revert "t_setrlimit: Adjust resource limit to 20M".
Dec 20 2021, 5:36 PM
mw committed R10:4b97eef0bb3e: Revert "t_setrlimit: Adjust resource limit to 20M" (authored by mw).
Revert "t_setrlimit: Adjust resource limit to 20M"
Dec 20 2021, 5:36 PM
mw added a reverting change for D33116: t_setrlimit: Adjust resource limit to 20M.: R10:4b97eef0bb3e: Revert "t_setrlimit: Adjust resource limit to 20M".
Dec 20 2021, 5:36 PM
mw added inline comments to D33457: Expand device_get_property API.
Dec 20 2021, 5:30 PM

Dec 19 2021

mw accepted D33457: Expand device_get_property API.

Tested with ACPI and DT on CN913x-DB (sdhci_xenon).

Dec 19 2021, 10:05 AM

Dec 1 2021

mw accepted D33222: NXP: Implement errata workaround for SDHCI driver .
Dec 1 2021, 3:13 PM

Nov 30 2021

mw added inline comments to D33170: USB: dwc3: use device_{has,get}_property().
Nov 30 2021, 5:23 PM
mw added a comment to D33170: USB: dwc3: use device_{has,get}_property().
In D33170#750128, @bz wrote:

Is someone else (from Semihalf) going to fix this?
I assume this is a missing bit in 3f9a00e3b577dcca57e331842e0baf2dbdf9325f which was only exercised with integers on FDT while the ACPI version does deal with the string specifically?

Nov 30 2021, 4:30 PM

Nov 29 2021

mw closed D33130: mmc: Fix HS200/HS400 capability check.
Nov 29 2021, 4:03 PM
mw committed R10:8661e085fb95: mmc: Fix HS200/HS400 capability check (authored by mindal_semihalf.com).
mmc: Fix HS200/HS400 capability check
Nov 29 2021, 4:03 PM
mw accepted D33130: mmc: Fix HS200/HS400 capability check.
Nov 29 2021, 6:55 AM

Nov 24 2021

mw committed R10:d9ed1dcc5c68: acpi: Fix error code returned in acpi_bus_get_prop (authored by bag_semihalf.com).
acpi: Fix error code returned in acpi_bus_get_prop
Nov 24 2021, 6:44 PM
mw closed D33103: acpi: fix device_get_property invalid return.
Nov 24 2021, 6:43 PM
mw accepted D33103: acpi: fix device_get_property invalid return.

Tested on: CN913x CEx7 Evaluation Board.

Nov 24 2021, 6:41 PM

Nov 21 2021

mw added a comment to D31597: device: add device_get_property and device_has_property.
In D31597#746913, @bz wrote:
In D31597#744282, @bz wrote:

Sorry; post-commit comment for enhancement.

Thank you for the comment. I will work on this next week.

FYI I have further changes to use the handle internally for _DSD as some non-native ACPI devices (no _HID) can then also use these functions (directly) to get properties; I'll extract them and post them and try to Cc: you. And maybe you guys have better ways to handle that; I hit the problem with MDI0/PHY and PR<n>s for dpaa2.

Nov 21 2021, 2:59 PM

Nov 16 2021

mw added a reverting change for R10:020f4112559e: bsdinstall: add knob to set ASLR sysctls: R10:bf410c6eda51: Revert "bsdinstall: add knob to set ASLR sysctls".
Nov 16 2021, 10:27 PM
mw committed R10:bf410c6eda51: Revert "bsdinstall: add knob to set ASLR sysctls" (authored by mw).
Revert "bsdinstall: add knob to set ASLR sysctls"
Nov 16 2021, 10:27 PM
mw committed R10:b014e0f15bc7: Enable ASLR by default for 64-bit executables (authored by mw).
Enable ASLR by default for 64-bit executables
Nov 16 2021, 10:27 PM
mw added a reverting change for D28418: bsdinstall: add knob to set ASLR sysctls: R10:bf410c6eda51: Revert "bsdinstall: add knob to set ASLR sysctls".
Nov 16 2021, 10:27 PM
mw closed D27666: Enable ASLR by default for 64-bit executables..
Nov 16 2021, 10:27 PM · PowerPC, security, arm64

Nov 15 2021

mw added a comment to D32833: bsdinstall: adjust ASLR knob to new defaults.

To be perfectly clear, my preference is:

  1. commit D27666
  2. revert R10:020f4112559ebf7e94665c9a69f89d21929ce82a
Nov 15 2021, 10:27 PM
mw updated the summary of D27666: Enable ASLR by default for 64-bit executables..
Nov 15 2021, 8:26 PM · PowerPC, security, arm64
mw updated the summary of D27666: Enable ASLR by default for 64-bit executables..
Nov 15 2021, 8:26 PM · PowerPC, security, arm64
mw added a comment to D27666: Enable ASLR by default for 64-bit executables..
In D27666#744977, @kib wrote:

I might write are not changed at this time to suggest this is not necessarily a final decision (in fact, it's not really a decision at all, 32-bit is probably not relevant enough to spend much effort on).

For 32bit, it might make sense to enable ASLR for 32bit binaries on 64bit host, still. That said, i386 kernel provides almost full 4G for UVA, so it might make sense to enable there as well, but lets limit the change to 64bit kernels, indeed.

Nov 15 2021, 4:21 PM · PowerPC, security, arm64
mw added a comment to D32833: bsdinstall: adjust ASLR knob to new defaults.

@emaste Have you decided about your preference whether we should update the menu option or remove it?

Nov 15 2021, 3:19 PM
mw added a comment to D27666: Enable ASLR by default for 64-bit executables..

As a result, although the tests on 32-bit architectures with ASLR enabled were
mostly on par with what was observed on 64-bit ones, the defaults for the
former are not changed. Also, for the sake of safety keep the feature disabled for 32-bit
executables on 64-bit machines, too.

I might write are not changed at this time to suggest this is not necessarily a final decision (in fact, it's not really a decision at all, 32-bit is probably not relevant enough to spend much effort on).

Nov 15 2021, 3:17 PM · PowerPC, security, arm64
mw updated the summary of D27666: Enable ASLR by default for 64-bit executables..
Nov 15 2021, 3:17 PM · PowerPC, security, arm64