Page MenuHomeFreeBSD
Differential D37441

param: increase KSTACK for hash context
Needs ReviewPublic
Actions

Authored by mkoz_semihalf.com on Nov 18 2022, 5:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 30, 3:03 AM
Unknown Object (File)
Oct 7 2024, 5:05 PM
Unknown Object (File)
Oct 5 2024, 4:05 PM
Unknown Object (File)
Oct 4 2024, 12:17 PM
Unknown Object (File)
Oct 4 2024, 7:52 AM
Unknown Object (File)
Oct 4 2024, 5:22 AM
Unknown Object (File)
Oct 4 2024, 12:23 AM
Unknown Object (File)
Oct 2 2024, 10:32 AM
View All 47 Files
Subscribers
andrew

Details

Reviewers
wma
mw
kd
imp
Summary

ossl_hash_context was increased (244 -> 2048bytes) for arm
https://reviews.freebsd.org/D37420

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mkoz_semihalf.com created this revision.Nov 18 2022, 5:44 PM
Herald added a subscriber: andrew. · View Herald TranscriptNov 18 2022, 5:44 PM
mkoz_semihalf.com requested review of this revision.Nov 18 2022, 5:44 PM
mkoz_semihalf.com mentioned this in D37419: arm: Add support for using VFP in kernel.Nov 18 2022, 5:47 PM
mkoz_semihalf.com added a reviewer: imp.Nov 18 2022, 5:50 PM
mw added a comment.Nov 18 2022, 7:15 PM

The default config Armada 38x should run with is sys/arm/conf/GENERIC. Can you please add a commit with that?

mw requested changes to this revision.Nov 18 2022, 7:16 PM
mw added inline comments.
sys/arm/conf/ARMADA38X
25 ↗(On Diff #113281)

This deserves a verbose commit message with explanation and probably a comment.

This revision now requires changes to proceed.Nov 18 2022, 7:16 PM
kd added a comment.Nov 21 2022, 9:21 AM

Since this isn't an Armada38x specific change I believe that it should be applied to all kernel configs.
IMHO we should modify the default value in arm/include/param.h.
Another thing is that 8 pages might be more than needed, e.g. amd64 defaults to 4/6 depending on whether KASAN is enabled.
Also as mw mentioned the commit message should contain a verbose explanation why we need to increase the kernel stack size.

andrew added a comment.Nov 23 2022, 8:13 AM

Why do you need 8 pages? That's a large increase from the 2 currently used on arm.

mkoz_semihalf.com updated this revision to Diff 113673.Nov 30 2022, 1:38 PM
mkoz_semihalf.com retitled this revision from conf: add support for neon/ossl to ARMADA38X to param: increase KSTACK for hash context.
mkoz_semihalf.com edited the summary of this revision. (Show Details)

Change default KSTACK_PAGES to 4

kd mentioned this in D37421: ossl: Add AES-GCM implementation for ARMv7 NEON.Dec 1 2022, 10:21 AM

Revision Contents
Changeset List

PathSize
sys/
arm/
include/
2 lines

Diff 113673

View Options

sys/arm/include/param.h

Loading...