Page MenuHomeFreeBSD

param: increase KSTACK for hash context
Needs ReviewPublic

Authored by mkoz_semihalf.com on Fri, Nov 18, 5:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 1, 2:02 AM
Unknown Object (File)
Thu, Dec 1, 2:02 AM
Subscribers

Details

Reviewers
wma
mw
kd
imp
Summary

ossl_hash_context was increased (244 -> 2048bytes) for arm
https://reviews.freebsd.org/D37420

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

The default config Armada 38x should run with is sys/arm/conf/GENERIC. Can you please add a commit with that?

mw requested changes to this revision.Fri, Nov 18, 7:16 PM
mw added inline comments.
sys/arm/conf/ARMADA38X
25 ↗(On Diff #113281)

This deserves a verbose commit message with explanation and probably a comment.

This revision now requires changes to proceed.Fri, Nov 18, 7:16 PM

Since this isn't an Armada38x specific change I believe that it should be applied to all kernel configs.
IMHO we should modify the default value in arm/include/param.h.
Another thing is that 8 pages might be more than needed, e.g. amd64 defaults to 4/6 depending on whether KASAN is enabled.
Also as mw mentioned the commit message should contain a verbose explanation why we need to increase the kernel stack size.

Why do you need 8 pages? That's a large increase from the 2 currently used on arm.

mkoz_semihalf.com retitled this revision from conf: add support for neon/ossl to ARMADA38X to param: increase KSTACK for hash context.
mkoz_semihalf.com edited the summary of this revision. (Show Details)

Change default KSTACK_PAGES to 4