param: increase KSTACK for hash context
Needs ReviewPublic
Actions

Authored by mkoz_semihalf.com on Nov 18 2022, 5:44 PM.

Details

Reviewers

wma
mw
kd
imp

Summary

ossl_hash_context was increased (244 -> 2048bytes) for arm
https://reviews.freebsd.org/D37420

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mkoz_semihalf.com created this revision.Nov 18 2022, 5:44 PM

Herald added a subscriber: andrew. · View Herald TranscriptNov 18 2022, 5:44 PM

mkoz_semihalf.com requested review of this revision.Nov 18 2022, 5:44 PM

mkoz_semihalf.com mentioned this in D37419: arm: Add support for using VFP in kernel.Nov 18 2022, 5:47 PM

mkoz_semihalf.com added a reviewer: imp.Nov 18 2022, 5:50 PM

The default config Armada 38x should run with is sys/arm/conf/GENERIC. Can you please add a commit with that?

mw requested changes to this revision.Nov 18 2022, 7:16 PM

mw added inline comments.

sys/arm/conf/ARMADA38X
25	This deserves a verbose commit message with explanation and probably a comment.

This revision now requires changes to proceed.Nov 18 2022, 7:16 PM

Since this isn't an Armada38x specific change I believe that it should be applied to all kernel configs.
IMHO we should modify the default value in arm/include/param.h.
Another thing is that 8 pages might be more than needed, e.g. amd64 defaults to 4/6 depending on whether KASAN is enabled.
Also as mw mentioned the commit message should contain a verbose explanation why we need to increase the kernel stack size.

Why do you need 8 pages? That's a large increase from the 2 currently used on arm.

Change default KSTACK_PAGES to 4

kd mentioned this in D37421: ossl: Add AES-GCM implementation for ARMv7 NEON.Dec 1 2022, 10:21 AM

Revision Contents
Changeset List

Path

Size

sys/

arm/

conf/

ARMADA38X

1 line

Diff 113281

View Options

param: increase KSTACK for hash contextNeeds ReviewPublicActions