Page MenuHomeFreeBSD

dgr_semihalf.com (Dawid Górecki)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 31 2020, 12:57 PM (69 w, 1 d)

Recent Activity

May 11 2021

dgr_semihalf.com added a comment to D29551: Add afterbuild target to bsd.prog.mk..

Ping. Does the patch look good? It's needed for D29553.

May 11 2021, 8:09 AM
dgr_semihalf.com added a comment to D29552: Add elfctl to toolchain..

Ping. Does the patch look good? It's needed for D29553.

May 11 2021, 8:09 AM
dgr_semihalf.com added a comment to D29550: usr.bin/elfctl: Allow for cross-endian operations..

Ping. Does the patch look good? It's needed for D29553.

May 11 2021, 8:09 AM

Apr 28 2021

dgr_semihalf.com added a comment to D29553: Disable stack gap for ntpd during build..
In D29553#673797, @cy wrote:

I will do a little more testing and commit.

Apr 28 2021, 3:51 PM
dgr_semihalf.com added a comment to D29832: ntpd: Change default stack limit to 4096 pages..

So, I've looked at this more and setting the stack size to 4096 pages should technically also resolve this problem. I tested this restarting the daemon multiple times and in my case it worked. However, the problem will occur randomly due to random nature of stack gap randomization. By default, the maximum size of stack gap is 15.36MiB on amd64, I'm not sure about other platforms. The default value of kern.elf64.aslr.stack_gap is 3, so in case of amd64, where the default stack limit is equal to 512MiB, that gives us the 15.36MiB number. I used 4096 as this means that we are setting the stack limit to 16MiB, which should leave enough stack for ntpd to work - I think that 15.56MiB is needed (15.36 of stack gap and 200K taken from the fact that we were limiting this to 200K previously), but I rounded this up to 16MiB.

Apr 28 2021, 2:59 PM

Apr 27 2021

dgr_semihalf.com added a comment to D29832: ntpd: Change default stack limit to 4096 pages..
In D29832#673048, @cy wrote:
In D29832#672594, @kib wrote:

Does ntpd still mlocall(2) itself? Issue there, I believe, is that all this memory, including gap, is wired.

Why not disable stack gap instead, with elfctl -e +noaslrstkgap ntpd (I think this is the right syntax)?

We already disable stack gap at line 447 of ntpd.c. Upstream inserted this patch after we applied it locally.

Apr 27 2021, 9:48 AM

Apr 26 2021

dgr_semihalf.com added a comment to D29832: ntpd: Change default stack limit to 4096 pages..

I re-opened D29553. I'm leaving this up as I don't know which will be the accepted method for solving the problem.

Apr 26 2021, 11:38 AM
dgr_semihalf.com reclaimed D29553: Disable stack gap for ntpd during build..

Re-opening this. As mentioned in D29832, @kib prefers this version.

Apr 26 2021, 11:37 AM
dgr_semihalf.com added a comment to D29832: ntpd: Change default stack limit to 4096 pages..
In D29832#672594, @kib wrote:

Does ntpd still mlocall(2) itself? Issue there, I believe, is that all this memory, including gap, is wired.

Why not disable stack gap instead, with elfctl -e +noaslrstkgap ntpd (I think this is the right syntax)?

Apr 26 2021, 9:37 AM

Apr 19 2021

dgr_semihalf.com abandoned D29553: Disable stack gap for ntpd during build..

D29832 changes the default stack size for ntpd, so I'm abandoning this revision. What do you think about D29550, D29551 and D29552?

Apr 19 2021, 10:56 AM
dgr_semihalf.com requested review of D29832: ntpd: Change default stack limit to 4096 pages..
Apr 19 2021, 10:45 AM

Apr 6 2021

dgr_semihalf.com added a comment to D29553: Disable stack gap for ntpd during build..

Yes, this could be resolved by changing the default stack resource limit from 200KiB to around 16MiB (maximum stack gap that can be created with default settings is 15.36MiB - 3% of default 512MiB stack resource limit). In that case the stack gap would actually exist, so any benefits resulting from it would still be there. Of course, the disadvantage of this approach is the increased resource utilization but that is expected with ASLR anyway. Also, if anyone changes the default stack limit to a lower value, this could result in segfault for them, so I think that information about that should be included somewhere in documentation.

Apr 6 2021, 1:55 PM

Apr 2 2021

dgr_semihalf.com added a comment to D27666: Enable ASLR by default for 64-bit executables..

I created D29550, D29551, D29552 and D29553, which allow us to disable stack gap for ntpd during build.

Apr 2 2021, 2:14 PM · PowerPC, security, arm64
dgr_semihalf.com added a comment to D29553: Disable stack gap for ntpd during build..

D29551 and D29552 are required for this to work.

Apr 2 2021, 2:11 PM
dgr_semihalf.com requested review of D29553: Disable stack gap for ntpd during build..
Apr 2 2021, 2:10 PM
dgr_semihalf.com requested review of D29552: Add elfctl to toolchain..
Apr 2 2021, 2:10 PM
dgr_semihalf.com requested review of D29551: Add afterbuild target to bsd.prog.mk..
Apr 2 2021, 2:09 PM
dgr_semihalf.com requested review of D29550: usr.bin/elfctl: Allow for cross-endian operations..
Apr 2 2021, 2:09 PM

Feb 23 2021

dgr_semihalf.com requested review of D28893: Disable PIE for PowerPC bootloaders..
Feb 23 2021, 2:13 PM · PowerPC

Feb 22 2021

dgr_semihalf.com requested review of D28869: multimedia/cx88: Fix build with default PIE..
Feb 22 2021, 3:46 PM
dgr_semihalf.com requested review of D28868: japanese/kon2-16dot: Fix build with default PIE..
Feb 22 2021, 3:43 PM
dgr_semihalf.com requested review of D28867: comms/birda: Fix build with default PIE..
Feb 22 2021, 3:31 PM
dgr_semihalf.com set the repository for D28865: net/packetdrill: Fix build with default PIE. to rP FreeBSD ports repository.
Feb 22 2021, 3:27 PM
dgr_semihalf.com set the repository for D28864: www/nostromo: Fix build with default PIE. to rP FreeBSD ports repository.
Feb 22 2021, 3:26 PM
dgr_semihalf.com set the repository for D28863: www/rssroll: Fix build with default PIE. to rP FreeBSD ports repository.
Feb 22 2021, 3:26 PM
dgr_semihalf.com requested review of D28866: mail/mailest: Fix build with default PIE..
Feb 22 2021, 3:25 PM
dgr_semihalf.com requested review of D28865: net/packetdrill: Fix build with default PIE..
Feb 22 2021, 3:20 PM
dgr_semihalf.com requested review of D28864: www/nostromo: Fix build with default PIE..
Feb 22 2021, 3:15 PM
dgr_semihalf.com requested review of D28863: www/rssroll: Fix build with default PIE..
Feb 22 2021, 3:11 PM

Feb 19 2021

dgr_semihalf.com requested review of D28801: net/sup: Fix build with default PIE..
Feb 19 2021, 6:57 PM
dgr_semihalf.com requested review of D28800: www/obhttpd: Fix build with default PIE..
Feb 19 2021, 6:48 PM
dgr_semihalf.com added a comment to D28793: www/mathopd: Fix build with default PIE..

My initial tests did not show any problems, but I only checked some basic functions of the server, for example CGI was not tested. This server is quite minimal, so testing reasonable part of this should not take long. Hopefully, the maintainer will tell us more about that. If not, I'll setup something and test this myself. Disabling PIE entirely, just because it does not build, may be an overkill here.

Feb 19 2021, 4:14 PM
dgr_semihalf.com added a comment to D28793: www/mathopd: Fix build with default PIE..

It seems that the maintainer doesn't have an account here. I'll send an email directly.

Feb 19 2021, 3:32 PM
dgr_semihalf.com requested review of D28793: www/mathopd: Fix build with default PIE..
Feb 19 2021, 3:26 PM

Feb 11 2021

dgr_semihalf.com added inline comments to D28328: Enable PIE by default on 64-bit architectures.
Feb 11 2021, 4:57 PM · PowerPC, arm64

Feb 10 2021

dgr_semihalf.com added a comment to D28328: Enable PIE by default on 64-bit architectures.

I have looked at *.mk files and if I am not mistaken it seems that there is currently no clean way of having a separate default option for PIE for base, as the __DEFAULT_YES_OPTIONS from bsd.opts.mk takes precedence and moving this option from bsd.opts.mk will leave us with no MK_PIE defined.

Feb 10 2021, 7:36 PM · PowerPC, arm64

Jan 28 2021

dgr_semihalf.com updated the diff for D28370: Disable PIE for MIPS u-boot-loader..

Added a comment indicating that PIE is incompatible with -mno-abicalls. Thanks, @emaste.

Jan 28 2021, 9:13 AM · MIPS

Jan 27 2021

dgr_semihalf.com requested review of D28370: Disable PIE for MIPS u-boot-loader..
Jan 27 2021, 11:36 AM · MIPS

Nov 12 2020

dgr_semihalf.com added a comment to D27025: [RFC] Fix abort in malloc extent coalescing..

Does it make sense also report to the upstream? https://github.com/jemalloc/jemalloc

Nov 12 2020, 2:57 PM

Oct 30 2020

dgr_semihalf.com requested review of D27025: [RFC] Fix abort in malloc extent coalescing..
Oct 30 2020, 6:58 PM

Jul 9 2020

dgr_semihalf.com requested review of D25599: vfs_syscalls: Call VFS_SYNC with MNT_WAIT argument..
Jul 9 2020, 2:01 PM

May 22 2020

dgr_semihalf.com updated the diff for D24466: Introduce a driver for NXP LS10xx SoC AHCI..

Replace SOC_NXP_LS1046 with SOC_NXP_LS.

May 22 2020, 8:09 PM
dgr_semihalf.com updated the diff for D24361: Introduce VF610 I2C controller support..

Replace SOC_NXP_LS1046A with SOC_NXP_LS.

May 22 2020, 8:04 PM
dgr_semihalf.com updated the diff for D24353: Add GPIO support for QorIQ boards..

Add ls1046_gpio device in kernel config. Replace SOC_NXP_LS1046 with SOC_NXP_LS.

May 22 2020, 8:01 PM
dgr_semihalf.com updated the diff for D24352: Add LS1046A clockgen driver..

Replace SOC_NXP_LS1046 with SOC_NXP_LS.

May 22 2020, 7:58 PM
dgr_semihalf.com updated the diff for D24351: Add QorIQ platform clockgen driver..

Added comment about 1:1 sysclk and coreclk divider nodes.

May 22 2020, 7:52 PM
dgr_semihalf.com added a comment to D24352: Add LS1046A clockgen driver..

I'll change it in all the patches to SOC_NXP_LS.

May 22 2020, 2:35 PM

May 21 2020

dgr_semihalf.com updated the diff for D24352: Add LS1046A clockgen driver..

Modified to work with new version of D24351

May 21 2020, 11:26 AM
dgr_semihalf.com added inline comments to D24351: Add QorIQ platform clockgen driver..
May 21 2020, 11:23 AM
dgr_semihalf.com updated the diff for D24351: Add QorIQ platform clockgen driver..

Modified driver to use clock id for lookup instead of names.
Modified the way sysclk and coreclk are created - currently
should follow bindings. The clock sources for PLLs are now
selected by driver automatically depending on the presence
of coreclk.

May 21 2020, 11:22 AM

May 15 2020

dgr_semihalf.com updated the diff for D24364: Introduce support for Epson RX-8803 RTC.

Moved to dev/iicbus/rtc/ directory.

May 15 2020, 5:37 PM
dgr_semihalf.com updated the diff for D24363: Add TCA6416 GPIO expander support..

Moved to dev/iicbus/gpio directory.

May 15 2020, 5:33 PM

May 12 2020

dgr_semihalf.com added a comment to D24466: Introduce a driver for NXP LS10xx SoC AHCI..

Hi, if you have any more comments or remarks, please let me know. Thanks.

May 12 2020, 2:04 PM
dgr_semihalf.com added a comment to D24364: Introduce support for Epson RX-8803 RTC.

Hi, if you have any more comments or remarks, please let me know. Thanks.

May 12 2020, 2:03 PM
dgr_semihalf.com added a comment to D24363: Add TCA6416 GPIO expander support..

Hi, if you have any more comments or remarks, please let me know. Thanks.

May 12 2020, 2:03 PM
dgr_semihalf.com added a comment to D24361: Introduce VF610 I2C controller support..

Hi, if you have any more comments or remarks, please let me know. Thanks.

May 12 2020, 2:02 PM
dgr_semihalf.com added a comment to D24353: Add GPIO support for QorIQ boards..

Hi, if you have any more comments or remarks, please let me know. Thanks.

May 12 2020, 2:02 PM
dgr_semihalf.com added a comment to D24352: Add LS1046A clockgen driver..

Hi, if you have any more comments or remarks, please let me know. Thanks.

May 12 2020, 2:01 PM
dgr_semihalf.com added a comment to D24351: Add QorIQ platform clockgen driver..

Hi, if you have any more comments or remarks, please let me know. Thanks.

May 12 2020, 2:01 PM

May 11 2020

dgr_semihalf.com added inline comments to D24353: Add GPIO support for QorIQ boards..
May 11 2020, 9:00 PM
dgr_semihalf.com updated the diff for D24353: Add GPIO support for QorIQ boards..

Added pin_access_32 and pin_config_32 functions.
Changed get_name function to generate "pin <pin_number>" as name.
Additional minor fixes.

May 11 2020, 8:55 PM
dgr_semihalf.com updated the diff for D24361: Introduce VF610 I2C controller support..

Added vf_i2c as driver name in files.arm64

May 11 2020, 8:49 PM
dgr_semihalf.com updated the diff for D24466: Introduce a driver for NXP LS10xx SoC AHCI..

Removed "All rights reserved" from copyright notice.
Added clock enabling in attach function.

May 11 2020, 8:47 PM

May 7 2020

dgr_semihalf.com added inline comments to D24352: Add LS1046A clockgen driver..
May 7 2020, 12:26 PM
dgr_semihalf.com added a comment to D24351: Add QorIQ platform clockgen driver..

Each PLL has multiple dividers. For each PLL single PLL node is created
and fixed factor clock nodes are created for each divider that the PLL has.
So only a single PLL node exists, but there are multiple divider nodes.

May 7 2020, 12:17 PM
dgr_semihalf.com added a comment to D24353: Add GPIO support for QorIQ boards..

Thanks, I'll prepare patch in the coming days.

May 7 2020, 11:06 AM
dgr_semihalf.com added inline comments to D24361: Introduce VF610 I2C controller support..
May 7 2020, 11:04 AM
dgr_semihalf.com added a comment to D24466: Introduce a driver for NXP LS10xx SoC AHCI..

The controller is actually connected to platform PLL, which
is always enabled, but since the controller might be used in
different SoC in the future, I'll add clock enabling.

May 7 2020, 10:55 AM

Apr 30 2020

dgr_semihalf.com added a comment to D24466: Introduce a driver for NXP LS10xx SoC AHCI..
In D24466#538161, @manu wrote:

Do you know how different this controller is compared to the other fsl ahci controller ? (like ls208x etc ...)
If it's very different the file should be renamed.

Apr 30 2020, 8:19 PM
dgr_semihalf.com updated the diff for D24466: Introduce a driver for NXP LS10xx SoC AHCI..

Add dependency on SOC_NXP_LS1046A option.

Apr 30 2020, 8:11 PM
dgr_semihalf.com updated the diff for D24364: Introduce support for Epson RX-8803 RTC.

Renamed file to rx8803.

Apr 30 2020, 8:06 PM
dgr_semihalf.com updated the diff for D24363: Add TCA6416 GPIO expander support..

Removed code that needed interrupts to start before executing.

Apr 30 2020, 8:05 PM
dgr_semihalf.com abandoned D24362: Add support for TI version of LM75..

The problem was with dts file not conforming to device tree documentation. Abandoning.

Apr 30 2020, 6:43 PM
dgr_semihalf.com updated the diff for D24361: Introduce VF610 I2C controller support..

Added bus_release_resources call and dependency on SOC_NXP_LS1046A.

Apr 30 2020, 6:37 PM
dgr_semihalf.com updated the diff for D24353: Add GPIO support for QorIQ boards..

Added SOC_NXP_LS1046A dependency.

Apr 30 2020, 6:18 PM
dgr_semihalf.com updated the diff for D24352: Add LS1046A clockgen driver..

I modified the driver to use the modified QorIQ clockgen classes.
Also added dependency on SOC_NXP_LS104A.

Apr 30 2020, 6:14 PM
dgr_semihalf.com updated the diff for D24351: Add QorIQ platform clockgen driver..

Pretty much a total rewrite. Now more closely represents the clock
node structure. For PLL nodes separate classes are now used, but
the PLL registers are read only, so there is no write functionality.
Other than that multiplexers are now represented by built-in classes
and PLL dividers are represented by fixed factor clocks.

Apr 30 2020, 6:14 PM

Apr 17 2020

dgr_semihalf.com added a comment to D24363: Add TCA6416 GPIO expander support..

Thanks for the comments, in the coming days I'll prepare v2 of this diff.

Apr 17 2020, 11:23 AM
dgr_semihalf.com created D24467: Add support for QorIQ FSL QSPI flash controller..
Apr 17 2020, 11:12 AM
dgr_semihalf.com created D24466: Introduce a driver for NXP LS10xx SoC AHCI..
Apr 17 2020, 11:12 AM

Apr 10 2020

dgr_semihalf.com created D24364: Introduce support for Epson RX-8803 RTC.
Apr 10 2020, 11:33 AM
dgr_semihalf.com created D24363: Add TCA6416 GPIO expander support..
Apr 10 2020, 11:28 AM
dgr_semihalf.com created D24362: Add support for TI version of LM75..
Apr 10 2020, 11:23 AM
dgr_semihalf.com created D24361: Introduce VF610 I2C controller support..
Apr 10 2020, 11:12 AM

Apr 9 2020

dgr_semihalf.com created D24353: Add GPIO support for QorIQ boards..
Apr 9 2020, 3:04 PM
dgr_semihalf.com created D24352: Add LS1046A clockgen driver..
Apr 9 2020, 2:49 PM
dgr_semihalf.com created D24351: Add QorIQ platform clockgen driver..
Apr 9 2020, 2:49 PM

Apr 6 2020

dgr_semihalf.com created D24310: hwpmc: Add Atom Goldmont microarchitecture support..
Apr 6 2020, 2:19 PM