Page MenuHomeFreeBSD

Disable PIE for PowerPC bootloaders.
ClosedPublic

Authored by dgr_semihalf.com on Tue, Feb 23, 2:13 PM.

Details

Summary

Bootloaders for powerpc are not built as position independent
code. Since bsd.prog.mk is used for building, when PIE is enabled,
the PIE flags are added and that causes the build to fail.
Adding MK_PIE=no stops bsd.prog.mk from adding PIE specific flags.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

stand/powerpc/boot1.chrp/Makefile
45

IMO a comment is warranted if there's something specific we can point out (such as the -mno-abicalls issue with MIPS) but otherwise it's not needed, MK_PIE=no is sufficiently self-explanatory.

LGTM. I think the comments are unnecessary though.

This revision is now accepted and ready to land.Wed, Feb 24, 6:52 PM
This revision was automatically updated to reflect the committed changes.