Disable PIE for PowerPC bootloaders.
ClosedPublic
Actions

Authored by dgr_semihalf.com on Feb 23 2021, 2:13 PM.

Details

Reviewers

mw
emaste
kib
imp
andrew
jhibbits
jhb
manu

Commits

R10:5b042fcbdff8: Disable PIE for powerpc bootloaders.
R10:9da7cdecf101: Disable PIE for powerpc bootloaders.
R10:3aa023643e9d: Disable PIE for powerpc bootloaders.

Summary

Bootloaders for powerpc are not built as position independent
code. Since bsd.prog.mk is used for building, when PIE is enabled,
the PIE flags are added and that causes the build to fail.
Adding MK_PIE=no stops bsd.prog.mk from adding PIE specific flags.

Diff Detail

Repository

R10 FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dgr_semihalf.com created this revision.Feb 23 2021, 2:13 PM

Herald added subscribers: alfredo, luporl, bdragon. · View Herald TranscriptFeb 23 2021, 2:13 PM

dgr_semihalf.com requested review of this revision.Feb 23 2021, 2:13 PM

dgr_semihalf.com added a child revision: D28328: Enable PIE by default on 64-bit architectures.

mw mentioned this in D28328: Enable PIE by default on 64-bit architectures.Feb 24 2021, 6:46 PM

emaste added inline comments.Feb 24 2021, 6:51 PM

stand/powerpc/boot1.chrp/Makefile
45	IMO a comment is warranted if there's something specific we can point out (such as the -mno-abicalls issue with MIPS) but otherwise it's not needed, MK_PIE=no is sufficiently self-explanatory.