Page MenuHomeFreeBSD

Disable PIE for PowerPC bootloaders.
ClosedPublic

Authored by dgr_semihalf.com on Feb 23 2021, 2:13 PM.
Referenced Files
Unknown Object (File)
Oct 10 2023, 6:28 PM
Unknown Object (File)
Sep 7 2023, 10:53 AM
Unknown Object (File)
Sep 6 2023, 9:33 AM
Unknown Object (File)
Aug 31 2023, 7:28 AM
Unknown Object (File)
Aug 27 2023, 5:22 AM
Unknown Object (File)
Aug 14 2023, 10:37 PM
Unknown Object (File)
Jul 5 2023, 4:34 PM
Unknown Object (File)
Jul 2 2023, 7:37 AM

Details

Summary

Bootloaders for powerpc are not built as position independent
code. Since bsd.prog.mk is used for building, when PIE is enabled,
the PIE flags are added and that causes the build to fail.
Adding MK_PIE=no stops bsd.prog.mk from adding PIE specific flags.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

stand/powerpc/boot1.chrp/Makefile
46

IMO a comment is warranted if there's something specific we can point out (such as the -mno-abicalls issue with MIPS) but otherwise it's not needed, MK_PIE=no is sufficiently self-explanatory.

LGTM. I think the comments are unnecessary though.

This revision is now accepted and ready to land.Feb 24 2021, 6:52 PM
This revision was automatically updated to reflect the committed changes.