Page MenuHomeFreeBSD
Differential D24364

Introduce support for Epson RX-8803 RTC
ClosedPublic
Actions

Authored by dgr_semihalf.com on Apr 10 2020, 11:33 AM.
Tags
None
Referenced Files
F132898416: D24364.id71833.diff
Mon, Oct 20, 11:43 PM
F132898415: D24364.id.diff
Mon, Oct 20, 11:43 PM
F132898412: D24364.id71205.diff
Mon, Oct 20, 11:43 PM
F132898410: D24364.id72241.diff
Mon, Oct 20, 11:43 PM
F132898408: D24364.id70397.diff
Mon, Oct 20, 11:43 PM
F132858195: D24364.diff
Mon, Oct 20, 1:42 PM
Unknown Object (File)
Thu, Oct 16, 12:50 AM
Unknown Object (File)
Wed, Oct 15, 7:09 PM
View All Files
Subscribers
imp
val_packett.cool

Details

Reviewers
mw
manu
• ian
Group Reviewers
ARM
arm64
Commits
rS361463: Introduce support for Epson RX-8803 RTC.
Summary

It has a resolution of 1 sec.
Support for interrupt based alarm was not implemented.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dgr_semihalf.com created this revision.Apr 10 2020, 11:33 AM
dgr_semihalf.com added a parent revision: D24363: Add TCA6416 GPIO expander support..
manu added a reviewer: • ian.Apr 10 2020, 11:39 AM
manu added reviewers: ARM, arm64.Apr 10 2020, 11:43 AM
val_packett.cool added a subscriber: val_packett.cool.Apr 13 2020, 2:06 PM
val_packett.cool added inline comments.
sys/conf/files
1807 ↗(On Diff #70397)

maybe name the file rx8803 instead of rtc8803 too?

dgr_semihalf.com added a child revision: D24466: Introduce a driver for NXP LS10xx SoC AHCI..Apr 17 2020, 11:12 AM
dgr_semihalf.com updated this revision to Diff 71205.Apr 30 2020, 8:06 PM

Renamed file to rx8803.

dgr_semihalf.com added a comment.May 12 2020, 2:03 PM

Hi, if you have any more comments or remarks, please let me know. Thanks.

manu accepted this revision.May 15 2020, 10:10 AM
manu added a subscriber: imp.

Would you mind moving the driver to a rtc subdirectory (sys/dev/iicbus/rtc/) ?
We've been talking with @ian and @imp about doing that for existing drivers.
Otherwise looks good to me.

This revision is now accepted and ready to land.May 15 2020, 10:10 AM
dgr_semihalf.com updated this revision to Diff 71833.May 15 2020, 5:37 PM

Moved to dev/iicbus/rtc/ directory.

This revision now requires review to proceed.May 15 2020, 5:37 PM
manu accepted this revision.May 15 2020, 5:49 PM
This revision is now accepted and ready to land.May 15 2020, 5:49 PM
Closed by commit rS361463: Introduce support for Epson RX-8803 RTC. (authored by mw). · Explain WhyMay 25 2020, 3:40 PM
This revision was automatically updated to reflect the committed changes.
mw added a commit: rS361463: Introduce support for Epson RX-8803 RTC..

Revision Contents
Changeset List

PathSize
head/
sys/
conf/
1 line
dev/
iicbus/
rtc/
246 lines
modules/
i2c/
3 lines
rx8803/
16 lines

Diff 72241

View Options

head/sys/conf/files

Loading...
View Options

head/sys/dev/iicbus/rtc/rx8803.c

Loading...
View Options

head/sys/modules/i2c/Makefile

Loading...
View Options

head/sys/modules/i2c/rx8803/Makefile

Loading...