Add TCA6416 GPIO expander support.
ClosedPublic
Actions

Authored by dgr_semihalf.com on Apr 10 2020, 11:28 AM.

Details

Reviewers

mw
manu
• ian
mmel

Group Reviewers

ARM
arm64

Commits

rS361462: Add TCA6416 GPIO expander support.

Summary

Add basic TCA6416 GPIO expander support. The driver handles
enabling and disabling pins, setting pin mode to IN and OUT and
toggling the pins. External interrupts are not supported.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dgr_semihalf.com created this revision.Apr 10 2020, 11:28 AM

Herald added a subscriber: loos. · View Herald TranscriptApr 10 2020, 11:28 AM

dgr_semihalf.com added a child revision: D24364: Introduce support for Epson RX-8803 RTC.Apr 10 2020, 11:34 AM

dgr_semihalf.com added a parent revision: D24362: Add support for TI version of LM75..

manu added a reviewer: • ian.Apr 10 2020, 11:40 AM

manu added inline comments.Apr 10 2020, 11:42 AM

sys/dev/iicbus/tca6416.c
151 ↗	(On Diff #70396)	Are all those extern devclass needed ? This might be our first gpio controller over i2c so maybe we need some new helpers for those.

manu added reviewers: ARM, arm64.Apr 10 2020, 11:43 AM

imp added a subscriber: imp.Apr 10 2020, 5:13 PM

imp added inline comments.

sys/dev/iicbus/tca6416.c
151 ↗	(On Diff #70396)	These aren't needed. See sys/arm/nvidia/as3722_gpio.c for an example.

mmel requested changes to this revision.Apr 14 2020, 4:20 PM

mmel added a subscriber: mmel.

mmel added inline comments.

sys/dev/iicbus/tca6416.c
151 ↗	(On Diff #70396)	Exactly, The trick is that driver class name (the string in driver_t structure or first argument to DEFINE_CLASS_0) should be "gpio" while driver module name (first argument to DRIVER_MODULE) should be unique.
228 ↗	(On Diff #70396)	This is not a safe. Changing polarity inversion register may also changes output value for affected output pin which may drive board reset for example.
244 ↗	(On Diff #70396)	This looks like leftover of debug code.
290 ↗	(On Diff #70396)	and since many gpio controllers are required to operate before interrupts start, the only real solution is teaching iic controller how to do polled mode.
293 ↗	(On Diff #70396)	We have config_intrhook_oneshot() exactly for this design pattern.

This revision now requires changes to proceed.Apr 14 2020, 4:20 PM

Thanks for the comments, in the coming days I'll prepare v2 of this diff.

Removed code that needed interrupts to start before executing.

Hi, if you have any more comments or remarks, please let me know. Thanks.

LGTM

Would you mind moving this driver to a gpio subdirectory (sys/dev/iicbus/gpio) ?
We've been talking with @ian and @imp doing that for existing drivers.
Otherwise LGTM.

This revision is now accepted and ready to land.May 15 2020, 10:11 AM

Moved to dev/iicbus/gpio directory.

This revision now requires review to proceed.May 15 2020, 5:33 PM

manu accepted this revision.May 15 2020, 5:49 PM

This revision is now accepted and ready to land.May 15 2020, 5:49 PM

Closed by commit rS361462: Add TCA6416 GPIO expander support. (authored by mw). · Explain WhyMay 25 2020, 3:31 PM

This revision was automatically updated to reflect the committed changes.

mw added a commit: rS361462: Add TCA6416 GPIO expander support..