Differential D36413

stand: Parse BIOS revision from SMBIOS
ClosedPublic
Actions

Authored by kd on Sep 1 2022, 2:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 6, 12:50 PM

	Unknown Object (File)
	Sat, Jul 6, 11:12 AM

	Unknown Object (File)
	Sat, Jun 29, 12:25 AM

	Unknown Object (File)
	Jun 26 2024, 12:21 AM

	Unknown Object (File)
	Jun 26 2024, 12:14 AM

	Unknown Object (File)
	Jun 24 2024, 1:45 PM

	Unknown Object (File)
	Jun 21 2024, 3:03 AM

	Unknown Object (File)
	Jun 21 2024, 12:50 AM

View All 57 Files

Subscribers

Details

Reviewers

mw
emaste
imp
manu

Commits

rG09932da03ec4: stand: Parse BIOS revision from SMBIOS
rG66c73af7ea59: stand: Parse BIOS revision from SMBIOS

Summary

Add a smbios.bios.revision kenv, which contains the system BIOS revision as defined in SMBIOS specification, section 3.3.1.
Since the revision is stored in two separate byte fields, the smbios_setenv helper can't be used.
Read and construct the kenv manually instead.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kd created this revision.Sep 1 2022, 2:13 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 1 2022, 2:13 PM

Herald added a subscriber: dab. · View Herald Transcript

kd requested review of this revision.Sep 1 2022, 2:13 PM

imp requested changes to this revision.Sep 1 2022, 2:37 PM

imp added inline comments.

stand/libsa/smbios.c
313	snprintf

This revision now requires changes to proceed.Sep 1 2022, 2:37 PM

manu added inline comments.Sep 1 2022, 2:45 PM

stand/libsa/smbios.c
313	Same comment, otherwise good for me.

sprintf -> snprintf

mw accepted this revision.Sep 1 2022, 11:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 2 2022, 11:20 AM

Closed by commit rG66c73af7ea59: stand: Parse BIOS revision from SMBIOS (authored by kd). · Explain Why

This revision was automatically updated to reflect the committed changes.

kd added a commit: rG66c73af7ea59: stand: Parse BIOS revision from SMBIOS.

imp added a commit: rG09932da03ec4: stand: Parse BIOS revision from SMBIOS.Jan 24 2023, 10:17 PM

Revision Contents
Changeset List

Path

Size

stand/

libsa/

9 lines

Diff 110076

stand/libsa/smbios.c

Loading...