e6000sw: Add readphy and writephy wrappers

[aja_semihalf.com]

Summary

New functions take lock and give lock after operation.
Removed locking and unlocking within other methods,
to prevent from recursive locking on non recursive lock.

Tested on EspressoBin.

[mw]

sys/dev/etherswitch/e6000sw/e6000sw.c

659

Please rename to e6000sw_readphy_locked - it will be more meaningful.

710

Please rename to e6000sw_writephy_locked.

1041

Don't remove this line.

[mw]

I agree the wrapper routines should not be suffixed with _locked. However, because we have a different case than e6000sw_readreg/e6000sw_readreg_wrapper, I propose a following change:
new functions should take the original name (the DEVMETHODs declarations will remain intact). i.e.:

• e6000sw_writephy_wrapper -> e6000sw_writephy
• e6000sw_readphy_wrapper -> e6000sw_readphy

the original routines should be suffixed with _locked:

• e6000sw_writephy -> e6000sw_writephy_locked
• e6000sw_readphy -> - e6000sw_readphy_locked

[mw]

sys/dev/etherswitch/e6000sw/e6000sw.c

115

Please do not modify the orignal lines, just add the new ones. This way the diff will be reduced to a minimum:

static int e6000sw_read_xmdio(device_t, int, int, int);
static int e6000sw_write_xmdio(device_t, int, int, int, int);
static int e6000sw_readphy(device_t, int, int);
static int e6000sw_writephy(device_t, int, int, int);
+static int e6000sw_readphy_locked(device_t, int, int);
+static int e6000sw_writephy_locked(device_t, int, int, int);
static int e6000sw_readphy(device_t, int, int);
static int e6000sw_writephy(device_t, int, int, int);