Paths

Table of Contentst

Differential D37825

Mechanically convert neta(4) to DrvAPI
ClosedPublic
Actions

Authored by jhibbits on Dec 22 2022, 3:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 12:12 AM

	Unknown Object (File)
	Fri, Nov 22, 11:46 AM

	Unknown Object (File)
	Tue, Nov 19, 9:58 AM

	Unknown Object (File)
	Wed, Nov 13, 8:16 AM

	Unknown Object (File)
	Thu, Nov 7, 5:12 PM

	Unknown Object (File)
	Thu, Nov 7, 5:12 PM

	Unknown Object (File)
	Thu, Nov 7, 5:10 PM

	Unknown Object (File)
	Thu, Nov 7, 3:57 AM

Subscribers

Details

Reviewers

manu
kd
mw

Commits

rG992fa62b2320: Mechanically convert neta(4) to IfAPI

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Dec 22 2022, 3:32 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 22 2022, 3:32 PM

jhibbits requested review of this revision.Dec 22 2022, 3:32 PM

jhibbits added a parent revision: D37824: Mechanically convert smc(4) to DrvAPI.

Harbormaster completed remote builds in B48837: Diff 114451.Dec 22 2022, 3:32 PM

jhibbits added a child revision: D37826: Mechanically convert sis(4) to DrvAPI.Dec 22 2022, 3:32 PM

jhibbits added reviewers: manu, kd, mw.Jan 9 2023, 2:45 PM

mw requested changes to this revision.Jan 9 2023, 3:04 PM

mw added inline comments.

sys/dev/neta/if_mvneta.c
936	Erroneous line removal.
943	ditto
2095	Can these 2 lines be wrapped into 1: if_setcapenablebit(ifp, IFCAP_HWCSUM & ifr->ifr_reqcap, IFCAP_HWCSUM); ?
2154	While at it, can you please fix line breaking?
3266	While at it, please add missing spaces around `\|`

This revision now requires changes to proceed.Jan 9 2023, 3:04 PM

Address feedback from @mw.

Harbormaster completed remote builds in B48997: Diff 114867.Jan 9 2023, 3:45 PM

mw added inline comments.Jan 9 2023, 5:58 PM

sys/dev/neta/if_mvneta.c
936	For other CTR* entries `ifp->if_xname` was updated to `if_name(sc->ifp)` - please do the same here for consistency.
943	For other CTR* entries `ifp->if_xname` was updated to `if_name(sc->ifp)` - please do the same here for consistency.
2095	?

jhibbits added inline comments.Jan 9 2023, 6:10 PM

sys/dev/neta/if_mvneta.c
2095	Not as it's currently implemented. It currently sets the "set" mask, then clears the "clear" mask, which is the opposite direction of this.

Address more from @mw.

Harbormaster completed remote builds in B49045: Diff 114927.Jan 10 2023, 2:14 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jan 10 2023, 9:25 AM

Closed by commit rG992fa62b2320: Mechanically convert neta(4) to IfAPI (authored by jhibbits). · Explain WhyJan 24 2023, 8:48 PM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rG992fa62b2320: Mechanically convert neta(4) to IfAPI.

Revision Contents
Changeset List

Path

Size

sys/

dev/

neta/

265 lines

4 lines

Diff 115549

sys/dev/neta/if_mvneta.c

Loading...

sys/dev/neta/if_mvnetavar.h

Loading...