Page MenuHomeFreeBSD

Mechanically convert neta(4) to DrvAPI
ClosedPublic

Authored by jhibbits on Dec 22 2022, 3:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 21, 1:07 PM
Unknown Object (File)
Fri, Jul 19, 9:18 AM
Unknown Object (File)
Thu, Jul 18, 10:48 AM
Unknown Object (File)
Wed, Jul 3, 11:36 AM
Unknown Object (File)
Jun 24 2024, 6:53 AM
Unknown Object (File)
Jun 23 2024, 10:25 AM
Unknown Object (File)
May 28 2024, 4:23 AM
Unknown Object (File)
May 11 2024, 6:28 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48997
Build 45886: arc lint + arc unit

Event Timeline

mw requested changes to this revision.Jan 9 2023, 3:04 PM
mw added inline comments.
sys/dev/neta/if_mvneta.c
936

Erroneous line removal.

943

ditto

2095

Can these 2 lines be wrapped into 1:
if_setcapenablebit(ifp, IFCAP_HWCSUM & ifr->ifr_reqcap, IFCAP_HWCSUM);
?

2154

While at it, can you please fix line breaking?

3266

While at it, please add missing spaces around |

This revision now requires changes to proceed.Jan 9 2023, 3:04 PM
sys/dev/neta/if_mvneta.c
936

For other CTR* entries ifp->if_xname was updated to if_name(sc->ifp) - please do the same here for consistency.

943

For other CTR* entries ifp->if_xname was updated to if_name(sc->ifp) - please do the same here for consistency.

2095

?

sys/dev/neta/if_mvneta.c
2095

Not as it's currently implemented. It currently sets the "set" mask, then clears the "clear" mask, which is the opposite direction of this.

This revision is now accepted and ready to land.Jan 10 2023, 9:25 AM
This revision was automatically updated to reflect the committed changes.