Page MenuHomeFreeBSD

Mechanically convert qlxge(4) to DrvAPI
ClosedPublic

Authored by jhibbits on Dec 22 2022, 3:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 28 2024, 8:36 AM
Unknown Object (File)
May 28 2024, 8:36 AM
Unknown Object (File)
May 28 2024, 8:36 AM
Unknown Object (File)
May 26 2024, 7:09 PM
Unknown Object (File)
May 19 2024, 8:30 AM
Unknown Object (File)
May 17 2024, 2:33 AM
Unknown Object (File)
May 7 2024, 12:52 AM
Unknown Object (File)
Apr 19 2024, 8:52 AM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei added a subscriber: zlei.

Other parts looks good to me.

sys/dev/qlxge/qls_os.c
306

if_sendq_empty(ifp) seems not identical to ifp->if_snd.ifq_head == NULL

1086–1087

Ditto

This revision is now accepted and ready to land.Feb 7 2023, 1:42 AM
sys/dev/qlxge/qls_os.c
306

It looks like the difference is that if_sendq_empty(), which uses IFQ_DRV_IS_EMPTY() also checks ifq_drv_len in addition to ifq_len. I don't know the impact of this difference.

sys/dev/qlxge/qls_os.c
306

Reviewing, I think if_sendq_empty() is safe and correct.

This revision was automatically updated to reflect the committed changes.