Page MenuHomeFreeBSD
Differential D37819

Mechanically convert qlxge(4) to DrvAPI
ClosedPublic
Actions

Authored by jhibbits on Dec 22 2022, 3:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 8:52 AM
Unknown Object (File)
Mar 21 2024, 7:05 AM
Unknown Object (File)
Mar 20 2024, 2:56 AM
Unknown Object (File)
Mar 20 2024, 2:48 AM
Unknown Object (File)
Mar 20 2024, 2:41 AM
Unknown Object (File)
Mar 19 2024, 3:51 PM
Unknown Object (File)
Mar 19 2024, 3:22 PM
Unknown Object (File)
Mar 19 2024, 4:26 AM
View All 37 Files
Subscribers
imp
zlei

Details

Reviewers
zlei
Group Reviewers
network
Commits
rG64c618ed7dbb: Mechanically convert qlxge(4) to IfAPI

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhibbits created this revision.Dec 22 2022, 3:30 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 22 2022, 3:30 PM
jhibbits requested review of this revision.Dec 22 2022, 3:30 PM
Harbormaster completed remote builds in B48831: Diff 114445.Dec 22 2022, 3:30 PM
jhibbits added a parent revision: D37818: Mechanically convert sk(4) to DrvAPI.Dec 22 2022, 3:30 PM
jhibbits added a child revision: D37820: Mechanically convert qlxgb(4) to DrvAPI.
jhibbits added a reviewer: network.Feb 6 2023, 7:40 PM
zlei accepted this revision.Feb 7 2023, 1:42 AM
zlei added a subscriber: zlei.

Other parts looks good to me.

sys/dev/qlxge/qls_os.c
306

if_sendq_empty(ifp) seems not identical to ifp->if_snd.ifq_head == NULL

1086–1087

Ditto

This revision is now accepted and ready to land.Feb 7 2023, 1:42 AM
zlei mentioned this in D37820: Mechanically convert qlxgb(4) to DrvAPI.Feb 7 2023, 1:48 AM
jhibbits added inline comments.Feb 7 2023, 3:27 PM
sys/dev/qlxge/qls_os.c
306

It looks like the difference is that if_sendq_empty(), which uses IFQ_DRV_IS_EMPTY() also checks ifq_drv_len in addition to ifq_len. I don't know the impact of this difference.

jhibbits added inline comments.Feb 7 2023, 6:57 PM
sys/dev/qlxge/qls_os.c
306

Reviewing, I think if_sendq_empty() is safe and correct.

Closed by commit rG64c618ed7dbb: Mechanically convert qlxge(4) to IfAPI (authored by jhibbits). · Explain WhyMar 7 2023, 8:29 PM
This revision was automatically updated to reflect the committed changes.
jhibbits added a commit: rG64c618ed7dbb: Mechanically convert qlxge(4) to IfAPI.

Revision Contents
Changeset List

PathSize
sys/
dev/
qlxge/
4 lines
2 lines
2 lines
4 lines
149 lines

Diff 118490

View Options

sys/dev/qlxge/qls_def.h

Loading...
View Options

sys/dev/qlxge/qls_hw.c

Loading...
View Options

sys/dev/qlxge/qls_ioctl.c

Loading...
View Options

sys/dev/qlxge/qls_isr.c

Loading...
View Options

sys/dev/qlxge/qls_os.c

Loading...