Page MenuHomeFreeBSD
Differential D37817

Mechanically convert sfxge(4) to DrvAPI
ClosedPublic
Actions

Authored by jhibbits on Dec 22 2022, 3:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 3:01 AM
Unknown Object (File)
Mon, Aug 10, 8:39 PM
Unknown Object (File)
Sat, Aug 8, 7:18 PM
Unknown Object (File)
Sat, Aug 8, 6:36 PM
Unknown Object (File)
Sat, Aug 8, 1:52 PM
Unknown Object (File)
Wed, Aug 5, 9:49 PM
Unknown Object (File)
Wed, Aug 5, 3:22 AM
Unknown Object (File)
Tue, Aug 4, 1:00 PM
View All Files
Subscribers
imp
zlei

Details

Reviewers
arybchik
zlei
Group Reviewers
network
Commits
rG04abf87b2a56: Mechanically convert sfxge(4) to IfAPI

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhibbits created this revision.Dec 22 2022, 3:30 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 22 2022, 3:30 PM
jhibbits requested review of this revision.Dec 22 2022, 3:30 PM
Harbormaster completed remote builds in B48829: Diff 114443.Dec 22 2022, 3:30 PM
jhibbits added a parent revision: D37816: Mechanically convert sge(4) to DrvAPI.Dec 22 2022, 3:30 PM
jhibbits added a child revision: D37818: Mechanically convert sk(4) to DrvAPI.
jhibbits added reviewers: glebius, melifaro.Jan 10 2023, 9:20 PM
jhibbits edited reviewers, added: network, arybchik; removed: glebius, melifaro.Feb 6 2023, 7:59 PM
zlei accepted this revision.Feb 7 2023, 2:23 AM
zlei added a subscriber: zlei.

Looks good to me.

sys/dev/sfxge/sfxge.h
273

Small nits, align member ifnet

sys/dev/sfxge/sfxge_port.c
519–520

Use if_getlladdr()

This revision is now accepted and ready to land.Feb 7 2023, 2:23 AM
arybchik accepted this revision.Feb 7 2023, 7:38 AM

Thanks, LGTM

Closed by commit rG04abf87b2a56: Mechanically convert sfxge(4) to IfAPI (authored by jhibbits). · Explain WhyFeb 7 2023, 7:19 PM
This revision was automatically updated to reflect the committed changes.
jhibbits added a commit: rG04abf87b2a56: Mechanically convert sfxge(4) to IfAPI.

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
6 lines
95 lines
29 lines
8 lines
4 lines
10 lines

Diff 116727

View Options

sys/dev/sfxge/sfxge.h

Loading...
View Options

sys/dev/sfxge/sfxge.c

Loading...
View Options

sys/dev/sfxge/sfxge_port.c

Loading...
View Options

sys/dev/sfxge/sfxge_rx.c

Loading...
View Options

sys/dev/sfxge/sfxge_tx.h

Loading...
View Options

sys/dev/sfxge/sfxge_tx.c

Loading...