Page MenuHomeFreeBSD
Differential D37821

Mechanically convert qlxgbe(4) to DrvAPI
ClosedPublic
Actions

Authored by jhibbits on Dec 22 2022, 3:30 PM.
Tags
None
Referenced Files
F157023989: D37821.id118491.diff
Mon, May 18, 12:22 AM
F157023163: D37821.id118491.diff
Mon, May 18, 12:19 AM
F156989672: D37821.id114447.diff
Sun, May 17, 8:18 PM
F156988663: D37821.id114447.diff
Sun, May 17, 8:10 PM
Unknown Object (File)
Sun, May 17, 10:40 AM
Unknown Object (File)
Sun, May 17, 6:14 AM
Unknown Object (File)
Sat, May 16, 11:45 PM
Unknown Object (File)
Wed, May 13, 6:28 PM
View All Files
Subscribers
imp
zlei

Details

Reviewers
zlei
Group Reviewers
network
Commits
rG54ab3b4a03f0: Mechanically convert qlxgbe(4) to IfAPI

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhibbits created this revision.Dec 22 2022, 3:30 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 22 2022, 3:30 PM
jhibbits requested review of this revision.Dec 22 2022, 3:30 PM
Harbormaster completed remote builds in B48833: Diff 114447.Dec 22 2022, 3:30 PM
jhibbits added a parent revision: D37820: Mechanically convert qlxgb(4) to DrvAPI.Dec 22 2022, 3:30 PM
jhibbits added a child revision: D37822: Mechanically convert sbni(4) to DrvAPI.
jhibbits added a reviewer: network.Feb 6 2023, 7:41 PM
zlei accepted this revision.Feb 7 2023, 1:23 AM
zlei added a subscriber: zlei.

Looks good to me.

sys/dev/qlxgbe/ql_ioctl.h
269

It seems this macro is not used anywhere, and I'd prefer leave it as is.

273

Ditto.

This revision is now accepted and ready to land.Feb 7 2023, 1:23 AM
jhibbits added inline comments.Feb 7 2023, 7:03 PM
sys/dev/qlxgbe/ql_ioctl.h
269

Odd, no idea why that got removed.

273

Same here...

Closed by commit rG54ab3b4a03f0: Mechanically convert qlxgbe(4) to IfAPI (authored by jhibbits). · Explain WhyMar 7 2023, 8:29 PM
This revision was automatically updated to reflect the committed changes.
jhibbits added a commit: rG54ab3b4a03f0: Mechanically convert qlxgbe(4) to IfAPI.

Revision Contents
Changeset List

PathSize
sys/
dev/
qlxgbe/
4 lines
16 lines
4 lines
8 lines
12 lines
183 lines

Diff 118491

View Options

sys/dev/qlxgbe/ql_def.h

Loading...
View Options

sys/dev/qlxgbe/ql_hw.c

Loading...
View Options

sys/dev/qlxgbe/ql_ioctl.h

Loading...
View Options

sys/dev/qlxgbe/ql_ioctl.c

Loading...
View Options

sys/dev/qlxgbe/ql_isr.c

Loading...
View Options

sys/dev/qlxgbe/ql_os.c

Loading...