Page MenuHomeFreeBSD

mk_semihalf.com (Michał Krawczyk)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 19 2017, 11:32 AM (122 w, 4 d)

Recent Activity

Apr 18 2019

mk_semihalf.com updated the diff for D19932: Add barrier in buf ring peek function to prevent race in ARM and ARM64.

Remove spurious comment about barrier

Apr 18 2019, 7:41 AM · ARM, arm64, network

Apr 17 2019

mk_semihalf.com updated the diff for D19932: Add barrier in buf ring peek function to prevent race in ARM and ARM64.

Mark the code as ARM/ARM64 specific and change barrier, to order only loads.

Apr 17 2019, 9:19 AM · ARM, arm64, network
mk_semihalf.com created D19932: Add barrier in buf ring peek function to prevent race in ARM and ARM64.
Apr 17 2019, 9:06 AM · ARM, arm64, network

Mar 20 2019

mk_semihalf.com created D19655: Do not activate admin interrupt in ENA.
Mar 20 2019, 10:19 AM · network

Mar 19 2019

mk_semihalf.com created D19641: Add bus_release_resource() method to nexus on arm64.
Mar 19 2019, 1:06 PM · arm64

Nov 9 2017

mk_semihalf.com updated the diff for D12860: Refactor style of the ENA driver.

Fix style issues and invalid conditional check

Nov 9 2017, 10:58 AM

Nov 8 2017

mk_semihalf.com updated the diff for D12868: Rework printouts and logging level in ENA driver.

Fix building error introduced by the r325506 by casting csum_flags to uint64_t

Nov 8 2017, 4:22 PM
mk_semihalf.com updated the diff for D12863: Allow partial MSI-x allocation in ENA driver.

Fix typo in printout

Nov 8 2017, 4:05 PM
mk_semihalf.com added inline comments to D12856: Check for Rx ring state to prevent from stall in the ENA driver.
Nov 8 2017, 4:04 PM
mk_semihalf.com updated the diff for D12856: Check for Rx ring state to prevent from stall in the ENA driver.
  • Change M_NOWAIT to M_WAITOK on taskqueue_create_fast
  • Style fix
Nov 8 2017, 4:04 PM
mk_semihalf.com added a comment to D12855: Add RX OOO completion feature.

Curious as to how this was tested since I assume 'out of order RX descriptors' condition is not common.

Nov 8 2017, 4:02 PM
mk_semihalf.com updated the diff for D12855: Add RX OOO completion feature.
  • Expand goto if retrieving RX mbuf fails
  • Fix error handling routine by assigning value to free_rx_ids instead of tx
Nov 8 2017, 4:01 PM

Nov 2 2017

mk_semihalf.com updated the diff for D12864: Cleanup of the ENA driver header file.

Removed unused macro and additional whitespace

Nov 2 2017, 2:53 PM
mk_semihalf.com updated the diff for D12861: Cover ENA driver code with branch predictioning statements.

Fix conflicts with recent update to D12860

Nov 2 2017, 2:51 PM
mk_semihalf.com updated the diff for D12860: Refactor style of the ENA driver.

The boolean variables are no longer compared explicitly to true/false.

Nov 2 2017, 2:48 PM
mk_semihalf.com updated the diff for D12859: Fix error handling in the ENA driver and lock drbr_free() call.

Update due to conflict with recent fix in the:
D12853 Fix ENA driver error handling in attach and basic style fixes

Nov 2 2017, 2:46 PM
mk_semihalf.com updated the diff for D12855: Add RX OOO completion feature.

Remove checking for NULL after calling malloc with M_WAITOK flag

Nov 2 2017, 2:41 PM
mk_semihalf.com updated the diff for D12853: Fix ENA driver error handling in attach and basic style fixes.

Fixes from review:

  • Remove checking for NULL after calling malloc with M_WAITOK flag
Nov 2 2017, 2:35 PM
mk_semihalf.com added inline comments to D12864: Cleanup of the ENA driver header file.
Nov 2 2017, 8:52 AM
mk_semihalf.com added inline comments to D12861: Cover ENA driver code with branch predictioning statements.
Nov 2 2017, 7:43 AM

Oct 31 2017

mk_semihalf.com created D12872: Fix setting AENQ group in ENA driver.
Oct 31 2017, 1:59 PM
mk_semihalf.com created D12871: Allow usage of more RX descriptors than 1 in ENA driver.
Oct 31 2017, 1:58 PM
mk_semihalf.com created D12870: Read max MTU from the ENA device.
Oct 31 2017, 1:57 PM
mk_semihalf.com created D12869: Fix calculating io queues number in ENA drive.
Oct 31 2017, 1:56 PM
mk_semihalf.com created D12868: Rework printouts and logging level in ENA driver.
Oct 31 2017, 1:53 PM
mk_semihalf.com created D12867: Fix comparing L3 type with L4 enum on RX hash in ENA driver.
Oct 31 2017, 1:48 PM
mk_semihalf.com created D12866: Fix compilation warnings when building ENA driver with gcc compiler.
Oct 31 2017, 1:47 PM
mk_semihalf.com created D12865: Fix checking if the DF flag was set in ENA driver.
Oct 31 2017, 1:45 PM
mk_semihalf.com created D12864: Cleanup of the ENA driver header file.
Oct 31 2017, 1:44 PM
mk_semihalf.com created D12863: Allow partial MSI-x allocation in ENA driver.
Oct 31 2017, 1:43 PM
mk_semihalf.com created D12862: Remove deprecated and unused counters in ENA driver.
Oct 31 2017, 1:42 PM
mk_semihalf.com created D12861: Cover ENA driver code with branch predictioning statements.
Oct 31 2017, 1:41 PM
mk_semihalf.com created D12860: Refactor style of the ENA driver.
Oct 31 2017, 1:39 PM
mk_semihalf.com created D12859: Fix error handling in the ENA driver and lock drbr_free() call.
Oct 31 2017, 1:37 PM
mk_semihalf.com created D12858: Destroy admin queue after freeing interrupts in ENA driver.
Oct 31 2017, 1:36 PM
mk_semihalf.com created D12857: Split function checking for missing TX completion in ENA driver.
Oct 31 2017, 1:34 PM
mk_semihalf.com created D12856: Check for Rx ring state to prevent from stall in the ENA driver.
Oct 31 2017, 1:33 PM
mk_semihalf.com created D12855: Add RX OOO completion feature.
Oct 31 2017, 1:32 PM
mk_semihalf.com created D12854: Change function validate_tx_req_id() to inline in ENA driver.
Oct 31 2017, 1:30 PM
mk_semihalf.com created D12853: Fix ENA driver error handling in attach and basic style fixes.
Oct 31 2017, 1:29 PM
mk_semihalf.com created D12852: Rework counting of hardware statistics in ENA driver.
Oct 31 2017, 1:26 PM

Sep 28 2017

mk_semihalf.com added a comment to D12143: Update ena-com HAL to newest version and update driver accordingly.

By the way the files in this review still have the wrong mode bits (100755 instead of 100644, need chmod a-x).

Sep 28 2017, 8:03 AM
mk_semihalf.com updated the diff for D12143: Update ena-com HAL to newest version and update driver accordingly.

We were waiting for Linux community to accept ena_com patch (common code for both FreeBSD and Linux), but to do not waste more time, we decided to upload fix to issue with uint64_t being defined as unsigned long on amd64 on FreeBSD, and on Linux it is being defined as unsigned long long.

Sep 28 2017, 8:00 AM

Aug 30 2017

mk_semihalf.com added inline comments to D12143: Update ena-com HAL to newest version and update driver accordingly.
Aug 30 2017, 11:09 AM
mk_semihalf.com updated the diff for D12143: Update ena-com HAL to newest version and update driver accordingly.
  • Remove non-generic ENA_MEMCPY_TO_DEVICE_64
  • Fix ENA_MEMCPY_TO_DEVICE_64
Aug 30 2017, 11:09 AM
mk_semihalf.com updated the diff for D12143: Update ena-com HAL to newest version and update driver accordingly.
  • The ena_efa files were removed
  • Removed usage of LinuxKPI
  • Implement macro ENA_MEMCPY_TO_DEVICE_64 in ena_plat.h file
Aug 30 2017, 7:06 AM

Aug 29 2017

mk_semihalf.com added a comment to D12143: Update ena-com HAL to newest version and update driver accordingly.

Thanks Ryan for checking build with gcc and review.

Aug 29 2017, 1:02 PM

Aug 28 2017

mk_semihalf.com created D12143: Update ena-com HAL to newest version and update driver accordingly.
Aug 28 2017, 12:48 PM

Aug 14 2017

mk_semihalf.com added inline comments to D10427: Add support for Amazon Elastic Network Adapter (ENA) NIC.
Aug 14 2017, 11:25 AM

May 26 2017

mk_semihalf.com created D10927: ena: add additional locks when releasing TX resources and bufs.
May 26 2017, 10:52 AM · network
mk_semihalf.com created D10926: ena: move hw stats updating routine to separate task.
May 26 2017, 10:51 AM · network
mk_semihalf.com created D10925: ena: add error handling if init of the reset task fails.
May 26 2017, 10:48 AM · network
mk_semihalf.com updated subscribers of D10923: ena: add mbuf defragmentation.
May 26 2017, 10:47 AM · network
mk_semihalf.com created D10924: ena: add locks before each ena_up and ena_down.
May 26 2017, 10:46 AM · network
mk_semihalf.com created D10923: ena: add mbuf defragmentation.
May 26 2017, 10:43 AM · network

May 15 2017

mk_semihalf.com updated the diff for D10427: Add support for Amazon Elastic Network Adapter (ENA) NIC.
  • Add manual entry for the driver
May 15 2017, 1:57 PM

Apr 28 2017

mk_semihalf.com updated the diff for D10427: Add support for Amazon Elastic Network Adapter (ENA) NIC.

Add new patchset. Manual and legal issues will be added in patchset 3.

Apr 28 2017, 11:19 AM
mk_semihalf.com commandeered D10427: Add support for Amazon Elastic Network Adapter (ENA) NIC.
Apr 28 2017, 11:16 AM
mk_semihalf.com added inline comments to D10427: Add support for Amazon Elastic Network Adapter (ENA) NIC.
Apr 28 2017, 10:07 AM