Refactor style of the ENA driver

[mk_semihalf.com]

Summary

• Change all conditional checks in "if" statement to boolean expressions
• Initialzie variables with too complex values outside the declaration
• Fix indentations
• Move code associated with sysctls to ena_sysctl.c file
• For consistency, remove unnecesary "return" from void functions
• Use if_getdrvflags() function instead of accesing variable directly

[rlibby]

Most of these changes look to be in the right direction. I don't think evaluating if a bool == true or == false is necessary. In some places parentheses have been added which are not strictly needed, I don't feel strongly about those either way. I did not evaluate for completeness.

sys/dev/ena/ena.c

1430 ↗

(On Diff #34523)

This one is not necessary, rss_support is already a bool.

1433 ↗

(On Diff #34523)

As above, frag is bool.

1434 ↗

(On Diff #34523)

style(9) discourages excess parentheses when the parsing is not confusing. I don't have a complaint if you prefer to parenthesize this, but FYI it is not required by style.

1587–1598 ↗

(On Diff #34523)

As above, l3_csum_err and l4_csum_err are already bools.

[mk_semihalf.com]

The boolean variables are no longer compared explicitly to true/false.

[mw]

sys/dev/ena/ena.c

2220 ↗

(On Diff #34672)

Please correct the condition or leave the original version, if running field is boolean.

2455 ↗

(On Diff #34672)

Please align lines 2427 and 2428

2980 ↗

(On Diff #34672)

is_drbr_empty is should be treated as boolean

[mk_semihalf.com]

Fix style issues and invalid conditional check