Cleanup of the ENA driver header file
ClosedPublic
Actions

Authored by mk_semihalf.com on Oct 31 2017, 1:44 PM.

Details

Reviewers

byenduri_gmail.com
rlibby
mw

Commits

rS325584: Cleanup of the ENA driver header file

Summary

Remove unused macros and fields - some of them were only initialized,
but had no further uses.

Minor style fixes and added required comments.

Missing TX completions counter was existing, but was not used in driver
code - the required line had been added.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mk_semihalf.com created this revision.Oct 31 2017, 1:44 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 31 2017, 1:44 PM

mk_semihalf.com added a parent revision: D12863: Allow partial MSI-x allocation in ENA driver.Oct 31 2017, 1:45 PM

mk_semihalf.com added a child revision: D12865: Fix checking if the DF flag was set in ENA driver.

Always nice to have minus diffs, assuming it still compiles :)

sys/dev/ena/ena.c
3407 ↗	(On Diff #34527)	Stray patch?
sys/dev/ena/ena.h
73 ↗	(On Diff #34527)	Can delete this too?
240 ↗	(On Diff #34527)	The leading whitespace looks funny in phabricator, can you double check it here?

mk_semihalf.com added inline comments.Nov 2 2017, 8:52 AM

sys/dev/ena/ena.c
3407 ↗	(On Diff #34527)	I wrote about this in the commit log. Should i split it into 2 patches?

Removed unused macro and additional whitespace

mw accepted this revision.Nov 8 2017, 11:27 PM

This revision is now accepted and ready to land.Nov 8 2017, 11:27 PM

Closed by commit rS325584: Cleanup of the ENA driver header file (authored by mw). · Explain WhyNov 9 2017, 12:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ena/

ena.h

59 lines

ena.c

13 lines

Diff 34988

View Options

head/sys/dev/ena/ena.h