Page MenuHomeFreeBSD

Cleanup of the ENA driver header file
ClosedPublic

Authored by mk_semihalf.com on Oct 31 2017, 1:44 PM.
Tags
None
Referenced Files
F132231378: D12864.id34674.diff
Wed, Oct 15, 12:48 AM
Unknown Object (File)
Thu, Oct 9, 11:44 PM
Unknown Object (File)
Wed, Sep 17, 6:05 PM
Unknown Object (File)
Wed, Sep 17, 5:09 PM
Unknown Object (File)
Sep 12 2025, 3:11 PM
Unknown Object (File)
Sep 5 2025, 6:38 AM
Unknown Object (File)
Sep 2 2025, 11:53 AM
Unknown Object (File)
Aug 26 2025, 2:11 AM

Details

Summary

Remove unused macros and fields - some of them were only initialized,
but had no further uses.

Minor style fixes and added required comments.

Missing TX completions counter was existing, but was not used in driver
code - the required line had been added.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Always nice to have minus diffs, assuming it still compiles :)

sys/dev/ena/ena.c
3407 ↗(On Diff #34527)

Stray patch?

sys/dev/ena/ena.h
73 ↗(On Diff #34527)

Can delete this too?

240 ↗(On Diff #34527)

The leading whitespace looks funny in phabricator, can you double check it here?

sys/dev/ena/ena.c
3407 ↗(On Diff #34527)

I wrote about this in the commit log. Should i split it into 2 patches?

mk_semihalf.com marked 2 inline comments as done.

Removed unused macro and additional whitespace

This revision is now accepted and ready to land.Nov 8 2017, 11:27 PM
This revision was automatically updated to reflect the committed changes.