Page MenuHomeFreeBSD

Fix compilation warnings when building ENA driver with gcc compiler
ClosedPublic

Authored by mk_semihalf.com on Oct 31 2017, 1:47 PM.
Tags
None
Referenced Files
F131971996: D12866.id34990.diff
Sun, Oct 12, 3:03 PM
Unknown Object (File)
Thu, Oct 2, 9:43 AM
Unknown Object (File)
Tue, Sep 30, 10:07 AM
Unknown Object (File)
Aug 29 2025, 9:28 AM
Unknown Object (File)
Aug 23 2025, 2:19 PM
Unknown Object (File)
Aug 19 2025, 11:27 AM
Unknown Object (File)
Aug 18 2025, 10:37 AM
Unknown Object (File)
Aug 14 2025, 11:55 PM

Details

Summary

The gcc compiler is more sensitive when variable is having an value
assigned, but it is not used anywhere further.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rlibby added inline comments.
sys/dev/ena/ena.c
2765–2766 ↗(On Diff #34529)

Nothing wrong with this formulation, but an alternative would have been just to delete the ena_dev variable, since it is otherwise pointless. ena_handle_msix and ena_unmask_all_io_irqs appear to have gone with that approach.

This revision is now accepted and ready to land.Nov 1 2017, 6:33 AM
This revision was automatically updated to reflect the committed changes.