Page MenuHomeFreeBSD

Fix compilation warnings when building ENA driver with gcc compiler
ClosedPublic

Authored by mk_semihalf.com on Oct 31 2017, 1:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 26, 4:01 PM
Unknown Object (File)
Sep 18 2024, 6:19 PM
Unknown Object (File)
Aug 15 2024, 5:53 AM
Unknown Object (File)
Jul 10 2024, 2:47 AM
Unknown Object (File)
Jun 19 2024, 5:50 PM
Unknown Object (File)
Jun 2 2024, 2:39 PM
Unknown Object (File)
May 17 2024, 9:50 AM
Unknown Object (File)
May 3 2024, 9:15 PM

Details

Summary

The gcc compiler is more sensitive when variable is having an value
assigned, but it is not used anywhere further.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rlibby added inline comments.
sys/dev/ena/ena.c
2765–2766 ↗(On Diff #34529)

Nothing wrong with this formulation, but an alternative would have been just to delete the ena_dev variable, since it is otherwise pointless. ena_handle_msix and ena_unmask_all_io_irqs appear to have gone with that approach.

This revision is now accepted and ready to land.Nov 1 2017, 6:33 AM
This revision was automatically updated to reflect the committed changes.