Page MenuHomeFreeBSD

Fix compilation warnings when building ENA driver with gcc compiler
ClosedPublic

Authored by mk_semihalf.com on Oct 31 2017, 1:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 29 2023, 4:08 AM
Unknown Object (File)
Dec 20 2023, 7:57 AM
Unknown Object (File)
Nov 23 2023, 5:08 PM
Unknown Object (File)
Sep 6 2023, 6:44 PM
Unknown Object (File)
Sep 5 2023, 4:00 PM
Unknown Object (File)
Aug 15 2023, 6:28 AM
Unknown Object (File)
Jul 4 2023, 12:41 AM
Unknown Object (File)
Jun 28 2023, 2:19 PM

Details

Summary

The gcc compiler is more sensitive when variable is having an value
assigned, but it is not used anywhere further.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rlibby added inline comments.
sys/dev/ena/ena.c
2765–2766 ↗(On Diff #34529)

Nothing wrong with this formulation, but an alternative would have been just to delete the ena_dev variable, since it is otherwise pointless. ena_handle_msix and ena_unmask_all_io_irqs appear to have gone with that approach.

This revision is now accepted and ready to land.Nov 1 2017, 6:33 AM
This revision was automatically updated to reflect the committed changes.