Change function validate_tx_req_id() to inline in ENA driver
ClosedPublic
Actions

Authored by mw on Oct 31 2017, 1:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 20, 3:44 PM

	Unknown Object (File)
	Mon, Apr 20, 1:00 AM

	Unknown Object (File)
	Wed, Apr 15, 11:41 AM

	Unknown Object (File)
	Mon, Apr 13, 6:03 AM

	Unknown Object (File)
	Sun, Apr 12, 3:14 PM

	Unknown Object (File)
	Sat, Apr 11, 10:33 AM

	Unknown Object (File)
	Sat, Apr 11, 10:00 AM

	Unknown Object (File)
	Thu, Apr 9, 11:26 PM

View All 72 Files

Subscribers

gtzalik_amazon.com

imp

Details

Reviewers

byenduri_gmail.com
rlibby
mk_semihalf.com

Commits

rS325512: Change function validate_tx_req_id() to inline in ENA driver

Summary

The function is in hot path of the driver (TX) and asking compiler for
making this function inline was changed for consistency and higher
readability.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mk_semihalf.com created this revision.Oct 31 2017, 1:30 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 31 2017, 1:30 PM

mk_semihalf.com added a parent revision: D12853: Fix ENA driver error handling in attach and basic style fixes.Oct 31 2017, 1:31 PM

mk_semihalf.com added a child revision: D12855: Add RX OOO completion feature.

Looks good to me.

This revision is now accepted and ready to land.Oct 31 2017, 8:42 PM

rlibby accepted this revision.Nov 1 2017, 6:35 AM

Commited in https://svnweb.freebsd.org/base?view=revision&revision=325512

Revision Contents
Changeset List

Path

Size

sys/

dev/

ena/

ena.c

4 lines

Diff 34517

View Options

Change function validate_tx_req_id() to inline in ENA driverClosedPublicActions