Fix checking if the DF flag was set in ENA driver
ClosedPublic
Actions

Authored by mk_semihalf.com on Oct 31 2017, 1:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 25, 6:12 PM

	Unknown Object (File)
	Wed, Apr 23, 11:53 AM

	Unknown Object (File)
	Tue, Apr 22, 5:33 AM

	Unknown Object (File)
	Mon, Apr 21, 9:30 AM

	Unknown Object (File)
	Thu, Apr 17, 6:50 AM

	Unknown Object (File)
	Tue, Apr 15, 2:46 PM

	Unknown Object (File)
	Feb 3 2025, 2:55 AM

	Unknown Object (File)
	Oct 1 2024, 12:44 PM

View All 43 Files

Subscribers

gtzalik_amazon.com

imp

Details

Reviewers

rlibby
byenduri_gmail.com
mw

Commits

rS325585: Fix checking if the DF flag was set in ENA driver

Summary

The previous way of checking for DF was not valid.
When DF is enabled, the DF bit should be 1.

The original way of checking it was wrong in 2 ways: first of all, it
was not checking for single bit, secondly, it was checking for 0.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mk_semihalf.com created this revision.Oct 31 2017, 1:45 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 31 2017, 1:45 PM

mk_semihalf.com added a parent revision: D12864: Cleanup of the ENA driver header file.Oct 31 2017, 1:46 PM

mk_semihalf.com added a child revision: D12866: Fix compilation warnings when building ENA driver with gcc compiler.

byenduri_gmail.com accepted this revision.Nov 7 2017, 2:21 AM

This revision is now accepted and ready to land.Nov 7 2017, 2:21 AM

Closed by commit rS325585: Fix checking if the DF flag was set in ENA driver (authored by mw). · Explain WhyNov 9 2017, 12:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ena/

ena.c

2 lines

Diff 34989

View Options

Fix checking if the DF flag was set in ENA driverClosedPublicActions