Differential D19655

Do not activate admin interrupt in ENA
ClosedPublic
Actions

Authored by mk_semihalf.com on Mar 20 2019, 10:19 AM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Sep 11, 5:34 PM

	Unknown Object (File)
	Thu, Sep 10, 8:11 PM

	Unknown Object (File)
	Sun, Sep 6, 12:23 AM

	Unknown Object (File)
	Sat, Sep 5, 10:39 PM

	Unknown Object (File)
	Sat, Sep 5, 3:39 PM

	Unknown Object (File)
	Sat, Sep 5, 3:36 PM

	Unknown Object (File)
	Sat, Sep 5, 2:12 PM

	Unknown Object (File)
	Sat, Sep 5, 10:11 AM

Subscribers

Details

Reviewers

Commits

rS345371: Prevent double activation of admin interrupt in ENA

Summary

The resource is already being activated in the bus_alloc_resource(),
because the flag RF_ACTIVE is being passed.

Double activation on arm64 is causing kernel panic.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mk_semihalf.com created this revision.Mar 20 2019, 10:19 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 20 2019, 10:19 AM

Works in my testing. Please commit.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2019, 10:46 AM

Closed by commit rS345371: Prevent double activation of admin interrupt in ENA (authored by mw). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ena/

ena.h

2 lines

ena.c

8 lines

Diff 55316

View Options

head/sys/dev/ena/ena.h