bnxt: isc_nrxd_max and isc_ntxd_max must be powers of two
ClosedPublic
Actions

Authored by kp on May 19 2020, 9:45 PM.

Details

Reviewers

shurd
gallatin
rpokala

Group Reviewers

network

Commits

rS361279: bnxt: isc_nrxd_max and isc_ntxd_max must be powers of two

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.May 19 2020, 9:45 PM

Herald added a reviewer: shurd. · View Herald TranscriptMay 19 2020, 9:45 PM

kp requested review of this revision.May 19 2020, 9:45 PM

Harbormaster completed remote builds in B31185: Diff 72005.May 19 2020, 9:46 PM

rpokala added a subscriber: rpokala.May 19 2020, 9:52 PM

rpokala added inline comments.

sys/dev/bnxt/bnxt.h
90 ↗	(On Diff #72005)	A comment explaining that these must be a (large-ish) power of two would be helpful.

gallatin accepted this revision.May 20 2020, 1:54 PM

gallatin added a reviewer: gallatin.

This revision is now accepted and ready to land.May 20 2020, 1:55 PM

Add a comment explaining that the RX/TX descriptor limit must be a power of two.

This revision now requires review to proceed.May 20 2020, 2:58 PM

Harbormaster completed remote builds in B31197: Diff 72028.May 20 2020, 2:58 PM

Thanks!

This revision is now accepted and ready to land.May 20 2020, 3:22 PM

gallatin accepted this revision.May 20 2020, 3:23 PM

Closed by commit rS361279: bnxt: isc_nrxd_max and isc_ntxd_max must be powers of two (authored by kp). · Explain WhyMay 20 2020, 4:07 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rS361279: bnxt: isc_nrxd_max and isc_ntxd_max must be powers of two.

Herald added a subscriber: imp. · View Herald TranscriptMay 20 2020, 4:07 PM

kd mentioned this in D21337: bnxt: Set max number of descriptors to a power of 2.Jan 19 2023, 10:17 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

bnxt/

bnxt.h

5 lines

if_bnxt.c

4 lines

Diff 72030

View Options

head/sys/dev/bnxt/bnxt.h