Page MenuHomeFreeBSD

bnxt: isc_nrxd_max and isc_ntxd_max must be powers of two
ClosedPublic

Authored by kp on Tue, May 19, 9:45 PM.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp created this revision.Tue, May 19, 9:45 PM
kp requested review of this revision.Tue, May 19, 9:45 PM
rpokala added inline comments.
sys/dev/bnxt/bnxt.h
90 ↗(On Diff #72005)

A comment explaining that these must be a (large-ish) power of two would be helpful.

gallatin accepted this revision.Wed, May 20, 1:54 PM
gallatin added a reviewer: gallatin.
This revision is now accepted and ready to land.Wed, May 20, 1:55 PM
kp updated this revision to Diff 72028.Wed, May 20, 2:58 PM

Add a comment explaining that the RX/TX descriptor limit must be a power of two.

This revision now requires review to proceed.Wed, May 20, 2:58 PM
rpokala accepted this revision.Wed, May 20, 3:22 PM

Thanks!

This revision is now accepted and ready to land.Wed, May 20, 3:22 PM
gallatin accepted this revision.Wed, May 20, 3:23 PM
This revision was automatically updated to reflect the committed changes.