Page MenuHomeFreeBSD

NXP: Implement errata workaround for SDHCI driver
ClosedPublic

Authored by hum_semihalf.com on Dec 1 2021, 2:46 PM.

Details

Summary

Some boards do not detect pulse width reliably. Implement workaround
by writing 0 to special register. Apply errata for board by adding
flag to chosen soc specific data.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu added inline comments.
sys/dev/sdhci/sdhci_fsl_fdt.c
4

You need to add 2020-2021

This revision is now accepted and ready to land.Dec 1 2021, 2:55 PM

Change time period in license entry from 2021 to 2020 - 2021.

This revision now requires review to proceed.Dec 1 2021, 3:06 PM
This revision is now accepted and ready to land.Dec 1 2021, 3:13 PM
bz added a subscriber: bz.

Is there a (public) reference for the errata? Might be worth mentioning that at least in the commit message.

sys/dev/sdhci/sdhci_fsl_fdt.c
742

technically you are only clearing a bit and not setting the register to 0...