Page MenuHomeFreeBSD

NXP: Implement errata workaround for SDHCI driver
ClosedPublic

Authored by hum_semihalf.com on Dec 1 2021, 2:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 28, 11:37 AM
Unknown Object (File)
Feb 18 2024, 8:24 AM
Unknown Object (File)
Feb 9 2024, 5:09 PM
Unknown Object (File)
Dec 20 2023, 4:24 AM
Unknown Object (File)
Dec 12 2023, 10:18 AM
Unknown Object (File)
Dec 4 2023, 5:05 PM
Unknown Object (File)
Oct 18 2023, 6:59 PM
Unknown Object (File)
Oct 15 2023, 12:14 AM

Details

Summary

Some boards do not detect pulse width reliably. Implement workaround
by writing 0 to special register. Apply errata for board by adding
flag to chosen soc specific data.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu added inline comments.
sys/dev/sdhci/sdhci_fsl_fdt.c
5

You need to add 2020-2021

This revision is now accepted and ready to land.Dec 1 2021, 2:55 PM

Change time period in license entry from 2021 to 2020 - 2021.

This revision now requires review to proceed.Dec 1 2021, 3:06 PM
This revision is now accepted and ready to land.Dec 1 2021, 3:13 PM
bz added a subscriber: bz.

Is there a (public) reference for the errata? Might be worth mentioning that at least in the commit message.

sys/dev/sdhci/sdhci_fsl_fdt.c
753

technically you are only clearing a bit and not setting the register to 0...