Page MenuHomeFreeBSD
Differential D35120

libsecureboot: Do not propagate empty string
Needs ReviewPublic
Actions

Authored by hum_semihalf.com on Wed, May 4, 11:57 AM.

Details

Reviewers
mw
wma
sjg
Summary

If Trust Anchors are provided by UEFI and not compiled into
libsecureboot the segmentation fault occurs due to empty
or NULL string usage.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

hum_semihalf.com created this revision.Wed, May 4, 11:57 AM
Herald added subscribers: dab, imp. · View Herald TranscriptWed, May 4, 11:57 AM
hum_semihalf.com requested review of this revision.Wed, May 4, 11:57 AM
sjg added inline comments.Fri, May 6, 4:15 PM
lib/libsecureboot/vets.c
424

you miss out on OpenPGP support?

hum_semihalf.com updated this revision to Diff 105780.Mon, May 9, 7:54 AM

Do not return immediately in case TRUST ANCHORS are NULL, as openpgp may be supported as well.

sjg accepted this revision.Fri, May 13, 5:59 PM
This revision is now accepted and ready to land.Fri, May 13, 5:59 PM
hum_semihalf.com updated this revision to Diff 106031.Mon, May 16, 5:23 AM

Rebase the revision.

This revision now requires review to proceed.Mon, May 16, 5:23 AM

Revision Contents
Changeset List

PathSize
lib/
libsecureboot/
5 lines

Diff 106031

View Options

lib/libsecureboot/vets.c

Loading...