Page MenuHomeFreeBSD

e6000sw: fix incorrect locking
ClosedPublic

Authored by kp on Aug 10 2022, 4:40 PM.
Tags
None
Referenced Files
F166571123: D36117.diff
Fri, Aug 14, 2:54 PM
Unknown Object (File)
Sat, Aug 8, 5:48 PM
Unknown Object (File)
Fri, Aug 7, 10:01 AM
Unknown Object (File)
Wed, Aug 5, 9:33 AM
Unknown Object (File)
Wed, Aug 5, 1:48 AM
Unknown Object (File)
Tue, Aug 4, 4:47 AM
Unknown Object (File)
Mon, Aug 3, 3:18 AM
Unknown Object (File)
Sun, Aug 2, 12:59 AM
Subscribers

Details

Summary

During attach we release the lock to call e6000sw_attach_miibus(), which
calls mii_attach(). The mii_attach() function calls miibus_readreg() /
miibus_writereg(). However, these are set to be
e6000sw_readphy_locked().

That is, the read/write phy functions do not acquire the lock, but
expect to be called while locked. Simply do not unlock and relock while
calling mii_attach().

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.Aug 10 2022, 4:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 19 2022, 9:10 PM
This revision was automatically updated to reflect the committed changes.