Page MenuHomeFreeBSD

e6000sw: fix incorrect locking
ClosedPublic

Authored by kp on Aug 10 2022, 4:40 PM.
Tags
None
Referenced Files
F170572935: D36117.id.diff
Sat, Sep 5, 11:29 AM
Unknown Object (File)
Fri, Sep 4, 1:37 AM
Unknown Object (File)
Tue, Sep 1, 7:41 PM
Unknown Object (File)
Tue, Sep 1, 5:45 PM
Unknown Object (File)
Tue, Sep 1, 5:02 PM
Unknown Object (File)
Tue, Aug 18, 12:28 AM
Unknown Object (File)
Fri, Aug 14, 2:54 PM
Unknown Object (File)
Sat, Aug 8, 5:48 PM
Subscribers

Details

Summary

During attach we release the lock to call e6000sw_attach_miibus(), which
calls mii_attach(). The mii_attach() function calls miibus_readreg() /
miibus_writereg(). However, these are set to be
e6000sw_readphy_locked().

That is, the read/write phy functions do not acquire the lock, but
expect to be called while locked. Simply do not unlock and relock while
calling mii_attach().

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.Aug 10 2022, 4:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 19 2022, 9:10 PM
This revision was automatically updated to reflect the committed changes.