Page MenuHomeFreeBSD

Add driver for marvell, a37x0 peripheral clocks
Needs ReviewPublic

Authored by on Oct 4 2021, 2:18 PM.



Add driver for Marvell, Armada-37xx peripheral clock.
Register clocks for various peripheral devices in
north bridge or south bridge domain. Dump clock's
domain while verbose boot.

Diff Detail

R10 FreeBSD src repository
Lint Skipped
Unit Tests Skipped

Event Timeline

Not gonna reviews the clock definitions but the overall looks good, just one question : would it be clearer to split the clock drivers ? (nb and sb in different drivers). They are mostly the same and uses the same type clocks from what I could see but it might be easier to read the code if they are each in one file with their clocks.

Split driver into two separate drivers, each for north bridge or south bridge domain.