Page MenuHomeFreeBSD

Add driver for marvell, a37x0 peripheral clocks
ClosedPublic

Authored by hum_semihalf.com on Oct 4 2021, 2:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 9:05 AM
Unknown Object (File)
Fri, Apr 5, 9:35 PM
Unknown Object (File)
Tue, Apr 2, 9:11 AM
Unknown Object (File)
Wed, Mar 27, 11:39 AM
Unknown Object (File)
Mar 7 2024, 4:30 PM
Unknown Object (File)
Feb 26 2024, 1:20 PM
Unknown Object (File)
Feb 1 2024, 1:51 PM
Unknown Object (File)
Jan 17 2024, 2:36 PM

Details

Summary

Add driver for Marvell, Armada-37xx peripheral clock.
Register clocks for various peripheral devices in
north bridge or south bridge domain. Dump clock's
domain while verbose boot.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Not gonna reviews the clock definitions but the overall looks good, just one question : would it be clearer to split the clock drivers ? (nb and sb in different drivers). They are mostly the same and uses the same type clocks from what I could see but it might be easier to read the code if they are each in one file with their clocks.

Split driver into two separate drivers, each for north bridge or south bridge domain.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 4 2022, 12:32 PM
This revision was automatically updated to reflect the committed changes.