ip_mroute: refactor epoch-based locking
ClosedPublic
Actions

Authored by wma on Jan 25 2022, 9:23 AM.

Details

Reviewers

mw
glebius

Commits

rG77223d98b6f8: ip_mroute: refactor epoch-basd locking

Summary

Remove duplicated epoch_enter and epoch_exit in IP inp/outp routines.
Remove unnecessary macros as well.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wma created this revision.Jan 25 2022, 9:23 AM

Herald added a subscriber: melifaro. · View Herald TranscriptJan 25 2022, 9:23 AM

wma requested review of this revision.Jan 25 2022, 9:23 AM

Why do you still require the epoch to enter X_ip_mrouter_done? Epoch isn't required to write to a pointer that points at data protected by epoch.

Do we still need include <netinet/ip_mroute.h> in ip_input.c and ip_output.c after this change?

Updated.

There is still a potential race between rip_detach and handling MRT_DONE (both call ip_mrouter_done). AFAIK these functions are not used at the same time so its highly unlikely this ever happen - I've never seen it so far.
I'm planning to further refactor ip_mroute.c to avoid this kind of issues, but not in this commit.

glebius accepted this revision.Feb 1 2022, 6:54 PM

This revision is now accepted and ready to land.Feb 1 2022, 6:54 PM

Closed by commit rG77223d98b6f8: ip_mroute: refactor epoch-basd locking (authored by wma). · Explain WhyFeb 2 2022, 5:49 AM

This revision was automatically updated to reflect the committed changes.

wma added a commit: rG77223d98b6f8: ip_mroute: refactor epoch-basd locking.

Herald added a subscriber: imp. · View Herald TranscriptFeb 2 2022, 5:49 AM