Page MenuHomeFreeBSD
Differential D33719

armv6/legacy: optimize cpy_getcount performance
ClosedPublic
Actions

Authored by wma on Jan 2 2022, 8:56 AM.
Tags
None
Referenced Files
F83413520: D33719.diff
Fri, May 10, 4:57 AM
Unknown Object (File)
Wed, May 8, 6:41 PM
Unknown Object (File)
Wed, May 8, 1:23 PM
Unknown Object (File)
Sat, May 4, 9:22 PM
Unknown Object (File)
Sat, Apr 20, 8:24 AM
Unknown Object (File)
Apr 5 2024, 4:35 PM
Unknown Object (File)
Mar 30 2024, 7:34 AM
Unknown Object (File)
Mar 23 2024, 2:10 PM
View All 26 Files
Subscribers
imp

Details

Reviewers
andrew
mw
Commits
rG25bcd81b8d12: armv6/legacy: optimize cpu_getcount performance
Summary

Use nanotime instread of binuptime.
This change is for old and legacy platforms and does not impact any armv7 and later.
Might be MFCed to 13.0 once armv6 support is finally dropped in 14.0

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wma requested review of this revision.Jan 2 2022, 8:56 AM
wma created this revision.
mw accepted this revision.Jan 10 2022, 12:11 PM
This revision is now accepted and ready to land.Jan 10 2022, 12:11 PM
andrew added a comment.Jan 10 2022, 12:23 PM

Is this code path used? The only armv6 CPU se support is the bcm2835 which is an arm1176 so should be handled by reading the appropriate register.

wma added a comment.Feb 4 2022, 10:13 AM

It's not used on any official FreeBSD platform. However, with some out-of-tree BSPs this portion of code becomes active.

Closed by commit rG25bcd81b8d12: armv6/legacy: optimize cpu_getcount performance (authored by wma). · Explain WhyMar 14 2022, 6:52 AM
This revision was automatically updated to reflect the committed changes.
wma added a commit: rG25bcd81b8d12: armv6/legacy: optimize cpu_getcount performance.
Herald added a subscriber: imp. · View Herald TranscriptMar 14 2022, 6:52 AM

Revision Contents
Changeset List

PathSize
sys/
arm/
include/
8 lines

Diff 103813

View Options

sys/arm/include/cpu.h

Loading...