Page MenuHomeFreeBSD

Enter epoch when addding IPv4 multicast forwarding cache entry
ClosedPublic

Authored by karels on Mar 21 2022, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 21 2024, 3:16 PM
Unknown Object (File)
Feb 12 2024, 4:29 AM
Unknown Object (File)
Jan 3 2024, 11:11 AM
Unknown Object (File)
Dec 20 2023, 7:34 AM
Unknown Object (File)
Dec 12 2023, 9:53 PM
Unknown Object (File)
Dec 1 2023, 1:11 AM
Unknown Object (File)
Nov 18 2023, 12:25 PM
Unknown Object (File)
Nov 13 2023, 4:59 AM

Details

Summary

The code path from the IPv4 multicast setsockopt could call ip_output()
without entering an epoch. Specifically, the MRT_ADD_MFC setbsocopt
would call add_mfc(), which in turn called ip_mdq() to send queued
packets. This resulted in an epoch assert failure in ip_output().
Enter an epoch in add_mfc(), and add some epoch asserts to check
for similar failures.

Test Plan

tested with mrouted and rwhod -m

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz added a subscriber: bz.

Sounds reasonable to me and I like the extra asserts for documentation purposes; I always wonder if the entire ioctl paths should just acquire/release epoch but that's a totally different can of worms.

This revision is now accepted and ready to land.Mar 21 2022, 3:24 PM
cy added a subscriber: cy.