Page MenuHomeFreeBSD

Enter epoch when addding IPv4 multicast forwarding cache entry
ClosedPublic

Authored by karels on Mar 21 2022, 3:07 PM.
Tags
None
Referenced Files
F137378202: D34624.diff
Sat, Nov 22, 10:18 PM
Unknown Object (File)
Wed, Nov 19, 10:51 PM
Unknown Object (File)
Tue, Nov 18, 6:40 PM
Unknown Object (File)
Oct 20 2025, 2:29 PM
Unknown Object (File)
Oct 17 2025, 10:17 PM
Unknown Object (File)
Oct 6 2025, 2:52 AM
Unknown Object (File)
Sep 29 2025, 9:13 PM
Unknown Object (File)
Sep 25 2025, 4:35 AM

Details

Summary

The code path from the IPv4 multicast setsockopt could call ip_output()
without entering an epoch. Specifically, the MRT_ADD_MFC setbsocopt
would call add_mfc(), which in turn called ip_mdq() to send queued
packets. This resulted in an epoch assert failure in ip_output().
Enter an epoch in add_mfc(), and add some epoch asserts to check
for similar failures.

Test Plan

tested with mrouted and rwhod -m

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz added a subscriber: bz.

Sounds reasonable to me and I like the extra asserts for documentation purposes; I always wonder if the entire ioctl paths should just acquire/release epoch but that's a totally different can of worms.

This revision is now accepted and ready to land.Mar 21 2022, 3:24 PM
cy added a subscriber: cy.