Page MenuHomeFreeBSD

Enter epoch when addding IPv4 multicast forwarding cache entry
ClosedPublic

Authored by karels on Mar 21 2022, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 12:38 PM
Unknown Object (File)
Mon, Apr 15, 7:52 PM
Unknown Object (File)
Mon, Apr 8, 2:52 PM
Unknown Object (File)
Sat, Apr 6, 10:34 AM
Unknown Object (File)
Sat, Apr 6, 10:27 AM
Unknown Object (File)
Feb 21 2024, 3:16 PM
Unknown Object (File)
Feb 12 2024, 4:29 AM
Unknown Object (File)
Jan 3 2024, 11:11 AM

Details

Summary

The code path from the IPv4 multicast setsockopt could call ip_output()
without entering an epoch. Specifically, the MRT_ADD_MFC setbsocopt
would call add_mfc(), which in turn called ip_mdq() to send queued
packets. This resulted in an epoch assert failure in ip_output().
Enter an epoch in add_mfc(), and add some epoch asserts to check
for similar failures.

Test Plan

tested with mrouted and rwhod -m

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44845
Build 41733: arc lint + arc unit

Event Timeline

bz added a subscriber: bz.

Sounds reasonable to me and I like the extra asserts for documentation purposes; I always wonder if the entire ioctl paths should just acquire/release epoch but that's a totally different can of worms.

This revision is now accepted and ready to land.Mar 21 2022, 3:24 PM
cy added a subscriber: cy.