Page MenuHomeFreeBSD

Enter epoch when addding IPv4 multicast forwarding cache entry
ClosedPublic

Authored by karels on Mar 21 2022, 3:07 PM.
Tags
None
Referenced Files
F122061068: D34624.id104081.diff
Tue, Jul 1, 10:06 PM
F122043659: D34624.id.diff
Tue, Jul 1, 5:37 PM
F121991887: D34624.id104068.diff
Tue, Jul 1, 6:30 AM
Unknown Object (File)
Mon, Jun 30, 5:37 PM
Unknown Object (File)
Sat, Jun 28, 2:43 AM
Unknown Object (File)
Fri, Jun 27, 4:15 PM
Unknown Object (File)
Fri, Jun 27, 2:30 PM
Unknown Object (File)
Thu, Jun 26, 3:42 PM

Details

Summary

The code path from the IPv4 multicast setsockopt could call ip_output()
without entering an epoch. Specifically, the MRT_ADD_MFC setbsocopt
would call add_mfc(), which in turn called ip_mdq() to send queued
packets. This resulted in an epoch assert failure in ip_output().
Enter an epoch in add_mfc(), and add some epoch asserts to check
for similar failures.

Test Plan

tested with mrouted and rwhod -m

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz added a subscriber: bz.

Sounds reasonable to me and I like the extra asserts for documentation purposes; I always wonder if the entire ioctl paths should just acquire/release epoch but that's a totally different can of worms.

This revision is now accepted and ready to land.Mar 21 2022, 3:24 PM
cy added a subscriber: cy.