Page MenuHomeFreeBSD

leandro.lupori_gmail.com (Leandro Lupori)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 17 2018, 7:13 PM (65 w, 5 d)

Recent Activity

Jan 7 2019

leandro.lupori_gmail.com accepted D18777: powerpc: Fix regression introduced in r342771.

Tested on my POWER8 machine.

Jan 7 2019, 7:30 PM

Dec 10 2018

leandro.lupori_gmail.com added inline comments to D17806: ppc64: handle exception 0x1500 (soft patch).
Dec 10 2018, 2:38 PM
leandro.lupori_gmail.com added a comment to D17806: ppc64: handle exception 0x1500 (soft patch).

This panic is fairly reliable on our Power8 box. Is it related to this change or is it unrelated? I'm not convinced this panic should keep this review blocked as it resolves other things.

panic: Memory modified after free 0xc0000000850584a0(32) val=0 @ 0xc0000000850584a0
cpuid = 31
time = 1544381394
KDB: stack backtrace:
0xe000000090207030: at .kdb_backtrace+0x5c
0xe000000090207160: at .vpanic+0x1b4
0xe000000090207220: at .panic+0x38
0xe0000000902072b0: at .trash_ctor+0x58
0xe000000090207330: at .trash_fini+0x1c
0xe0000000902073b0: at .uma_zdestroy+0x164
0xe000000090207460: at .uma_zdestroy+0x42c
0xe0000000902074f0: at .sys_swapoff+0x2c4
0xe000000090207580: at .uma_zfree_pcpu_arg+0x340
0xe000000090207610: at .zone_drain+0x18
0xe000000090207690: at .uma_avail+0x4c4
0xe000000090207720: at .zone_drain+0x410
0xe0000000902077b0: at .uma_reclaim_worker+0x20c
0xe000000090207860: at .fork_exit+0xd0
0xe000000090207900: at .fork_trampoline+0x10
0xe000000090207930: at -0x4
KDB: enter: panic
Dec 10 2018, 11:51 AM

Dec 7 2018

leandro.lupori_gmail.com accepted D17806: ppc64: handle exception 0x1500 (soft patch).

Great!
Thanks for fixing the issue I left behind on this!

Dec 7 2018, 4:29 PM

Nov 1 2018

leandro.lupori_gmail.com added reviewers for D17806: ppc64: handle exception 0x1500 (soft patch): jhibbits, sbruno, nwhitehorn.
Nov 1 2018, 4:47 PM
leandro.lupori_gmail.com created D17806: ppc64: handle exception 0x1500 (soft patch).
Nov 1 2018, 4:44 PM

Oct 29 2018

leandro.lupori_gmail.com added a comment to D17601: ppc64: limited 32-bit DMA address range.

I just rebased to today's HEAD from that of the 6th. This change makes my system unbootable. I haven't delved in to it, but my guess is I don't have enough contiguous memory below the limit (my system has 512GB)

Oct 29 2018, 1:18 PM

Oct 17 2018

leandro.lupori_gmail.com updated the summary of D17601: ppc64: limited 32-bit DMA address range.
Oct 17 2018, 8:44 PM
leandro.lupori_gmail.com added reviewers for D17601: ppc64: limited 32-bit DMA address range: jhibbits, jhb, nwhitehorn.
Oct 17 2018, 8:43 PM
leandro.lupori_gmail.com created D17601: ppc64: limited 32-bit DMA address range.
Oct 17 2018, 8:40 PM

Aug 9 2018

leandro.lupori_gmail.com added a comment to D16633: [powerpc] Fix kernel panic when using "options BOOTP_NFSROOT".

Approved. A cleaner solution might be to add another SI_SUB_ node, or reuse an existing one for all cases. But this unblocks us, and is sufficient. SI_SUB_INIT_IF looks like a good one (no need to do it now).

Aug 9 2018, 1:57 PM

Aug 8 2018

leandro.lupori_gmail.com updated subscribers of D16633: [powerpc] Fix kernel panic when using "options BOOTP_NFSROOT".
Aug 8 2018, 6:45 PM
leandro.lupori_gmail.com created D16633: [powerpc] Fix kernel panic when using "options BOOTP_NFSROOT".
Aug 8 2018, 6:38 PM

May 9 2018

leandro.lupori_gmail.com added inline comments to D15372: Fix PPC symbol resolution.
May 9 2018, 9:30 PM
leandro.lupori_gmail.com updated the summary of D15372: Fix PPC symbol resolution.
May 9 2018, 9:16 PM
leandro.lupori_gmail.com created D15372: Fix PPC symbol resolution.
May 9 2018, 9:13 PM

May 7 2018

leandro.lupori_gmail.com added a comment to D15174: Fix wrong cpu0 identification.

Yes, it is working fine for me.
I tried a couple different number of CPUs, with and without usefdt, and it all worked fine.
Although for me /chosen/cpu always seems to exist, so the /chosen/fdtbootcpu part wasn't tested.

May 7 2018, 7:58 PM
leandro.lupori_gmail.com updated the diff for D15174: Fix wrong cpu0 identification.
  • Use /chosen/{cpu,fdtbootcpu} to detect boot CPU
May 7 2018, 7:48 PM
leandro.lupori_gmail.com added reviewers for D15339: Mark relocated memory region as valid: jhibbits, nwhitehorn.
May 7 2018, 4:12 PM
leandro.lupori_gmail.com updated the diff for D15339: Mark relocated memory region as valid.

Minor style fix

May 7 2018, 4:09 PM
leandro.lupori_gmail.com created D15339: Mark relocated memory region as valid.
May 7 2018, 4:05 PM
leandro.lupori_gmail.com added a comment to D15174: Fix wrong cpu0 identification.

Ok, good to know, let me try that.

May 7 2018, 3:31 PM
leandro.lupori_gmail.com added a comment to D15174: Fix wrong cpu0 identification.

We should fix that, too, though. This code assumes that we are booting on CPU 0 -- the same assumption could continue as a stopgap until we figure out a reliable way to evaluate the boot processor.

May 7 2018, 3:19 PM

Apr 25 2018

leandro.lupori_gmail.com updated subscribers of D15174: Fix wrong cpu0 identification.
Apr 25 2018, 9:41 PM
leandro.lupori_gmail.com added a comment to D15174: Fix wrong cpu0 identification.

Is there a reason not to just adopt the PowerNV version of this code, which already does the right thing?

Apr 25 2018, 9:37 PM

Apr 24 2018

leandro.lupori_gmail.com added a comment to D15174: Fix wrong cpu0 identification.

Made cpu discovery accept non-contiguous ids

Apr 24 2018, 9:14 PM
leandro.lupori_gmail.com updated the diff for D15174: Fix wrong cpu0 identification.
  • Made cpu discovery accept non-contiguous ids
Apr 24 2018, 9:12 PM

Apr 23 2018

leandro.lupori_gmail.com added reviewers for D15174: Fix wrong cpu0 identification: jhibbits, nwhitehorn, linimon.
Apr 23 2018, 7:26 PM
leandro.lupori_gmail.com created D15174: Fix wrong cpu0 identification.
Apr 23 2018, 7:22 PM

Apr 19 2018

leandro.lupori_gmail.com added a comment to D15121: Fix detection of kernel memory overlap.

Thanks @jhibbits! Can you commit the change for me?

Apr 19 2018, 2:09 PM

Apr 17 2018

leandro.lupori_gmail.com updated the diff for D15121: Fix detection of kernel memory overlap.
  • Addressing review's comments
Apr 17 2018, 9:20 PM
leandro.lupori_gmail.com added inline comments to D15121: Fix detection of kernel memory overlap.
Apr 17 2018, 9:06 PM
leandro.lupori_gmail.com added reviewers for D15121: Fix detection of kernel memory overlap: jhibbits, nwhitehorn.
Apr 17 2018, 7:50 PM
leandro.lupori_gmail.com created D15121: Fix detection of kernel memory overlap.
Apr 17 2018, 7:47 PM