Fix kvm bitmap index
AbandonedPublic
Actions

Authored by luporl on Sep 6 2019, 5:43 PM.

Tags

None

Referenced Files

	F168624233: D21554.id61745.diff
	Sat, Aug 29, 7:45 AM

	F168622628: D21554.diff
	Sat, Aug 29, 7:37 AM

	Unknown Object (File)
	Thu, Aug 20, 10:22 AM

	Unknown Object (File)
	Wed, Aug 19, 10:33 AM

	Unknown Object (File)
	Thu, Aug 13, 8:58 PM

	Unknown Object (File)
	Thu, Aug 13, 8:56 PM

	Unknown Object (File)
	Mon, Aug 3, 1:22 PM

	Unknown Object (File)
	Sun, Aug 2, 4:53 AM

View All Files

Subscribers

alfredo

Details

Reviewers

will
emaste

Summary

_kvm_bitmap_next may perform an out-of-bounds access on bm->map array.
It seems the right is to divide *idx by CHAR_BIT, instead of multiplying it.

Another thing that looks strange to me is the function returning when it finds a bit that is not set. Shouldn't it be the opposite?

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26319
Build 24798: arc lint + arc unit

Event Timeline

luporl created this revision.Sep 6 2019, 5:43 PM

Harbormaster completed remote builds in B26319: Diff 61745.Sep 6 2019, 5:43 PM

luporl added a reviewer: emaste.Dec 9 2019, 3:57 PM

luporl abandoned this revision.Jul 28 2021, 5:37 PM

emaste mentioned this in D19183: libkvm: Fix the kvm_walk_pages in amd64.Jul 28 2021, 6:31 PM

There's more that needs to be fixed here but you can go ahead and commit this change

Revision Contents
Changeset List

Path

Size

lib/

libkvm/

kvm_private.c

2 lines

Diff 61745

View Options

Fix kvm bitmap indexAbandonedPublicActions