Fix kvm bitmap index
AbandonedPublic
Actions

Authored by luporl on Sep 6 2019, 5:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 15, 10:28 AM

	Unknown Object (File)
	Fri, May 15, 4:43 AM

	Unknown Object (File)
	Wed, May 13, 6:25 PM

	Unknown Object (File)
	Tue, May 12, 6:23 AM

	Unknown Object (File)
	Thu, Apr 30, 9:58 PM

	Unknown Object (File)
	Thu, Apr 30, 12:59 PM

	Unknown Object (File)
	Thu, Apr 30, 12:00 PM

	Unknown Object (File)
	Wed, Apr 29, 11:22 PM

View All Files

Subscribers

alfredo

Details

Reviewers

will
emaste

Summary

_kvm_bitmap_next may perform an out-of-bounds access on bm->map array.
It seems the right is to divide *idx by CHAR_BIT, instead of multiplying it.

Another thing that looks strange to me is the function returning when it finds a bit that is not set. Shouldn't it be the opposite?

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26319
Build 24798: arc lint + arc unit

Event Timeline

luporl created this revision.Sep 6 2019, 5:43 PM

Harbormaster completed remote builds in B26319: Diff 61745.Sep 6 2019, 5:43 PM

luporl added a reviewer: emaste.Dec 9 2019, 3:57 PM

luporl abandoned this revision.Jul 28 2021, 5:37 PM

emaste mentioned this in D19183: libkvm: Fix the kvm_walk_pages in amd64.Jul 28 2021, 6:31 PM

There's more that needs to be fixed here but you can go ahead and commit this change

Revision Contents
Changeset List

Path

Size

lib/

libkvm/

kvm_private.c

2 lines

Diff 61745

View Options

Fix kvm bitmap indexAbandonedPublicActions