will (Will Andrews)
User

Projects

User Details

User Since
Aug 7 2014, 1:05 PM (172 w, 1 d)

Recent Activity

Sun, Nov 12

will committed rS325735: libkvm: fix lib32 build..
libkvm: fix lib32 build.
Sun, Nov 12, 3:29 AM
will committed rS325732: libkvm: fix build failures.
libkvm: fix build failures
Sun, Nov 12, 1:37 AM
will committed rS325729: libkvm: fix 'index' shadowing..
libkvm: fix 'index' shadowing.
Sun, Nov 12, 12:00 AM

Sat, Nov 11

will committed rS325728: libkvm: add kvm_walk_pages API..
libkvm: add kvm_walk_pages API.
Sat, Nov 11, 11:31 PM
will closed D12279: libkvm: add kvm_walk_pages API..
Sat, Nov 11, 11:31 PM

Mon, Oct 30

will added a comment to D12279: libkvm: add kvm_walk_pages API..

@jhb Any further feedback? Does this look ready for HEAD?

Mon, Oct 30, 7:39 PM

Oct 2 2017

will added a comment to D12279: libkvm: add kvm_walk_pages API..

On amd64, this now requires v2 minidumps (generated since 2010).

Oct 2 2017, 5:53 PM
will updated the diff for D12279: libkvm: add kvm_walk_pages API..
  • libkvm: require v2 minidumps for walk_pages on amd64.
Oct 2 2017, 5:51 PM
will added inline comments to D12279: libkvm: add kvm_walk_pages API..
Oct 2 2017, 5:26 PM
will updated the diff for D12279: libkvm: add kvm_walk_pages API..
  • libkvm: fix minor nits.
Oct 2 2017, 5:26 PM

Sep 8 2017

will added a reviewer for D12279: libkvm: add kvm_walk_pages API.: jhb.
Sep 8 2017, 7:50 PM
will updated the diff for D12279: libkvm: add kvm_walk_pages API..
  • kvm: pass up better error messages.
Sep 8 2017, 7:49 PM
will created D12279: libkvm: add kvm_walk_pages API..
Sep 8 2017, 5:13 PM

Aug 24 2017

will abandoned D12113: MFC r278479,278494,278525,278545,278592,279237,280410:.

Committed.

Aug 24 2017, 6:20 PM
will committed rS322848: MFC r278479,278494,278525,278545,278592,279237,280410:.
MFC r278479,278494,278525,278545,278592,279237,280410:
Aug 24 2017, 5:25 PM
will retitled D12113: MFC r278479,278494,278525,278545,278592,279237,280410: from MFC r278479,278494,278525,278545,278592,279237,280410 from HEAD to stable/10. to MFC r278479,278494,278525,278545,278592,279237,280410:.
Aug 24 2017, 2:26 AM
will created D12113: MFC r278479,278494,278525,278545,278592,279237,280410:.
Aug 24 2017, 12:13 AM

Jun 6 2017

will committed rS319613: tsearch_test: Test twalk & add some determinism..
tsearch_test: Test twalk & add some determinism.
Jun 6 2017, 3:40 AM

May 7 2017

will accepted D10001: Fix memory leak in vmstat.
May 7 2017, 6:19 AM
will closed D1627: vm_pageout_oom(): Allow the option (via sysctl) of panic'ing instead of killing a process when required..
May 7 2017, 6:17 AM
will abandoned D6804: libkvm: performance improvements for minidump read routines.

Committed last summer in several parts.

May 7 2017, 6:16 AM
will added a comment to D849: Improve ctfconvert handling of C++ object files..

I don't remember much of the context of this, but apparently I have some unsubmitted comments (probably made nearly 3 years ago).
IIRC, I eventually concluded that running ctfconvert on C++ was a bit of a fool's errand, since DTrace doesn't support C++ symbols, and AFAIK that hasn't changed. You have to use the mangled symbol names to dtrace C++.
I'm fine with dropping this Diff.

May 7 2017, 6:14 AM
will added a comment to D873: Send universe build log files to .OBJDIR..
In D873#216330, @emaste wrote:

What does ${.OBJDIR} expand to for individual archs in universe?

May 7 2017, 6:10 AM

Mar 16 2017

will accepted D10037: Impelemnt ttys onifexists in init..

LGTM

Mar 16 2017, 8:25 PM

Sep 13 2016

will committed rS305779: MFC r305484:.
MFC r305484:
Sep 13 2016, 7:02 PM

Sep 6 2016

will committed rS305484: loader.efi: Bump the staging size to 64M..
loader.efi: Bump the staging size to 64M.
Sep 6 2016, 5:59 PM
will added a comment to D7797: rc.d/zfsbe: a new script designed for boot environment support.
In D7797#161821, @avg wrote:
zfs list -r -o name,mountpoint,canmount rpool/ROOT/20160614
NAME                                  MOUNTPOINT                             CANMOUNT
rpool/ROOT/20160614                   /rpool/ROOT/20160614                     noauto
rpool/ROOT/20160614/usr               /rpool/ROOT/20160614/usr                    off
rpool/ROOT/20160614/usr/compat        /rpool/ROOT/20160614/usr/compat          noauto
rpool/ROOT/20160614/usr/compat/linux  /rpool/ROOT/20160614/usr/compat/linux    noauto
rpool/ROOT/20160614/usr/lib           /rpool/ROOT/20160614/usr/lib                off
rpool/ROOT/20160614/usr/lib/debug     /rpool/ROOT/20160614/usr/lib/debug       noauto
rpool/ROOT/20160614/usr/local         /rpool/ROOT/20160614/usr/local           noauto
rpool/ROOT/20160614/usr/local/etc     /rpool/ROOT/20160614/usr/local/etc       noauto
Sep 6 2016, 3:34 PM
will added a comment to D7797: rc.d/zfsbe: a new script designed for boot environment support.
In D7797#161802, @avg wrote:

No difference whatsoever in that case.

Sep 6 2016, 3:05 PM
will added a comment to D7797: rc.d/zfsbe: a new script designed for boot environment support.

Looks good, though it might be helpful to include an explanation of what issue this is intended to address, or new feature this is intended to implement. I remember you telling me about this once, but it's been probably at least a year. I think it makes BEs more self-contained, but if they are single filesystems, what difference does it make?

Sep 6 2016, 2:08 PM

Jul 18 2016

will committed rS302977: Add my beinstall script..
Add my beinstall script.
Jul 18 2016, 2:14 AM
will committed rS302976: libkvm: Improve physical address lookup scaling..
libkvm: Improve physical address lookup scaling.
Jul 18 2016, 1:55 AM
will committed rS302975: libkvm: Bounds check (more) PTE indices..
libkvm: Bounds check (more) PTE indices.
Jul 18 2016, 1:03 AM
will committed rS302974: libkvm: Put private kvm routines in kvm_private.c..
libkvm: Put private kvm routines in kvm_private.c.
Jul 18 2016, 1:03 AM

Jun 21 2016

will abandoned D6900: Allow geom_part schemes to have a different default # entries than minimum..

gpart currently doesn't support MBR with gpart add -t efi. You have to say -t '!239' instead.

Jun 21 2016, 9:44 PM

Jun 20 2016

will updated D6900: Allow geom_part schemes to have a different default # entries than minimum..
Jun 20 2016, 7:11 PM
will retitled D6900: Allow geom_part schemes to have a different default # entries than minimum. from to Allow geom_part schemes to have a different default # entries than minimum..
Jun 20 2016, 7:06 PM

Jun 17 2016

will added a comment to D6783: libefi don't use TERM_EMU on arm.

Never mind, I applied the patch against a slightly older version of head.

Jun 17 2016, 2:14 AM
will added a comment to D6783: libefi don't use TERM_EMU on arm.

I don't see how this patch is supposed to work when efi_console.c:CD() requires curx/cury, but is not protected by #ifdef TERM_EMU.

Jun 17 2016, 2:09 AM

Jun 11 2016

will retitled D6804: libkvm: performance improvements for minidump read routines from to libkvm: performance improvements for minidump read routines.
Jun 11 2016, 1:20 AM

Jan 5 2016

will updated subscribers of D4515: ZFS EFI Boot Support #2.
Jan 5 2016, 9:26 PM
will updated subscribers of D4104: ZFS EFI Boot Support.
Jan 5 2016, 6:58 PM
will updated subscribers of D4797: add beastie support for loader.efi.
Jan 5 2016, 6:57 PM

Dec 31 2015

will added a comment to D3163: em(4): Add Skylake/I219 support..

I have a Skylake system with an onboard I219-V port. Would be happy to test, if needed.

Dec 31 2015, 1:06 AM

Jun 23 2015

will accepted D2865: zfs_mount(MS_REMOUNT): protect zfs_(un)register_callbacks calls.

LGTM.

Jun 23 2015, 3:59 PM

May 18 2015

will added a comment to D2466: lang/rust: Use LLVM from ports + cleanups.

Why are they required? What's the difference between Poudriere and a plain FreeBSD?

May 18 2015, 8:10 PM

May 17 2015

will added a comment to D2466: lang/rust: Use LLVM from ports + cleanups.

My version of this patch (before I knew anyone else was looking) has a few extra changes:

  • Use REINPLACE_CMD instead of patching curl/wget & forced-clang in configure. This is (still) required to pass poudriere builds.
  • Run the unit test suite, i.e. "gmake check".
  • Enable & ship the docs -- I determined that they only add a few % extra size, so they should at least be supported via PORTDOCS.
  • Set VERBOSE=1 unconditionally; its behavior is more like how FreeBSD usually builds things.
May 17 2015, 4:28 AM

Apr 6 2015

will added a comment to D874: Better sandbox 'make universe' targets to within the same tree that everything else uses, i.e. ${MAKEOBJDIRPREFIX}${.CURDIR}..

This seems to work ok (my test VM ran out of space before finishing 'make universe', but several non-x86 ARCHes built OK). Thoughts?

Apr 6 2015, 1:36 PM

Apr 4 2015

will updated the diff for D874: Better sandbox 'make universe' targets to within the same tree that everything else uses, i.e. ${MAKEOBJDIRPREFIX}${.CURDIR}..

Updated version against head/Makefile.inc1@281050.

Apr 4 2015, 12:11 AM

Mar 30 2015

will added a comment to D874: Better sandbox 'make universe' targets to within the same tree that everything else uses, i.e. ${MAKEOBJDIRPREFIX}${.CURDIR}..

I'll put together an updated patch tomorrow.

Mar 30 2015, 4:13 AM

Mar 24 2015

will added a comment to D2130: Unmout devfs when killing a jail..

As noted by others, this patch unmounts more than just the devfs filesystem. Which is fine, since it serves the purpose. Jail shutdown should clean up all resources associated with it.

Mar 24 2015, 9:24 PM
will added a comment to D2130: Unmout devfs when killing a jail..

The concept and mechanism look good to me, however I see a few potential issues:

Mar 24 2015, 9:14 PM

Feb 20 2015

will accepted D1881: Allow Illumos code to co-exist with nv(9).

Ok, LGTM. Thanks for your effort!

Feb 20 2015, 4:14 AM

Feb 19 2015

will added a comment to D1881: Allow Illumos code to co-exist with nv(9).
In D1881#9, @rstone wrote:

The primary testing that I did was to ensure that a kernel with "device zfs" would still link. However, I suppose that doesn't exclude the possibility of their being an zfs source file that is built wrong and doesn't include this header. Is there a zfs test suite that I could run?

Feb 19 2015, 12:37 AM

Feb 18 2015

will updated subscribers of D1881: Allow Illumos code to co-exist with nv(9).

What testing has been done with this change?

Feb 18 2015, 10:18 PM

Jan 23 2015

will retitled D1627: vm_pageout_oom(): Allow the option (via sysctl) of panic'ing instead of killing a process when required. from to vm_pageout_oom(): Allow the option (via sysctl) of panic'ing instead of killing a process when required..
Jan 23 2015, 11:46 PM
will retitled D1626: Add iostat-like NFS server statistics from to Add iostat-like NFS server statistics .
Jan 23 2015, 11:15 PM

Dec 29 2014

will accepted D844: Update ELF headers to include additional defines..
In D844#15, @emaste wrote:

Remove Linux NT_ types for now, pending a better compat implementation
Remove ARM and MIPS constants now defined in elf_common from arch-dependent files

Dec 29 2014, 9:54 PM

Dec 17 2014

will added a comment to D844: Update ELF headers to include additional defines..

Ed asked me to post an update about this revision.

Dec 17 2014, 9:35 PM
will closed D1326: Initialize an argument to NULL instead of expecting dlinfo() to do it..

Closed by commit rS275845 (authored by @will).

Dec 17 2014, 12:22 AM

Dec 16 2014

will closed D1321: Make NanoBSD source-able from other scripts..

Closed by commit rS275832 (authored by @will).

Dec 16 2014, 5:59 PM
will added a comment to D1321: Make NanoBSD source-able from other scripts..

That's true, but the point of the change is merely to enable reuse, not necessarily to make any sort of API guarantee.

Dec 16 2014, 5:39 PM
will closed D796: Root the lib32 object tree under the overall object tree..

This was committed a while ago.

Dec 16 2014, 2:54 PM
will retitled D1326: Initialize an argument to NULL instead of expecting dlinfo() to do it. from to Initialize an argument to NULL instead of expecting dlinfo() to do it..
Dec 16 2014, 2:48 PM
will added a comment to D1321: Make NanoBSD source-able from other scripts..

The motivation is primarily to enable using NanoBSD within another script. This can be useful for sharing configuration data, for example.

Dec 16 2014, 2:13 PM
will retitled D1321: Make NanoBSD source-able from other scripts. from to Make NanoBSD source-able from other scripts..
Dec 16 2014, 3:21 AM

Oct 3 2014

will added a comment to D891: hook up DTrace's userland CTF support.

I don't feel I know enough about this area to judge it ready, but it looks fine to me.

Oct 3 2014, 7:23 PM

Sep 30 2014

will added a comment to D844: Update ELF headers to include additional defines..

To clarify, the initial submission was primarily on a 'does this make sense to do here?' basis, not on a 'is this ready to commit?' basis.

Sep 30 2014, 1:43 PM
will added a comment to D844: Update ELF headers to include additional defines..

I have more updates for this change forthcoming. To answer the question, yes -- these #define's are taken as is from elftoolchain. I do assume they're correct; if not, they can be fixed in a later revision.

Sep 30 2014, 1:42 PM

Sep 29 2014

will retitled D874: Better sandbox 'make universe' targets to within the same tree that everything else uses, i.e. ${MAKEOBJDIRPREFIX}${.CURDIR}. from to Better sandbox 'make universe' targets to within the same tree that everything else uses, i.e. ${MAKEOBJDIRPREFIX}${.CURDIR}..
Sep 29 2014, 11:56 PM
will retitled D873: Send universe build log files to .OBJDIR. from to Send universe build log files to .OBJDIR..
Sep 29 2014, 11:54 PM
will closed D799: Incorporate a search mechanism for PORTSDIR..

Committed in r272282.

Sep 29 2014, 3:09 PM

Sep 26 2014

will updated the diff for D799: Incorporate a search mechanism for PORTSDIR..

Updated with a comment and ../../.. check in case ports grows a third level.

Sep 26 2014, 9:25 PM
will updated the diff for D799: Incorporate a search mechanism for PORTSDIR..

Updated version that doesn't use a shell callout.

Sep 26 2014, 9:20 PM
will retitled D849: Improve ctfconvert handling of C++ object files. from to Improve ctfconvert handling of C++ object files..
Sep 26 2014, 8:42 PM
will retitled D844: Update ELF headers to include additional defines. from to Update ELF headers to include additional defines..
Sep 26 2014, 3:25 PM
will added a comment to D799: Incorporate a search mechanism for PORTSDIR..

I could change this to use make conditionals instead and to explicitly check only .. and ../.. since those are the only reasonable cases really supported by ports right now.

Sep 26 2014, 3:20 PM

Sep 18 2014

will added a comment to D796: Root the lib32 object tree under the overall object tree..

Oops, meant to submit 1684 against D799.

Sep 18 2014, 6:50 PM
will updated the diff for D799: Incorporate a search mechanism for PORTSDIR..

Version with bsd.port.subdir.mk also adjusted.

Sep 18 2014, 6:48 PM
will updated the diff for D796: Root the lib32 object tree under the overall object tree..
Sep 18 2014, 6:48 PM
will retitled D799: Incorporate a search mechanism for PORTSDIR. from to Incorporate a search mechanism for PORTSDIR..
Sep 18 2014, 3:08 PM
will retitled D796: Root the lib32 object tree under the overall object tree. from to Root the lib32 object tree under the overall object tree..
Sep 18 2014, 12:59 AM