- User Since
- Aug 7 2014, 1:05 PM (154 w, 5 d)
Jun 6 2017
May 7 2017
Committed last summer in several parts.
I don't remember much of the context of this, but apparently I have some unsubmitted comments (probably made nearly 3 years ago).
IIRC, I eventually concluded that running ctfconvert on C++ was a bit of a fool's errand, since DTrace doesn't support C++ symbols, and AFAIK that hasn't changed. You have to use the mangled symbol names to dtrace C++.
I'm fine with dropping this Diff.
Mar 16 2017
Sep 13 2016
Sep 6 2016
Looks good, though it might be helpful to include an explanation of what issue this is intended to address, or new feature this is intended to implement. I remember you telling me about this once, but it's been probably at least a year. I think it makes BEs more self-contained, but if they are single filesystems, what difference does it make?
Jul 18 2016
Jun 21 2016
gpart currently doesn't support MBR with gpart add -t efi. You have to say -t '!239' instead.
Jun 20 2016
Jun 17 2016
Never mind, I applied the patch against a slightly older version of head.
I don't see how this patch is supposed to work when efi_console.c:CD() requires curx/cury, but is not protected by #ifdef TERM_EMU.
Jun 11 2016
Jan 5 2016
Dec 31 2015
I have a Skylake system with an onboard I219-V port. Would be happy to test, if needed.
Jun 23 2015
May 18 2015
May 17 2015
My version of this patch (before I knew anyone else was looking) has a few extra changes:
- Use REINPLACE_CMD instead of patching curl/wget & forced-clang in configure. This is (still) required to pass poudriere builds.
- Run the unit test suite, i.e. "gmake check".
- Enable & ship the docs -- I determined that they only add a few % extra size, so they should at least be supported via PORTDOCS.
- Set VERBOSE=1 unconditionally; its behavior is more like how FreeBSD usually builds things.
Apr 6 2015
This seems to work ok (my test VM ran out of space before finishing 'make universe', but several non-x86 ARCHes built OK). Thoughts?
Apr 4 2015
Updated version against head/Makefile.inc1@281050.
Mar 30 2015
I'll put together an updated patch tomorrow.
Mar 24 2015
As noted by others, this patch unmounts more than just the devfs filesystem. Which is fine, since it serves the purpose. Jail shutdown should clean up all resources associated with it.
The concept and mechanism look good to me, however I see a few potential issues:
Feb 20 2015
Ok, LGTM. Thanks for your effort!
Feb 19 2015
Feb 18 2015
What testing has been done with this change?
Jan 23 2015
Dec 29 2014
Dec 17 2014
Ed asked me to post an update about this revision.
Dec 16 2014
That's true, but the point of the change is merely to enable reuse, not necessarily to make any sort of API guarantee.
This was committed a while ago.
The motivation is primarily to enable using NanoBSD within another script. This can be useful for sharing configuration data, for example.
Oct 3 2014
I don't feel I know enough about this area to judge it ready, but it looks fine to me.
Sep 30 2014
To clarify, the initial submission was primarily on a 'does this make sense to do here?' basis, not on a 'is this ready to commit?' basis.
I have more updates for this change forthcoming. To answer the question, yes -- these #define's are taken as is from elftoolchain. I do assume they're correct; if not, they can be fixed in a later revision.
Sep 29 2014
Committed in r272282.
Sep 26 2014
Updated with a comment and ../../.. check in case ports grows a third level.
Updated version that doesn't use a shell callout.
I could change this to use make conditionals instead and to explicitly check only .. and ../.. since those are the only reasonable cases really supported by ports right now.
Sep 18 2014
Oops, meant to submit 1684 against D799.
Version with bsd.port.subdir.mk also adjusted.