will (Will Andrews)
User

Projects

User Details

User Since
Aug 7 2014, 1:05 PM (210 w, 5 d)

Recent Activity

Yesterday

will accepted D16785: Move all devfs related files to sbin/devfs/.
Tue, Aug 21, 9:19 PM
will added a comment to D16785: Move all devfs related files to sbin/devfs/.

It is not clear from the diff, does this change include deleting etc/defaults/* as well?

Tue, Aug 21, 8:03 PM
will accepted D16833: Move all bluetooth related config files out of etc/.
Tue, Aug 21, 7:10 PM
will added inline comments to D16833: Move all bluetooth related config files out of etc/.
Tue, Aug 21, 6:44 PM
will accepted D16781: Move all devd related configs to sbin/devd/.
Tue, Aug 21, 2:06 AM

Mon, Aug 20

will committed rS338103: iostat: update man page for r277566.
iostat: update man page for r277566
Mon, Aug 20, 1:42 PM

Sun, Aug 19

will added a comment to D16785: Move all devfs related files to sbin/devfs/.
In D16785#357262, @brd wrote:
In D16785#357233, @will wrote:

Sorta weird to set an empty FILES=, perhaps bluetooth.device.conf should be moved first, so this file can be moved along with deleting the etc/defaults directory altogether.

We do it in many places already, is it worth worrying about for a few days until the other move happens? The bluetooth move is a relatively bigger move so I was waiting a bit for that.

Sun, Aug 19, 8:48 AM
will added inline comments to D16781: Move all devd related configs to sbin/devd/.
Sun, Aug 19, 8:44 AM

Sat, Aug 18

will added a comment to D16770: Move dot.profile dot.cshrc to bin/sh/ and bin/csh/.

@rgrimes A lot of your questions would be resolved by reviewing how CONFS works in share/mk/bsd.confs.mk and its dependencies.

Sat, Aug 18, 9:48 PM
will accepted D16742: Create a manual page for beinstall.8.

This looks good to me.

Sat, Aug 18, 9:27 PM
will requested changes to D16781: Move all devd related configs to sbin/devd/.
Sat, Aug 18, 9:23 PM
will accepted D16783: Move all syslog related confs to usr.sbin/syslogd/.
Sat, Aug 18, 9:22 PM
will added a comment to D16785: Move all devfs related files to sbin/devfs/.

Sorta weird to set an empty FILES=, perhaps bluetooth.device.conf should be moved first, so this file can be moved along with deleting the etc/defaults directory altogether.

Sat, Aug 18, 9:04 PM
will accepted D16786: Move crontab to usr.sbin/cron/cron/.
Sat, Aug 18, 9:01 PM
will accepted D16787: Move ftpusers to libexec/ftpd/.
Sat, Aug 18, 9:01 PM

Fri, Aug 17

will accepted D16728: Move master.passwd to lib/libc/gen/.
Fri, Aug 17, 2:37 PM

Thu, Aug 16

will accepted D16742: Create a manual page for beinstall.8.
In D16742#356017, @0mp wrote:

Alright, those are fair reasons, @will.

I guess that the main reason of creating a manual page for beinstall.sh is having it show up search browsers and manpage browsers like http://man.freebsd.org/. Having a manpage for a command makes it more discoverable.

If you find this argument strong enough to install this manpage then we might consider committing these changes. Otherwise we should probably abandon this revision.

Thu, Aug 16, 1:22 PM
will added a comment to D16742: Create a manual page for beinstall.8.

Hi Mateusz,

Thu, Aug 16, 12:01 PM

Wed, Aug 15

will accepted D16737: Partially revert r337849 and r337857.
Wed, Aug 15, 11:16 PM
will accepted D16728: Move master.passwd to lib/libc/gen/.
Wed, Aug 15, 9:08 PM
will accepted D16729: Fix nuking .cshrc accidentially.
Wed, Aug 15, 9:08 PM
will accepted D16725: Fix links install for bin/csh and bin/sh.
Wed, Aug 15, 4:18 PM
will accepted D16708: Move all shell related files to bin/sh/ and bin/csh/.
Wed, Aug 15, 2:10 PM
will committed rS337840: zfs: add ztest to the kyua test suite..
zfs: add ztest to the kyua test suite.
Wed, Aug 15, 1:05 PM

Tue, Aug 14

will requested changes to D16708: Move all shell related files to bin/sh/ and bin/csh/.

Issues using LINKS, on cursory inspection.

Tue, Aug 14, 8:57 PM

Sat, Aug 4

will accepted D16553: Move all periodic scripts from etc/ to usr.sbin/periodic/.
Sat, Aug 4, 12:21 AM
will accepted D16554: Move portsnap.conf to usr.sbin/portsnap/portsnap/.
Sat, Aug 4, 12:19 AM
will accepted D16556: Move freebsd-update.conf to usr.sbin/freebsd-update/.
Sat, Aug 4, 12:19 AM
will accepted D16557: Move pf.os to sbin/pfctl/.
Sat, Aug 4, 12:19 AM
will accepted D16558: Move minfree to sbin/savecore.
Sat, Aug 4, 12:18 AM
will accepted D16559: Move sysctl.conf to sbin/sysctl/.
Sat, Aug 4, 12:16 AM
will accepted D16560: Move cron.d/at to usr.bin/at.
Sat, Aug 4, 12:15 AM

Wed, Aug 1

will accepted D16492: Move autofs related configs to usr.sbin/autofs.

LGTM.

Wed, Aug 1, 4:58 PM

Sun, Jul 29

will accepted D16495: Fix typo that prevents some init scripts from being installed.
Sun, Jul 29, 3:17 AM
will committed rS336856: beinstall: perform pre-installworld steps..
beinstall: perform pre-installworld steps.
Sun, Jul 29, 1:44 AM

Sat, Jul 28

will accepted D16490: Move nscd.conf from etc/ to usr.sbin/nscd/.
Sat, Jul 28, 11:28 PM
will accepted D16466: Move most startup scripts from etc/ to sbin/init/ and switch to CONFS.

Assuming:

  • The purpose of this particular change is to move only those things that would move to sbin/init. (Answer to my earlier question.)
  • You've tested this specific change. (I'm sure I've tested a similar version...)
Sat, Jul 28, 4:58 PM
will added inline comments to D16466: Move most startup scripts from etc/ to sbin/init/ and switch to CONFS.
Sat, Jul 28, 4:38 PM
will accepted D16467: Move etc/shells to lib/libc/gen/shells.
Sat, Jul 28, 4:36 PM
will added a comment to D16467: Move etc/shells to lib/libc/gen/shells.

Summarizing discussion:

  • chpass is the program that implements chsh which modifies /etc/shells, so it makes sense to install with this program.
  • However, one could, strictly speaking, choose not to install chpass on a system, either because it will never update the shells list, or they edit it through other means.
  • Additionally, /etc/shells is read by getusershell(3) in libc, which _is_ required by some programs, in particular su(1). So it could make more sense to install this file with libc instead.
Sat, Jul 28, 4:31 PM
will added a comment to D16476: Handle a bug with install(1) -C and /dev/null.

This seems like a bug that should be fixed in install(1), not here. It's unclear from the description what the actual bug is.

Sat, Jul 28, 3:16 PM

Jul 4 2018

will committed rS335928: Revert r335833..
Revert r335833.
Jul 4 2018, 3:37 AM

Jul 1 2018

will accepted D16081: tools/build/beinstall.sh: Use some slightly better shell syntax; reduce duplication.

Looks good to me, assuming you've tested this.

Jul 1 2018, 4:33 AM
will committed rS335835: pf(4): remove reference to non-existent pflow(4)..
pf(4): remove reference to non-existent pflow(4).
Jul 1 2018, 1:56 AM
will committed rS335833: pf: remove unused ioctls..
pf: remove unused ioctls.
Jul 1 2018, 1:16 AM
will closed D16076: pf: remove unused ioctls..
Jul 1 2018, 1:16 AM
will committed rS335832: Rather belatedly add myself to committers-src.dot..
Rather belatedly add myself to committers-src.dot.
Jul 1 2018, 1:11 AM
will committed rS335831: beinstall: enable use with git worktrees..
beinstall: enable use with git worktrees.
Jul 1 2018, 1:10 AM

Jun 30 2018

will created D16076: pf: remove unused ioctls..
Jun 30 2018, 6:14 PM

Feb 14 2018

will added a comment to D12685: Make ipfw dynamic states lockless on fast path.

Hi, just a quick question.

Feb 14 2018, 8:40 PM

Feb 3 2018

will created D14181: xinstall: add -P/-F to create parent directories..
Feb 3 2018, 1:32 AM

Jan 15 2018

will abandoned D849: Improve ctfconvert handling of C++ object files..

Dropping this for lack of interest.

Jan 15 2018, 11:52 PM

Jan 3 2018

will added a comment to D13529: Change default version of samba to 4.6.

Hi, @mat experience also bit me, running FreeBSD-head (last update 12/18/2017). The pkg package itself is 1.10.3_1. I do not get a REMOVED section. I only have the FreeBSD repository configured.

Jan 3 2018, 7:27 PM

Nov 12 2017

will committed rS325735: libkvm: fix lib32 build..
libkvm: fix lib32 build.
Nov 12 2017, 3:29 AM
will committed rS325732: libkvm: fix build failures.
libkvm: fix build failures
Nov 12 2017, 1:37 AM
will committed rS325729: libkvm: fix 'index' shadowing..
libkvm: fix 'index' shadowing.
Nov 12 2017, 12:00 AM

Nov 11 2017

will committed rS325728: libkvm: add kvm_walk_pages API..
libkvm: add kvm_walk_pages API.
Nov 11 2017, 11:31 PM
will closed D12279: libkvm: add kvm_walk_pages API..
Nov 11 2017, 11:31 PM

Oct 30 2017

will added a comment to D12279: libkvm: add kvm_walk_pages API..

@jhb Any further feedback? Does this look ready for HEAD?

Oct 30 2017, 7:39 PM

Oct 2 2017

will added a comment to D12279: libkvm: add kvm_walk_pages API..

On amd64, this now requires v2 minidumps (generated since 2010).

Oct 2 2017, 5:53 PM
will updated the diff for D12279: libkvm: add kvm_walk_pages API..
  • libkvm: require v2 minidumps for walk_pages on amd64.
Oct 2 2017, 5:51 PM
will added inline comments to D12279: libkvm: add kvm_walk_pages API..
Oct 2 2017, 5:26 PM
will updated the diff for D12279: libkvm: add kvm_walk_pages API..
  • libkvm: fix minor nits.
Oct 2 2017, 5:26 PM

Sep 8 2017

will added a reviewer for D12279: libkvm: add kvm_walk_pages API.: jhb.
Sep 8 2017, 7:50 PM
will updated the diff for D12279: libkvm: add kvm_walk_pages API..
  • kvm: pass up better error messages.
Sep 8 2017, 7:49 PM
will created D12279: libkvm: add kvm_walk_pages API..
Sep 8 2017, 5:13 PM

Aug 24 2017

will abandoned D12113: MFC r278479,278494,278525,278545,278592,279237,280410:.

Committed.

Aug 24 2017, 6:20 PM
will committed rS322848: MFC r278479,278494,278525,278545,278592,279237,280410:.
MFC r278479,278494,278525,278545,278592,279237,280410:
Aug 24 2017, 5:25 PM
will retitled D12113: MFC r278479,278494,278525,278545,278592,279237,280410: from MFC r278479,278494,278525,278545,278592,279237,280410 from HEAD to stable/10. to MFC r278479,278494,278525,278545,278592,279237,280410:.
Aug 24 2017, 2:26 AM
will created D12113: MFC r278479,278494,278525,278545,278592,279237,280410:.
Aug 24 2017, 12:13 AM

Jun 6 2017

will committed rS319613: tsearch_test: Test twalk & add some determinism..
tsearch_test: Test twalk & add some determinism.
Jun 6 2017, 3:40 AM

May 7 2017

will accepted D10001: Fix memory leak in vmstat.
May 7 2017, 6:19 AM
will closed D1627: vm_pageout_oom(): Allow the option (via sysctl) of panic'ing instead of killing a process when required..
May 7 2017, 6:17 AM
will abandoned D6804: libkvm: performance improvements for minidump read routines.

Committed last summer in several parts.

May 7 2017, 6:16 AM
will added a comment to D849: Improve ctfconvert handling of C++ object files..

I don't remember much of the context of this, but apparently I have some unsubmitted comments (probably made nearly 3 years ago).
IIRC, I eventually concluded that running ctfconvert on C++ was a bit of a fool's errand, since DTrace doesn't support C++ symbols, and AFAIK that hasn't changed. You have to use the mangled symbol names to dtrace C++.
I'm fine with dropping this Diff.

May 7 2017, 6:14 AM
will added a comment to D873: Send universe build log files to .OBJDIR..
In D873#216330, @emaste wrote:

What does ${.OBJDIR} expand to for individual archs in universe?

May 7 2017, 6:10 AM

Mar 16 2017

will accepted D10037: Impelemnt ttys onifexists in init..

LGTM

Mar 16 2017, 8:25 PM

Sep 13 2016

will committed rS305779: MFC r305484:.
MFC r305484:
Sep 13 2016, 7:02 PM

Sep 6 2016

will committed rS305484: loader.efi: Bump the staging size to 64M..
loader.efi: Bump the staging size to 64M.
Sep 6 2016, 5:59 PM
will added a comment to D7797: rc.d/zfsbe: a new script designed for boot environment support.
In D7797#161821, @avg wrote:
zfs list -r -o name,mountpoint,canmount rpool/ROOT/20160614
NAME                                  MOUNTPOINT                             CANMOUNT
rpool/ROOT/20160614                   /rpool/ROOT/20160614                     noauto
rpool/ROOT/20160614/usr               /rpool/ROOT/20160614/usr                    off
rpool/ROOT/20160614/usr/compat        /rpool/ROOT/20160614/usr/compat          noauto
rpool/ROOT/20160614/usr/compat/linux  /rpool/ROOT/20160614/usr/compat/linux    noauto
rpool/ROOT/20160614/usr/lib           /rpool/ROOT/20160614/usr/lib                off
rpool/ROOT/20160614/usr/lib/debug     /rpool/ROOT/20160614/usr/lib/debug       noauto
rpool/ROOT/20160614/usr/local         /rpool/ROOT/20160614/usr/local           noauto
rpool/ROOT/20160614/usr/local/etc     /rpool/ROOT/20160614/usr/local/etc       noauto
Sep 6 2016, 3:34 PM
will added a comment to D7797: rc.d/zfsbe: a new script designed for boot environment support.
In D7797#161802, @avg wrote:

No difference whatsoever in that case.

Sep 6 2016, 3:05 PM
will added a comment to D7797: rc.d/zfsbe: a new script designed for boot environment support.

Looks good, though it might be helpful to include an explanation of what issue this is intended to address, or new feature this is intended to implement. I remember you telling me about this once, but it's been probably at least a year. I think it makes BEs more self-contained, but if they are single filesystems, what difference does it make?

Sep 6 2016, 2:08 PM

Jul 18 2016

will committed rS302977: Add my beinstall script..
Add my beinstall script.
Jul 18 2016, 2:14 AM
will committed rS302976: libkvm: Improve physical address lookup scaling..
libkvm: Improve physical address lookup scaling.
Jul 18 2016, 1:55 AM
will committed rS302975: libkvm: Bounds check (more) PTE indices..
libkvm: Bounds check (more) PTE indices.
Jul 18 2016, 1:03 AM
will committed rS302974: libkvm: Put private kvm routines in kvm_private.c..
libkvm: Put private kvm routines in kvm_private.c.
Jul 18 2016, 1:03 AM

Jun 21 2016

will abandoned D6900: Allow geom_part schemes to have a different default # entries than minimum..

gpart currently doesn't support MBR with gpart add -t efi. You have to say -t '!239' instead.

Jun 21 2016, 9:44 PM

Jun 20 2016

will updated D6900: Allow geom_part schemes to have a different default # entries than minimum..
Jun 20 2016, 7:11 PM
will retitled D6900: Allow geom_part schemes to have a different default # entries than minimum. from to Allow geom_part schemes to have a different default # entries than minimum..
Jun 20 2016, 7:06 PM

Jun 17 2016

will added a comment to D6783: libefi don't use TERM_EMU on arm.

Never mind, I applied the patch against a slightly older version of head.

Jun 17 2016, 2:14 AM
will added a comment to D6783: libefi don't use TERM_EMU on arm.

I don't see how this patch is supposed to work when efi_console.c:CD() requires curx/cury, but is not protected by #ifdef TERM_EMU.

Jun 17 2016, 2:09 AM

Jun 11 2016

will retitled D6804: libkvm: performance improvements for minidump read routines from to libkvm: performance improvements for minidump read routines.
Jun 11 2016, 1:20 AM

Jan 5 2016

will updated subscribers of D4515: ZFS EFI Boot Support #2.
Jan 5 2016, 9:26 PM
will updated subscribers of D4104: ZFS EFI Boot Support.
Jan 5 2016, 6:58 PM
will updated subscribers of D4797: add beastie support for loader.efi.
Jan 5 2016, 6:57 PM

Dec 31 2015

will added a comment to D3163: em(4): Add Skylake/I219 support..

I have a Skylake system with an onboard I219-V port. Would be happy to test, if needed.

Dec 31 2015, 1:06 AM

Jun 23 2015

will accepted D2865: zfs_mount(MS_REMOUNT): protect zfs_(un)register_callbacks calls.

LGTM.

Jun 23 2015, 3:59 PM

May 18 2015

will added a comment to D2466: lang/rust: Use LLVM from ports + cleanups.

Why are they required? What's the difference between Poudriere and a plain FreeBSD?

May 18 2015, 8:10 PM

May 17 2015

will added a comment to D2466: lang/rust: Use LLVM from ports + cleanups.

My version of this patch (before I knew anyone else was looking) has a few extra changes:

  • Use REINPLACE_CMD instead of patching curl/wget & forced-clang in configure. This is (still) required to pass poudriere builds.
  • Run the unit test suite, i.e. "gmake check".
  • Enable & ship the docs -- I determined that they only add a few % extra size, so they should at least be supported via PORTDOCS.
  • Set VERBOSE=1 unconditionally; its behavior is more like how FreeBSD usually builds things.
May 17 2015, 4:28 AM

Apr 6 2015

will added a comment to D874: Better sandbox 'make universe' targets to within the same tree that everything else uses, i.e. ${MAKEOBJDIRPREFIX}${.CURDIR}..

This seems to work ok (my test VM ran out of space before finishing 'make universe', but several non-x86 ARCHes built OK). Thoughts?

Apr 6 2015, 1:36 PM