Page MenuHomeFreeBSD

Move device.hints install into stand
AcceptedPublic

Authored by brd on Sep 20 2018, 9:16 AM.

Details

Reviewers
bapt
will
Test Plan

Compare the results of make distribution

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 19693
Build 19258: arc lint + arc unit

Event Timeline

brd created this revision.Sep 20 2018, 9:16 AM
bapt accepted this revision.Sep 20 2018, 1:51 PM
This revision is now accepted and ready to land.Sep 20 2018, 1:51 PM
imp added a comment.Sep 20 2018, 4:47 PM

I really dislike this. It's not really a stand thing, and the GENERIC assumption is weak. We should be linking it to the installed kernel's hints, which maybe we should be installing into /boot/kernel when we install it.
It's always been an ugly wart on the side of things since it was introduced in FreeBSD 4.

brd added a comment.Sep 21 2018, 7:46 AM

@imp That probably requires more work.. do we want to bite that off before 12.0? Or should I do this for now and then we fix it properly after 12.0?

will added a comment.Sep 29 2018, 2:17 AM

@imp re the GENERIC linkage, note the original code only references GENERIC. However, a different location might be more appropriate, given this file is normally installed in /boot.