Move device.hints install into stand
AcceptedPublic
Actions

Authored by brd on Sep 20 2018, 9:16 AM.

Tags

None

Referenced Files

	F165146064: D17256.diff
	Thu, Aug 6, 9:45 AM

	Unknown Object (File)
	Mon, Aug 3, 9:13 AM

	Unknown Object (File)
	Sun, Aug 2, 2:53 AM

	Unknown Object (File)
	Wed, Jul 22, 11:52 PM

	Unknown Object (File)
	Jun 30 2026, 10:30 AM

	Unknown Object (File)
	Jun 29 2026, 9:35 AM

	Unknown Object (File)
	May 19 2026, 10:41 AM

	Unknown Object (File)
	May 18 2026, 5:56 PM

View All Files

Subscribers

imp

Details

Reviewers

bapt
will

Test Plan

Compare the results of make distribution

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19693
Build 19258: arc lint + arc unit

Event Timeline

brd created this revision.Sep 20 2018, 9:16 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 20 2018, 9:16 AM

Harbormaster completed remote builds in B19693: Diff 48254.Sep 20 2018, 9:16 AM

bapt accepted this revision.Sep 20 2018, 1:51 PM

This revision is now accepted and ready to land.Sep 20 2018, 1:51 PM

I really dislike this. It's not really a stand thing, and the GENERIC assumption is weak. We should be linking it to the installed kernel's hints, which maybe we should be installing into /boot/kernel when we install it.
It's always been an ugly wart on the side of things since it was introduced in FreeBSD 4.

@imp That probably requires more work.. do we want to bite that off before 12.0? Or should I do this for now and then we fix it properly after 12.0?

@imp ping?

@imp re the GENERIC linkage, note the original code only references GENERIC. However, a different location might be more appropriate, given this file is normally installed in /boot.