Page MenuHomeFreeBSD

Move regdomain.xml to sbin/ifconfig/
ClosedPublic

Authored by brd on Sep 18 2018, 8:59 PM.

Details

Test Plan

Test by comparing the results of make distribution

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

brd created this revision.Sep 18 2018, 8:59 PM
will requested changes to this revision.Sep 18 2018, 10:15 PM
will added inline comments.
sbin/ifconfig/Makefile
6 ↗(On Diff #48191)

The original file has a MK_WIRELESS requirement, but sbin/ifconfig does not.

This file is actually referenced by lib/lib80211 instead, why not move there?

This revision now requires changes to proceed.Sep 18 2018, 10:15 PM
will added a comment.Sep 18 2018, 10:16 PM

FWIW, since lib80211 does not have an MK_WIRELESS exclusion, I don't think it makes sense to require it, but I do think it makes sense to ship with that library instead of ifconfig.

brd updated this revision to Diff 48198.Sep 19 2018, 2:30 AM

Move to lib80211

will accepted this revision.Sep 19 2018, 2:39 AM
This revision is now accepted and ready to land.Sep 19 2018, 2:39 AM
This revision was automatically updated to reflect the committed changes.