Page MenuHomeFreeBSD

beinstall.sh: Use bectl instead of beadm by default
Needs ReviewPublic

Authored by 0mp on Jul 30 2019, 10:03 AM.

Details

Reviewers
will
brd
kevans
Group Reviewers
manpages
Summary
beinstall.sh: Use bectl instead of beadm by default

This patch also introduces an environment variable BE_UTILITY, which can be
used to specify the utility to use for managing ZFS boot environments (which
can be either bectl or beadm).

While here, fix some typos in the manual page and remove beadm from section
"SEE ALSO".
Test Plan
  • Apply the patch
  • Upgrade a system with beinstall

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 25720
Build 24303: arc lint + arc unit

Event Timeline

0mp created this revision.Jul 30 2019, 10:03 AM
bcr added a subscriber: bcr.Jul 30 2019, 6:53 PM

A few suggestions, nothing major.

share/man/man8/beinstall.8
66

I would leave the "a" here from the original.

89

I'd use either "from the Ports Collection" or simply "from ports".

kevans added a subscriber: kevans.

Throwing myself on as a reviewer so I remember to circle back to this... I seem to recall that bectl might have some issue with mount (not mounting everything that might be needed for some setups, maybe?) -- I'll search through my e-mail and get back to this, though.

I second @bcr's manpages comments. Otherwise LGTM.

kevans added inline comments.Jul 30 2019, 9:37 PM
share/man/man8/beinstall.8
83

It seemed like we generally used "FOO_CMD" for this kind of thing, but I might be mixing up conventions between FreeBSD and $work.

0mp updated this revision to Diff 60534.Aug 7 2019, 8:29 AM
  • Improve wording (as suggested by @bcr)
0mp marked 3 inline comments as done.Aug 7 2019, 8:30 AM
0mp added inline comments.
share/man/man8/beinstall.8
66

Done

83

We use CONFIG_UPDATER in this script, so that's why I decided not to follow the _CMD convention from ports.

89

Done

0mp added 1 blocking reviewer(s): kevans.Aug 7 2019, 8:31 AM
0mp marked 3 inline comments as done.Aug 8 2019, 2:38 PM

@kevans There is a bug report that bectl might have some problems with the activate command: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239702