Page MenuHomeFreeBSD
Feed Advanced Search

May 31 2022

luporl added inline comments to D35344: Refresh CPU types and classes from sys/sys/pmc.h..
May 31 2022, 4:22 PM

Feb 22 2022

luporl accepted D34315: powerpc: enable initial-exec TLS.
Feb 22 2022, 5:06 PM

Jan 10 2022

luporl committed rGc930d356a3a1: powerpc64: fix the calculation of Maxmem (authored by luporl).
powerpc64: fix the calculation of Maxmem
Jan 10 2022, 2:38 PM

Jan 6 2022

luporl accepted D33745: powerpc: add R_PPC_ADDR32 handler for kldxref.

Looks good.

Jan 6 2022, 6:53 PM · PowerPC

Dec 22 2021

luporl added a comment to D33515: kboot: move to generic syscall interface.

I was able to build kboot for powerpc64, with diffs D33511 - D33515.
In the machines that I have access to, Petitboot can't run BE loader.kboot, but I was able to build and run a LE loader.kboot.
However, as mentioned in D33511, it can just run some loader commands, but can't list files or load a kernel. But the older version, without these changes, also can't.

Dec 22 2021, 6:02 PM
luporl accepted D33513: kboot: Move powerpc kboot to top level.

Works fine, after the proposed fix in D33511.

Dec 22 2021, 1:13 PM
luporl requested changes to D33511: kboot: Add MK_LOADER_KBOOT.
Dec 22 2021, 12:48 PM
luporl accepted D33610: Let powerpc64le live as not experimental architecture..
Dec 22 2021, 11:30 AM

Dec 15 2021

luporl committed rGa076e2060c07: powerpc64: fix the calculation of Maxmem (authored by luporl).
powerpc64: fix the calculation of Maxmem
Dec 15 2021, 11:58 AM
luporl closed D33449: powerpc64: fix the calculation of Maxmem.
Dec 15 2021, 11:58 AM

Dec 14 2021

luporl requested review of D33449: powerpc64: fix the calculation of Maxmem.
Dec 14 2021, 9:12 PM

Dec 1 2021

luporl added a comment to D30799: aacraid: log DMA failures.

Is this change good to go now?

Dec 1 2021, 4:36 PM

Nov 25 2021

luporl committed rGe141b62d2088: powerpc64le: fix boot when using QEMU PowerNV (authored by luporl).
powerpc64le: fix boot when using QEMU PowerNV
Nov 25 2021, 7:44 PM
luporl closed D33104: powerpc64le: fix boot when using QEMU PowerNV.
Nov 25 2021, 7:44 PM
luporl committed rGb9f3b63ab21e: vt: export RGB offsets with FBIO_GETRGBOFFS (authored by luporl).
vt: export RGB offsets with FBIO_GETRGBOFFS
Nov 25 2021, 7:41 PM
luporl closed D29000: Export RGB offsets with FBIO_GETRGBOFFS.
Nov 25 2021, 7:40 PM · PowerPC

Nov 24 2021

luporl requested review of D33104: powerpc64le: fix boot when using QEMU PowerNV.
Nov 24 2021, 2:10 PM
luporl accepted D32838: powerpc64: add default boot option to enable autoboot.

Nice!

Nov 24 2021, 1:40 PM · PowerPC

Nov 5 2021

luporl committed rG8a62b07bce7b: powerpc64le: stand fixes (authored by luporl).
powerpc64le: stand fixes
Nov 5 2021, 2:32 PM
luporl committed rG84800daacf33: powerpc64: fix OFWFB with Radix MMU (authored by luporl).
powerpc64: fix OFWFB with Radix MMU
Nov 5 2021, 2:10 PM

Nov 4 2021

luporl added reviewers for D29000: Export RGB offsets with FBIO_GETRGBOFFS: ARM, PowerPC.
Nov 4 2021, 12:37 PM · PowerPC

Nov 1 2021

luporl accepted D30626: ofwfb: fix vga/hdmi console during boot on powerpc64.
Nov 1 2021, 12:29 PM · PowerPC

Oct 22 2021

luporl committed rGa23e18ea5456: powerpc64: tell kernel when radix is not available (authored by luporl).
powerpc64: tell kernel when radix is not available
Oct 22 2021, 4:54 PM

Oct 20 2021

luporl committed rGf83288645cd9: powerpc64le: stand fixes (authored by luporl).
powerpc64le: stand fixes
Oct 20 2021, 7:02 PM
luporl closed D32160: powerpc64le: stand fixes.
Oct 20 2021, 7:02 PM

Oct 18 2021

luporl added a comment to D30554: ofwbus: remove handling of resources from ofwbus.

I've tested these changes on a PPC64 VM. With them, the virtual SCSI device fails to attach, making it impossible to mount root.
Below are the relevant dmesg messages:

Oct 18 2021, 5:21 PM

Oct 14 2021

luporl added inline comments to D32160: powerpc64le: stand fixes.
Oct 14 2021, 5:38 PM
luporl updated the diff for D32160: powerpc64le: stand fixes.

Build uboot for ppc32 too

Oct 14 2021, 5:35 PM
luporl committed rG8ecf9a8bab60: powerpc64: make radix with superpages default (authored by luporl).
powerpc64: make radix with superpages default
Oct 14 2021, 4:17 PM
luporl closed D30797: powerpc64: make radix with superpages default.
Oct 14 2021, 4:17 PM · PowerPC
luporl committed rG76384bd10fdb: powerpc64: fix OFWFB with Radix MMU (authored by luporl).
powerpc64: fix OFWFB with Radix MMU
Oct 14 2021, 1:47 PM
luporl closed D31232: powerpc64: fix OFWFB with Radix MMU.
Oct 14 2021, 1:46 PM · PowerPC

Oct 13 2021

luporl retitled D29000: Export RGB offsets with FBIO_GETRGBOFFS from ofwfb: export RGB offsets with FBIO_GETRGBOFFS to Export RGB offsets with FBIO_GETRGBOFFS.
Oct 13 2021, 5:34 PM · PowerPC

Oct 6 2021

luporl added inline comments to D29000: Export RGB offsets with FBIO_GETRGBOFFS.
Oct 6 2021, 8:06 PM · PowerPC
luporl updated the diff for D29000: Export RGB offsets with FBIO_GETRGBOFFS.

Initialize RGB offsets along with palette.

Oct 6 2021, 8:01 PM · PowerPC

Sep 30 2021

luporl added inline comments to D30799: aacraid: log DMA failures.
Sep 30 2021, 6:07 PM
luporl added inline comments to D30799: aacraid: log DMA failures.
Sep 30 2021, 5:58 PM
luporl updated the diff for D30799: aacraid: log DMA failures.

Simplify sysctl setup

Sep 30 2021, 5:55 PM
luporl added a comment to D30799: aacraid: log DMA failures.

@scottl do you think this is ok now?

Sep 30 2021, 12:35 PM
luporl committed rGcc8e726c85be: powerpc64: change CAS to support Radix MMU (authored by luporl).
powerpc64: change CAS to support Radix MMU
Sep 30 2021, 11:35 AM

Sep 28 2021

luporl updated the diff for D31232: powerpc64: fix OFWFB with Radix MMU.

Address reviewer's comments

Sep 28 2021, 6:17 PM · PowerPC
luporl updated the diff for D32160: powerpc64le: stand fixes.

Remove obsolete endian conversions

Sep 28 2021, 11:41 AM

Sep 27 2021

luporl added inline comments to D32160: powerpc64le: stand fixes.
Sep 27 2021, 8:04 PM
luporl requested review of D32160: powerpc64le: stand fixes.
Sep 27 2021, 5:37 PM

Sep 21 2021

luporl committed rG680ca739458b: powerpc64: fix loader regression (authored by luporl).
powerpc64: fix loader regression
Sep 21 2021, 8:30 PM
luporl closed D32027: powerpc64: fix loader regression.
Sep 21 2021, 8:30 PM
luporl updated the diff for D32027: powerpc64: fix loader regression.

Initialize archsw earlier.

Sep 21 2021, 3:12 PM

Sep 20 2021

luporl requested review of D32027: powerpc64: fix loader regression.
Sep 20 2021, 5:54 PM

Sep 15 2021

luporl closed D31951: powerpc64: change CAS to support Radix MMU.
Sep 15 2021, 6:26 PM
luporl committed rGa58abcde2c83: powerpc64: change CAS to support Radix MMU (authored by luporl).
powerpc64: change CAS to support Radix MMU
Sep 15 2021, 6:26 PM
luporl added inline comments to D31951: powerpc64: change CAS to support Radix MMU.
Sep 15 2021, 5:06 PM
luporl updated the diff for D31951: powerpc64: change CAS to support Radix MMU.

Address reviewer's comments

Sep 15 2021, 5:06 PM
luporl updated the diff for D31951: powerpc64: change CAS to support Radix MMU.

Add missing break

Sep 15 2021, 2:48 PM
luporl updated the diff for D31951: powerpc64: change CAS to support Radix MMU.

Query device tree for Radix/GTSE support, instead of using CPU version and HV bit checks, as this is a better approach, as discussed in IRC.

Sep 15 2021, 2:43 PM

Sep 14 2021

luporl added inline comments to D31951: powerpc64: change CAS to support Radix MMU.
Sep 14 2021, 11:40 AM

Sep 13 2021

luporl requested review of D31951: powerpc64: change CAS to support Radix MMU.
Sep 13 2021, 6:53 PM

Sep 8 2021

luporl committed rG4f7c436548ea: powerpc64: fix radix on pseries TLB invalidation (authored by luporl).
powerpc64: fix radix on pseries TLB invalidation
Sep 8 2021, 11:44 AM
luporl closed D31775: powerpc64: fix radix on pseries TLB invalidation.
Sep 8 2021, 11:44 AM · PowerPC

Sep 6 2021

luporl updated the diff for D31775: powerpc64: fix radix on pseries TLB invalidation.
  • Address reviewer's comments
Sep 6 2021, 6:16 PM · PowerPC

Sep 1 2021

luporl requested review of D31775: powerpc64: fix radix on pseries TLB invalidation.
Sep 1 2021, 6:20 PM · PowerPC

Aug 31 2021

luporl updated the diff for D30799: aacraid: log DMA failures.

Address reviewer's comments:

  • log DMA load buffer error message only once for each device
  • add a per device error counter, exported via sysctl (inspired by mpr code)
Aug 31 2021, 12:08 PM

Aug 24 2021

luporl accepted D31387: hwpmc: consistently validate PMC class in allocation method.

Worked fine on POWER9.
For PowerPC, without these changes the allocation of more programmable counters than available already failed, because of the check for the counter number in allocate. But, as you said, it is always a good idea to validate the PMC class too.

Aug 24 2021, 12:38 PM

Jul 30 2021

luporl added inline comments to D31232: powerpc64: fix OFWFB with Radix MMU.
Jul 30 2021, 2:33 PM · PowerPC

Jul 29 2021

luporl committed rG95d619a8ea1f: hwpmc: remove static POWER8 definitions (authored by luporl).
hwpmc: remove static POWER8 definitions
Jul 29 2021, 5:57 PM
luporl closed D31334: hwpmc: remove static POWER8 definitions.
Jul 29 2021, 5:57 PM
luporl added inline comments to D31334: hwpmc: remove static POWER8 definitions.
Jul 29 2021, 5:33 PM

Jul 28 2021

luporl abandoned D24329: loader: allow TFTP to be used by default.
Jul 28 2021, 5:42 PM
luporl abandoned D21554: Fix kvm bitmap index.
Jul 28 2021, 5:38 PM
luporl committed rG7844e5a4fc0a: powerpc: change mfpvr return type to uint32_t (authored by luporl).
powerpc: change mfpvr return type to uint32_t
Jul 28 2021, 5:11 PM
luporl closed D31332: powerpc: change mfpvr return type to uint32_t.
Jul 28 2021, 5:11 PM
luporl requested review of D31334: hwpmc: remove static POWER8 definitions.
Jul 28 2021, 4:54 PM
luporl requested review of D31332: powerpc: change mfpvr return type to uint32_t.
Jul 28 2021, 12:41 PM

Jul 26 2021

luporl committed rG0f47f916811a: hwpmc: fix powerpc/powerpcspe builds (authored by luporl).
hwpmc: fix powerpc/powerpcspe builds
Jul 26 2021, 4:37 PM
luporl committed rGb48a2770d48b: powerpc64: add Power8 and Power9 PMCs (authored by luporl).
powerpc64: add Power8 and Power9 PMCs
Jul 26 2021, 1:31 PM
luporl closed D31109: Add Power8 and Power9 PMCs.
Jul 26 2021, 1:31 PM

Jul 23 2021

luporl added a comment to D31109: Add Power8 and Power9 PMCs.

Looks good, thanks for finishing this. Will you handle the removal of the static power8 definitions as well?

Jul 23 2021, 4:36 PM
luporl added a comment to D30626: ofwfb: fix vga/hdmi console during boot on powerpc64.

This approach of auto detecting the correct frame buffer physical address based on Vendor ID looks good.
It would help to make FreeBSD graphics work out of the box for Blackbird and Talos II machines, instead of forcing the user to figure out the physical address of its VGA adapter and pass it to the kernel manually, or else the system just hangs.
Ideally, Petitboot should fix it on their side, but I don't know if it will happen anytime soon, since Linux isn't affected, because it just talks directly to ASPEED video device, instead of relying on the framebuffer info exposed in the device tree.

Jul 23 2021, 2:49 PM · PowerPC
luporl added a reviewer for D29000: Export RGB offsets with FBIO_GETRGBOFFS: emaste.
Jul 23 2021, 12:26 PM · PowerPC
luporl added inline comments to D29000: Export RGB offsets with FBIO_GETRGBOFFS.
Jul 23 2021, 12:26 PM · PowerPC
luporl added a reviewer for D31109: Add Power8 and Power9 PMCs: PowerPC.
Jul 23 2021, 11:53 AM
luporl added a comment to D30797: powerpc64: make radix with superpages default.

D31232 fixes OFWFB with radix. After it lands it should be safe to make radix default.

Jul 23 2021, 11:51 AM · PowerPC
luporl added a reviewer for D30799: aacraid: log DMA failures: imp.
Jul 23 2021, 11:48 AM
luporl added a comment to D30799: aacraid: log DMA failures.

@imp I've added the rate limiter, do you think this revision is ok now?

Jul 23 2021, 11:47 AM
luporl committed rG572e3575dba5: aacraid: reduce max I/O size to avoid DMA issues (authored by luporl).
aacraid: reduce max I/O size to avoid DMA issues
Jul 23 2021, 11:31 AM

Jul 21 2021

luporl updated the diff for D31109: Add Power8 and Power9 PMCs.
  • Fix event name mapping
  • Handle non-programmable PMCs (PMC5 and PMC6)
  • Add missing event counter check
Jul 21 2021, 6:46 PM
luporl commandeered D31109: Add Power8 and Power9 PMCs.

Commandeering revision to finish changes while Leonardo is out.

Jul 21 2021, 6:42 PM

Jul 20 2021

luporl accepted D31221: Fix various issues with commit 28dd6730a5d6, 8cc3815f02be.

LGTM. The changes are similar to the PPC64 ones, in D31109.

Jul 20 2021, 2:08 PM
luporl added inline comments to D31109: Add Power8 and Power9 PMCs.
Jul 20 2021, 1:53 PM
luporl requested review of D31232: powerpc64: fix OFWFB with Radix MMU.
Jul 20 2021, 1:16 PM · PowerPC

Jul 15 2021

luporl added a comment to D31109: Add Power8 and Power9 PMCs.

I have investigated the issue further and have some suggestions of how it can be fixed (inline).

Jul 15 2021, 7:43 PM
luporl added a comment to D31109: Add Power8 and Power9 PMCs.

Overall the changes look good.

Jul 15 2021, 5:06 PM

Jun 21 2021

luporl committed rG71fd1bfd5ed5: aacraid: ignore data overrun on INQUIRY (authored by luporl).
aacraid: ignore data overrun on INQUIRY
Jun 21 2021, 6:16 PM
luporl closed D30843: aacraid: ignore data overrun on INQUIRY.
Jun 21 2021, 6:16 PM
luporl committed rG9c2c6353193b: aacraid: reduce max I/O size to avoid DMA issues (authored by luporl).
aacraid: reduce max I/O size to avoid DMA issues
Jun 21 2021, 6:11 PM
luporl closed D30798: aacraid: reduce max I/O size to avoid DMA issues.
Jun 21 2021, 6:11 PM
luporl added inline comments to D30799: aacraid: log DMA failures.
Jun 21 2021, 5:57 PM
luporl updated the diff for D30799: aacraid: log DMA failures.

Address review's comments

Jun 21 2021, 5:48 PM
luporl added inline comments to D30798: aacraid: reduce max I/O size to avoid DMA issues.
Jun 21 2021, 3:01 PM
luporl updated the summary of D30798: aacraid: reduce max I/O size to avoid DMA issues.
Jun 21 2021, 3:00 PM
luporl updated the diff for D30798: aacraid: reduce max I/O size to avoid DMA issues.

Address review's comments.

Jun 21 2021, 2:59 PM