Add CFI start/end proc directives to arm64, i386, and ppc

[cem]

Summary

Follow-up to r353959 and r368070: do the same for other architectures.

arm32 already seems to use its own .fnstart/.fnend directives, which
appear to be ARM-specific variants of the same thing. Likewise, MIPS
uses .frame directives.

Test Plan

Tinderbox running.

[jrtc27]

sys/powerpc/include/asm.h

112 ↗

(On Diff #80034)

This is the descriptor; you need it after DOT_LABEL(name).

163 ↗

(On Diff #80034)

END_SIZE(name) whilst you're here?

[cem]

sys/powerpc/include/asm.h

112 ↗

(On Diff #80034)

Thanks, will fix.

163 ↗

(On Diff #80034)

Sorry, what about END_SIZE?

[cem]

• Move cfi_startproc in ELFv1 prologue after DOT_LABEL

[jrtc27]

sys/powerpc/include/asm.h

163 ↗

(On Diff #80034)

Currently there's no .size directive for powerpc32, unlike powerpc64. There's an END_SIZE macro available for that, though it looks like it's assuming powerpc64 without checking so you might want to just do a normal .size.

[cem]

sys/powerpc/include/asm.h

163 ↗

(On Diff #80034)

Sure, I'll add it. Thanks.

[cem]

Add a lot of missing END directives. Tinderbox passes on arm64 and i386.
PowerPC mostly passes, except for all the PS3 HV calls which still need END
directives (and there are hundreds of these).

[cem]

• Add remaining missing END/ASEND directives in powerpc. Now tinderbox is clean.

[cem]

Fix ENTRY consumers in userspace (syscalls, MD assembly functions)

[cem]

Are there any outstanding objections? (I think I've addressed everything raised so far, but please correct me if I am mistaken.) Is there anyone who hasn't reviewed yet, but will have time to review in the next few days? Thanks.

[arichardson]

Looks good to me. Obviously there might be some non-default build configurations that are missing end() calls, but if so they been be fixed later.

Probably best to wait for at least one more review though.

[bdragon]

I'm fine with it on readthrough, I just hadn't gotten around to the actual tests. If it broke anything in powerpc land, it should be easy to fix. Thanks for tidying up the procedure annotations!

[cem]

In D27387#614192, @bdragon wrote:

I'm fine with it on readthrough, I just hadn't gotten around to the actual tests. If it broke anything in powerpc land, it should be easy to fix. Thanks for tidying up the procedure annotations!

Thanks! It compiles (tinderbox, anyway) and shouldn't affect code generation, so I'm cautiously optimistic nothing broke. Please let me know if it broke something and I can help fix it :-).

head/lib/libc/powerpc/SYS.h

 
 == FreeBSD runs thousands of applications.
 
 Because FreeBSD is based on 4.4BSD, an industry-standard version of UNIX, it is easy to compile and run programs. FreeBSD also includes an extensive packages collection and link:../ports/[ports collection] that bring precompiled and easy-to-build software right to your desktop or enterprise server. There is also a growing number of link:../commercial/software/[commercial applications] written for FreeBSD.
 
 Here are some examples of the environments in which FreeBSD is used:
 
 * *Internet services.* Many Internet Service Providers (ISPs) find FreeBSD ideal, running WWW, Usenet news, FTP, Email, and other services. Ready-to-run software like the http://nginx.org[NGINX] or http://www.apache.org/[Apache] web server or the http://proftpd.org/[ProFTPD] or http://security.appspot.com/vsftpd.html[vsftpd] FTP server make it easy to set up a business or community-centered ISP. Of course, with FreeBSD's unbeatable link:../internet/[networking], your users will enjoy high speed, reliable services.
-* *X Window workstation.* From an inexpensive X terminal to an advanced X display, FreeBSD works quite well. Free X software (http://x.org/[X.Org](T)) comes with the system. http://www.nvidia.com/[NVIDIA] offers native drivers for their high-performance graphics hardware, and the industry standard http://www.opengroup.org/motif/[Motif](R) and http://www.opengl.org/[OpenGL](R) libraries are supported. The http://xfce.org/[Xfce] and http://lxde.org/[LXDE] products provide a desktop environment. The http://www.kde.org[KDE] and http://www.gnome.org[GNOME] desktop environments also enjoy full support and provide office suite functionality, with further good functionality available in the https://www.libreoffice.org/[LibreOffice], http://www.openoffice.org/[OpenOffice.Org] and http://www.softmaker.com/en/[TextMaker] products.
+* *X Window workstation.* From an inexpensive X terminal to an advanced X display, FreeBSD works quite well. Free X software (https://x.org/[X.Org](T)) comes with the system. https://www.nvidia.com/[NVIDIA] offers native drivers for their high-performance graphics hardware, and the industry standard https://www.opengroup.org/motif/[Motif](R) and https://www.opengl.org/[OpenGL](R) libraries are supported. The https://xfce.org/[Xfce] and https://lxde.org/[LXDE] products provide a desktop environment. The https://www.kde.org[KDE] and https://www.gnome.org[GNOME] desktop environments also enjoy full support and provide office suite functionality, with further good functionality available in the https://www.libreoffice.org/[LibreOffice] and https://www.openoffice.org/[OpenOffice.Org] products.
 * *Networking.* From packet filtering to routing to name service, FreeBSD can turn any PC into a Internet firewall, email host, print server, PC/NFS server, and more.
-* *Software development.* A suite of development tools comes with FreeBSD, including the GNU C/C++ compiler and debugger. The LLVM-based clang suite is also provided and will eventually replace the GNU suite. Java(R) and Tcl/Tk development are also possible for example, and more esoteric programming languages like Icon work just fine, too. And FreeBSD's shared libraries have always been easy to make and use. You can also choose from a wide range of popular and powerful editors, such as Emacs and Vim.
+* *Software development.* A suite of https://docs.freebsd.org/en/books/developers-handbook/tools/[development tools] comes with FreeBSD, including the LLVM-based clang C/C++ compiler and debugger. Java(R) and Tcl/Tk development are also possible for example. And FreeBSD's shared libraries have always been easy to make and use. You can also choose from a wide range of popular and powerful editors, such as Emacs and Vim.
 * *Net surfing.* A real UNIX workstation makes a great Internet surfboard. FreeBSD versions of http://www.chromium.org/Home[Chromium] and http://www.mozilla.org/firefox/[Firefox] are available for serious web users. Surf the web, publish your own web pages, read Usenet news, and send and receive email with a FreeBSD system on your desktop.
 * *Education and research.* FreeBSD makes an excellent research platform because it includes complete source code. Students and researchers of operating systems or other computer science fields can benefit greatly from such an open and well-documented system.
 * *And much more.* Accounting, action games, MIS databases, scientific visualization, video conferencing, Internet relay chat (IRC), home automation, multiuser dungeons, bulletin board systems, image scanning, and more are all real uses for FreeBSD today.
 
 == FreeBSD is an operating system that will grow with your needs.
 
 Though FreeBSD is free software, it is also _user supported_ software. Any questions you have can be posted to hundreds of FreeBSD developers and users simply by e-mailing the [e-mail] mailing list.
 
 FreeBSD also has a worldwide group of programmers and writers who fix bugs, add new features and document the system. Support for new devices or special features is an almost constant development process, and the team keeps a special eye out for problems which affect system stability. FreeBSD users are quite proud of not only how fast but how reliable their systems are.
 
 == What experts have to say . . .
 
 _"FreeBSD handles [our] heavy load quite well and it is nothing short of amazing. Salutations to the FreeBSD team."_
 
 [.right]
 ---Mark Hittinger, administrator of WinNet Communications, Inc.

head/lib/libc/powerpc64/SYS.h

 
 == FreeBSD runs thousands of applications.
 
 Because FreeBSD is based on 4.4BSD, an industry-standard version of UNIX, it is easy to compile and run programs. FreeBSD also includes an extensive packages collection and link:../ports/[ports collection] that bring precompiled and easy-to-build software right to your desktop or enterprise server. There is also a growing number of link:../commercial/software/[commercial applications] written for FreeBSD.
 
 Here are some examples of the environments in which FreeBSD is used:
 
 * *Internet services.* Many Internet Service Providers (ISPs) find FreeBSD ideal, running WWW, Usenet news, FTP, Email, and other services. Ready-to-run software like the http://nginx.org[NGINX] or http://www.apache.org/[Apache] web server or the http://proftpd.org/[ProFTPD] or http://security.appspot.com/vsftpd.html[vsftpd] FTP server make it easy to set up a business or community-centered ISP. Of course, with FreeBSD's unbeatable link:../internet/[networking], your users will enjoy high speed, reliable services.
-* *X Window workstation.* From an inexpensive X terminal to an advanced X display, FreeBSD works quite well. Free X software (http://x.org/[X.Org](T)) comes with the system. http://www.nvidia.com/[NVIDIA] offers native drivers for their high-performance graphics hardware, and the industry standard http://www.opengroup.org/motif/[Motif](R) and http://www.opengl.org/[OpenGL](R) libraries are supported. The http://xfce.org/[Xfce] and http://lxde.org/[LXDE] products provide a desktop environment. The http://www.kde.org[KDE] and http://www.gnome.org[GNOME] desktop environments also enjoy full support and provide office suite functionality, with further good functionality available in the https://www.libreoffice.org/[LibreOffice], http://www.openoffice.org/[OpenOffice.Org] and http://www.softmaker.com/en/[TextMaker] products.
+* *X Window workstation.* From an inexpensive X terminal to an advanced X display, FreeBSD works quite well. Free X software (https://x.org/[X.Org](T)) comes with the system. https://www.nvidia.com/[NVIDIA] offers native drivers for their high-performance graphics hardware, and the industry standard https://www.opengroup.org/motif/[Motif](R) and https://www.opengl.org/[OpenGL](R) libraries are supported. The https://xfce.org/[Xfce] and https://lxde.org/[LXDE] products provide a desktop environment. The https://www.kde.org[KDE] and https://www.gnome.org[GNOME] desktop environments also enjoy full support and provide office suite functionality, with further good functionality available in the https://www.libreoffice.org/[LibreOffice] and https://www.openoffice.org/[OpenOffice.Org] products.
 * *Networking.* From packet filtering to routing to name service, FreeBSD can turn any PC into a Internet firewall, email host, print server, PC/NFS server, and more.
-* *Software development.* A suite of development tools comes with FreeBSD, including the GNU C/C++ compiler and debugger. The LLVM-based clang suite is also provided and will eventually replace the GNU suite. Java(R) and Tcl/Tk development are also possible for example, and more esoteric programming languages like Icon work just fine, too. And FreeBSD's shared libraries have always been easy to make and use. You can also choose from a wide range of popular and powerful editors, such as Emacs and Vim.
+* *Software development.* A suite of https://docs.freebsd.org/en/books/developers-handbook/tools/[development tools] comes with FreeBSD, including the LLVM-based clang C/C++ compiler and debugger. Java(R) and Tcl/Tk development are also possible for example. And FreeBSD's shared libraries have always been easy to make and use. You can also choose from a wide range of popular and powerful editors, such as Emacs and Vim.
 * *Net surfing.* A real UNIX workstation makes a great Internet surfboard. FreeBSD versions of http://www.chromium.org/Home[Chromium] and http://www.mozilla.org/firefox/[Firefox] are available for serious web users. Surf the web, publish your own web pages, read Usenet news, and send and receive email with a FreeBSD system on your desktop.
 * *Education and research.* FreeBSD makes an excellent research platform because it includes complete source code. Students and researchers of operating systems or other computer science fields can benefit greatly from such an open and well-documented system.
 * *And much more.* Accounting, action games, MIS databases, scientific visualization, video conferencing, Internet relay chat (IRC), home automation, multiuser dungeons, bulletin board systems, image scanning, and more are all real uses for FreeBSD today.
 
 == FreeBSD is an operating system that will grow with your needs.
 
 Though FreeBSD is free software, it is also _user supported_ software. Any questions you have can be posted to hundreds of FreeBSD developers and users simply by e-mailing the [e-mail] mailing list.
 
 FreeBSD also has a worldwide group of programmers and writers who fix bugs, add new features and document the system. Support for new devices or special features is an almost constant development process, and the team keeps a special eye out for problems which affect system stability. FreeBSD users are quite proud of not only how fast but how reliable their systems are.
 
 == What experts have to say . . .
 
 _"FreeBSD handles [our] heavy load quite well and it is nothing short of amazing. Salutations to the FreeBSD team."_
 
 [.right]
 ---Mark Hittinger, administrator of WinNet Communications, Inc.

head/lib/libc/powerpc64/sys/cerror.S

 
 == FreeBSD runs thousands of applications.
 
 Because FreeBSD is based on 4.4BSD, an industry-standard version of UNIX, it is easy to compile and run programs. FreeBSD also includes an extensive packages collection and link:../ports/[ports collection] that bring precompiled and easy-to-build software right to your desktop or enterprise server. There is also a growing number of link:../commercial/software/[commercial applications] written for FreeBSD.
 
 Here are some examples of the environments in which FreeBSD is used:
 
 * *Internet services.* Many Internet Service Providers (ISPs) find FreeBSD ideal, running WWW, Usenet news, FTP, Email, and other services. Ready-to-run software like the http://nginx.org[NGINX] or http://www.apache.org/[Apache] web server or the http://proftpd.org/[ProFTPD] or http://security.appspot.com/vsftpd.html[vsftpd] FTP server make it easy to set up a business or community-centered ISP. Of course, with FreeBSD's unbeatable link:../internet/[networking], your users will enjoy high speed, reliable services.
-* *X Window workstation.* From an inexpensive X terminal to an advanced X display, FreeBSD works quite well. Free X software (http://x.org/[X.Org](T)) comes with the system. http://www.nvidia.com/[NVIDIA] offers native drivers for their high-performance graphics hardware, and the industry standard http://www.opengroup.org/motif/[Motif](R) and http://www.opengl.org/[OpenGL](R) libraries are supported. The http://xfce.org/[Xfce] and http://lxde.org/[LXDE] products provide a desktop environment. The http://www.kde.org[KDE] and http://www.gnome.org[GNOME] desktop environments also enjoy full support and provide office suite functionality, with further good functionality available in the https://www.libreoffice.org/[LibreOffice], http://www.openoffice.org/[OpenOffice.Org] and http://www.softmaker.com/en/[TextMaker] products.
+* *X Window workstation.* From an inexpensive X terminal to an advanced X display, FreeBSD works quite well. Free X software (https://x.org/[X.Org](T)) comes with the system. https://www.nvidia.com/[NVIDIA] offers native drivers for their high-performance graphics hardware, and the industry standard https://www.opengroup.org/motif/[Motif](R) and https://www.opengl.org/[OpenGL](R) libraries are supported. The https://xfce.org/[Xfce] and https://lxde.org/[LXDE] products provide a desktop environment. The https://www.kde.org[KDE] and https://www.gnome.org[GNOME] desktop environments also enjoy full support and provide office suite functionality, with further good functionality available in the https://www.libreoffice.org/[LibreOffice] and https://www.openoffice.org/[OpenOffice.Org] products.
 * *Networking.* From packet filtering to routing to name service, FreeBSD can turn any PC into a Internet firewall, email host, print server, PC/NFS server, and more.
-* *Software development.* A suite of development tools comes with FreeBSD, including the GNU C/C++ compiler and debugger. The LLVM-based clang suite is also provided and will eventually replace the GNU suite. Java(R) and Tcl/Tk development are also possible for example, and more esoteric programming languages like Icon work just fine, too. And FreeBSD's shared libraries have always been easy to make and use. You can also choose from a wide range of popular and powerful editors, such as Emacs and Vim.
+* *Software development.* A suite of https://docs.freebsd.org/en/books/developers-handbook/tools/[development tools] comes with FreeBSD, including the LLVM-based clang C/C++ compiler and debugger. Java(R) and Tcl/Tk development are also possible for example. And FreeBSD's shared libraries have always been easy to make and use. You can also choose from a wide range of popular and powerful editors, such as Emacs and Vim.
 * *Net surfing.* A real UNIX workstation makes a great Internet surfboard. FreeBSD versions of http://www.chromium.org/Home[Chromium] and http://www.mozilla.org/firefox/[Firefox] are available for serious web users. Surf the web, publish your own web pages, read Usenet news, and send and receive email with a FreeBSD system on your desktop.
 * *Education and research.* FreeBSD makes an excellent research platform because it includes complete source code. Students and researchers of operating systems or other computer science fields can benefit greatly from such an open and well-documented system.
 * *And much more.* Accounting, action games, MIS databases, scientific visualization, video conferencing, Internet relay chat (IRC), home automation, multiuser dungeons, bulletin board systems, image scanning, and more are all real uses for FreeBSD today.
 
 == FreeBSD is an operating system that will grow with your needs.
 
 Though FreeBSD is free software, it is also _user supported_ software. Any questions you have can be posted to hundreds of FreeBSD developers and users simply by e-mailing the [e-mail] mailing list.
 
 FreeBSD also has a worldwide group of programmers and writers who fix bugs, add new features and document the system. Support for new devices or special features is an almost constant development process, and the team keeps a special eye out for problems which affect system stability. FreeBSD users are quite proud of not only how fast but how reliable their systems are.
 
 == What experts have to say . . .
 
 _"FreeBSD handles [our] heavy load quite well and it is nothing short of amazing. Salutations to the FreeBSD team."_
 
 [.right]
 ---Mark Hittinger, administrator of WinNet Communications, Inc.

head/lib/libthr/arch/i386/i386/_umtx_op_err.S

 
 == FreeBSD runs thousands of applications.
 
 Because FreeBSD is based on 4.4BSD, an industry-standard version of UNIX, it is easy to compile and run programs. FreeBSD also includes an extensive packages collection and link:../ports/[ports collection] that bring precompiled and easy-to-build software right to your desktop or enterprise server. There is also a growing number of link:../commercial/software/[commercial applications] written for FreeBSD.
 
 Here are some examples of the environments in which FreeBSD is used:
 
 * *Internet services.* Many Internet Service Providers (ISPs) find FreeBSD ideal, running WWW, Usenet news, FTP, Email, and other services. Ready-to-run software like the http://nginx.org[NGINX] or http://www.apache.org/[Apache] web server or the http://proftpd.org/[ProFTPD] or http://security.appspot.com/vsftpd.html[vsftpd] FTP server make it easy to set up a business or community-centered ISP. Of course, with FreeBSD's unbeatable link:../internet/[networking], your users will enjoy high speed, reliable services.
-* *X Window workstation.* From an inexpensive X terminal to an advanced X display, FreeBSD works quite well. Free X software (http://x.org/[X.Org](T)) comes with the system. http://www.nvidia.com/[NVIDIA] offers native drivers for their high-performance graphics hardware, and the industry standard http://www.opengroup.org/motif/[Motif](R) and http://www.opengl.org/[OpenGL](R) libraries are supported. The http://xfce.org/[Xfce] and http://lxde.org/[LXDE] products provide a desktop environment. The http://www.kde.org[KDE] and http://www.gnome.org[GNOME] desktop environments also enjoy full support and provide office suite functionality, with further good functionality available in the https://www.libreoffice.org/[LibreOffice], http://www.openoffice.org/[OpenOffice.Org] and http://www.softmaker.com/en/[TextMaker] products.
+* *X Window workstation.* From an inexpensive X terminal to an advanced X display, FreeBSD works quite well. Free X software (https://x.org/[X.Org](T)) comes with the system. https://www.nvidia.com/[NVIDIA] offers native drivers for their high-performance graphics hardware, and the industry standard https://www.opengroup.org/motif/[Motif](R) and https://www.opengl.org/[OpenGL](R) libraries are supported. The https://xfce.org/[Xfce] and https://lxde.org/[LXDE] products provide a desktop environment. The https://www.kde.org[KDE] and https://www.gnome.org[GNOME] desktop environments also enjoy full support and provide office suite functionality, with further good functionality available in the https://www.libreoffice.org/[LibreOffice] and https://www.openoffice.org/[OpenOffice.Org] products.
 * *Networking.* From packet filtering to routing to name service, FreeBSD can turn any PC into a Internet firewall, email host, print server, PC/NFS server, and more.
-* *Software development.* A suite of development tools comes with FreeBSD, including the GNU C/C++ compiler and debugger. The LLVM-based clang suite is also provided and will eventually replace the GNU suite. Java(R) and Tcl/Tk development are also possible for example, and more esoteric programming languages like Icon work just fine, too. And FreeBSD's shared libraries have always been easy to make and use. You can also choose from a wide range of popular and powerful editors, such as Emacs and Vim.
+* *Software development.* A suite of https://docs.freebsd.org/en/books/developers-handbook/tools/[development tools] comes with FreeBSD, including the LLVM-based clang C/C++ compiler and debugger. Java(R) and Tcl/Tk development are also possible for example. And FreeBSD's shared libraries have always been easy to make and use. You can also choose from a wide range of popular and powerful editors, such as Emacs and Vim.
 * *Net surfing.* A real UNIX workstation makes a great Internet surfboard. FreeBSD versions of http://www.chromium.org/Home[Chromium] and http://www.mozilla.org/firefox/[Firefox] are available for serious web users. Surf the web, publish your own web pages, read Usenet news, and send and receive email with a FreeBSD system on your desktop.
 * *Education and research.* FreeBSD makes an excellent research platform because it includes complete source code. Students and researchers of operating systems or other computer science fields can benefit greatly from such an open and well-documented system.
 * *And much more.* Accounting, action games, MIS databases, scientific visualization, video conferencing, Internet relay chat (IRC), home automation, multiuser dungeons, bulletin board systems, image scanning, and more are all real uses for FreeBSD today.
 
 == FreeBSD is an operating system that will grow with your needs.
 
 Though FreeBSD is free software, it is also _user supported_ software. Any questions you have can be posted to hundreds of FreeBSD developers and users simply by e-mailing the [e-mail] mailing list.
 
 FreeBSD also has a worldwide group of programmers and writers who fix bugs, add new features and document the system. Support for new devices or special features is an almost constant development process, and the team keeps a special eye out for problems which affect system stability. FreeBSD users are quite proud of not only how fast but how reliable their systems are.
 
 == What experts have to say . . .
 
 _"FreeBSD handles [our] heavy load quite well and it is nothing short of amazing. Salutations to the FreeBSD team."_
 
 [.right]
 ---Mark Hittinger, administrator of WinNet Communications, Inc.